<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
#email-body { min-width: 30em !important; }
#email-page { padding: 8px !important; }
#email-banner { padding: 8px 8px 0 8px !important; }
#email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
#email-fields { padding: 0 8px 8px 8px !important; }
#email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
<tr valign="top">
<td id="email-page" style="padding:16px !important;">
<table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
<tr valign="top">
<td bgcolor="#3e4c4e" style="background-color:#3e4c4e;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="https://www.jboss.org/dms/hibernate/images/jira/jiraheader_hibernate.png" alt="" style="vertical-align:top;" /></td>
</tr><tr valign="top">
<td id="email-banner" style="padding:32px 32px 0 32px;">
<table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
<img id="email-avatar" src="https://secure.gravatar.com/avatar/5db7154c0affd147037f4b7ce94e41d8?d=mm&s=48" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
<div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
<a class="user-hover" rel="aanisimov" id="email_aanisimov" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=aanisimov" style="color:#6c797f;">Andrew Anisimov</a>
created <img src="https://hibernate.atlassian.net/images/icons/issuetypes/bug.png" height="16" width="16" border="0" align="absmiddle" alt="Bug"> <a style='color:#6c797f;text-decoration:none;' href='https://hibernate.atlassian.net/browse/HHH-8158'>HHH-8158</a>
</div>
<div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
<a style='color:#6c797f;text-decoration:none;' href='https://hibernate.atlassian.net/browse/HHH-8158'><strong>Property with @Id and @GeneratedValue(strategy=IDENTITY) brokes @NaturalIdCache</strong></a>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td id="email-fields" style="padding:0 32px 32px 32px;">
<table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
<tr valign="top">
<td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Issue Type:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<img src="https://hibernate.atlassian.net/images/icons/issuetypes/bug.png" height="16" width="16" border="0" align="absmiddle" alt="Bug"> Bug
</td>
</tr> <tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Affects Versions:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
4.2.0.Final, 4.1.11 </td>
</tr>
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Assignee:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
Unassigned
</td>
</tr> <tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Components:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
caching (L2) </td>
</tr>
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Created:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
08/Apr/13 9:17 AM
</td>
</tr> <tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Description:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<p style='margin-top:0;margin-bottom:10px;'>The following test case demonstrates the issue.</p>
<div class="code panel" style="border-style: solid;border-width: 1px;"><div class="codeHeader panelHeader" style="border-bottom-width: 1px;border-bottom-style: solid;"><b>EntityWithNaturalKey.java</b></div><div class="codeContent panelContent">
<pre class="code-java">
<span class="code-keyword">import</span> org.hibernate.annotations.NaturalId;
<span class="code-keyword">import</span> org.hibernate.annotations.NaturalIdCache;
<span class="code-keyword">import</span> javax.persistence.Cacheable;
<span class="code-keyword">import</span> javax.persistence.Entity;
<span class="code-keyword">import</span> javax.persistence.GeneratedValue;
<span class="code-keyword">import</span> javax.persistence.Id;
<span class="code-keyword">import</span> <span class="code-keyword">static</span> javax.persistence.GenerationType.IDENTITY;
@Entity
@Cacheable
@NaturalIdCache
<span class="code-keyword">public</span> class EntityWithNaturalKey {
@Id
@GeneratedValue(strategy = IDENTITY)
<span class="code-keyword">private</span> <span class="code-object">long</span> id;
@NaturalId(mutable = <span class="code-keyword">false</span>)
<span class="code-keyword">private</span> <span class="code-object">String</span> name;
<span class="code-keyword">protected</span> EntityWithNaturalKey() {
}
<span class="code-keyword">public</span> EntityWithNaturalKey(<span class="code-object">String</span> name) {
<span class="code-keyword">this</span>.name = name;
}
<span class="code-keyword">public</span> <span class="code-object">long</span> getId() {
<span class="code-keyword">return</span> id;
}
<span class="code-keyword">public</span> <span class="code-object">String</span> getName() {
<span class="code-keyword">return</span> name;
}
<span class="code-keyword">public</span> void setName(<span class="code-object">String</span> name) {
<span class="code-keyword">this</span>.name = name;
}
}
</pre>
</div></div>
<div class="code panel" style="border-style: solid;border-width: 1px;"><div class="codeHeader panelHeader" style="border-bottom-width: 1px;border-bottom-style: solid;"><b>NaturalIdCacheTest.java</b></div><div class="codeContent panelContent">
<pre class="code-java">
<span class="code-keyword">import</span> org.hibernate.Session;
<span class="code-keyword">import</span> org.hibernate.cache.ehcache.SingletonEhCacheRegionFactory;
<span class="code-keyword">import</span> org.hibernate.cfg.Configuration;
<span class="code-keyword">import</span> org.hibernate.cfg.Environment;
<span class="code-keyword">import</span> org.hibernate.test.jpa.AbstractJPATest;
<span class="code-keyword">import</span> org.hibernate.testing.TestForIssue;
<span class="code-keyword">import</span> org.junit.Assert;
<span class="code-keyword">import</span> org.junit.Test;
<span class="code-keyword">public</span> class NaturalIdCacheTest <span class="code-keyword">extends</span> AbstractJPATest {
@Override
<span class="code-keyword">public</span> <span class="code-object">String</span>[] getMappings() {
<span class="code-keyword">return</span> NO_MAPPINGS;
}
@Override
<span class="code-keyword">public</span> void configure(Configuration cfg) {
<span class="code-keyword">super</span>.configure(cfg);
cfg.addAnnotatedClass(EntityWithNaturalKey.class);
cfg.setProperty(Environment.USE_SECOND_LEVEL_CACHE, <span class="code-quote">"<span class="code-keyword">true</span>"</span>);
cfg.setProperty(Environment.USE_QUERY_CACHE, <span class="code-quote">"<span class="code-keyword">true</span>"</span>);
cfg.setProperty(Environment.GENERATE_STATISTICS, <span class="code-quote">"<span class="code-keyword">true</span>"</span>);
cfg.setProperty(Environment.CACHE_REGION_FACTORY, SingletonEhCacheRegionFactory.class.getName());
}
@Test
@TestForIssue(jiraKey = <span class="code-quote">"???"</span>)
<span class="code-keyword">public</span> void testPutIntoNaturalIdCache_newlyCreatedIdentity() <span class="code-keyword">throws</span> Exception {
<span class="code-comment">// Bug description:
</span> <span class="code-comment">// Creating <span class="code-keyword">new</span> entity with auto generated identity
</span> <span class="code-comment">// puts <span class="code-keyword">new</span> item with value = <span class="code-keyword">null</span> into natural id
</span> <span class="code-comment">// cache region, and mainly because of <span class="code-keyword">this</span> it will
</span> <span class="code-comment">// never be (re-)populated later, causing natural
</span> <span class="code-comment">// id queries performing again and again.
</span>
Session s = openSession();
s.beginTransaction();
EntityWithNaturalKey e = <span class="code-keyword">new</span> EntityWithNaturalKey(<span class="code-quote">"test"</span>);
s.persist(e);
s.getTransaction().commit();
s.close();
<span class="code-comment">// Assert.assertEquals(0, sessionFactory().getStatistics().getNaturalIdQueryExecutionCount()); // it would be perfect but not necessary
</span>
s = openSession();
s.beginTransaction();
e = (EntityWithNaturalKey) s.bySimpleNaturalId(EntityWithNaturalKey.class).load(<span class="code-quote">"test"</span>);
Assert.assertNotNull(e);
s.getTransaction().commit();
s.close();
<span class="code-object">long</span> queryCount = sessionFactory().getStatistics().getNaturalIdQueryExecutionCount();
<span class="code-comment">// entity must be cached, no more queries bust be issued
</span> <span class="code-comment">// since we didn't modify anything.
</span>
s = openSession();
s.beginTransaction();
e = (EntityWithNaturalKey) s.bySimpleNaturalId(EntityWithNaturalKey.class).load(<span class="code-quote">"test"</span>);
Assert.assertNotNull(e);
s.getTransaction().commit();
s.close();
Assert.assertEquals(queryCount, sessionFactory().getStatistics().getNaturalIdQueryExecutionCount());
}
}
</pre>
</div></div>
</td>
</tr>
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Environment:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
Any.
</td>
</tr>
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Project:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<a style="color:#6c797f;" href="https://hibernate.atlassian.net/browse/HHH">Hibernate ORM</a>
</td>
</tr> <tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Priority:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<img src="https://hibernate.atlassian.net/images/icons/priorities/critical.png" height="16" width="16" border="0" align="absmiddle" alt="Critical"> Critical
</td>
</tr>
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Reporter:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<a class="user-hover" rel="aanisimov" id="email_aanisimov" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=aanisimov" style="color:#6c797f;">Andrew Anisimov</a>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td><!-- End #email-page -->
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
This message is automatically generated by JIRA.<br />
If you think it was sent incorrectly, please contact your JIRA administrators<br />
For more information on JIRA, see: <a style='color:#6c797f;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->