<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
#email-body { min-width: 30em !important; }
#email-page { padding: 8px !important; }
#email-banner { padding: 8px 8px 0 8px !important; }
#email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
#email-fields { padding: 0 8px 8px 8px !important; }
#email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
<tr valign="top">
<td id="email-page" style="padding:16px !important;">
<table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
<tr valign="top">
<td bgcolor="#3e4c4e" style="background-color:#3e4c4e;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="https://www.jboss.org/dms/hibernate/images/jira/jiraheader_hibernate.png" alt="" style="vertical-align:top;" /></td>
</tr><tr valign="top">
<td id="email-banner" style="padding:32px 32px 0 32px;">
<table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
<img id="email-avatar" src="https://secure.gravatar.com/avatar/19097d5cf2cd514aa099c002c7337111?d=mm&s=48" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
<div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
<a class="user-hover" rel="beamerblvd" id="email_beamerblvd" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=beamerblvd" style="color:#6c797f;">Nick Williams</a>
commented on <img src="https://hibernate.atlassian.net/images/icons/issuetypes/bug.png" height="16" width="16" border="0" align="absmiddle" alt="Bug"> <a style='color:#6c797f;text-decoration:none;' href='https://hibernate.atlassian.net/browse/HHH-8111'>HHH-8111</a>
</div>
<div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
<a style='color:#6c797f;text-decoration:none;' href='https://hibernate.atlassian.net/browse/HHH-8111'><strong>AttributeConverter doesn't override built-in type mappings</strong></a>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td id="email-fields" style="padding:0 32px 32px 32px;">
<table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
<tr valign="top">
<td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td colspan="2" style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 16px 0;width:100%;">
<div class="comment-block" style="background-color:#edf5ff;border:1px solid #dddddd;color:#000000;padding:12px;"><p>I don't really understand a lot about what's going on, but I <em>think</em> I know what needs to change. Lines 383-396 of <tt>org.hibernate.mapping.SimpleValue</tt> are as follows:</p>
<div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent">
<pre class="code-java"><span class="code-comment">// AttributeConverter works totally in memory, meaning it converts between one Java representation (the entity
</span><span class="code-comment">// attribute representation) and another (the value bound into JDBC statements or extracted from results).
</span><span class="code-comment">// However, the Hibernate Type system operates at the lower level of actually dealing with those JDBC objects.
</span><span class="code-comment">// So even though we have an AttributeConverter, we still need to <span class="code-quote">"fill out"</span> the <span class="code-keyword">rest</span> of the BasicType
</span><span class="code-comment">// data. For the JavaTypeDescriptor portion we simply resolve the <span class="code-quote">"entity attribute representation"</span> part of
</span><span class="code-comment">// the AttributeConverter to resolve the corresponding descriptor. For the SqlTypeDescriptor portion we use the
</span><span class="code-comment">// <span class="code-quote">"database column representation"</span> part of the AttributeConverter to resolve the <span class="code-quote">"recommended"</span> JDBC type-code
</span><span class="code-comment">// and use that type-code to resolve the SqlTypeDescriptor to use.
</span><span class="code-keyword">final</span> <span class="code-object">Class</span> entityAttributeJavaType = jpaAttributeConverterDefinition.getEntityAttributeType();
<span class="code-keyword">final</span> <span class="code-object">Class</span> databaseColumnJavaType = jpaAttributeConverterDefinition.getDatabaseColumnType();
<span class="code-keyword">final</span> <span class="code-object">int</span> jdbcTypeCode = JdbcTypeJavaClassMappings.INSTANCE.determineJdbcTypeCodeForJavaClass( databaseColumnJavaType );
<span class="code-keyword">final</span> JavaTypeDescriptor javaTypeDescriptor = JavaTypeDescriptorRegistry.INSTANCE.getDescriptor( entityAttributeJavaType );
<span class="code-keyword">final</span> SqlTypeDescriptor sqlTypeDescriptor = SqlTypeDescriptorRegistry.INSTANCE.getDescriptor( jdbcTypeCode );</pre>
</div></div>
<p>In this case, <tt>JavaTypeDescriptorRegistry.INSTANCE.getDescriptor</tt> will return a value based on the field type, not based on the type that the converter converts it to. It SHOULD be base on the type the converter converts it to:</p>
<div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent">
<pre class="code-java"><span class="code-keyword">final</span> JavaTypeDescriptor javaTypeDescriptor = JavaTypeDescriptorRegistry.INSTANCE.getDescriptor( databaseColumnJavaType );</pre>
</div></div>
<p>Now this will return the correct value. In theory. But, like I said, I could be missing something.</p></div>
<div style="color:#505050;padding:4px 0 0 0;"> </div>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td><!-- End #email-page -->
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
This message is automatically generated by JIRA.<br />
If you think it was sent incorrectly, please contact your JIRA administrators<br />
For more information on JIRA, see: <a style='color:#6c797f;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->