<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
#email-body { min-width: 30em !important; }
#email-page { padding: 8px !important; }
#email-banner { padding: 8px 8px 0 8px !important; }
#email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
#email-fields { padding: 0 8px 8px 8px !important; }
#email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
<tr valign="top">
<td id="email-page" style="padding:16px !important;">
<table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
<tr valign="top">
<td bgcolor="#3e4c4e" style="background-color:#3e4c4e;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="https://www.jboss.org/dms/hibernate/images/jira/jiraheader_hibernate.png" alt="" style="vertical-align:top;" /></td>
</tr><tr valign="top">
<td id="email-banner" style="padding:32px 32px 0 32px;">
<table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
<img id="email-avatar" src="https://secure.gravatar.com/avatar/df12d7792bd3b7be3a4edf12cabd58cb?d=mm&s=48" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
<div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
<a class="user-hover" rel="steve" id="email_steve" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=steve" style="color:#6c797f;">Steve Ebersole</a>
updated <img src="https://hibernate.atlassian.net/images/icons/issuetypes/improvement.png" height="16" width="16" border="0" align="absmiddle" alt="Improvement"> <a style='color:#6c797f;text-decoration:none;' href='https://hibernate.atlassian.net/browse/HHH-8284'>HHH-8284</a>
</div>
<div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
<a style='color:#6c797f;text-decoration:none;' href='https://hibernate.atlassian.net/browse/HHH-8284'><strong>Have JPA schema generation include work done by Integrators</strong></a>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td id="email-fields" style="padding:0 32px 32px 32px;">
<table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
<tr valign="top">
<td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td colspan="2" style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 16px 0;width:100%;">
<div class="comment-block" style="background-color:#edf5ff;border:1px solid #dddddd;color:#000000;padding:12px;"><p>I don't think this ever happened... It certainly did not happen by design if it did happen.</p></div>
<div style="color:#505050;padding:4px 0 0 0;"> </div>
</td>
</tr>
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Change By:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<a class="user-hover" rel="steve" id="email_steve" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=steve" style="color:#6c797f;">Steve Ebersole</a>
(01/Jun/13 11:32 AM)
</td>
</tr>
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Description:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">I'm</span>
<span class="diffaddedchars" style="background-color:#ddfade;">Currently {{JpaSchemaGenerator}} is</span>
<span class="diffcontext"> not</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> sure when this bug was introduced, maybe HHH-8113 was the wrong fix</span>
<span class="diffaddedchars" style="background-color:#ddfade;"> picking up stuff contributed by enabled {{org</span>
<span class="diffcontext">.</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> I might have not seen this for a few weeks</span>
<span class="diffaddedchars" style="background-color:#ddfade;">hibernate</span>
<span class="diffcontext">.</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><br><br>The JPASchemaGenerator ignores @NotNull constraints</span>
<span class="diffaddedchars" style="background-color:#ddfade;">integrator</span>
<span class="diffcontext">.</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> The attached screenshots show the call stacks for the Column#setNullable() method during bootstrap with schema generation enabled</span>
<span class="diffaddedchars" style="background-color:#ddfade;">spi</span>
<span class="diffcontext">.</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><br><br>The first call stack shows that JPASchemaGenerator only uses AnnotationBinder and Ejb3Column to determine whether</span>
<span class="diffaddedchars" style="background-color:#ddfade;">Integrator}} (</span>
<span class="diffcontext"> the</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> column</span>
<span class="diffaddedchars" style="background-color:#ddfade;"> Integerators are activated after JpaSchemaGenerator</span>
<span class="diffcontext"> is</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> nullable</span>
<span class="diffaddedchars" style="background-color:#ddfade;"> run)</span>
<span class="diffcontext">.<br><br></span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">The second call stack is buildSessionFactory</span>
<span class="diffaddedchars" style="background-color:#ddfade;">This includes contributions from Bean Validation</span>
<span class="diffcontext">(</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">) running right after performGeneration()</span>
<span class="diffaddedchars" style="background-color:#ddfade;">well</span>
<span class="diffcontext">,</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> here the BeanValidationIntegrator</span>
<span class="diffaddedchars" style="background-color:#ddfade;"> Hibernate Validator anyway, when DDL enforcement</span>
<span class="diffcontext"> is</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> called</span>
<span class="diffaddedchars" style="background-color:#ddfade;"> enabled), Envers and even Hibernate Spatial</span>
<span class="diffcontext">.</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><br></span>
</td>
</tr>
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Issue Type:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">Bug</span>
<span class="diffaddedchars" style="background-color:#ddfade;">Improvement</span>
</td>
</tr>
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Summary:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<span class="diffaddedchars" style="background-color:#ddfade;">Have</span>
<span class="diffcontext">JPA schema</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> generator ignores Bean Validation constraints</span>
<span class="diffaddedchars" style="background-color:#ddfade;"> generation include work done by Integrators</span>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td><!-- End #email-page -->
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
This message is automatically generated by JIRA.<br />
If you think it was sent incorrectly, please contact your JIRA administrators<br />
For more information on JIRA, see: <a style='color:#6c797f;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->