<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
#email-body { min-width: 30em !important; }
#email-page { padding: 8px !important; }
#email-banner { padding: 8px 8px 0 8px !important; }
#email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
#email-fields { padding: 0 8px 8px 8px !important; }
#email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
<tr valign="top">
<td id="email-page" style="padding:16px !important;">
<table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
<tr valign="top">
<td bgcolor="#3e4c4e" style="background-color:#3e4c4e;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="https://www.jboss.org/dms/hibernate/images/jira/jiraheader_hibernate.png" alt="" style="vertical-align:top;" /></td>
</tr><tr valign="top">
<td id="email-banner" style="padding:32px 32px 0 32px;">
<table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
<img id="email-avatar" src="https://secure.gravatar.com/avatar/9d09f05d50ce6624040126d9eaf727b8?d=mm&s=48" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
<div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
<a class="user-hover" rel="emmanuel" id="email_emmanuel" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=emmanuel" style="color:#6c797f;">Emmanuel Bernard</a>
updated <img src="https://hibernate.atlassian.net/images/icons/issuetypes/bug.png" height="16" width="16" border="0" align="absmiddle" alt="Bug"> <a style='color:#6c797f;text-decoration:none;' href='https://hibernate.atlassian.net/browse/HSEARCH-1346'>HSEARCH-1346</a>
</div>
<div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
<a style='color:#6c797f;text-decoration:none;' href='https://hibernate.atlassian.net/browse/HSEARCH-1346'><strong>Selected Facet object not equal to computed Facet object</strong></a>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td id="email-fields" style="padding:0 32px 32px 32px;">
<table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
<tr valign="top">
<td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Change By:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<a class="user-hover" rel="emmanuel" id="email_emmanuel" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=emmanuel" style="color:#6c797f;">Emmanuel Bernard</a>
(04/Jun/13 3:18 PM)
</td>
</tr>
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Description:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<span class="diffcontext">The following pseudo code scenario is expected to work but fails<br><br>{code}<br>//create some facet requests<br>//enable the facet requests<br></span>
<span class="diffaddedchars" style="background-color:#ddfade;"><br>//select by facet1<br></span>
<span class="diffcontext">Facet facet1 = facetManager.getFacets( facetGroupName1 ).get( 0 );<br>facetManager.getFacetGroup( facetGroupName1 ).selectFacets( facet1 );<br></span>
<span class="diffaddedchars" style="background-color:#ddfade;"><br>Facet facet2 = facetManager.getFacets( facetGroupName2 ).get( 0 );<br>//select by facet2 that reduces facet1 count<br>facetManager.getFacetGroup( facetGroupName2 ).selectFacets( facet2 );<br><br></span>
<span class="diffcontext">List<Facet> recomputedFacets = facetManager.getFacets( facetGroupName1 );<br>Facet almostFacet1 = facetManager.getFacets( facetGroupName1 ).get(0);<br>// Following test fails<br>assertTrue( facetManager.getFacetGroup( facetGroupName1 ).contains( almostFacet1 ) ); <br>{code}<br><br>This is due to the fact that facet objects are different (between selected ones and recomputed ones) and that equals takes the count into account.<br><br>There are two possible fixes:<br></span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">-</span>
<span class="diffaddedchars" style="background-color:#ddfade;">1.</span>
<span class="diffcontext"> replace selectedFacet with recomputed ones<br></span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">-</span>
<span class="diffaddedchars" style="background-color:#ddfade;">2.</span>
<span class="diffcontext"> not take count as part of Facet's equality</span>
<span class="diffaddedchars" style="background-color:#ddfade;"><br><br>I think 1. would be impractical especially since Facet reference can float around. So removing count from the equality seems best. However I don't fully understand why Facet.count was part of it in the first place</span>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td><!-- End #email-page -->
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
This message is automatically generated by JIRA.<br />
If you think it was sent incorrectly, please contact your JIRA administrators<br />
For more information on JIRA, see: <a style='color:#6c797f;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->