<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
#email-body { min-width: 30em !important; }
#email-page { padding: 8px !important; }
#email-banner { padding: 8px 8px 0 8px !important; }
#email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
#email-fields { padding: 0 8px 8px 8px !important; }
#email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
<tr valign="top">
<td id="email-page" style="padding:16px !important;">
<table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
<tr valign="top">
<td bgcolor="#3e4c4e" style="background-color:#3e4c4e;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="https://www.jboss.org/dms/hibernate/images/jira/jiraheader_hibernate.png" alt="" style="vertical-align:top;" /></td>
</tr><tr valign="top">
<td id="email-banner" style="padding:32px 32px 0 32px;">
<table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
<div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
<a class="user-hover" rel="steve" id="email_steve" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=steve" style="color:#6c797f;">Steve Ebersole</a>
edited a comment on <img src="https://hibernate.atlassian.net/images/icons/issuetypes/task_agile.png" height="16" width="16" border="0" align="absmiddle" alt="Technical task"> <a style='color:#6c797f;text-decoration:none;' href='https://hibernate.atlassian.net/browse/HHH-8354'>HHH-8354</a>
</div>
<div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
<a style='color:#6c797f;text-decoration:none;' href='https://hibernate.atlassian.net/browse/HHH-8354'><strong>New dirty-checking options based on bytecode enhancement</strong></a>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td id="email-fields" style="padding:0 32px 32px 32px;">
<table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
<tr valign="top">
<td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td colspan="2" style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 16px 0;width:100%;">
<div class="comment-block" style="background-color:#edf5ff;border:1px solid #dddddd;color:#000000;padding:12px;"><blockquote>
<p>not quite sure what the findDirty method should do</p></blockquote>
<p>First, that specific block you are talking about is the default <tt>CustomEntityDirtinessStrategy</tt> strategy to use if the application has not supplied one. <tt>CustomEntityDirtinessStrategy</tt> is a different parallel approach to dirty tracking. This bytecode enhanced dirty tracking does not hook in there. At all. It should hook in the same place that the <tt>CustomEntityDirtinessStrategy</tt> check (and all other dirtiness checking) happens: <tt>org.hibernate.event.internal.DefaultFlushEntityEventListener#dirtyCheck</tt></p>
<p>Ultimately here Hibernate needs to know the attributes that were dirty in terms of an <tt>int[]</tt>. The ints refer to the (internally based) attribute positions. The approach <tt>CustomEntityDirtinessStrategy</tt> takes is to iterate the attributes and for each one to ask the <tt>CustomEntityDirtinessStrategy</tt> (via the <tt>org.hibernate.CustomEntityDirtinessStrategy.DirtyCheckContext#doDirtyChecking</tt> and <tt>org.hibernate.CustomEntityDirtinessStrategy.AttributeChecker#isDirty</tt> communication. You took a different approach and just simply hand the attribute names back to Hibernate. There is nothing wrong with that per-se. <tt>CustomEntityDirtinessStrategy</tt> is from the start intended as a end-user hook-in point, and as such I wanted to make the API and clear and directed as possible. The main focus of <tt>DirtyTracker</tt> from the get-go is actually not end-user focused, so we don't necessarily have the same design goals in mind for both. 0</p>
<p> However within your choice you have to realize that you are bound by certain assumptions. As an example, consider a Person entity with an Address component. Imagine we enhance this entity. Then imagine the application calls: <tt>person.getAddress().setCity( "Austin" )</tt>. You see that there is nothing here to mark Person dirty right? The setter is called on the composite, not the entity.</p>
<p>This gets into what I talked about above. I think ultimately we want to start enhancing composites as well and have them mark their "owner" as dirty when they change. This is tricky though because a composite could be used in multiple attributes across multiple entities/collections.</p></div>
<div style="color:#505050;padding:4px 0 0 0;"> </div>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td><!-- End #email-page -->
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
This message is automatically generated by JIRA.<br />
If you think it was sent incorrectly, please contact your JIRA administrators<br />
For more information on JIRA, see: <a style='color:#6c797f;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->