<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0" /> <base href="https://hibernate.atlassian.net" />
<title>Message Title</title>
</head>
<body class="jira" style="color: #333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<!-- header here -->
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px"> <img id="header-avatar-image" class="image_fix" src="https://secure.gravatar.com/avatar/19097d5cf2cd514aa099c002c7337111?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top" />
</td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="beamerblvd" id="email_beamerblvd" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=beamerblvd" style="color:#6c797f;; color: #3b73af; text-decoration: none">Nick Williams</a> <strong>commented</strong> on an issue
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 15px; background-color: #fff; border-left: 1px solid #ccc; border-top: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly">
</td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 15px 16px; background-color: #fff; border-bottom: 1px solid #ccc; border-bottom: none; padding-bottom: 0px">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text" style="padding: 0px; border-collapse: collapse; padding: 0px; padding-left: 16px; padding-bottom: 10px; border-left: 1px solid #ccc">
<p style="margin: 10px 0 0 0">This bug is actually a duplicate of <a href="https://hibernate.atlassian.net/browse/EJB-224" title="<exclude-unlisted-classes>false</exclude-unlisted-classes> has no effect on J2SE" class="issue-link" data-issue-key="EJB-224" style="color: #3b73af; text-decoration: none"></a></p>
<del>
EJB-224
</del>, but that bug (filed in 2006) was never fixed. It was marked as a duplicate of a bug that was actually different (<a href="https://hibernate.atlassian.net/browse/EJB-212" title="excludeUnlistedClasses ignored in SE case" class="issue-link" data-issue-key="EJB-212" style="color: #3b73af; text-decoration: none"></a>
<del>
EJB-212
</del>), and when <a href="https://hibernate.atlassian.net/browse/EJB-212" title="excludeUnlistedClasses ignored in SE case" class="issue-link" data-issue-key="EJB-212" style="color: #3b73af; text-decoration: none"></a>
<del>
EJB-212
</del> was fixed <a href="https://hibernate.atlassian.net/browse/EJB-224" title="<exclude-unlisted-classes>false</exclude-unlisted-classes> has no effect on J2SE" class="issue-link" data-issue-key="EJB-224" style="color: #3b73af; text-decoration: none"></a>
<del>
EJB-224
</del> remained broken. 7 years later it is still broken.
<p style="margin: 10px 0 0 0">The title of this should be changed to "exclude-unlisted-classes is not parsed correctly with explicit value," but I can't change it.</p>
<p style="margin: 10px 0 0 0">I made some mistakes in my original posting but I cannot edit the description, either, so I will revise it here (due to discussion about element defaults <a href="http://www.codesynthesis.com/pipermail/xsd-users/2008-August/001885.html" class="external-link" rel="nofollow" style="color: #3b73af; text-decoration: none">here</a> and the identical Spring Framework bug <a href="https://jira.springsource.org/browse/SPR-10767" class="external-link" rel="nofollow" style="color: #3b73af; text-decoration: none">SPR-10767</a>). Please ignore the description and focus instead of this:</p>
<p style="margin: 10px 0 0 0">In JPA 1.0 <em><b>AND</b></em> 2.0, <tt><exclude-unlisted-classes></tt> has the following usage:</p>
<ol>
<li>
Omitted means don't exclude / do scan.
</li>
<li>
<tt><exclude-unlisted-classes /></tt> means exclude / don't scan.
</li>
<li>
<tt><exclude-unlisted-classes>false</exclude-unlisted-classes></tt> means don't exclude / do scan.
</li>
<li>
<tt><exclude-unlisted-classes>true</exclude-unlisted-classes></tt> means exclude / don't scan.
</li>
</ol>
<p style="margin: 10px 0 0 0">A test case is attached. As attached, <tt>persistence.xml</tt> contains this:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-xml" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">...
<span class="code-tag" style="color: #000091"><!--<class></span>com.wrox.site.entities.Author<span class="code-tag" style="color: #000091"></class></span>
<span class="code-tag" style="color: #000091"><class></span>com.wrox.site.entities.Book<span class="code-tag" style="color: #000091"></class></span>
<span class="code-tag" style="color: #000091"><class></span>com.wrox.site.entities.Publisher<span class="code-tag" style="color: #000091"></class></span>
<span class="code-tag" style="color: #000091"><exclude-unlisted-classes></span>false<span class="code-tag" style="color: #000091"></exclude-unlisted-classes></span>-->
...</pre>
</div>
</div>
<p style="margin: 10px 0 0 0">Notice that it all is commented out. If you compile and run this (in Tomcat), the entity classes are picked up (which <em><b>is</b></em> correct). Change <tt>persistence.xml</tt> to this (uncommenting just <tt><exclude-unlisted-classes></tt>):</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-xml" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">...
<span class="code-tag" style="color: #000091"><!--<class></span>com.wrox.site.entities.Author<span class="code-tag" style="color: #000091"></class></span>
<span class="code-tag" style="color: #000091"><class></span>com.wrox.site.entities.Book<span class="code-tag" style="color: #000091"></class></span>
<span class="code-tag" style="color: #000091"><class></span>com.wrox.site.entities.Publisher<span class="code-tag" style="color: #000091"></class></span>-->
<span class="code-tag" style="color: #000091"><exclude-unlisted-classes></span>false<span class="code-tag" style="color: #000091"></exclude-unlisted-classes></span>
...</pre>
</div>
</div>
<p style="margin: 10px 0 0 0">Now run it and the entity classes are NOT picked up, which <em><b>is not</b></em> correct. The behavior should be the reverse in this case. Now change the <tt>false</tt> to <tt>true</tt>:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-xml" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">...
<span class="code-tag" style="color: #000091"><!--<class></span>com.wrox.site.entities.Author<span class="code-tag" style="color: #000091"></class></span>
<span class="code-tag" style="color: #000091"><class></span>com.wrox.site.entities.Book<span class="code-tag" style="color: #000091"></class></span>
<span class="code-tag" style="color: #000091"><class></span>com.wrox.site.entities.Publisher<span class="code-tag" style="color: #000091"></class></span>-->
<span class="code-tag" style="color: #000091"><exclude-unlisted-classes></span>true<span class="code-tag" style="color: #000091"></exclude-unlisted-classes></span>
...</pre>
</div>
</div>
<p style="margin: 10px 0 0 0">And the entities are still NOT picked up, which in this case <em><b>is</b></em> correct. So the explicit values are simply being ignored. A quick look at the current code confirms this:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal"> <span class="code-keyword" style="color: #000091">else</span> <span class="code-keyword" style="color: #000091">if</span> ( tag.equals( <span class="code-quote" style="color: #009100">"exclude-unlisted-classes"</span> ) ) {
persistenceUnit.setExcludeUnlistedClasses( <span class="code-keyword" style="color: #000091">true</span> );
}</pre>
</div>
</div>
<p style="margin: 10px 0 0 0">My suggested code below resolves this issue:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal"> <span class="code-keyword" style="color: #000091">private</span> void bindPersistenceUnit(ParsedPersistenceXmlDescriptor persistenceUnit, Element persistenceUnitElement) {
...
persistenceUnit.setExcludeUnlistedClasses( <span class="code-keyword" style="color: #000091">false</span> );
NodeList children = persistenceUnitElement.getChildNodes();
<span class="code-keyword" style="color: #000091">for</span> ( <span class="code-object" style="color: #910091">int</span> i = 0; i < children.getLength() ; i++ ) {
...
<span class="code-keyword" style="color: #000091">else</span> <span class="code-keyword" style="color: #000091">if</span> ( tag.equals( <span class="code-quote" style="color: #009100">"exclude-unlisted-classes"</span> ) ) {
persistenceUnit.setExcludeUnlistedClasses( extractBooleanContent(element, <span class="code-keyword" style="color: #000091">true</span>) );
}
...
}
}
...
<span class="code-keyword" style="color: #000091">private</span> <span class="code-keyword" style="color: #000091">static</span> <span class="code-object" style="color: #910091">boolean</span> extractBooleanContent(Element element, <span class="code-object" style="color: #910091">boolean</span> defaultBool) {
<span class="code-object" style="color: #910091">String</span> content = extractContent( element, <span class="code-keyword" style="color: #000091">null</span> );
<span class="code-keyword" style="color: #000091">if</span> (content != <span class="code-keyword" style="color: #000091">null</span> && content.length() > 0) {
<span class="code-keyword" style="color: #000091">return</span> <span class="code-object" style="color: #910091">Boolean</span>.valueOf(content);
}
<span class="code-keyword" style="color: #000091">return</span> defaultBool;
}</pre>
</div>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 15px 16px; background-color: #fff">
<table id="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="page-title-pattern-first-line" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 16px"> <a href="https://hibernate.atlassian.net/browse/HHH" style="color: #3b73af; text-decoration: none">Hibernate ORM</a> / <a href="https://hibernate.atlassian.net/browse/HHH-8364" style="color: #3b73af; text-decoration: none"><img src="https://hibernate.atlassian.net/images/icons/issuetypes/bug.png" height="16" width="16" border="0" align="absmiddle" alt="Bug" /></a> <a href="https://hibernate.atlassian.net/browse/HHH-8364" style="color: #3b73af; text-decoration: none">HHH-8364</a>
</td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" id="page-title-pattern-header-container"> <span id="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-8364" style="color: #3b73af; text-decoration: none">exclude-unlisted-classes no longer works correctly with JPA 2.0</a> </span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 15px 16px; background-color: #fff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 0 0 0 24px; vertical-align: middle; padding-left: 0px">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-8364#add-comment" target="_blank" title="{getText($action.text)}" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="https://hibernate.atlassian.net/images/mail/comment-icon.png" alt="Add Comment" title="{Add Comment}-icon" height="16" width="16" border="0" style="vertical-align: middle" /> </a>
</td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-8364#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #fff; border-top: 0; border-left: 1px solid #ccc; border-bottom: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly">
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px">
This message is automatically generated by JIRA.<br /> If you think it was sent incorrectly, please contact your JIRA administrators<br /> For more information on JIRA, see: <a style="color:#6c797f;; color: #3b73af; text-decoration: none" href="http://www.atlassian.com/software/jira">http://www.atlassian.com/software/jira</a>
</td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="https://hibernate.atlassian.net/images/mail/footer-desktop-logo.png" alt="JIRA logo" title="JIRA logo" width="92" height="36" class="image_fix" />
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</body>
</html>