<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0" /> <base href="https://hibernate.atlassian.net" />
<title>Message Title</title>
</head>
<body class="jira" style="color: #333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<!-- header here -->
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px"> <img id="header-avatar-image" class="image_fix" src="https://secure.gravatar.com/avatar/ec96387a1a8295b6fd6dffb68f80c352?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top" />
</td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="gsmet" id="email_gsmet" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=gsmet" style="color:#6c797f;; color: #3b73af; text-decoration: none">Guillaume Smet</a> <strong>edited a comment</strong> on an issue
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 15px; background-color: #fff; border-left: 1px solid #ccc; border-top: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly">
</td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-special-margin comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 15px 16px; background-color: #fff; border-bottom: 1px solid #ccc; border-bottom: none; padding-bottom: 0px">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text" style="padding: 0px; border-collapse: collapse; padding: 0px; padding-left: 16px; padding-bottom: 10px; border-left: 1px solid #ccc; padding-top: 10px"> <span class="diffcontext">I started my work here:</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><br /></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br /></span> <span class="diffcontext">https://github.com/openwide-java/hibernate-search/commits/HSEARCH-1392</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><br /><br /></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br /><br /></span> <span class="diffcontext">I already fixed a couple of problems and enabled the enforcer DependencyConvergence rule, except for the hibernate-search-integrationtest-as module which has a *lot* of dependency issues and it will be a real pain to maintain a dependencyManagement for all these problems.</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><br /><br /></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br /><br /></span> <span class="diffcontext">I removed a couple of properties I shouldn't have removed as they are used in the modules. I kept my commits as is as I think it's interesting for the next one to see they shouldn't be removed - and I also added comments to prevent it.</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><br /><br /></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br /><br /></span> <span class="diffcontext">What I would like to do now:</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><br /><br /></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br /><br /></span> <span class="diffcontext">Cleaning up:</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><br /></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br /></span> <span class="diffcontext">- Reorganize the properties and the dependencies to be a bit more logical: especially group Hibernate / Lucene / Test dependencies.</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><br /></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br /></span> <span class="diffcontext">- Add the properties for the dependencies used in integration tests in the parent pom. I don't think it's a good idea to move the dependencyManagement in the parent pom but the versions would be a good reminder. The fact that they are really outdated is a good sign that they have been forgotten.</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><br /></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br /></span> <span class="diffcontext">- Be consistent for the property naming convention: it's not consistent between the parent pom and the integration tests (commonsCodecVersion, version.jboss.as, spring-release-version). I personnaly favor something like ${commons-codec.version} (${artifact-id.version}) and for the integration tests, I would have gone with ${integration-as.jboss-as.version}, ${integration-spring.spring.version}.</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><br /><br /></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br /><br /></span> <span class="diffcontext">Dependency upgrade:</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><br /><br /></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br /><br /></span> <span class="diffcontext">- Upgrade slf4j to the latest 1.6.x (1.6.6). We are currently using 1.6.1 which is needed by Solr but Avro already requires 1.6.4.</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><br /></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br /></span> <span class="diffcontext">- Upgrade Tika to 1.4: AFAICS, it's only used by Hibernate Search directly, not by its dependencies. It's usually a good idea to upgrade Tika as there are often a lot of fixes on the filters.</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><br /></span> <span class="diffaddedchars" style="background-color:#ddfade;"> It might be a good idea to create a specific issue for this one to have it in the changelog?<br /></span> <span class="diffcontext">- Upgrade all the test dependencies.</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><br /></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br /></span> <span class="diffcontext">- Upgrade Avro to 1.7.3? Looks like the upgrade is painless. I don't have any compilation error. But maybe it's still in 1.6 to be consistent with other components of the JBoss stack? This one is probably more 5.0 material as it touches the clustering part which is probably harder to test.</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><br /><br /></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br /><br /></span> <span class="diffcontext">Feedback welcome.</span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 15px 16px; background-color: #fff">
<table id="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="page-title-pattern-first-line" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 16px"> <a href="https://hibernate.atlassian.net/browse/HSEARCH" style="color: #3b73af; text-decoration: none">Hibernate Search</a> / <a href="https://hibernate.atlassian.net/browse/HSEARCH-1392" style="color: #3b73af; text-decoration: none"><img src="https://hibernate.atlassian.net/images/icons/issuetypes/improvement.png" height="16" width="16" border="0" align="absmiddle" alt="Improvement" /></a> <a href="https://hibernate.atlassian.net/browse/HSEARCH-1392" style="color: #3b73af; text-decoration: none">HSEARCH-1392</a>
</td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" id="page-title-pattern-header-container"> <span id="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HSEARCH-1392" style="color: #3b73af; text-decoration: none">Assorted fixes to the pom files for 4.4.0</a> </span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 15px 16px; background-color: #fff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 0 0 0 24px; vertical-align: middle; padding-left: 0px">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HSEARCH-1392#add-comment" target="_blank" title="{getText($action.text)}" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="https://hibernate.atlassian.net/images/mail/comment-icon.png" alt="Add Comment" title="{Add Comment}-icon" height="16" width="16" border="0" style="vertical-align: middle" /> </a>
</td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HSEARCH-1392#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #fff; border-top: 0; border-left: 1px solid #ccc; border-bottom: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly">
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px">
This message is automatically generated by JIRA.<br /> If you think it was sent incorrectly, please contact your JIRA administrators<br /> For more information on JIRA, see: <a style="color:#6c797f;; color: #3b73af; text-decoration: none" href="http://www.atlassian.com/software/jira">http://www.atlassian.com/software/jira</a>
</td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="https://hibernate.atlassian.net/images/mail/footer-desktop-logo.png" alt="JIRA logo" title="JIRA logo" width="92" height="36" class="image_fix" />
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</body>
</html>