<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0" /> <base href="https://hibernate.atlassian.net" />
<title>Message Title</title>
</head>
<body class="jira" style="color: #333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<!-- header here -->
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px"> <img id="header-avatar-image" class="image_fix" src="https://secure.gravatar.com/avatar/19097d5cf2cd514aa099c002c7337111?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top" />
</td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="beamerblvd" id="email_beamerblvd" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=beamerblvd" style="color:#6c797f;; color: #3b73af; text-decoration: none">Nick Williams</a> <strong>edited a comment</strong> on an issue
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 15px; background-color: #fff; border-left: 1px solid #ccc; border-top: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly">
</td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-special-margin comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 15px 16px; background-color: #fff; border-bottom: 1px solid #ccc; border-bottom: none; padding-bottom: 0px">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text" style="padding: 0px; border-collapse: collapse; padding: 0px; padding-left: 16px; padding-bottom: 10px; border-left: 1px solid #ccc; padding-top: 10px"> <span class="diffcontext">I never intended for you to misunderstand my incredulity, as you likely very accurately called it, for how long it took to fix this. I'm a committer on several open source projects and a contributor to</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> ever</span> <span class="diffaddedchars" style="background-color:#ddfade;"> even</span> <span class="diffcontext"> more. I'm well aware about how long it can take to fix a bug in open source, and it was _not_ what I was upset about.</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><br /><br /></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br /><br /></span> <span class="diffcontext">My frustration derived from the fact that this issue had gone five months without _acknowledgement_. Not a single person had responded with "thanks for the report, we'll look into it as soon as we can" or anything like that. I have _never_ had that experience with an open source project. _Ever_. Taking five months to fix I can understand. Taking five months to get someone to even say anything is what I take issue with.</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><br /><br /></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br /><br /></span> <span class="diffcontext">If five months ago someone had said, "Thanks. It might take us a while to look into this," I would have very quickly responded with, "If you can give me some direction on where to look I'll see if I can take care of it." But, even with regular comments on this issue from me and others continuously keeping it on the feed on the Jira dashboard, nobody said a peep. Unfortunately I couldn't just dive in because I'm in the middle of writing a JavaEE/Spring/JPA/Hibernate/Security book and contributing has been at the bottom of my list lately. I only spent the last WEEK that I spent working on this because it started blocking progress on my book and I couldn't proceed anymore. I was very blindly working on a code base that, I must say, is one of the most confusing code bases I have ever seen in 10 years of working with Java.</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><br /><br /></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br /><br /></span> <span class="diffcontext">And, unfortunately, it was not as simple as a one-liner. In addition to building the {{JavaTypeDescriptor}} based on the {{databaseColumnType}}, I also had to fix issues with the following:</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><br /><br /></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br /><br /></span> <span class="diffcontext"># The {{JavaTypeDescriptor}} for {{Serializable}} matching before other, more-specific descriptors.</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><br /></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br /></span> <span class="diffcontext"># The code in the descriptor registry having a reversed {{isAssignableFrom}} invocation.</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><br /></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br /></span> <span class="diffcontext"># The code calling things like {{getComparator}}, {{extractHashCode}}, {{areEqual}}, {{extractLoggableRepresentation}}, {{toString}}, and {{fromString}} on the {{JavaTypeDescriptor}}. However, since this descriptor is for the database Java type being converted to (for example, {{java.sql.Timestamp}}) instead of the entity attribute being converted from (for example, {{java.time.Instant}}) and the code was passing in the entity attribute, it was always going to fail (you can't cast {{Instant}} to {{Timestamp}} and compare it in the {{JdbcTimestampJavaTypeDescriptor}}).</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><br /><br /></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br /><br /></span> <span class="diffcontext">So, yes, considering all of this that still remained, I would call this "incomplete." Not "completely missing," but "incomplete." The frustrating part isn't that it was incomplete (which I would understand), but that the Hibernate website says otherwise ("only entity graphs remain to be completed"). _If_ this work was tested (which I'll take your word on, if so), it was _only_ tested converting between one type that Hibernate already supported and another type that Hibernate already supported, which is not a common use case for {{AttributeConverters}}. The whole purpose for the {{AttributeConverter}} feature is converting for types that the JPA provider does not already support, something that could not have been tested because I broke in every way imaginable.</span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 15px 16px; background-color: #fff">
<table id="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="page-title-pattern-first-line" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 16px"> <a href="https://hibernate.atlassian.net/browse/HHH" style="color: #3b73af; text-decoration: none">Hibernate ORM</a> / <a href="https://hibernate.atlassian.net/browse/HHH-8111" style="color: #3b73af; text-decoration: none"><img src="https://hibernate.atlassian.net/images/icons/issuetypes/bug.png" height="16" width="16" border="0" align="absmiddle" alt="Bug" /></a> <a href="https://hibernate.atlassian.net/browse/HHH-8111" style="color: #3b73af; text-decoration: none">HHH-8111</a>
</td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" id="page-title-pattern-header-container"> <span id="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-8111" style="color: #3b73af; text-decoration: none">AttributeConverter doesn't override built-in type mappings</a> </span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 15px 16px; background-color: #fff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 0 0 0 24px; vertical-align: middle; padding-left: 0px">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-8111#add-comment" target="_blank" title="{getText($action.text)}" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="https://hibernate.atlassian.net/images/mail/comment-icon.png" alt="Add Comment" title="{Add Comment}-icon" height="16" width="16" border="0" style="vertical-align: middle" /> </a>
</td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-8111#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #fff; border-top: 0; border-left: 1px solid #ccc; border-bottom: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly">
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px">
This message is automatically generated by JIRA.<br /> If you think it was sent incorrectly, please contact your JIRA administrators<br /> For more information on JIRA, see: <a style="color:#6c797f;; color: #3b73af; text-decoration: none" href="http://www.atlassian.com/software/jira">http://www.atlassian.com/software/jira</a>
</td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="https://hibernate.atlassian.net/images/mail/footer-desktop-logo.png" alt="JIRA logo" title="JIRA logo" width="92" height="36" class="image_fix" />
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</body>
</html>