<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0" /> <base href="https://hibernate.atlassian.net" />
<title>Message Title</title>
</head>
<body class="jira" style="color: #333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<!-- header here -->
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px"> <img id="header-avatar-image" class="image_fix" src="https://secure.gravatar.com/avatar/8e505cd452c21a4a81a29ca20c8f5368?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top" />
</td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="ghu" id="email_ghu" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=ghu" style="color:#6c797f;; color: #3b73af; text-decoration: none">Gary Hu</a> <strong>commented</strong> on <a href="https://hibernate.atlassian.net/browse/HHH-8643" style="color: #3b73af; text-decoration: none"><img src="https://hibernate.atlassian.net/images/icons/issuetypes/bug.png" height="16" width="16" border="0" align="absmiddle" alt="Bug" /> HHH-8643</a>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 15px; background-color: #fff; border-left: 1px solid #ccc; border-top: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly">
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-8643" style="color: #3b73af; text-decoration: none">Re: java.util.Calendar conversion to java.util.Date fails </a> </span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff; border-bottom: none; padding-bottom: 0">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0">
<p style="margin: 10px 0 0 0">When using java.util.Calendar in a query to retrieve an entity class containing a field of java.util.Date type it throws exceptions. </p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
Caused by: java.lang.IllegalArgumentException: Parameter value [java.util.GregorianCalendar[time=1382561831603,areFieldsSet=<span class="code-keyword" style="color: #000091">true</span>,areAllFieldsSet=<span class="code-keyword" style="color: #000091">true</span>,lenient=<span class="code-keyword" style="color: #000091">true</span>,zone=sun.util.calendar.ZoneInfo[id=<span class="code-quote" style="color: #009100">"America/Chicago"</span>,offset=-21600000,dstSavings=3600000,useDaylight=<span class="code-keyword" style="color: #000091">true</span>,transitions=235,lastRule=java.util.SimpleTimeZone[id=America/Chicago,offset=-21600000,dstSavings=3600000,useDaylight=<span class="code-keyword" style="color: #000091">true</span>,startYear=0,startMode=3,startMonth=2,startDay=8,startDayOfWeek=1,startTime=7200000,startTimeMode=0,endMode=3,endMonth=10,endDay=1,endDayOfWeek=1,endTime=7200000,endTimeMode=0]],firstDayOfWeek=1,minimalDaysInFirstWeek=1,ERA=1,YEAR=2013,MONTH=9,WEEK_OF_YEAR=43,WEEK_OF_MONTH=4,DAY_OF_MONTH=23,DAY_OF_YEAR=296,DAY_OF_WEEK=4,DAY_OF_WEEK_IN_MONTH=4,AM_PM=1,HOUR=3,HOUR_OF_DAY=15,MINUTE=57,SECOND=11,MILLISECOND=603,ZONE_OFFSET=-21600000,DST_OFFSET=3600000]] did not match expected type [java.util.Date]
at org.hibernate.ejb.AbstractQueryImpl.validateParameterBinding(AbstractQueryImpl.java:375) [hibernate-entitymanager-4.2.0.SP1-redhat-1.jar:4.2.0.SP1-redhat-1]
at org.hibernate.ejb.AbstractQueryImpl.registerParameterBinding(AbstractQueryImpl.java:348) [hibernate-entitymanager-4.2.0.SP1-redhat-1.jar:4.2.0.SP1-redhat-1]
at org.hibernate.ejb.QueryImpl.setParameter(QueryImpl.java:419) [hibernate-entitymanager-4.2.0.SP1-redhat-1.jar:4.2.0.SP1-redhat-1]
at org.hibernate.ejb.QueryImpl.setParameter(QueryImpl.java:73) [hibernate-entitymanager-4.2.0.SP1-redhat-1.jar:4.2.0.SP1-redhat-1]
at org.jboss.as.jpa.container.QueryNonTxInvocationDetacher.setParameter(QueryNonTxInvocationDetacher.java:142) [jboss-as-jpa-7.2.1.Final-redhat-10.jar:7.2.1.Final-redhat-10]
</pre>
</div>
</div>
<p style="margin: 10px 0 0 0">The same code worked fine in EAP 5 with Hibernate 3.<br /> Here are the code snippets:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<span class="code-comment" style="color: #808080">// With GregorianCalendar the execution failed in EAP6.1, but NOT in EAP5!
</span><span class="code-comment" style="color: #808080">// GregorianCalendar date = <span class="code-keyword" style="color: #000091; color: #808080">new</span> GregorianCalendar();
</span><span class="code-comment" style="color: #808080">// With Date the execution successes in EAP6.1!
</span>Date date = <span class="code-keyword" style="color: #000091">new</span> Date();
Query query = <span class="code-keyword" style="color: #000091">this</span>.manager.createQuery(<span class="code-quote" style="color: #009100">"from xxx where maketime <= :_maketime"</span>);
query.setParameter(<span class="code-quote" style="color: #009100">"_maketime"</span>, date, TemporalType.TIMESTAMP);
<span class="code-keyword" style="color: #000091">return</span> query.getResultList();
@Entity
<span class="code-keyword" style="color: #000091">public</span> class xxx <span class="code-keyword" style="color: #000091">implements</span> Serializable {
...
<span class="code-keyword" style="color: #000091">private</span> Date maketime;
<span class="code-keyword" style="color: #000091">public</span> Date getMaketime()
{ <span class="code-keyword" style="color: #000091">return</span> maketime; }
<span class="code-keyword" style="color: #000091">public</span> void setMaketime(Date maketime)
{ <span class="code-keyword" style="color: #000091">this</span>.maketime = maketime; }
}
</pre>
</div>
</div>
<p style="margin: 10px 0 0 0">I've checked the hibernate source code.<br /> In hibernate-entitymanager-3.4.0.GA-CP04(eap 5.1.2), I find the following code that seems to allow both java.util.Date and java.util.Calendar to work.<br /> org.hibernate.ejb.QueryImpl.java:<br /> public Query setParameter(String name, Date value, TemporalType temporalType);<br /> public Query setParameter(String name, Calendar value, TemporalType temporalType);<br /> The similar code still exists in hibernate-entitymanager-4.2.0.SP1-redhat-1 in org.hibernate.ejb.QueryImpl. However, it adds call to <br /> registerParameterBinding( getParameter(name), value );<br /> which in turns calls <br /> private void validateParameterBinding(Parameter parameter, Object value)<br /> in org.hibernate.ejb.AbstractQueryImpl:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<span class="code-keyword" style="color: #000091">private</span> void validateParameterBinding(Parameter parameter, <span class="code-object" style="color: #910091">Object</span> value) {
<span class="code-keyword" style="color: #000091">if</span> ( value == <span class="code-keyword" style="color: #000091">null</span> || parameter.getParameterType() == <span class="code-keyword" style="color: #000091">null</span> )
{ <span class="code-comment" style="color: #808080">// nothing we can check <span class="code-keyword" style="color: #000091; color: #808080">return</span>; }
</span><span class="code-keyword" style="color: #000091">if</span> ( Collection.class.isInstance( value )
&& ! Collection.class.isAssignableFrom( parameter.getParameterType() ) )
{ <span class="code-comment" style="color: #808080">// we have a collection passed in where we are expecting a non-collection. // NOTE : <span class="code-keyword" style="color: #000091; color: #808080">this</span> can happen in Hibernate's notion of <span class="code-quote" style="color: #009100; color: #808080">"parameter list"</span> binding // NOTE2 : the <span class="code-keyword" style="color: #000091; color: #808080">case</span> of a collection value and an expected collection (<span class="code-keyword" style="color: #000091; color: #808080">if</span> that can even happen) // will fall through to the main check. validateCollectionValuedParameterMultiBinding( parameter, (Collection) value ); }
</span><span class="code-keyword" style="color: #000091">else</span> <span class="code-keyword" style="color: #000091">if</span> ( value.getClass().isArray() )
{ validateArrayValuedParameterBinding( parameter, value ); }
<span class="code-keyword" style="color: #000091">else</span> {
<span class="code-keyword" style="color: #000091">if</span> ( ! parameter.getParameterType().isInstance( value ) )
{ <span class="code-keyword" style="color: #000091">throw</span> <span class="code-keyword" style="color: #000091">new</span> IllegalArgumentException( <span class="code-object" style="color: #910091">String</span>.format( <span class="code-quote" style="color: #009100">"Parameter value [%s] did not match expected type [%s]"</span>, value, parameter.getParameterType().getName() ) ); }
}
}
</pre>
</div>
</div>
<p style="margin: 10px 0 0 0">Is this the expected behavior? Any reason we make such change?<br /> I've also checked the JPA spec 2.0. It doesn't mention that java.util.Calendar should work with java.util.Date field or vice visa. It only mentions that the java.util.Date and java.util.Calendar should be supported for TemporalType.TIMESTAMP in "11.1.47 Temporal Annotation".</p>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-8643#add-comment" target="_blank" title="{getText($action.text)}" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="https://hibernate.atlassian.net/images/mail/comment-icon.png" alt="Add Comment" title="{Add Comment}-icon" height="16" width="16" border="0" style="vertical-align: middle" /> </a>
</td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-8643#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #fff; border-top: 0; border-left: 1px solid #ccc; border-bottom: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly">
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px">
This message was sent by Atlassian JIRA <span id="footer-build-information">(v6.2-OD-01#6204-<span title="9a81f1273565b708db95415d383556dcb6085057" data-commit-id="9a81f1273565b708db95415d383556dcb6085057}">sha1:9a81f12</span>)</span>
</td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="https://hibernate.atlassian.net/images/mail/footer-desktop-logo.png" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix" />
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</body>
</html>