<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0" /> <base href="https://hibernate.atlassian.net" />
<title>Message Title</title>
</head>
<body class="jira" style="color: #333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<!-- header here -->
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px"> <img id="header-avatar-image" class="image_fix" src="https://secure.gravatar.com/avatar/ba969a71818dc92ac9f73c861f21065b?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top" />
</td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="raffig" id="email_raffig" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=raffig" style="color:#6c797f;; color: #3b73af; text-decoration: none">Rafal Figas</a> <strong>created</strong> an issue
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 15px; background-color: #fff; border-left: 1px solid #ccc; border-top: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly">
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class="page-title-pattern-first-line " style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://hibernate.atlassian.net/browse/HHH" style="color: #3b73af; text-decoration: none">Hibernate ORM</a> / <a href="https://hibernate.atlassian.net/browse/HHH-8982" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-static-bug-eaf0c024-6053-4a5d-8495-156f2b972305" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom" /></a> <a href="https://hibernate.atlassian.net/browse/HHH-8982" style="color: #3b73af; text-decoration: none">HHH-8982</a>
</td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-8982" style="color: #3b73af; text-decoration: none">Set of value objects with primary key and composite user type causes GenericJDBCException with index out of range</a> </span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff; padding-top: 10px; padding-bottom: 5px">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Issue Type:
</th>
<td class="has-icon" style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <img src="cid:jira-generated-image-static-bug-eaf0c024-6053-4a5d-8495-156f2b972305" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom" /> Bug
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Affects Versions:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top">
4.2.8
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Assignee:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top">
Unassigned
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Components:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top">
core
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Created:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top">
18/Feb/14 9:06 AM
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Environment:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top">
HIbernate 4.2, HSQL, Java 6, Windows 7
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Priority:
</th>
<td class="has-icon" style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <img src="cid:jira-generated-image-static-major-b678c5d7-c4b7-49c4-beee-0d3abd081cb5" height="16" width="16" border="0" align="absmiddle" alt="Major" style="vertical-align: text-bottom" /> Major
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Reporter:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="raffig" id="email_raffig" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=raffig" style="color:#6c797f;; color: #3b73af; text-decoration: none">Rafal Figas</a>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff; padding-top: 5px; padding-bottom: 10px">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0">
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">First goes mappings, logs, code etc. Below find lyric description.</p>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">Mapping:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-xml" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<span class="code-tag" style="color: #000091"><class name=<span class="code-quote" style="color: #009100">"SimcCodedAddressTypeTest$SampleTestEntity2"</span> table=<span class="code-quote" style="color: #009100">"address_entity2"</span>></span>
<span class="code-tag" style="color: #000091"><id name=<span class="code-quote" style="color: #009100">"id"</span> column=<span class="code-quote" style="color: #009100">"id"</span> type=<span class="code-quote" style="color: #009100">"int"</span>></span>
<span class="code-tag" style="color: #000091"><generator class=<span class="code-quote" style="color: #009100">"native"</span>></span><span class="code-tag" style="color: #000091"></generator></span>
<span class="code-tag" style="color: #000091"></id></span>
<span class="code-tag" style="color: #000091"><set name=<span class="code-quote" style="color: #009100">"sampleVOS"</span> table=<span class="code-quote" style="color: #009100">"vos"</span>></span>
<span class="code-tag" style="color: #000091"><key column=<span class="code-quote" style="color: #009100">"FKentity"</span> not-null=<span class="code-quote" style="color: #009100">"true"</span>></span>
<span class="code-tag" style="color: #000091"></key></span>
<composite-element
class=<span class="code-quote" style="color: #009100">"pl.frati.dynx.contact.hibernate.types.SimcCodedAddressTypeTest$SampleVO"</span>>
<span class="code-tag" style="color: #000091"><property name=<span class="code-quote" style="color: #009100">"id"</span> not-null=<span class="code-quote" style="color: #009100">"true"</span> /></span>
<span class="code-tag" style="color: #000091"><property name=<span class="code-quote" style="color: #009100">"name"</span> /></span>
<property name=<span class="code-quote" style="color: #009100">"address"</span>
type=<span class="code-quote" style="color: #009100">"pl.frati.dynx.contact.hibernate.types.SimcCodedAddressType"</span>>
<span class="code-tag" style="color: #000091"><column name=<span class="code-quote" style="color: #009100">"simc_1"</span> /></span>
<span class="code-tag" style="color: #000091"><column name=<span class="code-quote" style="color: #009100">"street_1"</span> /></span>
<span class="code-tag" style="color: #000091"><column name=<span class="code-quote" style="color: #009100">"building_no_1"</span> /></span>
<span class="code-tag" style="color: #000091"><column name=<span class="code-quote" style="color: #009100">"flat_no_1"</span> /></span>
<span class="code-tag" style="color: #000091"><column name=<span class="code-quote" style="color: #009100">"postal_code_1"</span> /></span>
<span class="code-tag" style="color: #000091"><column name=<span class="code-quote" style="color: #009100">"post_office_1"</span> /></span>
<span class="code-tag" style="color: #000091"></property></span>
<span class="code-tag" style="color: #000091"></composite-element></span>
<span class="code-tag" style="color: #000091"></set></span>
<span class="code-tag" style="color: #000091"></class></span>
</pre>
</div>
</div>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">Assume that there is entity that contains two value objects in the set, and the code tries to remove one of them:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
session = sf.openSession();
session.beginTransaction();
entity = (SampleTestEntity2) session.get(SampleTestEntity2.class, entityId);
Assert.assertNotNull(entity);
Assert.assertNotNull(entity.sampleVOS);
Assert.assertEquals(2, entity.sampleVOS.size());
Assert.assertTrue(entity.sampleVOS.contains(vo1));
Assert.assertTrue(entity.sampleVOS.contains(vo2));
entity.sampleVOS.remove(vo2);
session.getTransaction().commit();
session.close();
</pre>
</div>
</div>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">This will cause an exception that is attached, but most important part is:</p>
<div class="panel" style="border-width: 1px;; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="panelContent" style="padding: 9px 12px">
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">org.hibernate.exception.GenericJDBCException: could not delete collection rows: <a href="#1" style="color: #3b73af; text-decoration: none">pl.frati.dynx.contact.hibernate.types.SimcCodedAddressTypeTest$SampleTestEntity2.sampleVOS#1</a><br /> at org.hibernate.exception.internal.StandardSQLExceptionConverter.convert(StandardSQLExceptionConverter.java:54)<br /> Caused by: java.sql.SQLException: Invalid argument in JDBC call: parameter index out of range: 3<br /> at org.hsqldb.jdbc.JDBCUtil.sqlException(Unknown Source)<br /> <span class="error">[...]</span><br /> at pl.frati.dynx.contact.hibernate.types.SimcCodedAddressType.nullSafeSet(SimcCodedAddressType.java:195)<br /> <span class="error">[...]</span><br /> Caused by: org.hsqldb.HsqlException: Invalid argument in JDBC call: parameter index out of range: 3<br /> at org.hsqldb.error.Error.error(Unknown Source)</p>
</div>
</div>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">and the log is:</p>
<div class="panel" style="border-width: 1px;; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="panelContent" style="padding: 9px 12px">
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">Hibernate: <br /> delete <br /> from<br /> vos <br /> where<br /> FKentity=? <br /> and id=?<br /> 2014-02-18 17:46:11,536 INFO - HHH000010: On release of batch it still contained JDBC statements [<span class="error">[org.hibernate.engine.jdbc.batch.internal.AbstractBatchImpl]</span>]<br /> 2014-02-18 17:46:11,537 WARN - SQL Error: -423, SQLState: S1000 [<span class="error">[org.hibernate.engine.jdbc.spi.SqlExceptionHelper]</span>]<br /> 2014-02-18 17:46:11,537 ERROR - Invalid argument in JDBC call: parameter index out of range: 3 [<span class="error">[org.hibernate.engine.jdbc.spi.SqlExceptionHelper]</span>]</p>
</div>
</div>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0"><b>What happens?</b> Well it seems that there is some kind of bug in handling CompositeUserType. Hibernate tries to delete given Value Object. Normally, if there are no not-null properties in the composite-element everything goes fine - Hibernate runs following query:</p>
<div class="panel" style="border-width: 1px;; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="panelContent" style="padding: 9px 12px">
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0"> delete <br /> from<br /> vos <br /> where<br /> FKentity=? <br /> and id=? <br /> and name=? <br /> and simc_1=? <br /> and street_1=? <br /> and building_no_1=? <br /> and flat_no_1=? <br /> and postal_code_1=? <br /> and post_office_1=?</p>
</div>
</div>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">However when any field is marked as not-null this causes creation of primary key. Lets assume that field <tt>id</tt> in composite-element is marked not-null. This should result in following SQL:</p>
<div class="panel" style="border-width: 1px;; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="panelContent" style="padding: 9px 12px">
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0"> delete <br /> from<br /> vos <br /> where<br /> FKentity=? <br /> and id=?</p>
</div>
</div>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">And it does. The problem is that Hibernate still tries to bind values of <tt>address</tt> property, despite it does not belong to primary key. As they are not expected (only FKentity and id are expected) this causes index out of range exception, as there is no third parameter, so there is no parameter to bind to.</p>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0"><b>Workaround</b>: Mark all properties in composite-element as <tt>not-null="false"</tt>.</p>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0"><b>Other facts</b>:<br /> 1. when no CompositeUserType is used everything works fine<br /> 2. when UserType is used everything works fine as well<br /> 3. CompositeUserType used in entity works fine</p>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-8982#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-5bc2a0b0-25a4-4ff8-91e0-4f037bfbb46a" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle" /> </a>
</td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-8982#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #fff; border-top: 0; border-left: 1px solid #ccc; border-bottom: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly">
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px">
This message was sent by Atlassian JIRA <span id="footer-build-information">(v6.2-OD-09-036#6252-<span title="44a5e2c694ab5edc4d35ca1eb19eecd9ebb0cbe0" data-commit-id="44a5e2c694ab5edc4d35ca1eb19eecd9ebb0cbe0}">sha1:44a5e2c</span>)</span>
</td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-4887e520-569a-4020-b6d7-a7d91388b442" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix" />
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</body>
</html>