<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0" /> <base href="https://hibernate.atlassian.net" />
<title>Message Title</title>
</head>
<body class="jira" style="color: #333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<!-- header here -->
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px"> <img id="header-avatar-image" class="image_fix" src="https://secure.gravatar.com/avatar/bfda4c8ce231d748d1123620ca048231?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top" />
</td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="brmeyer" id="email_brmeyer" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=brmeyer" style="color:#6c797f;; color: #3b73af; text-decoration: none">Brett Meyer</a> <strong>commented</strong> on <a href="https://hibernate.atlassian.net/browse/HHH-8290" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-static-bug-ad4bb423-f2e0-4c65-aede-ab347af26e1e" height="16" width="16" border="0" align="absmiddle" alt="Bug" /> HHH-8290</a>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 15px; background-color: #fff; border-left: 1px solid #ccc; border-top: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly">
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-8290" style="color: #3b73af; text-decoration: none">Re: Query translator generates an incorrect query with SELECT distinct + Order by + Implicit join </a> </span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff; border-bottom: none; padding-bottom: 0">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0">
<p style="margin: 10px 0 0 0">As a note to myself, pasting long pieces of a convo with <a href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=steve" class="user-hover" rel="steve" style="color: #3b73af; text-decoration: none">Steve Ebersole</a>:</p>
<blockquote style="margin: 10px 0 0 0; border-left: 1px solid #ccc; color: #707070; margin-left: 19px; padding: 10px 20px">
<p style="margin: 10px 0 0 0">(03:27:56 PM) sebersole: some.joined.path.separated.by.dots<br /> (03:28:01 PM) sebersole: thats a implcit join<br /> (03:28:17 PM) sebersole: as opposed to the explicit form<br /> (03:28:31 PM) sebersole: from ... join ... join ...<br /> (03:29:05 PM) sebersole: this is where the parser is not very smart<br /> (03:29:13 PM) sebersole: the new parser is much better at this<br /> (03:29:40 PM) sebersole: really the rule is that it is ok to reuse non-leaf parts of implicit join paths always<br /> (03:30:04 PM) sebersole: for leaf parts it depends on a few things<br /> (03:30:20 PM) sebersole: the old parser does not understand all that<br /> (03:30:59 PM) sebersole: it does not understand that it has seen part of prod.supplier.supplierName before<br /> (03:31:57 PM) sebersole: in general it just elects to be safe when it does not know<br /> (04:09:11 PM) sebersole: select prod.supplier from Products prod order by prod.supplier.supplierName<br /> (04:09:17 PM) sebersole: so thats your query<br /> (04:09:37 PM) sebersole: but imagine...<br /> (04:11:01 PM) sebersole: well first let me back up...<br /> (04:11:17 PM) sebersole: the concern is filtering results that should not be filtered<br /> (04:12:41 PM) sebersole: its hard to make up these models on the fly to explain by way of an example<br /> (04:13:26 PM) sebersole: product -> supplier -> industry lets say<br /> (04:15:06 PM) sebersole: so first look at:<br /> (04:16:25 PM) sebersole: ... from Product p where p.supplier.industry.code = 'R&D' or p.supplier.hq.city = 'Austin'<br /> (04:17:23 PM) sebersole: so the issue is that inner joins have a semantic of removing missing correlations<br /> (04:18:03 PM) sebersole: here, if a product's supplier does not have a hq-address or does not have an industry... should they still be returned?<br /> (04:18:31 PM) sebersole: say for example, a product from the supplier Acme that has no industry, but is in Austin<br /> (04:18:39 PM) sebersole: should they get returned?<br /> (04:19:36 PM) sebersole: as far as the alias part...<br /> (04:19:42 PM) sebersole: there is another forms here..<br /> (04:20:48 PM) sebersole: from Product p join p.supplier.industry i join p.supplier.hq h where i.code = 'R&D' or h.city = 'Austin'<br /> (04:21:17 PM) sebersole: but really where the alias part in my above commments come into play is in cases like:<br /> (04:22:32 PM) sebersole: select p.supplier.supplierName from Product p join p.supplier.industry i1 join p.supplier.industry i2 ...<br /> (04:23:19 PM) sebersole: its complicated, but the idea is that the 'p.supplier' join is probably safe to reuse<br /> (04:23:42 PM) sebersole: any dereference to 'p.supplier.industry; is not<br /> (04:23:51 PM) sebersole: any dereference to 'p.supplier.industry' is likely not<br /> (04:24:11 PM) sebersole: and even if it were safe... which woould you use?<br /> (04:24:27 PM) sebersole: so "safe" is releative to the path<br /> (04:24:44 PM) sebersole: aka, these aliases implicit joins are named<br /> (04:24:52 PM) sebersole: wow<br /> (04:24:56 PM) sebersole: aka, these aliased implicit joins are named<br /> (04:25:18 PM) sebersole: and so should not be reused<br /> (04:25:22 PM) sebersole: thats the safest<br /> (04:25:59 PM) sebersole: actually the new parser looks at each "path part" separate and decides<br /> (04:26:21 PM) sebersole: starting a new Join branch whenever it deems it needs to<br /> (04:26:27 PM) sebersole: so part could be reused<br /> (04:26:38 PM) sebersole: i think the current parser is not that smart<br /> (04:26:43 PM) sebersole: i think its all/none to it<br /> (04:27:12 PM) sebersole: aka, either the full p.supplier.industry path<br /> (04:27:28 PM) sebersole: aka, either the full p.supplier.industry path can be reused, or none of it (no part of it) can</p>
</blockquote>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-8290#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-9c2714de-71b9-478d-8bc5-c66fa5f08e57" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle" /> </a>
</td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-8290#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #fff; border-top: 0; border-left: 1px solid #ccc; border-bottom: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly">
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px">
This message was sent by Atlassian JIRA <span id="footer-build-information">(v6.2-OD-10-004-WN#6253-<span title="0f638781a9eb90c00e546dda3da3aa1c24cb2738" data-commit-id="0f638781a9eb90c00e546dda3da3aa1c24cb2738}">sha1:0f63878</span>)</span>
</td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-5a01ddc2-2e50-4573-ba16-beffdc7ccf37" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix" />
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</body>
</html>