<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0" /> <base href="https://hibernate.atlassian.net" />
<title>Message Title</title>
</head>
<body class="jira" style="color: #333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<!-- header here -->
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px"> <img id="header-avatar-image" class="image_fix" src="https://secure.gravatar.com/avatar/acad0f6a32a98b314b6dae8f7466dde5?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top" />
</td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="svanhoose" id="email_svanhoose" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=svanhoose" style="color:#6c797f;; color: #3b73af; text-decoration: none">Spencer Van Hoose</a> <strong>created</strong> an issue
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 15px; background-color: #fff; border-left: 1px solid #ccc; border-top: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly">
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class="page-title-pattern-first-line " style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://hibernate.atlassian.net/browse/HHH" style="color: #3b73af; text-decoration: none">Hibernate ORM</a> / <a href="https://hibernate.atlassian.net/browse/HHH-9087" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-static-bug-5a1aed0e-04ef-4788-b816-a720256f0d3c" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom" /></a> <a href="https://hibernate.atlassian.net/browse/HHH-9087" style="color: #3b73af; text-decoration: none">HHH-9087</a>
</td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-9087" style="color: #3b73af; text-decoration: none">Version increment on joined-subclass uses incorrect column names</a> </span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff; padding-top: 10px; padding-bottom: 5px">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Issue Type:
</th>
<td class="has-icon" style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <img src="cid:jira-generated-image-static-bug-5a1aed0e-04ef-4788-b816-a720256f0d3c" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom" /> Bug
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Affects Versions:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top">
4.3.4, 3.5.2
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Assignee:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top">
Unassigned
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Attachments:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top">
invalid_identifier.txt
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Components:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top">
core
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Created:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top">
26/Mar/14 6:11 PM
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Priority:
</th>
<td class="has-icon" style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <img src="cid:jira-generated-image-static-major-67b0e911-2737-419c-a0bb-c4bf6ed04845" height="16" width="16" border="0" align="absmiddle" alt="Major" style="vertical-align: text-bottom" /> Major
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Reporter:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="svanhoose" id="email_svanhoose" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=svanhoose" style="color:#6c797f;; color: #3b73af; text-decoration: none">Spencer Van Hoose</a>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff; padding-top: 5px; padding-bottom: 10px">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0">
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">When forcing a version increment on an entity mapped with joined-subclass, the generated SQL will be incorrect if the subclass has a different ID column than the parent.</p>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0"><b>Test case:</b></p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<span class="code-keyword" style="color: #000091">public</span> class Phone {
<span class="code-keyword" style="color: #000091">protected</span> <span class="code-object" style="color: #910091">int</span> id;
<span class="code-keyword" style="color: #000091">protected</span> <span class="code-object" style="color: #910091">long</span> version;
<span class="code-keyword" style="color: #000091">protected</span> <span class="code-object" style="color: #910091">String</span> name;
<span class="code-keyword" style="color: #000091">public</span> <span class="code-object" style="color: #910091">int</span> getId() { <span class="code-keyword" style="color: #000091">return</span> id; }
<span class="code-keyword" style="color: #000091">public</span> <span class="code-object" style="color: #910091">long</span> getVersion() { <span class="code-keyword" style="color: #000091">return</span> version; }
<span class="code-keyword" style="color: #000091">public</span> <span class="code-object" style="color: #910091">String</span> getName() { <span class="code-keyword" style="color: #000091">return</span> name; }
<span class="code-keyword" style="color: #000091">public</span> void setName(<span class="code-object" style="color: #910091">String</span> name) { <span class="code-keyword" style="color: #000091">this</span>.name = name; }
}
<span class="code-keyword" style="color: #000091">public</span> class CellPhone <span class="code-keyword" style="color: #000091">extends</span> Phone { }
</pre>
</div>
</div>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-xml" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<span class="code-tag" style="color: #000091"><hibernate-mapping package=<span class="code-quote" style="color: #009100">"org.example"</span> default-access=<span class="code-quote" style="color: #009100">"field"</span>></span>
<span class="code-tag" style="color: #000091"><class name=<span class="code-quote" style="color: #009100">"Phone"</span> table=<span class="code-quote" style="color: #009100">"HT_PHONE"</span>></span>
<span class="code-tag" style="color: #000091"><id name=<span class="code-quote" style="color: #009100">"id"</span> column=<span class="code-quote" style="color: #009100">"ID"</span>></span>
<span class="code-tag" style="color: #000091"><generator class=<span class="code-quote" style="color: #009100">"org.hibernate.id.enhanced.SequenceStyleGenerator"</span>/></span>
<span class="code-tag" style="color: #000091"></id></span>
<span class="code-tag" style="color: #000091"><version type=<span class="code-quote" style="color: #009100">"long"</span> name=<span class="code-quote" style="color: #009100">"version"</span> column=<span class="code-quote" style="color: #009100">"VERSION"</span> /></span>
<span class="code-tag" style="color: #000091"><property name=<span class="code-quote" style="color: #009100">"name"</span> /></span>
<span class="code-tag" style="color: #000091"><joined-subclass name=<span class="code-quote" style="color: #009100">"CellPhone"</span> table=<span class="code-quote" style="color: #009100">"HT_CELLPHONE"</span>></span>
<span class="code-tag" style="color: #000091"><key column=<span class="code-quote" style="color: #009100">"PHONE_ID"</span> /></span>
<span class="code-tag" style="color: #000091"></joined-subclass></span>
<span class="code-tag" style="color: #000091"></class></span>
<span class="code-tag" style="color: #000091"></hibernate-mapping></span>
</pre>
</div>
</div>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
Configuration cfg = <span class="code-keyword" style="color: #000091">new</span> Configuration()
.addResource(<span class="code-quote" style="color: #009100">"org/example/mapping.xml"</span>)
.setProperty(<span class="code-quote" style="color: #009100">"hibernate.dialect"</span>, <span class="code-quote" style="color: #009100">"org.hibernate.dialect.Oracle10gDialect"</span>)
.setProperty(<span class="code-quote" style="color: #009100">"hibernate.connection.url"</span>, "")
.setProperty(<span class="code-quote" style="color: #009100">"hibernate.connection.username"</span>, "")
.setProperty(<span class="code-quote" style="color: #009100">"hibernate.connection.password"</span>, "")
.setProperty(<span class="code-quote" style="color: #009100">"hibernate.hbm2ddl.auto"</span>, <span class="code-quote" style="color: #009100">"create"</span>);
SessionFactory sf = cfg.buildSessionFactory();
Session session = sf.openSession();
Transaction transaction = session.beginTransaction();
<span class="code-comment" style="color: #808080">// Create a persisted joined-subclass object
</span>CellPhone phone = <span class="code-keyword" style="color: #000091">new</span> CellPhone();
phone.setName(<span class="code-quote" style="color: #009100">"Droid"</span>);
session.save(phone);
session.flush();
<span class="code-comment" style="color: #808080">// Force a version update
</span><span class="code-comment" style="color: #808080">// The following line will fail because PHONE_ID doesn't exist on the PHONE table
</span>session.buildLockRequest(LockOptions.UPGRADE)
.setLockMode(LockMode.PESSIMISTIC_FORCE_INCREMENT)
.lock(phone);
session.flush();
transaction.commit();
session.close();
sf.close();
</pre>
</div>
</div>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0"><b>Result:</b><br /> <tt>java.sql.SQLSyntaxErrorException: ORA-00904: "PHONE_ID": invalid identifier</tt></p>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">The full stack trace can be found in the attached file. Basically, hibernate tries to use the ID column for the subclass table when building the update statement (PHONE_ID in this case) but since the update is being performed on the root table, the column does not exist and the update fails.</p>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">This bug was previously reported as <a href="https://hibernate.atlassian.net/browse/HHH-5237" title="Version increment on joined subclass uses incorrect column names" class="issue-link" data-issue-key="HHH-5237" style="color: #3b73af; text-decoration: none"></a></p>
<del>
HHH-5237
</del> but was closed for not including a test case. We have been using the patch attached to that bug successfully in our application.
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-9087#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-5df42f65-08ba-4fab-990e-f193532043e3" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle" /> </a>
</td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-9087#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #fff; border-top: 0; border-left: 1px solid #ccc; border-bottom: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly">
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px">
This message was sent by Atlassian JIRA <span id="footer-build-information">(v6.2-OD-10-004-WN#6253-<span title="0f638781a9eb90c00e546dda3da3aa1c24cb2738" data-commit-id="0f638781a9eb90c00e546dda3da3aa1c24cb2738}">sha1:0f63878</span>)</span>
</td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-527d2e2f-2216-4065-bc9d-179084f0e886" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix" />
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</body>
</html>