<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0" /> <base href="https://hibernate.atlassian.net" />
<title>Message Title</title>
</head>
<body class="jira" style="color: #333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<!-- header here -->
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px"> <img id="header-avatar-image" class="image_fix" src="https://secure.gravatar.com/avatar/22b82410be00baf91b159f889f0f6660?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top" />
</td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="dashorst" id="email_dashorst" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=dashorst" style="color:#6c797f;; color: #3b73af; text-decoration: none">Martijn Dashorst</a> <strong>commented</strong> on <a href="https://hibernate.atlassian.net/browse/HHH-3930" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-static-bug-42454d5f-4a09-4ffe-b212-f204e8f073f1" height="16" width="16" border="0" align="absmiddle" alt="Bug" /> HHH-3930</a>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 15px; background-color: #fff; border-left: 1px solid #ccc; border-top: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly">
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-3930" style="color: #3b73af; text-decoration: none">Re: one-to-one causes redundant select query</a> </span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff; border-bottom: none; padding-bottom: 0">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0">
<p style="margin: 10px 0 0 0">This is still an issue with hibernate 4.3.5.final. The code below shows (if you browse the logs between "Before retrieve" and "After retrieve") that Hibernate performs 2 selects instead of the expected 1 select, as specified by the FetchType.EAGER.</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<span class="code-keyword" style="color: #000091">package</span> org.hibernate.bugs;
<span class="code-keyword" style="color: #000091">import</span> java.util.List;
<span class="code-keyword" style="color: #000091">import</span> javax.persistence.CascadeType;
<span class="code-keyword" style="color: #000091">import</span> javax.persistence.Entity;
<span class="code-keyword" style="color: #000091">import</span> javax.persistence.FetchType;
<span class="code-keyword" style="color: #000091">import</span> javax.persistence.GeneratedValue;
<span class="code-keyword" style="color: #000091">import</span> javax.persistence.GenerationType;
<span class="code-keyword" style="color: #000091">import</span> javax.persistence.Id;
<span class="code-keyword" style="color: #000091">import</span> javax.persistence.OneToOne;
<span class="code-keyword" style="color: #000091">import</span> javax.persistence.Table;
<span class="code-keyword" style="color: #000091">import</span> org.hibernate.Session;
<span class="code-keyword" style="color: #000091">import</span> org.hibernate.SessionFactory;
<span class="code-keyword" style="color: #000091">import</span> org.hibernate.Transaction;
<span class="code-keyword" style="color: #000091">import</span> org.hibernate.cfg.Configuration;
<span class="code-keyword" style="color: #000091">import</span> org.hibernate.testing.junit4.BaseUnitTestCase;
<span class="code-keyword" style="color: #000091">import</span> org.junit.Before;
<span class="code-keyword" style="color: #000091">import</span> org.junit.Test;
<span class="code-keyword" style="color: #000091">public</span> class Hhh3930 <span class="code-keyword" style="color: #000091">extends</span> BaseUnitTestCase {
        @Entity
        @Table(name = <span class="code-quote" style="color: #009100">"Address"</span>)
        <span class="code-keyword" style="color: #000091">public</span> <span class="code-keyword" style="color: #000091">static</span> class Address {
                @Id
                @GeneratedValue(strategy = GenerationType.AUTO)
                <span class="code-keyword" style="color: #000091">private</span> <span class="code-object" style="color: #910091">Long</span> id;
                @OneToOne(mappedBy = <span class="code-quote" style="color: #009100">"address"</span>)
                <span class="code-keyword" style="color: #000091">private</span> Customer customer;
        }
        @Entity
        @Table(name = <span class="code-quote" style="color: #009100">"Customer"</span>)
        <span class="code-keyword" style="color: #000091">public</span> <span class="code-keyword" style="color: #000091">static</span> class Customer {
                @Id
                @GeneratedValue(strategy = GenerationType.AUTO)
                <span class="code-keyword" style="color: #000091">private</span> <span class="code-object" style="color: #910091">Long</span> id;
                @OneToOne(fetch = FetchType.EAGER, cascade = CascadeType.ALL)
                <span class="code-keyword" style="color: #000091">private</span> Address address = <span class="code-keyword" style="color: #000091">new</span> Address();
                <span class="code-keyword" style="color: #000091">public</span> <span class="code-object" style="color: #910091">Long</span> getId() {
                        <span class="code-keyword" style="color: #000091">return</span> id;
                }
        }
        <span class="code-keyword" style="color: #000091">private</span> Configuration config;
        <span class="code-keyword" style="color: #000091">private</span> SessionFactory sessionFactory;
        @SuppressWarnings(<span class="code-quote" style="color: #009100">"deprecation"</span>)
        @Before
        <span class="code-keyword" style="color: #000091">public</span> void setup() {
                config = <span class="code-keyword" style="color: #000091">new</span> Configuration();
                config.addAnnotatedClass(Customer.class);
                config.addAnnotatedClass(Address.class);
                config.setProperty(<span class="code-quote" style="color: #009100">"hibernate.connection.driver_class"</span>, <span class="code-quote" style="color: #009100">"org.hsqldb.jdbcDriver"</span>);
                config.setProperty(<span class="code-quote" style="color: #009100">"hibernate.connection.url"</span>, <span class="code-quote" style="color: #009100">"jdbc:hsqldb:mem:myunittests"</span>);
                config.setProperty(<span class="code-quote" style="color: #009100">"hibernate.connection.username"</span>, <span class="code-quote" style="color: #009100">"sa"</span>);
                config.setProperty(<span class="code-quote" style="color: #009100">"hibernate.connection.password"</span>, "");
                config.setProperty(<span class="code-quote" style="color: #009100">"hibernate.connection.pool_size"</span>, <span class="code-quote" style="color: #009100">"1"</span>);
                config.setProperty(<span class="code-quote" style="color: #009100">"hibernate.current_session_context_class"</span>, <span class="code-quote" style="color: #009100">"thread"</span>);
                config.setProperty(<span class="code-quote" style="color: #009100">"hibernate.hbm2ddl.auto"</span>, <span class="code-quote" style="color: #009100">"update"</span>);
                config.setProperty(<span class="code-quote" style="color: #009100">"hibernate.dialect"</span>, <span class="code-quote" style="color: #009100">"org.hibernate.dialect.HSQLDialect"</span>);
                config.setProperty(<span class="code-quote" style="color: #009100">"hibernate.show_sql"</span>, <span class="code-quote" style="color: #009100">"<span class="code-keyword" style="color: #000091; color: #009100">true</span>"</span>);
                sessionFactory = config.buildSessionFactory();
        }
        @Test
        <span class="code-keyword" style="color: #000091">public</span> void persistentities() {
                Customer c = <span class="code-keyword" style="color: #000091">new</span> Customer();
                Address a = <span class="code-keyword" style="color: #000091">new</span> Address();
                c.address = a;
                a.customer = c;
                Session session = sessionFactory.getCurrentSession();
                Transaction transaction = session.beginTransaction();
                session.save(c);
                transaction.commit();
                session = sessionFactory.getCurrentSession();
                transaction = session.beginTransaction();
                <span class="code-object" style="color: #910091">System</span>.out.println(<span class="code-quote" style="color: #009100">"Before retrieve"</span>);
                @SuppressWarnings(<span class="code-quote" style="color: #009100">"unchecked"</span>)
                List<Customer> list = session.createCriteria(Customer.class).list();
                <span class="code-object" style="color: #910091">System</span>.out.println(<span class="code-quote" style="color: #009100">"After retrieve"</span>);
                <span class="code-object" style="color: #910091">System</span>.out.println(list);
        }
}
</pre>
</div>
</div>
<p style="margin: 10px 0 0 0">I have also attached the Maven project which includes this code, and a working POM.</p>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-3930#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-12496ad9-2f61-4bd0-b416-cc8a2765442b" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle" /> </a>
</td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-3930#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #fff; border-top: 0; border-left: 1px solid #ccc; border-bottom: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly">
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px">
This message was sent by Atlassian JIRA <span id="footer-build-information">(v6.3-OD-02-026#6318-<span title="955a9ee8603120962156c99532466d8e78960b49" data-commit-id="955a9ee8603120962156c99532466d8e78960b49}">sha1:955a9ee</span>)</span>
</td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-cac0d7d2-99c7-4a9b-bf02-8f43bffd3686" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix" />
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</body>
</html>