<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0" /> <base href="https://hibernate.atlassian.net" />
<title>Message Title</title>
</head>
<body class="jira" style="color: #333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<!-- header here -->
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px"> <img id="header-avatar-image" class="image_fix" src="https://secure.gravatar.com/avatar/12c5823f6e94b1ce6b44a6084945441c?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top" />
</td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="gor" id="email_gor" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=gor" style="color:#6c797f;; color: #3b73af; text-decoration: none">Eugene Goroschenya</a> <strong>commented</strong> on <a href="https://hibernate.atlassian.net/browse/HHH-8093" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-static-newfeature-7c22824c-ff20-42a2-a045-6e462298e8b2" height="16" width="16" border="0" align="absmiddle" alt="New Feature" /> HHH-8093</a>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 15px; background-color: #fff; border-left: 1px solid #ccc; border-top: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly">
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-8093" style="color: #3b73af; text-decoration: none">Re: Add the ability to handle related entity not found gracefully</a> </span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff; border-bottom: none; padding-bottom: 0">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0">
<p style="margin: 10px 0 0 0">I think the problem/reason is in org.hibernate.envers.entities.mapper.relation.lazy.ToOneDelegateSessionImplementor#doImmediateLoad</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<span class="code-keyword" style="color: #000091">public</span> <span class="code-object" style="color: #910091">Object</span> doImmediateLoad(<span class="code-object" style="color: #910091">String</span> entityName) <span class="code-keyword" style="color: #000091">throws</span> HibernateException {
<span class="code-keyword" style="color: #000091">if</span>(entCfg.getNotVersionEntityConfiguration(entityName) == <span class="code-keyword" style="color: #000091">null</span>){
<span class="code-comment" style="color: #808080">// audited relation, look up entity with envers
</span> <span class="code-keyword" style="color: #000091">return</span> versionsReader.find(entityClass, entityName, entityId, revision);
} <span class="code-keyword" style="color: #000091">else</span> {
<span class="code-comment" style="color: #808080">// notAudited relation, look up entity with hibernate
</span> <span class="code-keyword" style="color: #000091">return</span> delegate.immediateLoad(entityName, (Serializable) entityId);
}
}
</pre>
</div>
</div>
<p style="margin: 10px 0 0 0">The versionsReader.find(...) is used always to return result immediatly if entityName is configured as @Audited, <br /> doesn't matter if it is only asking reference for property annotated as targetAuditMode=RelationTargetAuditMode.NOT_AUDITED (Employee.company from example in description)</p>
<p style="margin: 10px 0 0 0">What about to slightly change ToOneDelegateSessionImplementor#doImmediateLoad <br /> and add fallback to delegate if versionsReader.find(entityClass, entityName, entityId, revision) == null ?</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<span class="code-keyword" style="color: #000091">public</span> <span class="code-object" style="color: #910091">Object</span> doImmediateLoad(<span class="code-object" style="color: #910091">String</span> entityName) <span class="code-keyword" style="color: #000091">throws</span> HibernateException {
<span class="code-object" style="color: #910091">Object</span> immediatlyLoaded = <span class="code-keyword" style="color: #000091">null</span>;
<span class="code-keyword" style="color: #000091">if</span> (entCfg.getNotVersionEntityConfiguration(entityName) == <span class="code-keyword" style="color: #000091">null</span>) {
<span class="code-comment" style="color: #808080">// audited relation, look up entity with envers
</span> immediatlyLoaded = versionsReader.find(entityClass, entityName, entityId, revision);
}
<span class="code-keyword" style="color: #000091">if</span> (immediatlyLoaded == <span class="code-keyword" style="color: #000091">null</span>) {
<span class="code-comment" style="color: #808080">// notAudited relation or relation is not in AUD table, look up entity with hibernate
</span> <span class="code-keyword" style="color: #000091">return</span> delegate.immediateLoad(entityName, (Serializable) entityId);
}
}
</pre>
</div>
</div>
<p style="margin: 10px 0 0 0">It doesn't solve problem mentioned in description with 'purging feature' but solves the real case <br /> when we started with @Audited Employee but not-audited Company and after some period made Company @Audited</p>
<p style="margin: 10px 0 0 0">So it is easier than what proposed in description</p>
<blockquote style="margin: 10px 0 0 0; border-left: 1px solid #ccc; color: #707070; margin-left: 19px; padding: 10px 20px">
<p style="margin: 10px 0 0 0">1. Look up related entity with the max revision number equal or less than the targeted entity's revision number.<br /> 2. If not found, look up related entity with the min revision number larger than the targeted entity's revision number.<br /> 3. If not found, look up related entity in "current" version.<br /> 4. If not found, return null or empty entity with id field populated.</p>
</blockquote>
<p style="margin: 10px 0 0 0">and just <br /> 1. Look up related entity with the max revision number equal or less than the targeted entity's revision number. // versionsReader.find(entityClass, entityName, entityId, revision);<br /> 2. If not found, look up related entity in "current" version in real table // delegate.immediateLoad(entityName, (Serializable) entityId);</p>
<p style="margin: 10px 0 0 0">Otherwise we have to create initial revisions for Company in scope of migration effort<br /> Is there some generic tool to do this ? <br /> I found </p>
<ul class="alternate" type="square">
<li>
<a href="https://community.jboss.org/thread/177321?tstart=0" class="external-link" rel="nofollow" style="color: #3b73af; text-decoration: none">https://community.jboss.org/thread/177321?tstart=0</a>
</li>
<li>
<a href="http://stackoverflow.com/questions/898529/populate-envers-revision-tables-with-existing-data-from-hibernate-entities" class="external-link" rel="nofollow" style="color: #3b73af; text-decoration: none">http://stackoverflow.com/questions/898529/populate-envers-revision-tables-with-existing-data-from-hibernate-entities</a>
</li>
<li>
<a href="https://github.com/hydra1983/hibernate-envers-tools" class="external-link" rel="nofollow" style="color: #3b73af; text-decoration: none">https://github.com/hydra1983/hibernate-envers-tools</a>
</li>
</ul>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-8093#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-77acc330-a235-4b05-b618-26f0f96ff512" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle" /> </a>
</td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-8093#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #fff; border-top: 0; border-left: 1px solid #ccc; border-bottom: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly">
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px">
This message was sent by Atlassian JIRA <span id="footer-build-information">(v6.3-OD-05-016#6325-<span title="052255dd9af96562f72347fc52f51555af33d252" data-commit-id="052255dd9af96562f72347fc52f51555af33d252}">sha1:052255d</span>)</span>
</td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-05f02241-2a31-4281-8f51-3dbb9e7732bc" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix" />
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</body>
</html>