<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0" /> <base href="https://hibernate.atlassian.net" />
<title>Message Title</title>
</head>
<body class="jira" style="color: #333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<!-- header here -->
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px"> <img id="header-avatar-image" class="image_fix" src="https://secure.gravatar.com/avatar/c32c4103dacf291cdfa0439e34f2c07e?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top" />
</td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="gbadner" id="email_gbadner" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=gbadner" style="color:#6c797f;; color: #3b73af; text-decoration: none">Gail Badner</a> <strong>commented</strong> on <a href="https://hibernate.atlassian.net/browse/HHH-9550" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-static-improvement-395f11f6-59aa-4976-b188-d25cf8c79b5a" height="16" width="16" border="0" align="absmiddle" alt="Improvement" /> HHH-9550</a>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 15px; background-color: #fff; border-left: 1px solid #ccc; border-top: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly">
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-9550" style="color: #3b73af; text-decoration: none">Re: Allow a dialect to determine a proper SchemaSupport to be used</a> </span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff; border-bottom: none; padding-bottom: 0">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0">
<p style="margin: 10px 0 0 0">(12:32:32 PM) gbadner-gmail: if no schema is provided in @Table, shouldn't hibernate assume table should be in the default schema?<br /> (12:33:09 PM) gbadner-gmail: seems reasonable that orm would pass the default schema to validator<br /> (12:33:23 PM) gbadner-gmail: rather than no schema<br /> (12:33:30 PM) Steve Ebersole: yes, but, it really just assumes any namespace that can be seen<br /> (12:34:32 PM) Steve Ebersole: not sure what you mean by "no schema"<br /> (12:34:53 PM) Steve Ebersole: for databases that utilize schemas, there is never "no schema"<br /> (12:35:04 PM) Steve Ebersole: so not sure what you mean there<br /> (12:35:49 PM) Steve Ebersole: you mean in terms of the DatabaseMetaData calls?<br /> (12:36:29 PM) Steve Ebersole: for those this is the difference between passing null and ""<br /> (12:37:30 PM) Steve Ebersole: iirc tools deals with this in an awkward way<br /> (12:37:44 PM) Steve Ebersole: like it pulls all tables first maybe<br /> (12:37:48 PM) Steve Ebersole: something like that<br /> (12:38:16 PM) Steve Ebersole: but i seem to remember it does not apply schema/catalog filters in the best way<br /> (12:38:23 PM) Steve Ebersole: however that happens<br /> (12:39:44 PM) gbadner-gmail: iiuc, validator says the table exists because it finds a table in some non-default schema/catalog, but ORM throwns an exception because it's not in the default schema/catalog<br /> (12:40:08 PM) Steve Ebersole: um<br /> (12:40:26 PM) gbadner-gmail: looks like when @Table does not have the schema or catalog, those values are passed as null<br /> (12:41:11 PM) Steve Ebersole: null == do not filter based on that<br /> (12:41:13 PM) gbadner-gmail: at least that's what a commentsays<br /> (12:41:25 PM) Steve Ebersole: aka, pull from any visible schema<br /> (12:41:31 PM) gbadner-gmail: ah, ok, so that is expected<br /> (12:41:53 PM) Steve Ebersole: well its wrong<br /> (12:42:09 PM) Steve Ebersole: however<br /> (12:42:28 PM) Steve Ebersole: i think the only thing that could be changed here is to have validator fail<br /> (12:42:48 PM) Steve Ebersole: as is, the set up is not correct to see that table<br /> (12:42:49 PM) gbadner-gmail: yeah, I think that's better than having ORM fail later when the table is not found<br /> (12:43:37 PM) gbadner-gmail: the problem here is that validator says it's ok, but it's not found by orm<br /> (12:43:48 PM) Steve Ebersole: i just am not sure how this should work between dbs that use catalogs but not schema and vixce versa<br /> (12:44:01 PM) Steve Ebersole: yes, i get what the mismatch is<br /> (12:44:10 PM) gbadner-gmail: ah, ok; <br /> (12:44:36 PM) gbadner-gmail: iac, the workaround is to just put the schema/catalog in the @Table<br /> (12:45:09 PM) Steve Ebersole: sure<br /> (12:45:19 PM) gbadner-gmail: then validator and orm would would either both be OK, or both broken<br /> (12:45:26 PM) Steve Ebersole: i think the solution is to be better at filtering these results<br /> (12:45:35 PM) Steve Ebersole: but<br /> (12:45:55 PM) Steve Ebersole: that requires understanding which dbs use catalog, which use schema and which use both<br /> (12:46:14 PM) Steve Ebersole: and applying that to the DatabaseMetaData calls properly<br /> (12:46:30 PM) gbadner-gmail: would that be defined on the dialect?<br /> (12:46:41 PM) gbadner-gmail: supportsSchema(), supportsCatalog()?<br /> (12:46:55 PM) Steve Ebersole: i'd prefer one call<br /> (12:47:01 PM) Steve Ebersole: returning an enum<br /> (12:47:31 PM) gbadner-gmail: SCHEMA_ONLY, CATALOG_ONLY, CATALOG_AND_SCHEMA<br /> (12:47:37 PM) Steve Ebersole: possibly even with the enum handling name formatting<br /> (12:47:51 PM) Steve Ebersole: but thats not pertinent here<br /> (12:51:35 PM) Steve Ebersole: tbh, i am not sure there is any that support "just catalog"<br /> (12:51:48 PM) Steve Ebersole: tbh, i am not sure that really even makes sense<br /> (12:52:01 PM) gbadner-gmail: no idea<br /> (12:53:02 PM) Steve Ebersole: catalogs are essentially defined as collections of schemas<br /> (12:53:14 PM) Steve Ebersole: schemas are what hold tables, etc<br /> (12:53:43 PM) Steve Ebersole: but, its probably best to allow for every oddball<br /> (12:54:59 PM) Steve Ebersole: I'd also want to collect this into a unified contract<br /> (12:55:06 PM) gbadner-gmail: ok, so this would be an improvement; and it's also not going to get into eap 6.3.3/6.4.0<br /> (12:55:16 PM) Steve Ebersole: Dialect.getSchemaSupport()<br /> (12:55:23 PM) gbadner-gmail: ah, I see<br /> (12:55:48 PM) Steve Ebersole: SchemaSupport#renderName( ... )<br /> (12:57:10 PM) Steve Ebersole: SchemaSupport#getSupportStyle()<br /> (12:57:12 PM) Steve Ebersole: etc<br /> (12:57:57 PM) gbadner-gmail: do you see backporting this into 4.2 branch?<br /> (12:58:37 PM) Steve Ebersole: i see backporting this to any branch that has this problem (all of them) where we want it fixed<br /> (12:58:52 PM) gbadner-gmail: ok<br /> (12:59:10 PM) Steve Ebersole: i hate this idea of porting solutions differently to different branches<br /> (12:59:18 PM) Steve Ebersole: i think that is a recipse for disaster<br /> (12:59:45 PM) gbadner-gmail: right, that's why I'm wondering if we should backport to 4.2 when there is an easy workaround<br /> (01:00:08 PM) Steve Ebersole: well, thats a pretty onerous workaround though<br /> (01:00:41 PM) Steve Ebersole: effectively rendering default schema/catalog moot for those users</p>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-9550#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-235d772c-ceba-4158-b7e5-ecdc3b3cf583" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle" /> </a>
</td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-9550#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #fff; border-top: 0; border-left: 1px solid #ccc; border-bottom: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly">
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px">
This message was sent by Atlassian JIRA <span id="footer-build-information">(v6.4-OD-12-026#64007-<span title="039f45b47f55c447e3f50e58b0fe607132611944" data-commit-id="039f45b47f55c447e3f50e58b0fe607132611944}">sha1:039f45b</span>)</span>
</td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-eb153f7d-790a-4509-9114-6b847143a4d3" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix" />
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</body>
</html>