<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0" /> <base href="https://hibernate.atlassian.net" />
<title>Message Title</title>
</head>
<body class="jira" style="color: #333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<!-- header here -->
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px"> <img id="header-avatar-image" class="image_fix" src="https://secure.gravatar.com/avatar/4b00b2737a9602e5d0c97e42e4d0051e?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top" />
</td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="pkrauzowicz" id="email_pkrauzowicz" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=pkrauzowicz" style="color:#6c797f;; color: #3b73af; text-decoration: none">Piotr Krauzowicz</a> <strong>created</strong> an issue
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 15px; background-color: #fff; border-left: 1px solid #ccc; border-top: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly">
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class="page-title-pattern-first-line " style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://hibernate.atlassian.net/browse/HHH" style="color: #3b73af; text-decoration: none">Hibernate ORM</a> / <a href="https://hibernate.atlassian.net/browse/HHH-9606" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-static-bug-6656c6fb-641b-4fc3-a137-ac40cb20f10c" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom" /></a> <a href="https://hibernate.atlassian.net/browse/HHH-9606" style="color: #3b73af; text-decoration: none">HHH-9606</a>
</td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-9606" style="color: #3b73af; text-decoration: none">NPE when updating or deleting entities with byte array as Id.</a> </span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff; padding-top: 10px; padding-bottom: 5px">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Issue Type:
</th>
<td class="has-icon" style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <img src="cid:jira-generated-image-static-bug-6656c6fb-641b-4fc3-a137-ac40cb20f10c" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom" /> Bug
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Affects Versions:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top">
4.3.8
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Assignee:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top">
Unassigned
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Attachments:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top">
DemoByteArrayPK.tar
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Components:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top">
core
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Created:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top">
09/Feb/2015 05:13 AM
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Environment:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top">
Hibernate ORM 4.3.X, all databases
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Labels:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top">
NPE core
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Priority:
</th>
<td class="has-icon" style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <img src="cid:jira-generated-image-static-major-c80933b3-5036-4844-a5b7-252447ede48f" height="16" width="16" border="0" align="absmiddle" alt="Major" style="vertical-align: text-bottom" /> Major
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Reporter:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="pkrauzowicz" id="email_pkrauzowicz" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=pkrauzowicz" style="color:#6c797f;; color: #3b73af; text-decoration: none">Piotr Krauzowicz</a>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff; padding-top: 5px; padding-bottom: 10px">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0">
<h2 style="margin: 10px 0 0 0; font-size: 20px; font-weight: normal; line-height: 1.500; margin: 40px 0 0 0"><a name="Issuedescription" style="color: #3b73af; text-decoration: none"></a>Issue description</h2>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">Updating or removing entities with byte array as primary key causes <b>NullPointerException</b>. Tested on Derby and Oracle database using Java 1.8.0_31 and 1.7.0_71 version. <b>All ORM Hibernte 4.3 versions are affected</b>. On 4.2.X everything works as expected.</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeHeader panelHeader" style="border-bottom-width: 1px;; border-bottom: 1px solid #ccc; padding: 9px 12px">
<b>DemoEntity.java</b>
</div>
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<span class="code-keyword" style="color: #000091">import</span> java.io.Serializable;
<span class="code-keyword" style="color: #000091">import</span> javax.persistence.Column;
<span class="code-keyword" style="color: #000091">import</span> javax.persistence.Entity;
<span class="code-keyword" style="color: #000091">import</span> javax.persistence.Id;
@Entity
<span class="code-keyword" style="color: #000091">public</span> class DemoEntity <span class="code-keyword" style="color: #000091">implements</span> Serializable {
@Id
@Column
<span class="code-keyword" style="color: #000091">private</span> <span class="code-object" style="color: #910091">byte</span>[] id;
@Column
<span class="code-keyword" style="color: #000091">private</span> <span class="code-object" style="color: #910091">String</span> name;
<span class="code-keyword" style="color: #000091">public</span> DemoEntity() {
}
<span class="code-keyword" style="color: #000091">public</span> void setId(<span class="code-object" style="color: #910091">byte</span>[] id) {
<span class="code-keyword" style="color: #000091">this</span>.id = id;
}
<span class="code-keyword" style="color: #000091">public</span> <span class="code-object" style="color: #910091">byte</span>[] getId() {
<span class="code-keyword" style="color: #000091">return</span> id;
}
<span class="code-keyword" style="color: #000091">public</span> void setName(<span class="code-object" style="color: #910091">String</span> data) {
<span class="code-keyword" style="color: #000091">this</span>.name = data;
}
<span class="code-keyword" style="color: #000091">public</span> <span class="code-object" style="color: #910091">String</span> getName() {
<span class="code-keyword" style="color: #000091">return</span> name;
}
}
</pre>
</div>
</div>
<h2 style="margin: 10px 0 0 0; font-size: 20px; font-weight: normal; line-height: 1.500; margin: 40px 0 0 0"><a name="Example" style="color: #3b73af; text-decoration: none"></a>Example</h2>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">Following unit tests demonstrates both issues. At the beginning of each test there are 3 records in database.</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeHeader panelHeader" style="border-bottom-width: 1px;; border-bottom: 1px solid #ccc; padding: 9px 12px">
<b>NPE during remove</b>
</div>
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
/**
* Tries to remove two records from database.
*
* Second remove operation <span class="code-keyword" style="color: #000091">throws</span> NPE. It is marked as expected <span class="code-keyword" style="color: #000091">for</span>
* demonstration purpose.
*/
@Test(expected = NullPointerException.class)
<span class="code-keyword" style="color: #000091">public</span> void testMultipleDeletionsNPE() {
EntityManager em = <span class="code-keyword" style="color: #000091">null</span>;
<span class="code-keyword" style="color: #000091">try</span> {
em = prepareEntityManager();
Query q = em.createQuery(<span class="code-quote" style="color: #009100">"SELECT s FROM DemoEntity s"</span>, DemoEntity.class);
List<DemoEntity> results = q.getResultList();
em.remove(results.get(0));
em.remove(results.get(1)); <span class="code-comment" style="color: #808080">// NPE
</span>
em.getTransaction().commit();
assertEquals(1, q.getResultList().size());
} <span class="code-keyword" style="color: #000091">finally</span> {
closeEntityManager(em);
}
}
</pre>
</div>
</div>
<div class="panel" style="border-width: 1px;; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="panelHeader" style="border-bottom-width: 1px;; border-bottom: 1px solid #ccc; padding: 9px 12px">
<b>Stack Trace when deleting</b>
</div>
<div class="panelContent" style="padding: 9px 12px">
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">java.lang.NullPointerException<br /> at org.hibernate.type.AbstractStandardBasicType.compare(AbstractStandardBasicType.java:221)<br /> at org.hibernate.action.internal.EntityAction.compareTo(EntityAction.java:171)<br /> at org.hibernate.engine.spi.ExecutableList.add(ExecutableList.java:222)<br /> at org.hibernate.engine.spi.ActionQueue.addAction(ActionQueue.java:219)<br /> at org.hibernate.event.internal.DefaultDeleteEventListener.deleteEntity(DefaultDeleteEventListener.java:299)<br /> at org.hibernate.event.internal.DefaultDeleteEventListener.onDelete(DefaultDeleteEventListener.java:160)<br /> at org.hibernate.event.internal.DefaultDeleteEventListener.onDelete(DefaultDeleteEventListener.java:73)<br /> at org.hibernate.internal.SessionImpl.fireDelete(SessionImpl.java:916)<br /> at org.hibernate.internal.SessionImpl.delete(SessionImpl.java:892)<br /> at org.hibernate.jpa.spi.AbstractEntityManagerImpl.remove(AbstractEntityManagerImpl.java:1214)<br /> at ByteArrayPKTest.testMultipleDeletionsBugged(ByteArrayPKTest.java:103)<br /> ...</p>
</div>
</div>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeHeader panelHeader" style="border-bottom-width: 1px;; border-bottom: 1px solid #ccc; padding: 9px 12px">
<b>NPE during update</b>
</div>
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
/**
* Tries to update two records in database.
*
* Throws RollbackException caused by NPE during commit. It is marked as expected <span class="code-keyword" style="color: #000091">for</span>
* demonstration purpose.
*/
@Test(expected = RollbackException.class)
<span class="code-keyword" style="color: #000091">public</span> void testMultipleUpdatesNPE() {
EntityManager em = <span class="code-keyword" style="color: #000091">null</span>;
<span class="code-keyword" style="color: #000091">try</span> {
em = prepareEntityManager();
Query q = em.createQuery(<span class="code-quote" style="color: #009100">"select s from DemoEntity s"</span>, DemoEntity.class);
List<DemoEntity> results = q.getResultList();
results.get(0).setName(<span class="code-quote" style="color: #009100">"Different 0"</span>);
results.get(1).setName(<span class="code-quote" style="color: #009100">"Different 1"</span>);
em.getTransaction().commit(); <span class="code-comment" style="color: #808080">// RollbackException caused by NPE
</span>
List<DemoEntity> check = q.getResultList();
assertEquals(<span class="code-quote" style="color: #009100">"Different 0"</span>, check.get(0).getName());
assertEquals(<span class="code-quote" style="color: #009100">"Different 1"</span>, check.get(1).getName());
} <span class="code-keyword" style="color: #000091">finally</span> {
closeEntityManager(em);
}
}
</pre>
</div>
</div>
<div class="panel" style="border-width: 1px;; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="panelHeader" style="border-bottom-width: 1px;; border-bottom: 1px solid #ccc; padding: 9px 12px">
<b>Stack Trace when updating</b>
</div>
<div class="panelContent" style="padding: 9px 12px">
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">javax.persistence.RollbackException: Error while committing the transaction<br /> at org.hibernate.jpa.internal.TransactionImpl.commit(TransactionImpl.java:94)<br /> at ByteArrayPKTest.testMultipleUpdatesBugged(ByteArrayPKTest.java:152)<br /> ...<br /> Caused by: java.lang.NullPointerException<br /> at org.hibernate.type.AbstractStandardBasicType.compare(AbstractStandardBasicType.java:221)<br /> at org.hibernate.action.internal.EntityAction.compareTo(EntityAction.java:171)<br /> at org.hibernate.engine.spi.ExecutableList.add(ExecutableList.java:222)<br /> at org.hibernate.engine.spi.ActionQueue.addAction(ActionQueue.java:237)<br /> at org.hibernate.event.internal.DefaultFlushEntityEventListener.scheduleUpdate(DefaultFlushEntityEventListener.java:313)<br /> at org.hibernate.event.internal.DefaultFlushEntityEventListener.onFlushEntity(DefaultFlushEntityEventListener.java:160)<br /> at org.hibernate.event.internal.AbstractFlushingEventListener.flushEntities(AbstractFlushingEventListener.java:231)<br /> at org.hibernate.event.internal.AbstractFlushingEventListener.flushEverythingToExecutions(AbstractFlushingEventListener.java:102)<br /> at org.hibernate.event.internal.DefaultFlushEventListener.onFlush(DefaultFlushEventListener.java:55)<br /> at org.hibernate.internal.SessionImpl.flush(SessionImpl.java:1218)<br /> at org.hibernate.internal.SessionImpl.managedFlush(SessionImpl.java:421)<br /> at org.hibernate.engine.transaction.internal.jdbc.JdbcTransaction.beforeTransactionCommit(JdbcTransaction.java:101)<br /> at org.hibernate.engine.transaction.spi.AbstractTransactionImpl.commit(AbstractTransactionImpl.java:177)<br /> at org.hibernate.jpa.internal.TransactionImpl.commit(TransactionImpl.java:77)</p>
</div>
</div>
<h2 style="margin: 10px 0 0 0; font-size: 20px; font-weight: normal; line-height: 1.500; margin: 40px 0 0 0"><a name="Problemreason" style="color: #3b73af; text-decoration: none"></a>Problem reason</h2>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">In delete/update process <em>org.hibernate.engine.spi.ExecutableList</em> collection is used. This is a sorted list and each add operation compares adding object to last added. In this case comparison is performed on <em>EntityAction</em> objects.</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeHeader panelHeader" style="border-bottom-width: 1px;; border-bottom: 1px solid #ccc; padding: 9px 12px">
<b>org/hibernate/action/internal/EntityAction.java</b>
</div>
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
...
@Override
<span class="code-keyword" style="color: #000091">public</span> <span class="code-object" style="color: #910091">int</span> compareTo(<span class="code-object" style="color: #910091">Object</span> other) {
<span class="code-keyword" style="color: #000091">final</span> EntityAction action = (EntityAction) other;
<span class="code-comment" style="color: #808080">//sort first by entity name
</span> <span class="code-keyword" style="color: #000091">final</span> <span class="code-object" style="color: #910091">int</span> roleComparison = entityName.compareTo( action.entityName );
<span class="code-keyword" style="color: #000091">if</span> ( roleComparison != 0 ) {
<span class="code-keyword" style="color: #000091">return</span> roleComparison;
}
<span class="code-keyword" style="color: #000091">else</span> {
<span class="code-comment" style="color: #808080">//then by id
</span> <span class="code-keyword" style="color: #000091">return</span> persister.getIdentifierType().compare( id, action.id );
}
}
...
</pre>
</div>
</div>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">Accordingly, method <em>EntityAction.compareTo</em> compares wrapped primary keys of entities. Byte array is wrapped by <em>PrimitiveByteArrayTypeDescriptor</em>.<br /> This class calls its super constructor (<em>AbstractTypeDescriptor</em>) with <b>byte[].class</b> as argument.</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeHeader panelHeader" style="border-bottom-width: 1px;; border-bottom: 1px solid #ccc; padding: 9px 12px">
<b>org/hibernate/type/descriptor/java/PrimitiveByteArrayTypeDescriptor.java</b>
</div>
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
...
<span class="code-keyword" style="color: #000091">public</span> PrimitiveByteArrayTypeDescriptor() {
<span class="code-keyword" style="color: #000091">super</span>( <span class="code-object" style="color: #910091">byte</span>[].class, ArrayMutabilityPlan.INSTANCE );
}
...
</pre>
</div>
</div>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0"><em>AbstractTypeDescriptor</em> constructor set <b>comparator</b> only if given class implements <em>Comparator</em> interface:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeHeader panelHeader" style="border-bottom-width: 1px;; border-bottom: 1px solid #ccc; padding: 9px 12px">
<b>org/hibernate/type/descriptor/java/AbstractTypeDescriptor.java</b>
</div>
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
...
<span class="code-keyword" style="color: #000091">protected</span> AbstractTypeDescriptor(<span class="code-object" style="color: #910091">Class</span><T> type, MutabilityPlan<T> mutabilityPlan) {
<span class="code-keyword" style="color: #000091">this</span>.type = type;
<span class="code-keyword" style="color: #000091">this</span>.mutabilityPlan = mutabilityPlan;
<span class="code-keyword" style="color: #000091">this</span>.comparator = Comparable.class.isAssignableFrom( type )
? (Comparator<T>) ComparableComparator.INSTANCE
: <span class="code-keyword" style="color: #000091">null</span>;
}
...
</pre>
</div>
</div>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">Byte array of course doesn't implement <em>Comparator</em> interface and during comparison of <em>PrimitiveByteArrayTypeDescriptor</em> objects their comparators are <b>null</b>.</p>
<h2 style="margin: 10px 0 0 0; font-size: 20px; font-weight: normal; line-height: 1.500; margin: 40px 0 0 0"><a name="Avoidingproblem" style="color: #3b73af; text-decoration: none"></a>Avoiding problem</h2>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">Issues in both cases can be avoided by explicitly calling <b>em.flush()</b> after each update/delete operation. Flush clears <em>ExecutableList</em> collections and <b>NPE</b> is not thrown. Although this does not solve the problem.</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeHeader panelHeader" style="border-bottom-width: 1px;; border-bottom: 1px solid #ccc; padding: 9px 12px">
<b>Avoiding NPE during delete</b>
</div>
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
/**
* Removes two records from database.
*
* Flush operation placed between removing each entity prevent NPE throwing.
*/
@Test
<span class="code-keyword" style="color: #000091">public</span> void testMultipleDeletions() {
EntityManager em = <span class="code-keyword" style="color: #000091">null</span>;
<span class="code-keyword" style="color: #000091">try</span> {
em = prepareEntityManager();
Query q = em.createQuery(<span class="code-quote" style="color: #009100">"select s from DemoEntity s"</span>, DemoEntity.class);
List<DemoEntity> results = q.getResultList();
em.remove(results.get(0));
em.flush(); <span class="code-comment" style="color: #808080">// clear deletions queue - prevent throwing NPE
</span> em.remove(results.get(1));
em.getTransaction().commit(); <span class="code-comment" style="color: #808080">//implicitly calls flush
</span>
assertEquals(1, q.getResultList().size());
} <span class="code-keyword" style="color: #000091">finally</span> {
closeEntityManager(em);
}
}
</pre>
</div>
</div>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeHeader panelHeader" style="border-bottom-width: 1px;; border-bottom: 1px solid #ccc; padding: 9px 12px">
<b>Avoiding NPE during update</b>
</div>
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
/**
* Updates two records in database.
*
* Flush operation placed between changing each entity prevents NPE throwing.
*/
@Test
<span class="code-keyword" style="color: #000091">public</span> void testMultipleUpdates() {
EntityManager em = <span class="code-keyword" style="color: #000091">null</span>;
<span class="code-keyword" style="color: #000091">try</span> {
em = prepareEntityManager();
Query q = em.createQuery(<span class="code-quote" style="color: #009100">"select s from DemoEntity s"</span>, DemoEntity.class);
List<DemoEntity> results = q.getResultList();
results.get(0).setName(<span class="code-quote" style="color: #009100">"Different 0"</span>);
em.flush();
results.get(1).setName(<span class="code-quote" style="color: #009100">"Different 1"</span>);
em.getTransaction().commit(); <span class="code-comment" style="color: #808080">//implicitly calls flush
</span>
List<DemoEntity> check = q.getResultList();
assertEquals(<span class="code-quote" style="color: #009100">"Different 0"</span>, check.get(0).getName());
assertEquals(<span class="code-quote" style="color: #009100">"Different 1"</span>, check.get(1).getName());
} <span class="code-keyword" style="color: #000091">finally</span> {
closeEntityManager(em);
}
}
</pre>
</div>
</div>
<h2 style="margin: 10px 0 0 0; font-size: 20px; font-weight: normal; line-height: 1.500; margin: 40px 0 0 0"><a name="Issuereproduction" style="color: #3b73af; text-decoration: none"></a>Issue reproduction</h2>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">In order to reproduce this problem (on 4.3.X version), demonstration project has been attached.</p>
<div class="panel" style="border-width: 1px;; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="panelHeader" style="border-bottom-width: 1px;; border-bottom: 1px solid #ccc; padding: 9px 12px">
<b>Test cases can be run with command</b>
</div>
<div class="panelContent" style="padding: 9px 12px">
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">mvn test</p>
</div>
</div>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">All tests will be successful <b>because undesirable exceptions thrown in <em>testMultipleDeletionsNPE</em> and <em>testMultipleUpdatesNPE</em> are annotated as expected</b> but problem still exists.</p>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">In order to verify the proper behavior of version <em>4.2.X</em> the <b>hibernate-entitymanager</b> version and the <b>jpa provider</b> should be changed e.g:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeHeader panelHeader" style="border-bottom-width: 1px;; border-bottom: 1px solid #ccc; padding: 9px 12px">
<b>persistence.xml</b>
</div>
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-xml" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<span class="code-tag" style="color: #000091"><persistence ...></span>
<span class="code-tag" style="color: #000091"><persistence-unit name=<span class="code-quote" style="color: #009100">"DEMO"</span> transaction-type=<span class="code-quote" style="color: #009100">"RESOURCE_LOCAL"</span>></span>
<span class="code-tag" style="color: #000091"><provider></span>org.hibernate.ejb.HibernatePersistence<span class="code-tag" style="color: #000091"></provider></span>
...
<span class="code-tag" style="color: #000091"></persistence-unit></span>
<span class="code-tag" style="color: #000091"></persistence></span>
</pre>
</div>
</div>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeHeader panelHeader" style="border-bottom-width: 1px;; border-bottom: 1px solid #ccc; padding: 9px 12px">
<b>pom.xml</b>
</div>
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-xml" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
...
<span class="code-tag" style="color: #000091"><dependency></span>
<span class="code-tag" style="color: #000091"><groupId></span>org.hibernate<span class="code-tag" style="color: #000091"></groupId></span>
<span class="code-tag" style="color: #000091"><artifactId></span>hibernate-entitymanager<span class="code-tag" style="color: #000091"></artifactId></span>
<span class="code-tag" style="color: #000091"><version></span>4.2.17.Final<span class="code-tag" style="color: #000091"></version></span>
<span class="code-tag" style="color: #000091"><dependency></span>
...
</pre>
</div>
</div>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">In this case exceptions in <em>testMultipleDeletionsNPE</em> and <em>testMultipleUpdatesNPE</em> will not be thrown and those tests will fail.</p>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-9606#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-2670ce41-16d2-4ac9-9fe2-73d41a4b489a" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle" /> </a>
</td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-9606#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #fff; border-top: 0; border-left: 1px solid #ccc; border-bottom: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly">
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px">
This message was sent by Atlassian JIRA <span id="footer-build-information">(v6.4-OD-14-082#64012-<span title="d36fff0c243be42df61ba548758835b0b39acb15" data-commit-id="d36fff0c243be42df61ba548758835b0b39acb15}">sha1:d36fff0</span>)</span>
</td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-3c6c80ac-56e9-4e69-9f24-b643eb8aeb88" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix" />
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</body>
</html>