<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0" /> <base href="https://hibernate.atlassian.net" />
<title>Message Title</title>
</head>
<body class="jira" style="color: #333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<!-- header here -->
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px"> <img id="header-avatar-image" class="image_fix" src="https://secure.gravatar.com/avatar/12df4da7e3351be801bc16b66caf8038?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top" />
</td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="hardy.ferentschik" id="email_hardy.ferentschik" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=hardy.ferentschik" style="color:#6c797f;; color: #3b73af; text-decoration: none">Hardy Ferentschik</a> <strong>commented</strong> on <a href="https://hibernate.atlassian.net/browse/HV-976" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-static-bug-8c02986f-d3ab-44a8-903c-6b18b6e5d5ac" height="16" width="16" border="0" align="absmiddle" alt="Bug" /> HV-976</a>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 15px; background-color: #fff; border-left: 1px solid #ccc; border-top: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly">
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HV-976" style="color: #3b73af; text-decoration: none">Re: Optional and Type Annotations</a> </span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff; border-bottom: none; padding-bottom: 0">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0">
<div class="code panel" style="border-style: solid;border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeHeader panelHeader" style="border-bottom-width: 1px;border-bottom-style: solid;; border-bottom: 1px solid #ccc; padding: 9px 12px">
<b>OptionalTypeAnnotationConstraintTest.java</b>
</div>
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
ublic class OptionalTypeAnnotationConstraintTest {
<span class="code-keyword" style="color: #000091">private</span> Validator validator;
@BeforeClass
<span class="code-keyword" style="color: #000091">public</span> void setup() {
validator = getValidator();
}
@Test
<span class="code-keyword" style="color: #000091">public</span> void without_type_annotation_on_optional_is_validated_for_null_value() {
Model model = <span class="code-keyword" style="color: #000091">new</span> Model();
model.valueWithoutTypeAnnotation = <span class="code-keyword" style="color: #000091">null</span>;
Set<ConstraintViolation<Model>> constraintViolations = validator.validateProperty(
model,
<span class="code-quote" style="color: #009100">"valueWithoutTypeAnnotation"</span>
);
assertNumberOfViolations( constraintViolations, 1 );
assertCorrectPropertyPaths( constraintViolations, <span class="code-quote" style="color: #009100">"valueWithoutTypeAnnotation"</span> );
assertConstraintViolation( constraintViolations.iterator().next(), <span class="code-quote" style="color: #009100">"container"</span> );
assertCorrectConstraintTypes( constraintViolations, NotNull.class );
}
@Test
<span class="code-keyword" style="color: #000091">public</span> void without_type_annotation_on_optional_is_validated_for_empty_value() {
Model model = <span class="code-keyword" style="color: #000091">new</span> Model();
model.valueWithoutTypeAnnotation = Optional.empty();
Set<ConstraintViolation<Model>> constraintViolations = validator.validateProperty(
model,
<span class="code-quote" style="color: #009100">"valueWithoutTypeAnnotation"</span>
);
assertNumberOfViolations( constraintViolations, 0 );
}
/**
* Actual: Fails with NullPointerException (Unexpected exception during isValid call)
*/
@Test
<span class="code-keyword" style="color: #000091">public</span> void not_null_type_on_optional_is_validated_for_null_value() {
Model model = <span class="code-keyword" style="color: #000091">new</span> Model();
model.valueWithNotNull = <span class="code-keyword" style="color: #000091">null</span>;
Set<ConstraintViolation<Model>> constraintViolations = validator.validateProperty( model, <span class="code-quote" style="color: #009100">"valueWithNotNull"</span> );
assertNumberOfViolations( constraintViolations, 1 );
assertCorrectPropertyPaths( constraintViolations, <span class="code-quote" style="color: #009100">"valueWithNotNull"</span> );
assertConstraintViolation( constraintViolations.iterator().next(), <span class="code-quote" style="color: #009100">"container"</span> );
assertCorrectConstraintTypes( constraintViolations, NotNull.class );
}
/**
* Actual: NotNull violation occurs on container's annotation
*/
@Test
<span class="code-keyword" style="color: #000091">public</span> void not_null_type_on_optional_is_validated_for_empty_value() {
Model model = <span class="code-keyword" style="color: #000091">new</span> Model();
model.valueWithNotNull = Optional.empty();
Set<ConstraintViolation<Model>> constraintViolations = validator.validateProperty( model, <span class="code-quote" style="color: #009100">"valueWithNotNull"</span> );
assertNumberOfViolations( constraintViolations, 1 );
assertCorrectPropertyPaths( constraintViolations, <span class="code-quote" style="color: #009100">"valueWithNotNull"</span> );
assertConstraintViolation( constraintViolations.iterator().next(), <span class="code-quote" style="color: #009100">"type"</span> );
assertCorrectConstraintTypes( constraintViolations, NotNullTypeUse.class );
}
/**
* Actual: Fails with NullPointerException (Unexpected exception during isValid call)
*/
@Test
<span class="code-keyword" style="color: #000091">public</span> void null_or_not_blank_type_on_optional_is_validated_for_null_value() {
Model model = <span class="code-keyword" style="color: #000091">new</span> Model();
model.valueWithNullOrNotBlank = <span class="code-keyword" style="color: #000091">null</span>;
Set<ConstraintViolation<Model>> constraintViolations = validator.validateProperty(
model,
<span class="code-quote" style="color: #009100">"valueWithNullOrNotBlank"</span>
);
assertNumberOfViolations( constraintViolations, 1 );
assertCorrectPropertyPaths( constraintViolations, <span class="code-quote" style="color: #009100">"valueWithNullOrNotBlank"</span> );
assertConstraintViolation( constraintViolations.iterator().next(), <span class="code-quote" style="color: #009100">"container"</span> );
assertCorrectConstraintTypes( constraintViolations, NotNull.class );
}
/**
* Actual: NotNull violation occurs on container's annotation
*/
@Test
<span class="code-keyword" style="color: #000091">public</span> void null_or_not_blank_type_on_optional_is_validated_for_empty_value() {
Model model = <span class="code-keyword" style="color: #000091">new</span> Model();
model.valueWithNullOrNotBlank = Optional.empty();
Set<ConstraintViolation<Model>> constraintViolations = validator.validateProperty(
model,
<span class="code-quote" style="color: #009100">"valueWithNullOrNotBlank"</span>
);
assertNumberOfViolations( constraintViolations, 0 );
}
/**
* Actual: No violation
*/
@Test
<span class="code-keyword" style="color: #000091">public</span> void null_or_not_blank_type_on_optional_is_validated_for_blank_string() {
Model model = <span class="code-keyword" style="color: #000091">new</span> Model();
model.valueWithNullOrNotBlank = Optional.of( "" );
Set<ConstraintViolation<Model>> constraintViolations = validator.validateProperty(
model,
<span class="code-quote" style="color: #009100">"valueWithNullOrNotBlank"</span>
);
assertNumberOfViolations( constraintViolations, 1 );
assertCorrectPropertyPaths( constraintViolations, <span class="code-quote" style="color: #009100">"valueWithNullOrNotBlank"</span> );
assertConstraintViolation( constraintViolations.iterator().next(), <span class="code-quote" style="color: #009100">"type"</span> );
assertCorrectConstraintTypes( constraintViolations, NullOrNotBlank.class );
}
@Test
<span class="code-keyword" style="color: #000091">public</span> void reference_is_validated_for_null_value() {
Model model = <span class="code-keyword" style="color: #000091">new</span> Model();
model.valueReference = <span class="code-keyword" style="color: #000091">null</span>;
Set<ConstraintViolation<Model>> constraintViolations = validator.validateProperty( model, <span class="code-quote" style="color: #009100">"valueReference"</span> );
assertNumberOfViolations( constraintViolations, 0 );
}
@Test
<span class="code-keyword" style="color: #000091">public</span> void reference_is_validated_for_empty_string() {
Model model = <span class="code-keyword" style="color: #000091">new</span> Model();
model.valueReference = "";
Set<ConstraintViolation<Model>> constraintViolations = validator.validateProperty( model, <span class="code-quote" style="color: #009100">"valueReference"</span> );
assertNumberOfViolations( constraintViolations, 1 );
assertCorrectPropertyPaths( constraintViolations, <span class="code-quote" style="color: #009100">"valueReference"</span> );
assertConstraintViolation( constraintViolations.iterator().next(), <span class="code-quote" style="color: #009100">"reference"</span> );
assertCorrectConstraintTypes( constraintViolations, NullOrNotBlank.class );
}
@Test
<span class="code-keyword" style="color: #000091">public</span> void reference_is_validated_for_valid_string() {
Model model = <span class="code-keyword" style="color: #000091">new</span> Model();
model.valueReference = <span class="code-quote" style="color: #009100">"1"</span>;
Set<ConstraintViolation<Model>> constraintViolations = validator.validateProperty( model, <span class="code-quote" style="color: #009100">"valueReference"</span> );
assertNumberOfViolations( constraintViolations, 0 );
}
@ConstraintComposition(CompositionType.OR)
@Null
@NotBlank
@ReportAsSingleViolation
@Constraint(validatedBy = { })
@Target({ TYPE_USE, METHOD, FIELD, ANNOTATION_TYPE, CONSTRUCTOR, PARAMETER })
@Retention(RUNTIME)
@Documented
<span class="code-keyword" style="color: #000091">public</span> @<span class="code-keyword" style="color: #000091">interface</span> NullOrNotBlank {
<span class="code-object" style="color: #910091">String</span> message() <span class="code-keyword" style="color: #000091">default</span> <span class="code-quote" style="color: #009100">"NullOrNotBlank"</span>;
<span class="code-object" style="color: #910091">Class</span><?>[] groups() <span class="code-keyword" style="color: #000091">default</span> { };
<span class="code-object" style="color: #910091">Class</span><? <span class="code-keyword" style="color: #000091">extends</span> Payload>[] payload() <span class="code-keyword" style="color: #000091">default</span> { };
}
<span class="code-keyword" style="color: #000091">private</span> <span class="code-keyword" style="color: #000091">static</span> class Model {
@UnwrapValidatedValue(<span class="code-keyword" style="color: #000091">false</span>)
@NotNull(message = <span class="code-quote" style="color: #009100">"container"</span>)
Optional<<span class="code-object" style="color: #910091">String</span>> valueWithoutTypeAnnotation;
@UnwrapValidatedValue(<span class="code-keyword" style="color: #000091">false</span>)
@NotNull(message = <span class="code-quote" style="color: #009100">"container"</span>)
Optional<@NotNullTypeUse(message = <span class="code-quote" style="color: #009100">"type"</span>) <span class="code-object" style="color: #910091">String</span>> valueWithNotNull;
@UnwrapValidatedValue(<span class="code-keyword" style="color: #000091">false</span>)
@NotNull(message = <span class="code-quote" style="color: #009100">"container"</span>)
Optional<@NullOrNotBlank(message = <span class="code-quote" style="color: #009100">"type"</span>) <span class="code-object" style="color: #910091">String</span>> valueWithNullOrNotBlank;
@NullOrNotBlank(message = <span class="code-quote" style="color: #009100">"reference"</span>)
<span class="code-object" style="color: #910091">String</span> valueReference;
}
}
</pre>
</div>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HV-976#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-e471ff28-83c2-4604-93cf-ad59fc42a087" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle" /> </a>
</td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HV-976#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #fff; border-top: 0; border-left: 1px solid #ccc; border-bottom: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly">
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px">
This message was sent by Atlassian JIRA <span id="footer-build-information">(v6.4-OD-15-055#64014-<span title="797c660868dfc4d690d8b76e2560e35770d95524" data-commit-id="797c660868dfc4d690d8b76e2560e35770d95524}">sha1:797c660</span>)</span>
</td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-d6023e7d-3d37-4bc6-aa0c-5f98888fe970" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix" />
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</body>
</html>