<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0" /> <base href="https://hibernate.atlassian.net" />
<title>Message Title</title>
</head>
<body class="jira" style="color: #333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<!-- header here -->
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px"> <img id="header-avatar-image" class="image_fix" src="https://secure.gravatar.com/avatar/c32c4103dacf291cdfa0439e34f2c07e?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top" />
</td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="gbadner" id="email_gbadner" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=gbadner" style="color:#6c797f;; color: #3b73af; text-decoration: none">Gail Badner</a> <strong>updated</strong> an issue
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 15px; background-color: #fff; border-left: 1px solid #ccc; border-top: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly">
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class="page-title-pattern-first-line " style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://hibernate.atlassian.net/browse/HHH" style="color: #3b73af; text-decoration: none">Hibernate ORM</a> / <a href="https://hibernate.atlassian.net/browse/HHH-9736" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-static-bug-1009d9e6-cba1-415b-ba33-a4811a799702" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom" /></a> <a href="https://hibernate.atlassian.net/browse/HHH-9736" style="color: #3b73af; text-decoration: none">HHH-9736</a>
</td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-9736" style="color: #3b73af; text-decoration: none">BigIntegerType should use BigIntTypeDescriptor</a> </span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff; padding-top: 10px; padding-bottom: 5px">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Change By:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="gbadner" id="email_gbadner" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=gbadner" style="color:#6c797f;; color: #3b73af; text-decoration: none">Gail Badner</a>
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Summary:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">Column generated for big_integer properties</span> <span class="diffaddedchars" style="background-color:#ddfade;">BigIntegerType</span> <span class="diffcontext"> should</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> have scale=0 by default</span> <span class="diffaddedchars" style="background-color:#ddfade;"> use BigIntTypeDescriptor</span>
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Issue Type:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">Improvement</span> <span class="diffaddedchars" style="background-color:#ddfade;">Bug</span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff; padding-top: 5px; padding-bottom: 10px">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0"> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">The scale</span> <span class="diffaddedchars" style="background-color:#ddfade;">Currently, BigIntegerType specifies NumericTypeDescriptor.INSTANCE as its SqlTypeDescriptor; instead it</span> <span class="diffcontext"> should</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> be 0 for the column generated for a property</span> <span class="diffaddedchars" style="background-color:#ddfade;"> use org.hibernate.type.descriptor.sql,BigIntTypeDescriptor.INSTANCE.<br /><br />A consequence</span> <span class="diffcontext"> of</span> <span class="diffaddedchars" style="background-color:#ddfade;"> NumericTypeDescriptor.INSTANCE being defined is that columns involved in properties of "big_integer"</span> <span class="diffcontext"> type</span> <span class="diffaddedchars" style="background-color:#ddfade;"> are treated as</span> <span class="diffcontext"> java.sql.Types.</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">BIGINT</span> <span class="diffaddedchars" style="background-color:#ddfade;">NUMERIC</span> <span class="diffcontext">.</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> Currently, the default is 2</span> <span class="diffaddedchars" style="background-color:#ddfade;"> This means that such columns are:<br />* bound using PreparedStatement</span> <span class="diffcontext">.</span> <span class="diffaddedchars" style="background-color:#ddfade;">setBigDecimal();</span> <span class="diffcontext"><br /></span> <span class="diffaddedchars" style="background-color:#ddfade;">* extracted using ResultSet.getBigDecimal();</span> <span class="diffcontext"><br /></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">Making this change will fix problems with SQL Server sequences of</span> <span class="diffaddedchars" style="background-color:#ddfade;">* exported using the</span> <span class="diffcontext"> type</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> bigint</span> <span class="diffaddedchars" style="background-color:#ddfade;"> mapped by the dialect for java</span> <span class="diffcontext">.</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> By default</span> <span class="diffaddedchars" style="background-color:#ddfade;">sql.Types.NUMERIC (e.g.</span> <span class="diffcontext">,</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> a bigint sequence ranges from -9</span> <span class="diffaddedchars" style="background-color:#ddfade;"> for H2Dialect</span> <span class="diffcontext">,</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">223</span> <span class="diffaddedchars" style="background-color:#ddfade;"> the column would be exported as decimal(19</span> <span class="diffcontext">,</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">372,036,854,775,808</span> <span class="diffaddedchars" style="background-color:#ddfade;">2) by default).<br /><br />By changing BigIntegerType</span> <span class="diffcontext"> to</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> 9</span> <span class="diffaddedchars" style="background-color:#ddfade;"> specify org.hibernate.type.descriptor.sql</span> <span class="diffcontext">,</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">223,372,036,854,775,807</span> <span class="diffaddedchars" style="background-color:#ddfade;">BigIntTypeDescriptor</span> <span class="diffcontext">.</span> <span class="diffaddedchars" style="background-color:#ddfade;">INSTANCE as its SqlTypeDescriptor, columns for "big_integer" properties will be</span> <span class="diffcontext"> <br /></span> <span class="diffaddedchars" style="background-color:#ddfade;">* bound using PreparedStatement.setLong();</span> <span class="diffcontext"><br /></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">By default,</span> <span class="diffaddedchars" style="background-color:#ddfade;">* extracted using ResultSet.getLong();<br />* exported using</span> <span class="diffcontext"> the</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> first sequence value returned</span> <span class="diffaddedchars" style="background-color:#ddfade;"> type mapped</span> <span class="diffcontext"> by</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> SQL Server is -9</span> <span class="diffaddedchars" style="background-color:#ddfade;"> the dialect for java.sql.Types.BIGINT (e.g.</span> <span class="diffcontext">,</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">223</span> <span class="diffaddedchars" style="background-color:#ddfade;"> for H2Dialect</span> <span class="diffcontext">,</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">372,036,854,775,808. With</span> <span class="diffcontext"> the</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> current</span> <span class="diffaddedchars" style="background-color:#ddfade;"> column would be exported as bigint by</span> <span class="diffcontext"> default</span> <span class="diffaddedchars" style="background-color:#ddfade;">).<br /><br />Dialects already register a type to be used for java.sql.Types.BIGINT that has</span> <span class="diffcontext"> scale</span> <span class="diffaddedchars" style="background-color:#ddfade;">=0, either implicitly</span> <span class="diffcontext"> (</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">of 2)</span> <span class="diffaddedchars" style="background-color:#ddfade;">e.g</span> <span class="diffcontext">,</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> SQL Server throws</span> <span class="diffaddedchars" style="background-color:#ddfade;"> H2Dialect has</span> <span class="diffcontext">:</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> com</span> <span class="diffaddedchars" style="background-color:#ddfade;"> registerColumnType( Types</span> <span class="diffcontext">.</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">microsoft</span> <span class="diffaddedchars" style="background-color:#ddfade;">BIGINT, "bigint" )), or explicitly (e</span> <span class="diffcontext">.</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">sqlserver</span> <span class="diffaddedchars" style="background-color:#ddfade;">g</span> <span class="diffcontext">.</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">jdbc.SQLServerException</span> <span class="diffaddedchars" style="background-color:#ddfade;">, Oracle8iDialect has</span> <span class="diffcontext">:</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> Arithmetic overflow error converting numeric to data type numeric</span> <span class="diffaddedchars" style="background-color:#ddfade;"> registerColumnType( Types</span> <span class="diffcontext">.</span> <span class="diffaddedchars" style="background-color:#ddfade;">BIGINT, "number(19,0)" )). This mapping is properly used for "long" properties. When this is fixed, the same mapping will be used for "big_integer" properties.</span> <span class="diffcontext"><br /><br /></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">See</span> <span class="diffaddedchars" style="background-color:#ddfade;">This issue will fix</span> <span class="diffcontext"> HHH-9250</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> for more details of the failure on SQL Server</span> <span class="diffcontext">. The fix for HHH-9250 simply</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> changes</span> <span class="diffaddedchars" style="background-color:#ddfade;"> changed</span> <span class="diffcontext"> the mapping for a test that fails using SQL Server to explicitly set scale="0" as a workaround.</span> <span class="diffaddedchars" style="background-color:#ddfade;"><br /><br />In order to restore the legacy behavior, an application will have to override the "big_integer" type with a custom type that specifies NumericTypeDescriptor.INSTANCE as its SqlTypeDescriptor.</span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-9736#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-bfb040f4-5beb-4019-94d2-292454d8b856" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle" /> </a>
</td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-9736#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #fff; border-top: 0; border-left: 1px solid #ccc; border-bottom: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly">
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px">
This message was sent by Atlassian JIRA <span id="footer-build-information">(v6.5-OD-01-120#65000-<span title="0dc1796b325ae7e85b1dca228885a3417f39097a" data-commit-id="0dc1796b325ae7e85b1dca228885a3417f39097a}">sha1:0dc1796</span>)</span>
</td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-41ce1760-ca68-44ca-9fe9-ed9de4b0845b" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix" />
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</body>
</html>