<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0" /> <base href="https://hibernate.atlassian.net" />
<title>Message Title</title>
</head>
<body class="jira" style="color: #333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<!-- header here -->
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px"> <img id="header-avatar-image" class="image_fix" src="https://secure.gravatar.com/avatar/f03a995c7faf8268813bec82e9b9ac00?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top" />
</td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="gurkerl" id="email_gurkerl" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=gurkerl" style="color:#6c797f;; color: #3b73af; text-decoration: none">Markus Gritsch</a> <strong>commented</strong> on <a href="https://hibernate.atlassian.net/browse/OGM-783" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-static-bug-16449319-58ea-4d09-9c5d-462d32f3a693" height="16" width="16" border="0" align="absmiddle" alt="Bug" /> OGM-783</a>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 15px; background-color: #fff; border-left: 1px solid #ccc; border-top: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly">
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/OGM-783" style="color: #3b73af; text-decoration: none">Re: [Neo4j][JP-QL] Select of entity with embedded collection returns two nodes instead of one</a> </span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff; border-bottom: none; padding-bottom: 0">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0">
<p style="margin: 10px 0 0 0">As you described this is a must have feature.</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<span class="code-comment" style="color: #808080">// result 1 is empty
</span>List<?> result1 = session.createQuery( <span class="code-quote" style="color: #009100">"from Person e where e.id.firstName = 'Emmanuel'"</span> ).list();
PersonPK emmanuelPk = <span class="code-keyword" style="color: #000091">new</span> PersonPK();
emmanuelPk.setFirstName( <span class="code-quote" style="color: #009100">"Emmanuel"</span> );
emmanuelPk.setLastName( <span class="code-quote" style="color: #009100">"Bernard"</span> );
<span class="code-comment" style="color: #808080">// result 2 corresponds to the correct entity
</span><span class="code-object" style="color: #910091">Object</span> result2 = session.get(Person.class, emmanuelPk);
<span class="code-comment" style="color: #808080">// result 3 corresponds to the correct entity - <span class="code-keyword" style="color: #000091; color: #808080">this</span> was fixed by the pull request
</span>List<?> result3 = session.createQuery( <span class="code-quote" style="color: #009100">"from Person e where e.address.street = 'Penion Str.'"</span> ).list();
</pre>
</div>
</div>
<p style="margin: 10px 0 0 0">Did some more digging. I wanted to know if the Match statement was not generated properly by comparing @EmbbededId and @Embedded.</p>
<p style="margin: 10px 0 0 0">queryBuilder.toString() corresponds to the following <b>(identical)</b> match statements</p>
<p style="margin: 10px 0 0 0">MATCH (e:Person) </p>
<del>
<span class="error">[:id]</span>
</del>> (`_e1`:EMBEDDED) WHERE `_e1`.firstName = "Emmanuel" RETURN e<br /> MATCH (e:Person)
<del>
<span class="error">[:address]</span>
</del>> (`_e1`:EMBEDDED) WHERE `_e1`.street = "Penion Str." RETURN e
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
@Override
<span class="code-keyword" style="color: #000091">public</span> Neo4jQueryParsingResult getResult() {
<span class="code-object" style="color: #910091">String</span> targetAlias = embeddedAliasResolver.findAliasForType( targetTypeName );
<span class="code-object" style="color: #910091">String</span> label = getKeyMetaData( targetType ).getTable();
StringBuilder queryBuilder = <span class="code-keyword" style="color: #000091">new</span> StringBuilder();
match( queryBuilder, targetAlias, label );
where( queryBuilder );
optionalMatch( queryBuilder, targetAlias );
returns( queryBuilder, targetAlias );
orderBy( queryBuilder );
<span class="code-keyword" style="color: #000091">return</span> <span class="code-keyword" style="color: #000091">new</span> Neo4jQueryParsingResult( targetType, projections, queryBuilder.toString() );
}
</pre>
</div>
</div>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
@Embeddable
<span class="code-keyword" style="color: #000091">public</span> class Address <span class="code-keyword" style="color: #000091">implements</span> Serializable {
<span class="code-keyword" style="color: #000091">private</span> <span class="code-keyword" style="color: #000091">static</span> <span class="code-keyword" style="color: #000091">final</span> <span class="code-object" style="color: #910091">long</span> serialVersionUID = 1L;
<span class="code-keyword" style="color: #000091">private</span> <span class="code-object" style="color: #910091">String</span> street;
<span class="code-keyword" style="color: #000091">private</span> <span class="code-object" style="color: #910091">String</span> city;
<span class="code-keyword" style="color: #000091">public</span> <span class="code-object" style="color: #910091">String</span> getStreet() {
<span class="code-keyword" style="color: #000091">return</span> street;
}
<span class="code-keyword" style="color: #000091">public</span> <span class="code-object" style="color: #910091">String</span> getCity() {
<span class="code-keyword" style="color: #000091">return</span> city;
}
<span class="code-keyword" style="color: #000091">public</span> void setStreet(<span class="code-object" style="color: #910091">String</span> street) {
<span class="code-keyword" style="color: #000091">this</span>.street = street;
}
<span class="code-keyword" style="color: #000091">public</span> void setCity(<span class="code-object" style="color: #910091">String</span> city) {
<span class="code-keyword" style="color: #000091">this</span>.city = city;
}
@Override
<span class="code-keyword" style="color: #000091">public</span> <span class="code-object" style="color: #910091">boolean</span> equals(<span class="code-object" style="color: #910091">Object</span> o) {
<span class="code-keyword" style="color: #000091">if</span> ( <span class="code-keyword" style="color: #000091">this</span> == o ) {
<span class="code-keyword" style="color: #000091">return</span> <span class="code-keyword" style="color: #000091">true</span>;
}
<span class="code-keyword" style="color: #000091">if</span> ( !( o <span class="code-keyword" style="color: #000091">instanceof</span> Address ) ) {
<span class="code-keyword" style="color: #000091">return</span> <span class="code-keyword" style="color: #000091">false</span>;
}
Address address = (Address) o;
<span class="code-keyword" style="color: #000091">if</span> ( street != <span class="code-keyword" style="color: #000091">null</span> ? !street.equals( address.street ) : address.street != <span class="code-keyword" style="color: #000091">null</span> ) {
<span class="code-keyword" style="color: #000091">return</span> <span class="code-keyword" style="color: #000091">false</span>;
}
<span class="code-keyword" style="color: #000091">if</span> ( city != <span class="code-keyword" style="color: #000091">null</span> ? !city.equals( address.city ) : address.city != <span class="code-keyword" style="color: #000091">null</span> ) {
<span class="code-keyword" style="color: #000091">return</span> <span class="code-keyword" style="color: #000091">false</span>;
}
<span class="code-keyword" style="color: #000091">return</span> <span class="code-keyword" style="color: #000091">true</span>;
}
@Override
<span class="code-keyword" style="color: #000091">public</span> <span class="code-object" style="color: #910091">int</span> hashCode() {
<span class="code-object" style="color: #910091">int</span> result;
result = ( street != <span class="code-keyword" style="color: #000091">null</span> ? street.hashCode() : 0 );
result = 31 * result + ( city != <span class="code-keyword" style="color: #000091">null</span> ? city.hashCode() : 0 );
<span class="code-keyword" style="color: #000091">return</span> result;
}
}
@Entity
@Indexed
<span class="code-keyword" style="color: #000091">public</span> class Person {
@EmbeddedId
@FieldBridge(impl = PersonPKBridge.class)
@DocumentId
<span class="code-keyword" style="color: #000091">private</span> PersonPK id;
<span class="code-keyword" style="color: #000091">private</span> <span class="code-object" style="color: #910091">String</span> favoriteColor;
@Embedded
<span class="code-keyword" style="color: #000091">private</span> Address address;
<span class="code-keyword" style="color: #000091">public</span> PersonPK getId() {
<span class="code-keyword" style="color: #000091">return</span> id;
}
<span class="code-keyword" style="color: #000091">public</span> void setId(PersonPK id) {
<span class="code-keyword" style="color: #000091">this</span>.id = id;
}
@Field
<span class="code-keyword" style="color: #000091">public</span> <span class="code-object" style="color: #910091">String</span> getFavoriteColor() {
<span class="code-keyword" style="color: #000091">return</span> favoriteColor;
}
<span class="code-keyword" style="color: #000091">public</span> void setFavoriteColor(<span class="code-object" style="color: #910091">String</span> favoriteColor) {
<span class="code-keyword" style="color: #000091">this</span>.favoriteColor = favoriteColor;
}
<span class="code-keyword" style="color: #000091">public</span> Address getAddress() {
<span class="code-keyword" style="color: #000091">return</span> address;
}
<span class="code-keyword" style="color: #000091">public</span> void setAddress(Address address) {
<span class="code-keyword" style="color: #000091">this</span>.address = address;
}
}
</pre>
</div>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/OGM-783#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-90afc403-ff89-48f2-9248-a4d7222487cc" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle" /> </a>
</td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/OGM-783#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #fff; border-top: 0; border-left: 1px solid #ccc; border-bottom: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly">
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px">
This message was sent by Atlassian JIRA <span id="footer-build-information">(v6.5-OD-03-002#65000-<span title="b8f65f822a3fd2ca02be441f51a3c335a581ff1e" data-commit-id="b8f65f822a3fd2ca02be441f51a3c335a581ff1e}">sha1:b8f65f8</span>)</span>
</td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-9eb9715f-8784-47af-bc83-8090a5d4dbb0" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix" />
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</body>
</html>