<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0" /> <base href="https://hibernate.atlassian.net" />
<title>Message Title</title>
</head>
<body class="jira" style="color: #333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<!-- header here -->
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px"> <img id="header-avatar-image" class="image_fix" src="https://secure.gravatar.com/avatar/57637a2eb871b34eba14e700c78c6a5d?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top" />
</td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="sanne" id="email_sanne" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=sanne" style="color:#6c797f;; color: #3b73af; text-decoration: none">Sanne Grinovero</a> <strong>commented</strong> on <a href="https://hibernate.atlassian.net/browse/HSEARCH-1880" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-static-bug-1fef1fce-0bdb-415f-928e-5724d34ecea2" height="16" width="16" border="0" align="absmiddle" alt="Bug" /> HSEARCH-1880</a>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 15px; background-color: #fff; border-left: 1px solid #ccc; border-top: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly">
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HSEARCH-1880" style="color: #3b73af; text-decoration: none">Re: Unresolved slot for Infinispan in hibernate-search-engine module</a> </span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff; border-bottom: none; padding-bottom: 0">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0">
<p style="margin: 10px 0 0 0">I'l record a chat here which contains our debate and explanation on why the integration slot shall not contain the Infinispan version but rather the pattern <b>for-hibernatesearch-5.3</b> - where 5.3 is the major.minor of the current search release.</p>
<blockquote style="margin: 10px 0 0 0; border-left: 1px solid #ccc; color: #707070; margin-left: 19px; padding: 10px 20px">
<p style="margin: 10px 0 0 0"><sannegrinovero> I'm trying to express that "twisted concept" of slot name which is then provided by a different project<br /> <sannegrinovero> ultimately the benefit would be that HS can build w/o having to define which Infinispan version will consume it<br /> <sannegrinovero> i.e. the slot encodes the HS version, not the Infinispan version.<br /> <gustavonalle> sannegrinovero, "for-hibernatesearch-5.3" slot name? shouldn't it be "ispn-8.0" ? <img class="emoticon" src="https://hibernate.atlassian.net/images/icons/emoticons/smile.gif" height="16" width="16" align="absmiddle" alt="" border="0" /> <br /> <sannegrinovero> Makes sense right? Since the Infinispan build will know which version of HS it targets<br /> <sannegrinovero> you remember what we discussed on EAP 6.4 depending on JDG 6.5 using slot "jdg-6.4" right?<br /> <gustavonalle> yes<br /> <gustavonalle> sannegrinovero, it let me think in a name<br /> <sannegrinovero> ok, so I'm trying to use a better readable name to make it understandable<br /> <sannegrinovero> also, consider@<br /> <sannegrinovero> - what if you decide to backport the upgrade to HS 5.3 to some other Infinispan 7.2 release<br /> <sannegrinovero> - what if you decide to stick to HS 5.3 in some other Infinispan release beyond 8.0<br /> <sannegrinovero> ..<br /> <sannegrinovero> so I don't want to encode the Infinispan target version in the HS module<br /> <sannegrinovero> which implies Infinispan will release a module <b>for</b> a specific HS version it's testing successfully with<br /> <sannegrinovero> hence the pattern "for-hibernatesearch-5.3"<br /> <gustavonalle> sannegrinovero, at the end of the day, what matters is if they are compatible or not<br /> <sannegrinovero> lol<br /> <sannegrinovero> I guess the answer would be "most of the combinations are not compatible" <img class="emoticon" src="https://hibernate.atlassian.net/images/icons/emoticons/wink.gif" height="16" width="16" align="absmiddle" alt="" border="0" /><br /> <gustavonalle> sannegrinovero, I don't know if 5.3 works with 8.0 tbh <img class="emoticon" src="https://hibernate.atlassian.net/images/icons/emoticons/smile.gif" height="16" width="16" align="absmiddle" alt="" border="0" /><br /> <sannegrinovero> no but this HS release doesn't make assumptions on that<br /> <sannegrinovero> it's more that Infinispan will <b>optionally</b> provide a module which will work with 5.3<br /> <sannegrinovero> or choose a different version..<br /> <sannegrinovero> gustavonalle: keep in mind we need this to break out of the circularity: I must be able to release HS w/o any assumption on which Infinispan version will use it.<br /> <gustavonalle> sannegrinovero, yes, but this "optionally" means certain versions of search will not have the ispn directory at all?<br /> <sannegrinovero> that's possible. Up to us to try have at least one version, but it's not something that the rules of physics will enforce.<br /> <sannegrinovero> I call it flexibility <img class="emoticon" src="https://hibernate.atlassian.net/images/icons/emoticons/smile.gif" height="16" width="16" align="absmiddle" alt="" border="0" /><br /> <gustavonalle> sannegrinovero, <img class="emoticon" src="https://hibernate.atlassian.net/images/icons/emoticons/smile.gif" height="16" width="16" align="absmiddle" alt="" border="0" /><br /> <sannegrinovero> gustavonalle: it's also possible for one Infinispan version to publish aliases to satisfy multiple versions of Search.<br /> <sannegrinovero> gustavonalle: with this approach, the benefit is that it's the project running the integration tests which tells if it's going to be compatible (or not) and to which versions it's testing (if more than one, optionally)<br /> <gustavonalle> sannegrinovero, let's give a try...<br /> <sannegrinovero> we don't do multiple versions now but that's going to be handy when testing on multiple, long term supported platforms <img class="emoticon" src="https://hibernate.atlassian.net/images/icons/emoticons/wink.gif" height="16" width="16" align="absmiddle" alt="" border="0" /><br /> <sannegrinovero> gustavonalle: ok so under this light, you like the name?<br /> <gustavonalle> sannegrinovero, alternative: ispn-hibernatesearch-5.3<br /> <sannegrinovero> well remember it's ispn publishing this under namespace org.infinispan<br /> <sannegrinovero> so ispn is a bit redundant (and not the official name)<br /> <sannegrinovero> so I like the "for-" prefix to explain/remind of all the above ^<br /> <gustavonalle> sannegrinovero, yes, the for create a nice natural language description of the module <br /> <gustavonalle> sannegrinovero, other idea "hibernatesearch-5.3-compat"<br /> <sannegrinovero> hum I think I would mistake it for some "compatibility module", like an adapter<br /> <gustavonalle> sannegrinovero, right<br /> <sannegrinovero> are you trying to find alternatives because you don't like the proposal?<br /> <gustavonalle> sannegrinovero, after understanding the motivation of it, your name makes sense, but my 1st reaction was weirdness <img class="emoticon" src="https://hibernate.atlassian.net/images/icons/emoticons/smile.gif" height="16" width="16" align="absmiddle" alt="" border="0" /><br /> <sannegrinovero> ok well that's fine <img class="emoticon" src="https://hibernate.atlassian.net/images/icons/emoticons/smile.gif" height="16" width="16" align="absmiddle" alt="" border="0" /> thanks I'll go with it then<br /> <gustavonalle> sannegrinovero, yeah, go for it, don't have any other better ideas</p>
</blockquote>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HSEARCH-1880#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-1a3a2c3d-23b1-4899-bc80-7e19576a76f0" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle" /> </a>
</td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HSEARCH-1880#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #fff; border-top: 0; border-left: 1px solid #ccc; border-bottom: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly">
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px">
This message was sent by Atlassian JIRA <span id="footer-build-information">(v6.5-OD-05-041#65001-<span title="e07c9f6ede7074bd21de4ab8b492355afe6390de" data-commit-id="e07c9f6ede7074bd21de4ab8b492355afe6390de}">sha1:e07c9f6</span>)</span>
</td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-5076dcbf-520f-418b-b16f-e3dbe692957f" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix" />
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</body>
</html>