<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0" /> <base href="https://hibernate.atlassian.net" />
<title>Message Title</title>
</head>
<body class="jira" style="color: #333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<!-- header here -->
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px"> <img id="header-avatar-image" class="image_fix" src="https://secure.gravatar.com/avatar/2a27de201092b6da61ad91629a8de43c?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top" />
</td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="alextunick" id="email_alextunick" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=alextunick" style="color:#6c797f;; color: #3b73af; text-decoration: none">Alex Tunick</a> <strong>commented</strong> on <a href="https://hibernate.atlassian.net/browse/HHH-9922" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-static-bug-f93b819e-6b7e-4ba4-bd09-ca3bfda82cb3" height="16" width="16" border="0" align="absmiddle" alt="Bug" /> HHH-9922</a>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 15px; background-color: #fff; border-left: 1px solid #ccc; border-top: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly">
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-9922" style="color: #3b73af; text-decoration: none">Re: hibernate.hbm2ddl.auto="validate" works incorrectly with Postgres 9.1 sequences</a> </span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff; border-bottom: none; padding-bottom: 0">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0">
<p style="margin: 10px 0 0 0">I had exactly the same issue while using <b>hibernate.globally_quoted_identifiers=true</b> with Postgres9.<br /> The workaround I have is to set <b>hibernate.globally_quoted_identifiers=false</b>.</p>
<p style="margin: 10px 0 0 0">If I understand it correctly the logic is next.</p>
<p style="margin: 10px 0 0 0">When <b>globally_quoted_identifiers</b> is set to <b>false</b> it runs <b>org.hibernate.tool.hbm2ddl.DatabaseMetadata.initSequences</b> method at line 169,<br /> then it runs into line 171 <b>String sql = dialect.getQuerySequencesString();</b> and returns query <b>select relname from pg_class where relkind='S'</b> which seems to be ok.<br /> Based on the results of that query it populates <b>sequences</b> object with the values at line 181 in a loop <b>sequences.add(rs.getString(1).toLowerCase(Locale.ROOT).trim());</b>.<br /> So <b>sequences</b> object is populated with values like <b>[ users_seq, roles_seq ]</b></p>
<p style="margin: 10px 0 0 0">Then it runs into <b>org.hibernate.cfg.Configuration.iterateGenerators</b> method at line 918.<br /> After that it runs into <b>org.hibernate.cfg.Configuration.generateSchemaUpdateScriptList</b> where the last step is to iterate through generators at line 1304.<br /> And here where the issue starts: condition <b>if ( !databaseMetadata.isSequence( key ) && !databaseMetadata.isTable( key ) )</b> does not work correctly in case of <b>hibernate.globally_quoted_identifiers=true</b> however it works fine for <b>hibernate.globally_quoted_identifiers=false</b>.<br /> The <b>key</b> value is <b>"app"."users_seq"</b> and <b>databaseMetadata.isSequence( key )</b> returns <b>false</b> while it has to return <b>true</b> like this would be without quotes - <b>databaseMetadata.isSequence( "app.users_seq" )</b> instead of <b>databaseMetadata.isSequence( "\"app\".\"users_seq\"" )</b>.<br /> As you can see the issue is with the quotes and may be related to another opened issue <a href="https://hibernate.atlassian.net/browse/HHH-8574" title="Postgres incorrectly quotes readback of sequence for IDENTITY IDs" class="issue-link" data-issue-key="HHH-8574" style="color: #3b73af; text-decoration: none">HHH-8574</a>.<br /> And it must not run into line 1309 since I already have the sequence with that name but it cannot be found due to quotes.</p>
<p style="margin: 10px 0 0 0">The query mentioned in description of this issue is related to <b>databaseMetadata.isTable</b> method invocation, that is why the query must not be fixed since it will break <b>isTable</b> method.<br /> So I believe the query is fine and it runs as a fallback because it could not find sequence due to quotes bug.</p>
<p style="margin: 10px 0 0 0">In case of <b>globally_quoted_identifiers</b> is set to <b>false</b> it is able to find all sequences and does not run the query you want to fix.</p>
<p style="margin: 10px 0 0 0">So in my opinion the fix has to be done inside <b>isSequence</b> method of <b>org.hibernate.tool.hbm2ddl.DatabaseMetadata</b> class.<br /> The logic of <b>isSequence</b> method has to be smart about quotes at lines 198 and 199:</p>
<div class="code panel" style="border-style: solid;border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeHeader panelHeader" style="border-bottom-width: 1px;border-bottom-style: solid;; border-bottom: 1px solid #ccc; padding: 9px 12px">
<b>org.hibernate.tool.hbm2ddl.DatabaseMetadata.java</b>
</div>
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<span class="code-object" style="color: #910091">String</span>[] strings = StringHelper.split(<span class="code-quote" style="color: #009100">"."</span>, (<span class="code-object" style="color: #910091">String</span>) key);
<span class="code-keyword" style="color: #000091">return</span> sequences.contains( strings[strings.length-1].toLowerCase(Locale.ROOT));
</pre>
</div>
</div>
<p style="margin: 10px 0 0 0">Since <b>hibernate.globally_quoted_identifiers=false</b> works for me as a solution for now I'm not going to make any code changes as for now.<br /> Anybody who needs quotes turned on please go ahead or you can wait for my contribution until I need it )))</p>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-9922#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-e01bcb3d-3584-4b1f-92c1-a23902a5b62d" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle" /> </a>
</td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-9922#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #fff; border-top: 0; border-left: 1px solid #ccc; border-bottom: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly">
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px">
This message was sent by Atlassian JIRA <span id="footer-build-information">(v6.5-OD-08-001#65007-<span title="1fc98468dfd18a5f35861f5c2ab67219b6b6f2f6" data-commit-id="1fc98468dfd18a5f35861f5c2ab67219b6b6f2f6}">sha1:1fc9846</span>)</span>
</td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-a501bfb8-ed74-4a90-a75d-ffe661a34d5a" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix" />
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</body>
</html>