<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0" /> <base href="https://hibernate.atlassian.net" />
<title>Message Title</title>
</head>
<body class="jira" style="color: #333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<!-- header here -->
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px"> <img id="header-avatar-image" class="image_fix" src="https://secure.gravatar.com/avatar/b7744bb64a641785a0448dda887e29f1?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top" />
</td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="mspiegel" id="email_mspiegel" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=mspiegel" style="color:#6c797f;; color: #3b73af; text-decoration: none">Markus</a> <strong>created</strong> an issue
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 15px; background-color: #fff; border-left: 1px solid #ccc; border-top: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly">
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class="page-title-pattern-first-line " style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://hibernate.atlassian.net/browse/HHH" style="color: #3b73af; text-decoration: none">Hibernate ORM</a> / <a href="https://hibernate.atlassian.net/browse/HHH-10027" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-static-bug-cd930fe6-5de0-45d7-b741-e90e5b04b10f" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom" /></a> <a href="https://hibernate.atlassian.net/browse/HHH-10027" style="color: #3b73af; text-decoration: none">HHH-10027</a>
</td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-10027" style="color: #3b73af; text-decoration: none">Dynamic filter parameter can be bound in wrong order when applied to OneToMany collections</a> </span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff; padding-top: 10px; padding-bottom: 5px">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Issue Type:
</th>
<td class="has-icon" style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <img src="cid:jira-generated-image-static-bug-cd930fe6-5de0-45d7-b741-e90e5b04b10f" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom" /> Bug
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Affects Versions:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top">
4.2.20
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Assignee:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top">
Unassigned
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Components:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top">
query-hql
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Created:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top">
09/Aug/2015 23:32 PM
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Priority:
</th>
<td class="has-icon" style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <img src="cid:jira-generated-image-static-blocker-9b2f8fd2-aa11-45a6-8394-7b0357ec7f17" height="16" width="16" border="0" align="absmiddle" alt="Blocker" style="vertical-align: text-bottom" /> Blocker
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Reporter:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="mspiegel" id="email_mspiegel" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=mspiegel" style="color:#6c797f;; color: #3b73af; text-decoration: none">Markus</a>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff; padding-top: 5px; padding-bottom: 10px">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0">
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">There is a problem with the parameter binding of dynamic filter parameters in case you use a dynamic filter definition on a OneToMany child collection. The order in which the parameters get bound does not necessarily match the order in which the query defined them.</p>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">I am quite new to this so I try to explain as best as I can.</p>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">I have a root entity with a filter definition for the deletion timestamp column, and I also apply this filter on its child entities for their deletion timestamp columns:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
@Entity
@Table( name = <span class="code-quote" style="color: #009100">"`ArticleRevision`"</span> )
@FilterDefs( { @FilterDef( name = <span class="code-quote" style="color: #009100">"aliveOnly"</span>, parameters = { @ParamDef( name = <span class="code-quote" style="color: #009100">"aliveTimestamp"</span>, type = <span class="code-quote" style="color: #009100">"timestamp"</span> ) }, defaultCondition = <span class="code-quote" style="color: #009100">"`DeletionTimestamp` = :aliveTimestamp"</span> ) } )
@Filters( { @Filter( name = <span class="code-quote" style="color: #009100">"aliveOnly"</span>, condition = <span class="code-quote" style="color: #009100">"`DeletionTimestamp` = :aliveTimestamp"</span> ) } )
<span class="code-keyword" style="color: #000091">public</span> class ArticleRevision
{
@Column( name = <span class="code-quote" style="color: #009100">"`ArticleID`"</span> )
<span class="code-keyword" style="color: #000091">private</span> <span class="code-object" style="color: #910091">Long</span> articleId = <span class="code-keyword" style="color: #000091">null</span>;
@Column( name = <span class="code-quote" style="color: #009100">"`DeletionTimestamp`"</span> )
<span class="code-keyword" style="color: #000091">protected</span> Timestamp deletionTimestamp;
@OneToMany( mappedBy = <span class="code-quote" style="color: #009100">"articleRevision"</span>, cascade = CascadeType.ALL, fetch = FetchType.LAZY )
@Filter( name = <span class="code-quote" style="color: #009100">"aliveOnly"</span> )
<span class="code-keyword" style="color: #000091">private</span> Set< ArticleTrading > articleTradings = <span class="code-keyword" style="color: #000091">new</span> HashSet< ArticleTrading >();
}
</pre>
</div>
</div>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">This is one of the child entites:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
@Entity
@Table( name = <span class="code-quote" style="color: #009100">"`ArticleTrading`"</span> )
<span class="code-keyword" style="color: #000091">public</span> class ArticleTrading
{
@ManyToOne( fetch = FetchType.LAZY )
@JoinColumn( name = <span class="code-quote" style="color: #009100">"`ArticleRevisionID`"</span>, nullable = <span class="code-keyword" style="color: #000091">false</span> )
<span class="code-keyword" style="color: #000091">private</span> ArticleRevision articleRevision = <span class="code-keyword" style="color: #000091">null</span>;
@Column( name = <span class="code-quote" style="color: #009100">"`PartyID`"</span> )
<span class="code-keyword" style="color: #000091">private</span> <span class="code-object" style="color: #910091">long</span> partyId = 0;
@Column( name = <span class="code-quote" style="color: #009100">"`Classifier`"</span> )
<span class="code-keyword" style="color: #000091">private</span> <span class="code-object" style="color: #910091">String</span> classifier = <span class="code-keyword" style="color: #000091">null</span>;
@Column( name = <span class="code-quote" style="color: #009100">"`DeletionTimestamp`"</span> )
<span class="code-keyword" style="color: #000091">protected</span> Timestamp deletionTimestamp;
}
</pre>
</div>
</div>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">Now if I enable the filter in the session:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
Filter enableFilter = session.enableFilter( <span class="code-quote" style="color: #009100">"aliveOnly"</span> );
enableFilter.setParameter( <span class="code-quote" style="color: #009100">"aliveTimestamp"</span>, Timestamp.valueOf( <span class="code-quote" style="color: #009100">"9999-12-31 00:00:00"</span> ) );
enableFilter.validate();
</pre>
</div>
</div>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">and execute the following query:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
select a_root.articleId
from ArticleRevision as a_root
left join a_root.articleTradings as al_0
with ( (al_0.partyId = :p_0) and (al_0.classifier = :p_1) )
</pre>
</div>
</div>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">the query will result in the following SQL:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
[SQL]
select
articlerev0_.<span class="code-quote" style="color: #009100">"ArticleID"</span> as col_0_0_
from
<span class="code-quote" style="color: #009100">"ArticleRevision"</span> articlerev0_
left <span class="code-keyword" style="color: #000091">outer</span> join
<span class="code-quote" style="color: #009100">"ArticleTrading"</span> articletra1_
on articlerev0_.<span class="code-quote" style="color: #009100">"ID"</span>=articletra1_.<span class="code-quote" style="color: #009100">"ArticleRevisionID"</span>
and articletra1_.<span class="code-quote" style="color: #009100">"DeletionTimestamp"</span> = ?
and (
articletra1_.<span class="code-quote" style="color: #009100">"PartyID"</span>=?
and articletra1_.<span class="code-quote" style="color: #009100">"Classifier"</span>=?
)
where
articlerev0_.<span class="code-quote" style="color: #009100">"DeletionTimestamp"</span> = ?
</pre>
</div>
</div>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">Now watch how the parameters get bound in the wrong order (the dynamic filter is parameter 3 although it should be 1):</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
[BasicBinder] binding parameter [1] as [BIGINT] - 1
[BasicBinder] binding parameter [2] as [VARCHAR] - Classifier
[BasicBinder] binding parameter [3] as [TIMESTAMP] - 9999-12-31 00:00:00.0
[BasicBinder] binding parameter [4] as [TIMESTAMP] - 9999-12-31 00:00:00.0
</pre>
</div>
</div>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">I have debugged the code and I found out that although method <b>JoinProcessor#processDynamicFilterParameters()</b> adds the dynamic filter parameters last to the current JOIN, the SQL statement generation happens in the opposite order in method <b>JoinSequence#toJoinFragment()</b> and puts it first:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<span class="code-keyword" style="color: #000091">for</span> ( Join join: joins ) {
<span class="code-object" style="color: #910091">String</span> on = join.getAssociationType().getOnCondition( join.getAlias(), factory, enabledFilters );
</pre>
</div>
</div>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">That is why I would suggest that the easiest bugfix for this is just putting the filter condition in the <b>JoinSequence#toJoinFragment()</b> method to the end as well:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<span class="code-keyword" style="color: #000091">for</span> ( Join join: joins ) {
<span class="code-object" style="color: #910091">String</span> condition = "";
<span class="code-keyword" style="color: #000091">if</span> ( withClauseFragment != <span class="code-keyword" style="color: #000091">null</span> && !isManyToManyRoot( join.joinable )) {
condition += <span class="code-quote" style="color: #009100">" and "</span> + withClauseFragment;
}
<span class="code-object" style="color: #910091">String</span> on = join.getAssociationType().getOnCondition( join.getAlias(), factory, enabledFilters );
<span class="code-keyword" style="color: #000091">if</span> ( last != <span class="code-keyword" style="color: #000091">null</span> &&
isManyToManyRoot( last ) &&
( ( QueryableCollection ) last ).getElementType() == join.getAssociationType() ) {
<span class="code-comment" style="color: #808080">// the current join represents the join between a many-to-many association table
</span> <span class="code-comment" style="color: #808080">// and its <span class="code-quote" style="color: #009100; color: #808080">"target"</span> table. Here we need to apply any additional filters
</span> <span class="code-comment" style="color: #808080">// defined specifically on the many-to-many
</span> <span class="code-object" style="color: #910091">String</span> manyToManyFilter = ( ( QueryableCollection ) last )
.getManyToManyFilterFragment( join.getAlias(), enabledFilters );
condition += "".equals( manyToManyFilter )
? on
: "".equals( on )
? manyToManyFilter
: on + <span class="code-quote" style="color: #009100">" and "</span> + manyToManyFilter;
}
<span class="code-keyword" style="color: #000091">else</span> {
condition += on;
}
joinFragment.addJoin(
join.getJoinable().getTableName(),
join.getAlias(),
join.getLHSColumns(),
JoinHelper.getRHSColumnNames( join.getAssociationType(), factory ),
join.joinType,
condition
);
<span class="code-keyword" style="color: #000091">if</span> (includeExtraJoins) { <span class="code-comment" style="color: #808080">//TODO: not quite sure about the full implications of <span class="code-keyword" style="color: #000091; color: #808080">this</span>!
</span> addExtraJoins( joinFragment, join.getAlias(), join.getJoinable(), join.joinType == JoinType.INNER_JOIN );
}
last = join.getJoinable();
}
</pre>
</div>
</div>
<p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0 0">This is a blocker because there is no workaround for that case.</p>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-10027#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-dd0e686a-31f7-497f-98bb-173073430b4a" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle" /> </a>
</td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-10027#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #fff; border-top: 0; border-left: 1px solid #ccc; border-bottom: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly">
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px">
This message was sent by Atlassian JIRA <span id="footer-build-information">(v6.5-OD-08-001#65007-<span title="1fc98468dfd18a5f35861f5c2ab67219b6b6f2f6" data-commit-id="1fc98468dfd18a5f35861f5c2ab67219b6b6f2f6}">sha1:1fc9846</span>)</span>
</td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-c1a122d3-1baa-4e54-9e4f-c0f0cf900681" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix" />
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</body>
</html>