<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0" /> <base href="https://hibernate.atlassian.net" />
<title>Message Title</title>
</head>
<body class="jira" style="color: #333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<!-- header here -->
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px"> <img id="header-avatar-image" class="image_fix" src="https://secure.gravatar.com/avatar/c32c4103dacf291cdfa0439e34f2c07e?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top" />
</td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="gbadner" id="email_gbadner" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=gbadner" style="color:#6c797f;; color: #3b73af; text-decoration: none">Gail Badner</a> <strong>updated</strong> an issue
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 15px; background-color: #fff; border-left: 1px solid #ccc; border-top: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly">
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class="page-title-pattern-first-line " style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://hibernate.atlassian.net/browse/HHH" style="color: #3b73af; text-decoration: none">Hibernate ORM</a> / <a href="https://hibernate.atlassian.net/browse/HHH-9979" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-77baf7ac-eb8a-4fe0-a92f-73609c9c69ea" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom" /></a> <a href="https://hibernate.atlassian.net/browse/HHH-9979" style="color: #3b73af; text-decoration: none">HHH-9979</a>
</td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-9979" style="color: #3b73af; text-decoration: none">Merged transient entity may not contain some associations when passed to PrePersist/PostPersist callbacks </a> </span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff; padding-top: 10px; padding-bottom: 5px">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Change By:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="gbadner" id="email_gbadner" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=gbadner" style="color:#6c797f;; color: #3b73af; text-decoration: none">Gail Badner</a>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff; padding-top: 5px; padding-bottom: 10px">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0"> <span class="diffcontext">This can happen when merging an entity has a "post-insert" ID that requires an insert to obtain the ID (e.g., identity ID).<br /><br />Currently, when a transient entity with a post-insert ID is merged:<br />1) a new entity is instantiated;<br />2)</span> <span class="diffaddedchars" style="background-color:#ddfade;"> merge operation is cascaded to associations with {{AssociationType.getForeignKeyDirection() == ForeignKeyDirection#FROM_PARENT}}<br />3)</span> <span class="diffcontext"> basic properties and associations with {{AssociationType.getForeignKeyDirection() == ForeignKeyDirection#FROM_PARENT}} are copied to the new entity;<br /></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">3</span> <span class="diffaddedchars" style="background-color:#ddfade;">4</span> <span class="diffcontext">) all inserts in the ActionQueue are executed</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">;</span> <span class="diffcontext"><br /></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">4</span> <span class="diffaddedchars" style="background-color:#ddfade;">5</span> <span class="diffcontext">) PrePersist</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> callback is</span> <span class="diffaddedchars" style="background-color:#ddfade;"> callbacks are</span> <span class="diffcontext"> called</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> prior to inserting</span> <span class="diffaddedchars" style="background-color:#ddfade;"> with</span> <span class="diffcontext"> the new entity</span> <span class="diffaddedchars" style="background-color:#ddfade;"> as argument</span> <span class="diffcontext">;</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> <br /></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br />6)</span> <span class="diffcontext">the new entity is inserted</span> <span class="diffaddedchars" style="background-color:#ddfade;">.</span> <span class="diffcontext"><br /></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">4</span> <span class="diffaddedchars" style="background-color:#ddfade;">7</span> <span class="diffcontext">)</span> <span class="diffaddedchars" style="background-color:#ddfade;"> PostPersist callbacks are called with the new entity as argument;<br />8) merge is cascaded to</span> <span class="diffcontext"> associations with {{AssociationType.getForeignKeyDirection() == ForeignKeyDirection#TO_PARENT}}</span> <span class="diffaddedchars" style="background-color:#ddfade;">;<br />9) associations with {{AssociationType.getForeignKeyDirection() == ForeignKeyDirection#TO_PARENT}}</span> <span class="diffcontext"> are copied to the new entity.</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> <br /></span> <span class="diffcontext"><br /></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">If</span> <span class="diffaddedchars" style="background-color:#ddfade;"><br />In 5) and 7),</span> <span class="diffcontext"> the</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> <br /></span> <span class="diffaddedchars" style="background-color:#ddfade;"> entity passed to PrePersist/PostPersist callbacks do not have all associations copied yet. The values for the uncopied properties will be as set by the no-arg constructor used to instantiate the entity.</span> <span class="diffcontext"><br /><br /></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">Because Validator</span> <span class="diffaddedchars" style="background-color:#ddfade;">Other transient entities still in the process of being merged that have inserts in the ActionQueue will be affected in the same way, even if they do not have post-insert IDs. This</span> <span class="diffcontext"> is</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> a PrePersist Merge operation throws a ConstraintValidationException on</span> <span class="diffaddedchars" style="background-color:#ddfade;"> because "</span> <span class="diffcontext"> non-</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">empty list marked as</span> <span class="diffaddedchars" style="background-color:#ddfade;">owned" associations will not be copied to these entities</span> <span class="diffcontext"> when</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> using</span> <span class="diffaddedchars" style="background-color:#ddfade;"> the insert action is executed due to 4)..<br /><br />An example where this is a problem is when merging a transient entity with a</span> <span class="diffcontext"> @OneToMany</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> &</span> <span class="diffcontext"> @NotNull</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> <br /></span> <span class="diffaddedchars" style="background-color:#ddfade;"> on a collection. If the collection is not initialized when the entity is instantiated, the PrePersist callback to Validator will throws a ConstraintValidationException. This is because the collection in the entity passed to {{Session#merge}} has not been copied to the newly instantiated entity yet (this is done at step 9)). As a result,</span> <span class="diffcontext">"null" is always passed to the validator during a merge operation</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">, even when the collection is non-empty, causing this operation to fail with C</span> <span class="diffcontext">.</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">V.E.</span> <span class="diffaddedchars" style="background-color:#ddfade;"> <br /></span> <span class="diffcontext"><br /></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"><br /></span> <span class="diffcontext">For more details see: https://bugzilla.redhat.com/show_bug.cgi?id=1245082</span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-9979#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-81a54e89-c4bb-4399-b075-5dcaf2aee69f" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle" /> </a>
</td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-9979#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #fff; border-top: 0; border-left: 1px solid #ccc; border-bottom: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly">
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px">
This message was sent by Atlassian JIRA <span id="footer-build-information">(v7.0.0-OD-02-259#70102-<span title="6147844ca4f0fe2eb2b7ae6af1e7bdb8d38cf75d" data-commit-id="6147844ca4f0fe2eb2b7ae6af1e7bdb8d38cf75d}">sha1:6147844</span>)</span>
</td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-f6ade8a0-97f3-41ab-8814-398859eae391" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix" />
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</body>
</html>