<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0" /> <base href="https://hibernate.atlassian.net" />
<title>Message Title</title>
</head>
<body class="jira" style="color: #333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<!-- header here -->
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px"> <img id="header-avatar-image" class="image_fix" src="cid:jira-generated-image-avatar-bae27543-f7a6-463d-aa15-242215064b32" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top" />
</td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="donsenior" id="email_donsenior" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=donsenior" style="color:#6c797f;; color: #3b73af; text-decoration: none">Pablo Lascano</a> <strong>commented</strong> on <a href="https://hibernate.atlassian.net/browse/HV-1028" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-dbac084f-297f-41db-a041-a2139cdf91b3" height="16" width="16" border="0" align="absmiddle" alt="Bug" /> HV-1028</a>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 15px; background-color: #fff; border-left: 1px solid #ccc; border-top: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly">
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HV-1028" style="color: #3b73af; text-decoration: none">Re: Parameters validation works randomly on Weblogic EJB</a> </span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff; border-bottom: none; padding-bottom: 0">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0">
<p style="margin: 10px 0 0 0">Hello @hardy, first I want to apologize for my bad English! </p>
<p style="margin: 10px 0 0 0">I've attached a fully deployable webapp as test case, that includes an ejb (<b>TestBean</b>) that implements a very simple interface (<b>Test</b>) that has constraints. I don't know if that is what you mean ass relevant code...?</p>
<p style="margin: 10px 0 0 0">"It works randomly" means, per request while in the same JVM, using a different ValidatorFactory for each request, sometimes the validation works, this is, for a value that does not meet the constraints, sometimes it returns the errors correctly and sometimes it doesn't return errors. Also it fails more than not (<b>fails means, does not return errors</b>). No exceptions, no warnings. Caching the ValidatorFactory causes that if it works once it continue working, or if it fails, it continue failing. </p>
<p style="margin: 10px 0 0 0">Original classes:</p>
<div class="code panel" style="border-style: solid;border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeHeader panelHeader" style="border-bottom-width: 1px;border-bottom-style: solid;; border-bottom: 1px solid #ccc; padding: 9px 12px">
<b>TestBean.java</b>
</div>
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<span class="code-keyword" style="color: #000091">package</span> bval.ejb;
<span class="code-keyword" style="color: #000091">import</span> javax.ejb.Stateless;
<span class="code-keyword" style="color: #000091">import</span> javax.interceptor.Interceptors;
<span class="code-keyword" style="color: #000091">import</span> bval.interceptor.ValidateParameters;
@Stateless
<span class="code-keyword" style="color: #000091">public</span> class TestBean <span class="code-keyword" style="color: #000091">implements</span> Test {
@Override
@Interceptors(ValidateParameters.class)
<span class="code-keyword" style="color: #000091">public</span> <span class="code-object" style="color: #910091">String</span> validate(<span class="code-object" style="color: #910091">String</span> param) {
<span class="code-keyword" style="color: #000091">return</span> <span class="code-quote" style="color: #009100">"OK"</span>;
}
}
</pre>
</div>
</div>
<div class="code panel" style="border-style: solid;border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeHeader panelHeader" style="border-bottom-width: 1px;border-bottom-style: solid;; border-bottom: 1px solid #ccc; padding: 9px 12px">
<b>Test.java</b>
</div>
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<span class="code-keyword" style="color: #000091">package</span> bval.ejb;
<span class="code-keyword" style="color: #000091">import</span> javax.ejb.Local;
<span class="code-keyword" style="color: #000091">import</span> javax.validation.constraints.Size;
<span class="code-keyword" style="color: #000091">import</span> org.hibernate.validator.constraints.NotBlank;
@Local
<span class="code-keyword" style="color: #000091">public</span> <span class="code-keyword" style="color: #000091">interface</span> Test {
<span class="code-object" style="color: #910091">String</span> validate(@NotBlank @Size(max = 2) <span class="code-object" style="color: #910091">String</span> param);
}
</pre>
</div>
</div>
<div class="code panel" style="border-style: solid;border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeHeader panelHeader" style="border-bottom-width: 1px;border-bottom-style: solid;; border-bottom: 1px solid #ccc; padding: 9px 12px">
<b>ValidateParameters.java</b>
</div>
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<span class="code-keyword" style="color: #000091">package</span> bval.interceptor;
<span class="code-keyword" style="color: #000091">import</span> java.util.Set;
<span class="code-keyword" style="color: #000091">import</span> javax.interceptor.AroundInvoke;
<span class="code-keyword" style="color: #000091">import</span> javax.interceptor.InvocationContext;
<span class="code-keyword" style="color: #000091">import</span> javax.validation.ConstraintViolation;
<span class="code-keyword" style="color: #000091">import</span> javax.validation.Validation;
<span class="code-keyword" style="color: #000091">import</span> javax.validation.executable.ExecutableValidator;
<span class="code-keyword" style="color: #000091">public</span> class ValidateParameters {
@AroundInvoke
<span class="code-keyword" style="color: #000091">public</span> <span class="code-object" style="color: #910091">Object</span> checkArguments(InvocationContext context) <span class="code-keyword" style="color: #000091">throws</span> Exception {
validateParameters(context);
<span class="code-keyword" style="color: #000091">return</span> context.proceed();
}
<span class="code-keyword" style="color: #000091">private</span> void validateParameters(InvocationContext context) <span class="code-keyword" style="color: #000091">throws</span> Exception {
ExecutableValidator executableValidator = Validation.buildDefaultValidatorFactory().getValidator().forExecutables();
Set<ConstraintViolation<<span class="code-object" style="color: #910091">Object</span>>> errors = executableValidator.validateParameters(
context.getTarget(),
context.getMethod(),
context.getParameters());
<span class="code-keyword" style="color: #000091">if</span> (!errors.isEmpty()) {
<span class="code-keyword" style="color: #000091">throw</span> <span class="code-keyword" style="color: #000091">new</span> IllegalArgumentException();
}
}
}
</pre>
</div>
</div>
<p style="margin: 10px 0 0 0">I suspect the problem is in <tt>AnnotationMetaDataProvider</tt> and the enhanced interfaces that weblogic creates:</p>
<div class="code panel" style="border-style: solid;border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeHeader panelHeader" style="border-bottom-width: 1px;border-bottom-style: solid;; border-bottom: 1px solid #ccc; padding: 9px 12px">
<b>TestBean_hpp1x8_Impl.java</b>
</div>
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<span class="code-keyword" style="color: #000091">package</span> bval.ejb;
<span class="code-keyword" style="color: #000091">import</span> javax.ejb.EJBContext;
<span class="code-keyword" style="color: #000091">import</span> weblogic.ejb.container.interfaces.WLEnterpriseBean;
<span class="code-comment" style="color: #808080">// Referenced classes of <span class="code-keyword" style="color: #000091; color: #808080">package</span> bval.ejb:
</span><span class="code-comment" style="color: #808080">// TestBean, TestBean_hpp1x8_Intf
</span>
<span class="code-keyword" style="color: #000091">public</span> class TestBean_hpp1x8_Impl <span class="code-keyword" style="color: #000091">extends</span> TestBean
<span class="code-keyword" style="color: #000091">implements</span> TestBean_hpp1x8_Intf, WLEnterpriseBean
{
<span class="code-keyword" style="color: #000091">public</span> TestBean_hpp1x8_Impl()
{
}
<span class="code-keyword" style="color: #000091">public</span> <span class="code-object" style="color: #910091">int</span> __WL_getMethodState()
{
<span class="code-keyword" style="color: #000091">return</span> __WL_method_state;
}
<span class="code-keyword" style="color: #000091">public</span> void __WL_setMethodState(<span class="code-object" style="color: #910091">int</span> i)
{
__WL_method_state = i;
}
<span class="code-keyword" style="color: #000091">public</span> EJBContext __WL_getEJBContext()
{
<span class="code-keyword" style="color: #000091">return</span> __WL_EJBContext;
}
<span class="code-keyword" style="color: #000091">public</span> void __WL_setEJBContext(EJBContext ejbcontext)
{
__WL_EJBContext = ejbcontext;
}
<span class="code-keyword" style="color: #000091">private</span> <span class="code-object" style="color: #910091">int</span> __WL_method_state;
<span class="code-keyword" style="color: #000091">private</span> EJBContext __WL_EJBContext;
}
</pre>
</div>
</div>
<div class="code panel" style="border-style: solid;border-width: 1px;; border: 1px solid #ccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeHeader panelHeader" style="border-bottom-width: 1px;border-bottom-style: solid;; border-bottom: 1px solid #ccc; padding: 9px 12px">
<b>TestBean_hpp1x8_Intf.java</b>
</div>
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<span class="code-keyword" style="color: #000091">package</span> bval.ejb;
<span class="code-keyword" style="color: #000091">import</span> weblogic.ejb.container.interfaces.WLEnterpriseBean;
<span class="code-keyword" style="color: #000091">public</span> <span class="code-keyword" style="color: #000091">interface</span> TestBean_hpp1x8_Intf
<span class="code-keyword" style="color: #000091">extends</span> WLEnterpriseBean
{
<span class="code-keyword" style="color: #000091">public</span> <span class="code-keyword" style="color: #000091">abstract</span> <span class="code-object" style="color: #910091">String</span> validate(<span class="code-object" style="color: #910091">String</span> s);
}
</pre>
</div>
</div>
<p style="margin: 10px 0 0 0">I think, depending on the order that *AnnotationMetaDataProvider *gets the metadata into the bean configuration, the validator gets the original constraints or not. This is just an speculation, as I have not fully understand how validation works.</p>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HV-1028#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-2271de5c-729b-466d-8668-b54dbf8f1238" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle" /> </a>
</td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HV-1028#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #fff; border-top: 0; border-left: 1px solid #ccc; border-bottom: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly">
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px">
This message was sent by Atlassian JIRA <span id="footer-build-information">(v7.0.0-OD-08-005#70107-<span title="5fb2f7e0c016d05ff672e1e32fcd963de6cf92ae" data-commit-id="5fb2f7e0c016d05ff672e1e32fcd963de6cf92ae}">sha1:5fb2f7e</span>)</span>
</td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-da9d64a8-d836-4a64-9bfb-8a2a6f44422a" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix" />
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</body>
</html>