<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0" /> <base href="https://hibernate.atlassian.net" />
<title>Message Title</title>
</head>
<body class="jira" style="color: #333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<!-- header here -->
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px"> <img id="header-avatar-image" class="image_fix" src="https://secure.gravatar.com/avatar/c5421d46af1828a345e42c6bad54ae01?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top" />
</td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="jmax01" id="email_jmax01" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=jmax01" style="color:#6c797f;; color: #3b73af; text-decoration: none">Jeff Maxwell</a> <strong>updated</strong> an issue
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 15px; background-color: #fff; border-left: 1px solid #ccc; border-top: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly">
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class="page-title-pattern-first-line " style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://hibernate.atlassian.net/browse/HV" style="color: #3b73af; text-decoration: none">Hibernate Validator</a> / <a href="https://hibernate.atlassian.net/browse/HV-1031" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-a08c672c-7d09-4310-b554-cf653e0d80e5" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom" /></a> <a href="https://hibernate.atlassian.net/browse/HV-1031" style="color: #3b73af; text-decoration: none">HV-1031</a>
</td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HV-1031" style="color: #3b73af; text-decoration: none">Type parameter validations are not executed against all elements in a collection if elements contain the same object instance.</a> </span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff; border-bottom: none; padding-bottom: 0">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0">
<p style="margin: 10px 0 0 0">Updated with List<String> example.</p>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff; padding-top: 10px; padding-bottom: 5px">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Change By:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="jmax01" id="email_jmax01" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=jmax01" style="color:#6c797f;; color: #3b73af; text-decoration: none">Jeff Maxwell</a>
</td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">
Summary:
</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <span class="diffcontext">Type parameter validations are not executed against all</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> entries</span> <span class="diffaddedchars" style="background-color:#ddfade;"> elements</span> <span class="diffcontext"> in a</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> map</span> <span class="diffaddedchars" style="background-color:#ddfade;"> collection</span> <span class="diffcontext"> if</span> <span class="diffaddedchars" style="background-color:#ddfade;"> elements contain</span> <span class="diffcontext"> the</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> value is the</span> <span class="diffcontext"> same</span> <span class="diffaddedchars" style="background-color:#ddfade;"> object</span> <span class="diffcontext"> instance</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> across entries</span> <span class="diffcontext">.</span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff; padding-top: 5px; padding-bottom: 10px">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0"> <span class="diffcontext">Type parameter validations are not executed against all</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> entries</span> <span class="diffaddedchars" style="background-color:#ddfade;"> elements</span> <span class="diffcontext"> in a</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> map</span> <span class="diffaddedchars" style="background-color:#ddfade;"> collection</span> <span class="diffcontext"> if</span> <span class="diffaddedchars" style="background-color:#ddfade;"> elements contain</span> <span class="diffcontext"> the</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> value is the</span> <span class="diffcontext"> same</span> <span class="diffaddedchars" style="background-color:#ddfade;"> object</span> <span class="diffcontext"> instance</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> across entries</span> <span class="diffcontext">.<br /><br />{code:java}<br /> /** The Constant VALIDATOR_FACTORY. */<br /> static final ValidatorFactory VALIDATOR_FACTORY = Validation.byDefaultProvider()<br /> .configure()<br /> .buildValidatorFactory();<br /><br /> /** The Constant VALIDATOR. */<br /> static final Validator VALIDATOR = VALIDATOR_FACTORY.getValidator();<br /><br /> public static class WithMap {<br /><br /> @Valid<br /> final private Map<String, @Size(min = 1) List<String>> lists;<br /><br /> public WithMap(Map<String, List<String>> lists) {<br /> super();<br /> this.lists = lists;<br /> }<br /><br /> public Map<String, List<String>> getLists() {<br /> return this.lists;<br /> }<br /><br /> }<br /><br /> /**<br /> * Test fails as it does not consider the property path when checking if already validated.<br /> */<br /> @Test<br /> public void</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> testSameInstance</span> <span class="diffaddedchars" style="background-color:#ddfade;"> testMapSameInstance</span> <span class="diffcontext">() {<br /><br /> List<String> emptyList = new ArrayList<>();<br /><br /> String[] stringArray = { "A" };<br /><br /> List<String> populatedList = Arrays.asList(stringArray);<br /><br /> HashMap<String, List<String>> map = new HashMap<>();<br /> map.put("POPULATED", populatedList);<br /> map.put("EMPTY_LIST1", emptyList);<br /> map.put("EMPTY_LIST2", emptyList);<br /><br /> WithMap withMap = new WithMap(map);<br /><br /> Set<ConstraintViolation<WithMap>> constraintViolations = VALIDATOR.validate(withMap);<br /><br /> // java.lang.AssertionError: expected:<2> but was:<1><br /> assertEquals(2, constraintViolations.size());<br /> }<br /><br /> /**<br /> * Test passes since the lists are different instances.<br /> */<br /> @Test<br /> public void</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> testDifferentInstance</span> <span class="diffaddedchars" style="background-color:#ddfade;"> testMapDifferentInstance</span> <span class="diffcontext">() {<br /><br /> String[] stringArray = { "A" };<br /><br /> List<String> populatedList = Arrays.asList(stringArray);<br /><br /> HashMap<String, List<String>> map = new HashMap<>();<br /> map.put("POPULATED", populatedList);<br /> map.put("EMPTY_LIST1", new ArrayList<>());<br /> map.put("EMPTY_LIST2", new ArrayList<>());<br /><br /> WithMap withMap = new WithMap(map);<br /><br /> Set<ConstraintViolation<WithMap>> constraintViolations = VALIDATOR.validate(withMap);<br /><br /> // Passes<br /> assertEquals(2, constraintViolations.size());<br /> }<br /><br /></span> <span class="diffaddedchars" style="background-color:#ddfade;"> public static class WithList</span> <span class="diffcontext">{</span> <span class="diffaddedchars" style="background-color:#ddfade;"><br /><br /> @Valid<br /> final private List<@Size(min = 1) String> list;<br /><br /> public WithList(List<String> list) {<br /> super();<br /> this.list = list;<br /> }<br /><br /> public List<String> getLists() {<br /> return this.list;<br /> }<br /><br /> }<br /><br /> /**<br /> * Test fails as it does not consider the property path when checking if already validated.<br /> */<br /> @Test<br /> public void testListSameInstance() {<br /><br /> String[] stringArray = { "", "A", "" };<br /><br /> List<String> populatedList = Arrays.asList(stringArray);<br /><br /> WithList withList = new WithList(populatedList);<br /><br /> Set<ConstraintViolation<WithList>> constraintViolations = VALIDATOR.validate(withList);<br /><br /> // java.lang.AssertionError: expected:<2> but was:<1><br /> assertEquals(2, constraintViolations.size());<br /> }<br /><br /> /**<br /> * Test passes since the lists are different instances.<br /> */<br /> @Test<br /> public void testListDifferentInstance() {<br /><br /> String[] stringArray = { new String(""), "A", new String("") };<br /><br /> List<String> populatedList = Arrays.asList(stringArray);<br /><br /> WithList withList = new WithList(populatedList);<br /><br /> Set<ConstraintViolation<WithList>> constraintViolations = VALIDATOR.validate(withList);<br /><br /> assertEquals(2, constraintViolations.size());<br /> }<br /><br />{</span> <span class="diffcontext">code}<br /></span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HV-1031#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-1d241a22-6d7f-43ac-a147-088bcd9154a6" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle" /> </a>
</td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HV-1031#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #fff; border-top: 0; border-left: 1px solid #ccc; border-bottom: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly">
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px">
This message was sent by Atlassian JIRA <span id="footer-build-information">(v7.0.0-OD-08-005#70107-<span title="5fb2f7e0c016d05ff672e1e32fcd963de6cf92ae" data-commit-id="5fb2f7e0c016d05ff672e1e32fcd963de6cf92ae}">sha1:5fb2f7e</span>)</span>
</td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-6aacb07a-5f3d-45ed-9d8e-9a81c383f036" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix" />
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</body>
</html>