<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="cid:jira-generated-image-avatar-91e213fa-8ba1-4d25-826b-acd22e5b8362" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="michael.simons" id="email_michael.simons" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=michael.simons" style="color:#6c797f;; color: #3b73af; text-decoration: none">Michael Simons</a> <strong>commented</strong> on <a href="https://hibernate.atlassian.net/browse/HHH-8632" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-d93a80bb-6419-4d1e-913d-466f2594d192" height="16" width="16" border="0" align="absmiddle" alt="Bug"> HHH-8632</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-8632" style="color: #3b73af; text-decoration: none">Re: CriteriaBuilder#concat(Expression<String>, Expression<String>) produces wrong SQL expressions</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; border-bottom: none; padding-bottom: 0" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0"> <p style="margin: 10px 0 0 0; margin-top: 0"> <span class="nobr"><a href="https://hibernate.atlassian.net/secure/attachment/30743/30743_HHH-8632-4.zip" title="HHH-8632-4.zip attached to HHH-8632" style="color: #3b73af; text-decoration: none">HHH-8632-4.zip<sup><img class="rendericon" src="cid:jira-generated-image-static-link_attachment_7-5219fc62-44d9-4d85-9808-a30be76a614b" height="7" width="7" align="absmiddle" alt="" border="0"></sup></a></span> <span class="nobr"><a href="https://hibernate.atlassian.net/secure/attachment/30744/30744_HHH-8632-5.zip" title="HHH-8632-5.zip attached to HHH-8632" style="color: #3b73af; text-decoration: none">HHH-8632-5.zip<sup><img class="rendericon" src="cid:jira-generated-image-static-link_attachment_7-5219fc62-44d9-4d85-9808-a30be76a614b" height="7" width="7" align="absmiddle" alt="" border="0"></sup></a></span> Hello,</p> <p style="margin: 10px 0 0 0">first of all, let me please apologize for the bad report. Not only was a real test case missing, the fragment i've posted is wrong also.</p> <p style="margin: 10px 0 0 0">Nevertheless, the problem is still there.</p> <p style="margin: 10px 0 0 0">Thanks to @mih_vlad it's pretty easy now to provide JPA test cases. Attached are test cases for both 4.3.11 and 5.0.7</p> <p style="margin: 10px 0 0 0">What i want: Query a person on their full name. The full name is defined as "name, firstname" if there is a non-null first name, otherwise "name". Also, the person with id 0 is a special, not used instance.</p> <p style="margin: 10px 0 0 0">It's pretty easy to do this in SQL:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-sql" style="margin: 10px 0 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<span class="code-keyword" style="color: #000091">select</span> count(m.id) as col_0_0_
<span class="code-keyword" style="color: #000091">from</span> marktteilnehmer m
<span class="code-keyword" style="color: #000091">where</span> decode(m.id, 0, null, m.name||decode(m.vorname,null, null, ', ' ||m.vorname)) like '%'
</pre>
</div>
</div> <p style="margin: 10px 0 0 0">and not to hard using the criteria API:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<span class="code-keyword" style="color: #000091">final</span> CriteriaBuilder criteriaBuilder = entityManager.getCriteriaBuilder();
<span class="code-keyword" style="color: #000091">final</span> CriteriaQuery<<span class="code-object" style="color: #910091">Long</span>> query = criteriaBuilder.createQuery(<span class="code-object" style="color: #910091">Long</span>.class);
<span class="code-keyword" style="color: #000091">final</span> Root<Marktteilnehmer> root = query.from(Marktteilnehmer.class);
<span class="code-keyword" style="color: #000091">final</span> Expression<<span class="code-object" style="color: #910091">String</span>> nameAndVorname = criteriaBuilder.function(
<span class="code-quote" style="color: #009100">"decode"</span>, <span class="code-object" style="color: #910091">String</span>.class,
root.get(<span class="code-quote" style="color: #009100">"id"</span>),
criteriaBuilder.literal(0l),
criteriaBuilder.nullLiteral(<span class="code-object" style="color: #910091">String</span>.class),
criteriaBuilder.concat(
root.<<span class="code-object" style="color: #910091">String</span>>get(<span class="code-quote" style="color: #009100">"name"</span>),
criteriaBuilder.function(<span class="code-quote" style="color: #009100">"decode"</span>, <span class="code-object" style="color: #910091">String</span>.class,
root.get(<span class="code-quote" style="color: #009100">"vorname"</span>),
criteriaBuilder.nullLiteral(<span class="code-object" style="color: #910091">String</span>.class),
criteriaBuilder.nullLiteral(<span class="code-object" style="color: #910091">String</span>.class),
criteriaBuilder.concat(
criteriaBuilder.literal(<span class="code-quote" style="color: #009100">", "</span>),
root.<<span class="code-object" style="color: #910091">String</span>>get(<span class="code-quote" style="color: #009100">"vorname"</span>)
)
)
)
);
<span class="code-object" style="color: #910091">long</span> cnt = entityManager.createQuery(
query.select(criteriaBuilder.count(root)).where(criteriaBuilder.like(nameAndVorname, <span class="code-quote" style="color: #009100">"%"</span>))
).getSingleResult();
</pre>
</div>
</div> <p style="margin: 10px 0 0 0">The generated sql looks like this:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-sql" style="margin: 10px 0 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<span class="code-keyword" style="color: #000091">select</span> count(marktteiln0_.id) as col_0_0_
<span class="code-keyword" style="color: #000091">from</span> marktteilnehmer marktteiln0_
<span class="code-keyword" style="color: #000091">where</span> decode(marktteiln0_.id, 0, null, marktteiln0_.name||decode(marktteiln0_.vorname||null||null||?||marktteiln0_.vorname)) like ?
</pre>
</div>
</div> <p style="margin: 10px 0 0 0">which is pretty obvious wrong.</p> <p style="margin: 10px 0 0 0">To use the test cases:</p>
<ul>
<li>You'll need an Oracle (10g or 11g) database with the scott/tiger schema</li>
<li>Eventually fix the coordinates of the JDBC driver in pom.xml, i used com.oracle:ojdbc6, as far as i know Oracles JDBC driver still isn't in maven.org</li>
<li>Replace the line 19 in persistence.xml with your host and sid (<property name="hibernate.connection.url" value="jdbc:oracle:thin:@host:1521:sid"/>)</li>
</ul> <p style="margin: 10px 0 0 0">I would write it down as a native query, but it's part of a bigger system where a lot of generated queries are used for dynamically fetching stuff.</p> <p style="margin: 10px 0 0 0">Thanks a lot for looking at it!</p> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-8632#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-703880f5-932e-40cf-bbb7-83657cf25cfa" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-8632#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian JIRA <span id="footer-build-information">(v7.1.0-OD-04-012#71001-<span title="dd0493d72352e1a51e29faeaa551e16c27e40a01" data-commit-id="dd0493d72352e1a51e29faeaa551e16c27e40a01}">sha1:dd0493d</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-8c62be1d-09f8-4e63-9c56-98e3ef27e78b" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>