<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="cid:jira-generated-image-avatar-f6be661d-b17e-4560-b71e-9472bd7add21" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="Madhusudana Reddy Sunnapu" id="email_Madhusudana Reddy Sunnapu" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=Madhusudana+Reddy+Sunnapu" style="color:#6c797f;; color: #3b73af; text-decoration: none">Madhusudana Reddy Sunnapu</a> <strong>updated</strong> an issue </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td class="page-title-pattern-first-line " style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://hibernate.atlassian.net/browse/HHH" style="color: #3b73af; text-decoration: none">Hibernate ORM</a> / <a href="https://hibernate.atlassian.net/browse/HHH-10454" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-c86347ad-2125-4941-9384-363c28c127e8" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom"></a> <a href="https://hibernate.atlassian.net/browse/HHH-10454" style="color: #3b73af; text-decoration: none">HHH-10454</a> </td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-10454" style="color: #3b73af; text-decoration: none">session.persist fails for OneToOne relation with optional=false and generator is IDENTITY/AUTO</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 10px; padding-bottom: 5px" bgcolor="#ffffff">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Change By:</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="Madhusudana Reddy Sunnapu" id="email_Madhusudana Reddy Sunnapu" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=Madhusudana+Reddy+Sunnapu" style="color:#6c797f;; color: #3b73af; text-decoration: none">Madhusudana Reddy Sunnapu</a> </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Summary:</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <span class="diffcontext">session.persist fails for OneToOne relation with optional=false and generator is IDENTITY</span> <span class="diffaddedchars" style="background-color:#ddfade;">/AUTO</span> </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Environment:</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <span class="diffcontext">Java 1.8, Derby DB 10.12.1.1</span> <span class="diffaddedchars" style="background-color:#ddfade;">, h2</span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 5px; padding-bottom: 10px" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0"> <span class="diffcontext">I have two entities Post and PostDetails that are mapped as OneToOne with shared primary key, optional=false and id generator strategy set as IDENTITY</span> <span class="diffaddedchars" style="background-color:#ddfade;">/AUTO</span> <span class="diffcontext">. When I try to persist the Post entity it fails with</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> following</span> <span class="diffaddedchars" style="background-color:#ddfade;"> throwing</span> <span class="diffcontext"> exception</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> "org</span> <span class="diffcontext">.</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">hibernate.id.IdentifierGenerationException: null id generated for:class com.demo.hibernate.PostDetails".</span> <span class="diffcontext"><br><br>Assuming we have following entities Post and PostDetails mapped as OneToOne with shared primary key, optional=false and id generator strategy set as IDENTITY</span> <span class="diffaddedchars" style="background-color:#ddfade;">/AUTO</span> <span class="diffcontext"> as below<br><br>{code:java}<br>@Entity<br>public class Post implements Serializable {<br> @Id<br> @GeneratedValue(strategy = GenerationType.IDENTITY)<br> private long id;<br> @OneToOne(mappedBy="post", cascade = { CascadeType.ALL }, optional=false)<br> private PostDetails details;<br> public long getId() {<br> return id;<br> }<br> public PostDetails getDetails() {<br> return details;<br> }<br> public void addDetails(PostDetails details) {<br> this.details = details;<br> details.setPost(this);<br> }<br><br> public void deleteDetails() {<br> if(details !=null) {<br> details.setPost(null);<br> }<br> this.details = null;<br> }<br>}<br><br>@Entity<br>public class PostDetails implements Serializable {<br> @Id<br> @Column<br> private long id;<br> @OneToOne<br> @JoinColumn(name="id") <br> @MapsId <br> private Post post;<br> <br> public long getId() {<br> return id;<br> }<br> public Post getPost() {<br> return post;<br> }<br> public void setPost(Post post) {<br> this.post = post;<br> }<br>}<br><br>{code}<br><br>When</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> I</span> <span class="diffaddedchars" style="background-color:#ddfade;"> we</span> <span class="diffcontext"> execute the following test case to save the entities,<br><br>{code:java}<br> @Test<br> public void persistPost() {<br> Session session = sf.getCurrentSession();<br> session.getTransaction().begin();<br> Post post = new Post();<br> PostDetails details = new PostDetails();<br> post.addDetails(details);<br> session.persist(post);<br> session.beginTransaction().commit();<br> }<br>{code}<br><br>It fails to save and throws the following exception:<br><br>{code:java}<br>org.hibernate.id.IdentifierGenerationException: null id generated for:class</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> com.demo.hibernate.</span> <span class="diffcontext">PostDetails<br>{code}</span> <span class="diffaddedchars" style="background-color:#ddfade;"> for IDENTITY</span> <span class="diffcontext"><br></span> <span class="diffaddedchars" style="background-color:#ddfade;">and</span> <span class="diffcontext"><br></span> <span class="diffaddedchars" style="background-color:#ddfade;">org.hibernate.exception.ConstraintViolationException: could not execute statement for AUTO<br><br></span> <span class="diffcontext">The same code works</span> <span class="diffaddedchars" style="background-color:#ddfade;"> with both IDENTITY/AUTO</span> <span class="diffcontext"> if</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> I</span> <span class="diffaddedchars" style="background-color:#ddfade;"> we</span> <span class="diffcontext"> change</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> the generator strategy</span> <span class="diffaddedchars" style="background-color:#ddfade;"> it</span> <span class="diffcontext"> to</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> AUTO from IDENTITY or change to</span> <span class="diffcontext"> optional=true as below.<br><br>{code:java}<br>Changing</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> <br> @GeneratedValue(strategy = GenerationType.IDENTITY)</span> <span class="diffcontext"><br></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">to <br></span> <span class="diffcontext"> @</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">GeneratedValue(strategy = GenerationType.AUTO)<br>{code}<br><br>OR<br><br>{code:java}<br>Changing<br>@</span> <span class="diffcontext">OneToOne(mappedBy="post", cascade = { CascadeType.ALL }, optional=false)<br>to<br>@OneToOne(mappedBy="post", cascade = { CascadeType.ALL }, optional=true)<br>{code}</span> <span class="diffaddedchars" style="background-color:#ddfade;"><br><br>Although I tested only with DerbyDB and h2, I believe, issue can be replicated on other databases as well.</span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-10454#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-0e4a216d-b39b-4035-9baf-1ba5a8797a0a" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-10454#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian JIRA <span id="footer-build-information">(v7.1.0-OD-04-012#71001-<span title="dd0493d72352e1a51e29faeaa551e16c27e40a01" data-commit-id="dd0493d72352e1a51e29faeaa551e16c27e40a01}">sha1:dd0493d</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-682d3313-a333-413e-b56c-377b183b2f95" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>