<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="cid:jira-generated-image-avatar-971c5285-a070-4da9-9258-12069cc6ea3a" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="gabor.varga" id="email_gabor.varga" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=gabor.varga" style="color:#6c797f;; color: #3b73af; text-decoration: none">Gábor Varga</a> <strong>updated</strong> an issue </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td class="page-title-pattern-first-line " style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://hibernate.atlassian.net/browse/HHH" style="color: #3b73af; text-decoration: none">Hibernate ORM</a> / <a href="https://hibernate.atlassian.net/browse/HHH-10551" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-529c01d3-dbd9-47fc-8d42-811296346333" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom"></a> <a href="https://hibernate.atlassian.net/browse/HHH-10551" style="color: #3b73af; text-decoration: none">HHH-10551</a> </td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-10551" style="color: #3b73af; text-decoration: none">NonIdentifierAttribute.isLazy() returns false when @Basic(fetch=FetchType.LAZY)</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 10px; padding-bottom: 5px" bgcolor="#ffffff">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Change By:</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="gabor.varga" id="email_gabor.varga" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=gabor.varga" style="color:#6c797f;; color: #3b73af; text-decoration: none">Gábor Varga</a> </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Environment:</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">{{hibernate-enhance-maven-plugin}} configuration:<br>{code:xml}<br><configuration><br> <enableLazyInitialization>true</enableLazyInitialization><br> <enableDirtyTracking>false</enableDirtyTracking><br> <enableAssociationManagement>false</enableAssociationManagement><br> <enableExtendedEnhancement>false</enableExtendedEnhancement><br></configuration><br>{code}</span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 5px; padding-bottom: 10px" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0"> <span class="diffcontext">When setting the {{enableLazyInitialization}} parameter of the {{hibernate-enhance-maven-plugin}}'s configuration to {{true}}, the non-identifier attributes annotated with {{@Basic(fetch = FetchType.LAZY)}} will show as {{LazyPropertyInitializer.UNFETCHED_PROPERTY}} in [{{EntityEntry.getLoadedState()}}|https://github.com/hibernate/hibernate-orm/blob/5.0.8/hibernate-core/src/main/java/org/hibernate/engine/spi/EntityEntry.java#L38], while [{{AbstractEntityTuplizer.getPropertyValues(Object)}}|https://github.com/hibernate/hibernate-orm/blob/5.0.8/hibernate-core/src/main/java/org/hibernate/tuple/entity/AbstractEntityTuplizer.java#L493] will show {{null}} current values because [{{NonIdentifierAttribute.isLazy()}}|https://github.com/hibernate/hibernate-orm/blob/5.0.8/hibernate-core/src/main/java/org/hibernate/tuple/NonIdentifierAttribute.java#L17] returns {{false}}.<br><br>This causes a problem in [{{DefaultFlushEntityEventListener.dirtyCheck(FlushEntityEvent)}}|https://github.com/hibernate/hibernate-orm/blob/5.0.8/hibernate-core/src/main/java/org/hibernate/event/internal/DefaultFlushEntityEventListener.java#L465], where the two different representations are stored in the following two variables:<br>{code:java}<br>final Object[] loadedState = entry.getLoadedState();<br>final Object[] values = event.getPropertyValues();<br>{code}<br>And then (when there is no {{findDirty()}} interceptor override, and the entity is not an instance of {{SelfDirtinessTracker}}, so the {{enableDirtyTracking}} parameter of the {{hibernate-enhance-maven-plugin}} configuration is {{false}}), the dirty check is performed by [{{AbstractEntityPersister.findDirty(Object\[\] currentState, Object\[\] previousState, Object entity, SessionImplementor session)}}|https://github.com/hibernate/hibernate-orm/blob/5.0.8/hibernate-core/src/main/java/org/hibernate/persister/entity/AbstractEntityPersister.java#L4079], and then forwarded to [{{TypeHelper.findDirty(NonIdentifierAttribute\[\] properties, Object\[\] currentState, Object\[\] previousState, boolean\[\]\[\] includeColumns, boolean anyUninitializedProperties, SessionImplementor session)}}|https://github.com/hibernate/hibernate-orm/blob/5.0.8/hibernate-core/src/main/java/org/hibernate/type/TypeHelper.java#L282]. This checks if the current state holds {{LazyPropertyInitializer.UNFETCHED_PROPERTY}}, but it holds {{null}} instead (as described in the first paragraph). These two values are then compared in the appropriate {{Type}} subclass' {{isDirty()}}, {{isSame()}} and {{isEqual()}} methods, which (depending on the actual implementation) either return an incorrect dirty state (and then an unnecessary UPDATE is scheduled in [{{DefaultFlushEntityEventListener.onFlushEntity(FlushEntityEvent)}}|https://github.com/hibernate/hibernate-orm/blob/5.0.8/hibernate-core/src/main/java/org/hibernate/event/internal/DefaultFlushEntityEventListener.java#L143]), or throw an exception (e.g. {{ClassCastException}} when comparing a primitive byte array to {{LazyPropertyInitializer.UNFETCHED_PROPERTY}}.<br><br>In my opinion, the problem lies in [{{NonIdentifierAttribute.isLazy()}}|https://github.com/hibernate/hibernate-orm/blob/5.0.8/hibernate-core/src/main/java/org/hibernate/tuple/NonIdentifierAttribute.java#L17] returning {{false}} in {{AbstractEntityTuplizer.getPropertyValues(Object)}}, causing the current state array to hold {{null}} instead of {{LazyPropertyInitializer.UNFETCHED_PROPERTY}}. (As far as I can tell, no {{Type}} subclasses are prepared to handle {{LazyPropertyInitializer.UNFETCHED_PROPERTY}} directly, so it shouldn't be propagated to them from {{TypeHelper.findDirty()}}.)<br><br>The code path of the error that I've observed:<br>- [{{DefaultFlushEntityEventListener.onFlushEntity(FlushEntityEvent)}}|https://github.com/hibernate/hibernate-orm/blob/5.0.8/hibernate-core/src/main/java/org/hibernate/event/internal/DefaultFlushEntityEventListener.java#L125]<br>- [{{DefaultFlushEntityEventListener.isUpdateNecessary(FlushEntityEvent, boolean)}}|https://github.com/hibernate/hibernate-orm/blob/5.0.8/hibernate-core/src/main/java/org/hibernate/event/internal/DefaultFlushEntityEventListener.java#L211]<br>- [{{DefaultFlushEntityEventListener.dirtyCheck(FlushEntityEvent)}}|https://github.com/hibernate/hibernate-orm/blob/5.0.8/hibernate-core/src/main/java/org/hibernate/event/internal/DefaultFlushEntityEventListener.java#L465]<br>- [{{AbstractEntityPersister.findDirty(Object\[\], Object\[\], Object, SessionImplementor)}}|https://github.com/hibernate/hibernate-orm/blob/5.0.8/hibernate-core/src/main/java/org/hibernate/persister/entity/AbstractEntityPersister.java#L4079]<br>- [{{TypeHelper.findDirty(NonIdentifierAttribute\[\], Object\[\], Object\[\], boolean\[\]\[\], boolean, SessionImplementor)}}|https://github.com/hibernate/hibernate-orm/blob/5.0.8/hibernate-core/src/main/java/org/hibernate/type/TypeHelper.java#L282]<br>- [{{Type.isDirty(Object, Object, boolean\[\], SessionImplementor)}}|https://github.com/hibernate/hibernate-orm/blob/5.0.8/hibernate-core/src/main/java/org/hibernate/type/Type.java#L263]<br>- [{{Type.isDirty(Object, Object, SessionImplementor)}}|https://github.com/hibernate/hibernate-orm/blob/5.0.8/hibernate-core/src/main/java/org/hibernate/type/Type.java#L249]<br>- [{{Type.isSame(Object, Object)}}|https://github.com/hibernate/hibernate-orm/blob/5.0.8/hibernate-core/src/main/java/org/hibernate/type/Type.java#L167]<br>- [{{Type.isEqual(Object, Object)}}|https://github.com/hibernate/hibernate-orm/blob/5.0.8/hibernate-core/src/main/java/org/hibernate/type/Type.java#L184]<br><br>First I've observed this problem with a {{UserType}} field, but I could reproduce it with {{byte[]}} too.<br><br>Setting {{enableDirtyTracking}} to {{true}} is a possible workaround, as [{{DefaultFlushEntityEventListener.dirtyCheck(FlushEntityEvent)}}|https://github.com/hibernate/hibernate-orm/blob/5.0.8/hibernate-core/src/main/java/org/hibernate/event/internal/DefaultFlushEntityEventListener.java#L465] uses a different code path in that case.</span> <span class="diffaddedchars" style="background-color:#ddfade;"><br><br>My original {{hibernate-enhance-maven-plugin}} configuration:<br>{code:xml}<br><configuration><br> <enableLazyInitialization>true</enableLazyInitialization><br> <enableDirtyTracking>false</enableDirtyTracking><br> <enableAssociationManagement>false</enableAssociationManagement><br> <enableExtendedEnhancement>false</enableExtendedEnhancement><br></configuration><br>{code}</span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-10551#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-89926086-64a6-44be-baf0-baa89eb2173c" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-10551#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian JIRA <span id="footer-build-information">(v7.2.0-OD-02-009#72000-<span title="d1626757ba045a4d612b2b04acf81f585dd9c6b8" data-commit-id="d1626757ba045a4d612b2b04acf81f585dd9c6b8}">sha1:d162675</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-c3649203-f362-4d54-b105-b0c8c9b8b3af" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>