<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="cid:jira-generated-image-avatar-3d628dab-b202-47b7-ba2d-33e48641e35c" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="mih_vlad" id="email_mih_vlad" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=mih_vlad" style="color:#6c797f;; color: #3b73af; text-decoration: none">Vlad Mihalcea</a> <strong>updated</strong> an issue </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td class="page-title-pattern-first-line " style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://hibernate.atlassian.net/browse/HHH" style="color: #3b73af; text-decoration: none">Hibernate ORM</a> / <a href="https://hibernate.atlassian.net/browse/HHH-9744" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-ab31a1ea-1463-49f8-aab5-d24eb5dcf362" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom"></a> <a href="https://hibernate.atlassian.net/browse/HHH-9744" style="color: #3b73af; text-decoration: none">HHH-9744</a> </td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-9744" style="color: #3b73af; text-decoration: none">TemporaryTableBulkIdStrategy always creates a temporary table even when the dropTemporaryTableAfterUse Dialect setting is set to true</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 10px; padding-bottom: 5px" bgcolor="#ffffff">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Change By:</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="mih_vlad" id="email_mih_vlad" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=mih_vlad" style="color:#6c797f;; color: #3b73af; text-decoration: none">Vlad Mihalcea</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 5px; padding-bottom: 10px" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0"> <span class="diffcontext">I think this is a bug in</span> <span class="diffaddedchars" style="background-color:#ddfade;"> {{</span> <span class="diffcontext"> TemporaryTableBulkIdStrategy</span> <span class="diffaddedchars" style="background-color:#ddfade;">}}</span> <span class="diffcontext">, because</span> <span class="diffaddedchars" style="background-color:#ddfade;">,</span> <span class="diffcontext"> when using the Oracle8iDialect</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> says</span> <span class="diffaddedchars" style="background-color:#ddfade;">, it appears</span> <span class="diffcontext"> that temporary tables shouldn't be deleted:<br><br>{code:java}<br>@Override<br>public boolean dropTemporaryTableAfterUse() {<br> return false;<br>}<br>{code}<br><br></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"><br></span> <span class="diffcontext">But this check is made only when deleting the table:<br><br>{code:java}<br>protected void releaseTempTable(Queryable persister, SessionImplementor session) {<br> if ( session.getFactory().getDialect().dropTemporaryTableAfterUse() ) {<br> TemporaryTableDropWork work = new TemporaryTableDropWork( persister, session );<br> if ( shouldIsolateTemporaryTableDDL( session ) ) {<br> session.getTransactionCoordinator()<br> .getTransaction()<br> .createIsolationDelegate()<br> .delegateWork( work, shouldTransactIsolatedTemporaryTableDDL( session ) );<br> }<br> else {<br> final Connection connection = session.getTransactionCoordinator()<br> .getJdbcCoordinator()<br> .getLogicalConnection()<br> .getConnection();<br> work.execute( connection );<br> session.getTransactionCoordinator()<br> .getJdbcCoordinator()<br> .afterStatementExecution();<br> }<br> }<br> else {<br> // at the very least cleanup the data :)<br> PreparedStatement ps = null;<br> try {<br> final String sql = "delete from " + persister.getTemporaryIdTableName();<br> ps = session.getTransactionCoordinator().getJdbcCoordinator().getStatementPreparer().prepareStatement( sql, false );<br> session.getTransactionCoordinator().getJdbcCoordinator().getResultSetReturn().executeUpdate( ps );<br> }<br> catch( Throwable t ) {<br> log.unableToCleanupTemporaryIdTable(t);<br> }<br> finally {<br> if ( ps != null ) {<br> try {<br> session.getTransactionCoordinator().getJdbcCoordinator().release( ps );<br> }<br> catch( Throwable ignore ) {<br> // ignore<br> }<br> }<br> }<br> }<br>}<br>{code}<br><br>but now when creating the table:<br><br>{code:java}<br></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">// Some comments here<br>public String getFoo()<br>{<br> return foo;<br>}<br>{code}<br><br>{code:java}<br></span> <span class="diffcontext">protected void createTempTable(Queryable persister, SessionImplementor session) {<br> // Don't really know all the codes required to adequately decipher returned jdbc exceptions here.<br> // simply allow the failure to be eaten and the subsequent insert-selects/deletes should fail<br> TemporaryTableCreationWork work = new TemporaryTableCreationWork( persister );<br> if ( shouldIsolateTemporaryTableDDL( session ) ) {<br> session.getTransactionCoordinator()<br> .getTransaction()<br> .createIsolationDelegate()<br> .delegateWork( work, shouldTransactIsolatedTemporaryTableDDL( session ) );<br> }<br> else {<br> final Connection connection = session.getTransactionCoordinator()<br> .getJdbcCoordinator()<br> .getLogicalConnection()<br> .getConnection();<br> work.execute( connection );<br> session.getTransactionCoordinator()<br> .getJdbcCoordinator()<br> .afterStatementExecution();<br> }<br>}<br>{code}<br><br>As a workaround, you could extend the Oracle dialect and override the dropTemporaryTableAfterUse method to return false.</span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-9744#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-8e959e72-fa43-41a7-9285-8682d8111869" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-9744#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian JIRA <span id="footer-build-information">(v7.2.0-OD-02-009#72000-<span title="d1626757ba045a4d612b2b04acf81f585dd9c6b8" data-commit-id="d1626757ba045a4d612b2b04acf81f585dd9c6b8}">sha1:d162675</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-33489b46-3f29-4c1c-97ef-eeb9df5f65e8" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>