<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="cid:jira-generated-image-avatar-78619a4c-7686-45d9-9cfe-ce8b05c8332d" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="Myeonghyeon-Lee" id="email_Myeonghyeon-Lee" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=Myeonghyeon-Lee" style="color:#6c797f;; color: #3b73af; text-decoration: none">Myeonghyeon-Lee</a> <strong>updated</strong> an issue </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="page-title-pattern-first-line " style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://hibernate.atlassian.net/browse/HHH" style="color: #3b73af; text-decoration: none">Hibernate ORM</a> / <a href="https://hibernate.atlassian.net/browse/HHH-10984" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-c35ab186-3c18-46d6-88df-ee3af246eff9" height="16" width="16" border="0" align="absmiddle" alt="Patch" style="vertical-align: text-bottom"></a> <a href="https://hibernate.atlassian.net/browse/HHH-10984" style="color: #3b73af; text-decoration: none">HHH-10984</a> </td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-10984" style="color: #3b73af; text-decoration: none">Change multiLoad sessionCheckingEnabled default value is true and Fix few bugs.</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 10px; padding-bottom: 5px" bgcolor="#ffffff">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Change By:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="Myeonghyeon-Lee" id="email_Myeonghyeon-Lee" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=Myeonghyeon-Lee" style="color:#6c797f;; color: #3b73af; text-decoration: none">Myeonghyeon-Lee</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 5px; padding-bottom: 10px" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <span class="diffcontext">When using *session.byMulipleIds(SimpleEntity.class).multipleLoad(ids);* I got a few problems.<br><br>1. multiLoad 's sessionCheckingEnabled option default value should be true.<br><br>If one of ids which managed entity by session should not be included in multiLoad query's 'in' conditions.<br><br></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">```</span> <span class="diffaddedchars" style="background-color:#ddfade;"><br>{code:</span> <span class="diffcontext"> java</span> <span class="diffaddedchars" style="background-color:#ddfade;">}</span> <span class="diffcontext"><br>SimpleEntity third = session.byId( SimpleEntity.class ).load( 3 );<br>List<SimpleEntity> list = session.byMultipleIds(SimpleEntity.class).multiLoad( Arrays.asList(1 , 2 , 3 );<br>assertEquals( 3, list.size() );<br></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">```</span> <span class="diffaddedchars" style="background-color:#ddfade;">{code}</span> <span class="diffcontext"><br><br></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br></span> <span class="diffcontext">id "3" is already loaded in session that i expect query include only another ids "2", "3" ; like *session.byId(SimpleEntity.class).load(1);*<br>But default value of sessionCheckingEnable is false that query include all ids even "1".<br>It is more efficient i think.<br><br>If some of one wants to execute query include all ids like REFRESH it will be better.<br>session.byMultipleIds(SimpleEntity.class).enableSessionCheck(false).multiLoad( Arrays.asList(1 , 2 , 3 );<br><br>I fixed it in my forked repository.<br>https://github.com/Myeonghyeon-Lee/hibernate-orm/commit/3e1b471a9d795b52aee930702856e7f06bf7eb00<br><br><br>2. Fix in multiLoad bugs with non flushed entities both side of sessionCheckingEnable true and false<br><br>When sessionCheckingEnabled is true, *DynamicBatchingEntityLoaderBuilder* will check if some of ids are managed entities from session then they will exclude for query.<br>But, below test will be failed.<br></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">```</span> <span class="diffaddedchars" style="background-color:#ddfade;"><br><br>{code:</span> <span class="diffcontext"> java</span> <span class="diffaddedchars" style="background-color:#ddfade;">}</span> <span class="diffcontext"><br>@Test<br>public void testBasicMultiLoadWithManagedButRemovedAndChecking() {<br> Session session = openSession();<br> session.getTransaction().begin();<br> SimpleEntity third = session.byId( SimpleEntity.class ).load( 3 );<br> session.remove(third);<br> List<SimpleEntity> list = session.byMultipleIds(SimpleEntity.class).enableSessionCheck(true).multiLoad( ids(56) );<br> // removed entity excluded in results<br> assertEquals( 55, list.size() );<br> session.getTransaction().commit();<br> session.close();<br>}<br></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">```</span> <span class="diffaddedchars" style="background-color:#ddfade;">{code}</span> <span class="diffcontext"><br><br></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br></span> <span class="diffcontext">removed but non flushed entity will be founded by *DynamicBatchingEntityLoaderBuilder<br>* that it will be excluded in query but included in results.<br>I think it is a kind of bug. removed and non flushed entity should be excluded query and results.<br>So *DynamicBatchingEntityLoaderBuilder* need to check if managedEntity marked DELETED or GONE.<br><br>When sessionCheckingEnabled is false, *DynamicBatchingEntityLoaderBuilder* should flush non flushed entity queries for consistence query results like executing HQL. (depends on FlushMode)<br>Below test will be failed.<br><br></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">```</span> <span class="diffaddedchars" style="background-color:#ddfade;"><br><br>{code:</span> <span class="diffcontext"> java</span> <span class="diffaddedchars" style="background-color:#ddfade;">}</span> <span class="diffcontext"><br>@Test<br>public void testBasicMultiLoadWithNonFlushedAndNoChecking() {<br> Session session = openSession();<br> session.getTransaction().begin();<br> session.save( new SimpleEntity( 100, "Entity #" + 100 ) );<br> Integer[] ids = { 1, 2, 3, 100 };<br> List<SimpleEntity> list = session.byMultipleIds(SimpleEntity.class).enableSessionCheck(false).multiLoad( ids );<br> // should include saved(non-flushed) entities in results depends on FlushMode<br> assertEquals( 4, list.size() );<br> session.getTransaction().commit();<br> session.close();<br>}<br></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">```</span> <span class="diffaddedchars" style="background-color:#ddfade;">{code}</span> <span class="diffcontext"><br></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br><br></span> <span class="diffcontext">ids "1", "2", "3" are persisted but non managed entities, and id "100" saved before executing mulgiLoad(). id "100" of entity is managed in session but non flushed.<br>When executing multiLoad() then results size is only 3 exclude "100". It is weird result with AutoFlush mode. If i use HQL query session will flush before executing query then result will correct.<br>As a result, I think if sessionCheckingEnabled is false session flushed before executing multiLoad().<br><br>I fixed it in my forked repository.<br>https://github.com/Myeonghyeon-Lee/hibernate-orm/commit/dc8c51a8ab38badc233277c4d84926d05a93c3ec<br><br>3. Enhance multiLoad test case<br><br>When sessionCheckingEnabled is true that managed entities put in first position of results.<br>But current both of test case tested by first entity and assert with first position of results.<br>Given entity for right test will be another position of entity<br><br>I fixed it for enhancement of test<br>https://github.com/Myeonghyeon-Lee/hibernate-orm/commit/4893a4835dfcaf5ee4d8512ea203b87bf9bfab29<br><br>It would be nice, if either these things apply in hibernate-orm<br></span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-10984#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-0d6a29d1-046a-4ec3-8558-a538a7fd3d8d" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-10984#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian JIRA <span id="footer-build-information">(v1000.184.1#100008-<span title="1fb1cc9d7843d715cb5c8659dca05d9b0372565f" data-commit-id="1fb1cc9d7843d715cb5c8659dca05d9b0372565f}">sha1:1fb1cc9</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-da6e351d-741e-4d3c-b335-e815a4d5cdac" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>