<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
    <head> 
        <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> 
        <meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0"> 
        <base href="https://hibernate.atlassian.net"> 
        <title>Message Title</title> 
    </head> 
    <body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429"> 
        <table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5"> 
            <!-- header here --> 
            <tbody>
                <tr> 
                    <td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px"> 
                        <table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0"> 
                            <tbody>
                                <tr> 
                                    <td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="cid:jira-generated-image-avatar-e43a7247-8c86-48ca-b18f-6e65bdc08e56" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td> 
                                    <td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="Myeonghyeon-Lee" id="email_Myeonghyeon-Lee" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=Myeonghyeon-Lee" style="color:#6c797f;; color: #3b73af; text-decoration: none">Myeonghyeon-Lee</a> <strong>commented</strong> on <a href="https://hibernate.atlassian.net/browse/HHH-10984" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-54292cba-c745-44d7-8a73-b8781ee1a6ff" height="16" width="16" border="0" align="absmiddle" alt="Patch"> HHH-10984</a> </td> 
                                </tr> 
                            </tbody>
                        </table> </td> 
                </tr> 
                <tr> 
                    <td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px"> 
                        <table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate"> 
                            <tbody>
                                <tr> 
                                    <!-- there needs to be content in the cell for it to render in some clients --> 
                                    <td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff">&nbsp;</td> 
                                </tr> 
                                <tr> 
                                    <td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff"> 
                                        <table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0"> 
                                            <tbody>
                                                <tr> 
                                                    <td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-10984" style="color: #3b73af; text-decoration: none">Re: Change multiLoad sessionCheckingEnabled default value is true and Fix few bugs.</a> </span> </td> 
                                                </tr> 
                                            </tbody>
                                        </table> </td> 
                                </tr> 
                                <tr> 
                                    <td id="text-paragraph-pattern-top" class="email-content-main mobile-expand  comment-top-pattern" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; border-bottom: none; padding-bottom: 0" bgcolor="#ffffff"> 
                                        <table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px"> 
                                            <tbody>
                                                <tr> 
                                                    <td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <p style="margin: 10px 0 0; margin-top: 0">@Emmanuel Bernard <br> I guess you mentioned about my second topic; <b>2. Fix in multiLoad bugs with non flushed entities both side of sessionCheckingEnable true and false</b></p> <p style="margin: 10px 0 0">I agree with you partially. delete (or save) before multiLoad is not a common use case in same method. <br> But I'm not sure never exists these kind of code.<br> I think production code (as you said realistic code) could be possible in the same long process session such as using OSIV (Open Session In View).<br> Some of complexity business logics call many method in the same Transaction(Session) and each method might be responsible for their operations. Then each method doesn't know entity(matched id) is deleted ( or flushed ).</p> <p style="margin: 10px 0 0">Below are simple examples</p> <h3 style="margin: 10px 0 0; font-size: 16px; line-height: 1.563; margin: 30px 0 0"><a name="1.savebeforemultiLoadinthesamesession" style="color: #3b73af; text-decoration: none"></a>1. save before multiLoad in the same session</h3> 
                                                        <div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px; border-radius: 3px; margin: 9px 0">
                                                            <div class="codeContent panelContent" style="padding: 9px 12px"> 
                                                                <pre class="code-java" style="margin: 10px 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
@Test
<span class="code-keyword" style="color: #000091">public</span> void test() {
        Session session = openSession();
        session.getTransaction().begin();

        List&lt;<span class="code-object" style="color: #910091">String</span>&gt; requestParams = Arrays.asList(<span class="code-quote" style="color: #009100">"Post 1"</span>, <span class="code-quote" style="color: #009100">"Post 2"</span>, <span class="code-quote" style="color: #009100">"Too <span class="code-object" style="color: #910091; color: #009100">Long</span> Text Post"</span>);
                
        List&lt;<span class="code-object" style="color: #910091">Integer</span>&gt; ids = createPosts(requestParams);
        doSomethingIfExists(ids);

        session.getTransaction().commit();
        session.close();
}

<span class="code-keyword" style="color: #000091">public</span> List&lt;<span class="code-object" style="color: #910091">Integer</span>&gt; createPosts(List&lt;<span class="code-object" style="color: #910091">String</span>&gt; texts) {
        Session session = getSession();
        List&lt;<span class="code-object" style="color: #910091">Integer</span>&gt; createdIds = <span class="code-keyword" style="color: #000091">new</span> ArrayList&lt;&gt;();
        <span class="code-keyword" style="color: #000091">for</span> (<span class="code-object" style="color: #910091">int</span> i = 0; i &lt; texts.size(); i++) {
                Post post = <span class="code-keyword" style="color: #000091">new</span> Post(texts.get(i));
                session.save(post);
                createdIds.add(post.getId());
        }
        <span class="code-keyword" style="color: #000091">return</span> createdIds;
}

<span class="code-keyword" style="color: #000091">public</span> void doSomethingIfExists(List&lt;<span class="code-object" style="color: #910091">Integer</span>&gt; ids) {
        Session session = getSession();

        List&lt;Post&gt; posts = session.byMultipleIds(Post.class).enableSessionCheck(<span class="code-keyword" style="color: #000091">false</span>).multiLoad(ids);

        <span class="code-keyword" style="color: #000091">for</span> (Post post : posts) {
                <span class="code-object" style="color: #910091">System</span>.out.println(post.getText());
        }
}
</pre> 
                                                            </div>
                                                        </div> <p style="margin: 10px 0 0">doSomethingIfExists will print <b>nothing</b>; results posts is empty<br> (session.byMultipleIds(Post.class).enableSessionCheck(<b>false</b>).multiLoad(ids)<img class="emoticon" src="cid:jira-generated-image-static-wink-e16315c5-1f6c-4a2d-bfab-b05938b71cfd" height="16" width="16" align="absmiddle" alt="" border="0"></p> 
                                                        <div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px; border-radius: 3px; margin: 9px 0">
                                                            <div class="codeContent panelContent" style="padding: 9px 12px"> 
                                                                <pre class="code-java" style="margin: 10px 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<span class="code-keyword" style="color: #000091">public</span> void doSomethingIfExists(List&lt;<span class="code-object" style="color: #910091">Integer</span>&gt; ids) {
        Session session = getSession();

        List&lt;Post&gt; posts = session.byMultipleIds(Post.class).enableSessionCheck(<span class="code-keyword" style="color: #000091">true</span>).multiLoad(ids);

        <span class="code-keyword" style="color: #000091">for</span> (Post post : posts) {
                <span class="code-object" style="color: #910091">System</span>.out.println(post.getText());
        }
}
</pre> 
                                                            </div>
                                                        </div> <p style="margin: 10px 0 0">doSomethingIfExists will print <b>Post 1</b>, <b>Post 2</b>, <b>Too Long Text Post</b><br> (session.byMultipleIds(Post.class).enableSessionCheck(<b>true</b>).multiLoad(ids)<img class="emoticon" src="cid:jira-generated-image-static-wink-e16315c5-1f6c-4a2d-bfab-b05938b71cfd" height="16" width="16" align="absmiddle" alt="" border="0"></p> 
                                                        <div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px; border-radius: 3px; margin: 9px 0">
                                                            <div class="codeContent panelContent" style="padding: 9px 12px"> 
                                                                <pre class="code-java" style="margin: 10px 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<span class="code-keyword" style="color: #000091">public</span> void doSomethingIfExists(List&lt;<span class="code-object" style="color: #910091">Integer</span>&gt; ids) {
        Session session = getSession();

        Query&lt;Post&gt; query = session.createQuery(<span class="code-quote" style="color: #009100">"from Post p where p.id in (:ids)"</span>);
        query.setParameterList(<span class="code-quote" style="color: #009100">"ids"</span>, ids);
        List&lt;Post&gt; posts = query.list();

        <span class="code-keyword" style="color: #000091">for</span> (Post post : posts) {
                <span class="code-object" style="color: #910091">System</span>.out.println(post.getText());
        }
}
</pre> 
                                                            </div>
                                                        </div> <p style="margin: 10px 0 0">doSomethingIfExists will print <b>Post 1</b>, <b>Post 2</b>, <b>Too Long Text Post</b><br> (Session will flush saved posts before executing HQL query)</p> 
                                                        <div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px; border-radius: 3px; margin: 9px 0">
                                                            <div class="codeContent panelContent" style="padding: 9px 12px"> 
                                                                <pre class="code-java" style="margin: 10px 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<span class="code-keyword" style="color: #000091">public</span> void doSomethingIfExists(List&lt;<span class="code-object" style="color: #910091">Integer</span>&gt; ids) {
        Session session = getSession();

        List&lt;Post&gt; posts = <span class="code-keyword" style="color: #000091">new</span> ArrayList&lt;&gt;();
        <span class="code-keyword" style="color: #000091">for</span>(<span class="code-object" style="color: #910091">Integer</span> id : ids) {
                Post post = session.byId(Post.class).load(id);
                posts.add(post);
        }

        <span class="code-keyword" style="color: #000091">for</span> (Post post : posts) {
                <span class="code-object" style="color: #910091">System</span>.out.println(post.getText());
        }
}
</pre> 
                                                            </div>
                                                        </div> <p style="margin: 10px 0 0">doSomethingIfExists will print <b>Post 1</b>, <b>Post 2</b>, <b>Too Long Text Post</b><br> (byId.load each Id)</p> <p style="margin: 10px 0 0">Only one case is different (multiLoad with sessionCheckingEnabled == false)</p> <p style="margin: 10px 0 0">I think Session should flush before executing multiLoad if sessionCheckingEnabled is false like executing HQL for consistency result.</p> <h3 style="margin: 10px 0 0; font-size: 16px; line-height: 1.563; margin: 30px 0 0"><a name="2.deletebeforemultiLoadinthesamesession" style="color: #3b73af; text-decoration: none"></a>2. delete before multiLoad in the same session</h3> 
                                                        <div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px; border-radius: 3px; margin: 9px 0">
                                                            <div class="codeContent panelContent" style="padding: 9px 12px"> 
                                                                <pre class="code-java" style="margin: 10px 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
@Test
<span class="code-keyword" style="color: #000091">public</span> void test2() {
        Session session = openSession();
        session.getTransaction().begin();

        List&lt;<span class="code-object" style="color: #910091">Integer</span>&gt; requestParams = Arrays.asList(1, 2, 3);
        deleteTooLongTextPosts(requestParams);
        doSomethingIfExists(requestParams);

        session.getTransaction().commit();
        session.close();
}

<span class="code-keyword" style="color: #000091">public</span> void deleteTooLongTextPosts(List&lt;<span class="code-object" style="color: #910091">Integer</span>&gt; ids) {
        Session session = getSession();
        Query&lt;Post&gt; query = session.createQuery(<span class="code-quote" style="color: #009100">"from Post p where p.text.size &gt; 10 and p.id in (:ids)"</span>);
        query.setParameter(<span class="code-quote" style="color: #009100">"ids"</span>, ids);
        List&lt;Post&gt; posts = query.list();

        <span class="code-comment" style="color: #808080">// <span class="code-keyword" style="color: #000091; color: #808080">do</span> something business logic
</span>
        <span class="code-keyword" style="color: #000091">for</span>(Post post : posts) {
                session.remove(post);
        }
}

<span class="code-keyword" style="color: #000091">public</span> void doSomethingIfExists(List&lt;<span class="code-object" style="color: #910091">Integer</span>&gt; ids) {
        Session session = getSession();

        List&lt;Post&gt; posts = session.byMultipleIds(Post.class).enableSessionCheck(<span class="code-keyword" style="color: #000091">false</span>).multiLoad(ids);

        <span class="code-keyword" style="color: #000091">for</span> (Post post : posts) {
                <span class="code-object" style="color: #910091">System</span>.out.println(post.getText());
        }
}
</pre> 
                                                            </div>
                                                        </div> <p style="margin: 10px 0 0">doSomethingIfExists will print <b>Post 1</b>, <b>Post 2</b>, <b>Too Long Text Post</b> ; <b>Too Long Text Post</b> entity is already deleted in <b>deleteTooLongTextPosts</b> method but printed.<br> (session.byMultipleIds(Post.class).enableSessionCheck(<b>false</b>).multiLoad(ids)<img class="emoticon" src="cid:jira-generated-image-static-wink-e16315c5-1f6c-4a2d-bfab-b05938b71cfd" height="16" width="16" align="absmiddle" alt="" border="0"></p> 
                                                        <div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px; border-radius: 3px; margin: 9px 0">
                                                            <div class="codeContent panelContent" style="padding: 9px 12px"> 
                                                                <pre class="code-java" style="margin: 10px 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<span class="code-keyword" style="color: #000091">public</span> void doSomethingIfExists(List&lt;<span class="code-object" style="color: #910091">Integer</span>&gt; ids) {
        Session session = getSession();

        List&lt;Post&gt; posts = session.byMultipleIds(Post.class).enableSessionCheck(<span class="code-keyword" style="color: #000091">true</span>).multiLoad(ids);

        <span class="code-keyword" style="color: #000091">for</span> (Post post : posts) {
                <span class="code-object" style="color: #910091">System</span>.out.println(post.getText());
        }
}
</pre> 
                                                            </div>
                                                        </div> <p style="margin: 10px 0 0">doSomethingIfExists will print <b>Post 1</b>, <b>Post 2</b>, <b>Too Long Text Post</b> ; <b>Too Long Text Post</b> entity is already deleted in <b>deleteTooLongTextPosts</b> method but printed.<br> (session.byMultipleIds(Post.class).enableSessionCheck(<b>true</b>).multiLoad(ids)<img class="emoticon" src="cid:jira-generated-image-static-wink-e16315c5-1f6c-4a2d-bfab-b05938b71cfd" height="16" width="16" align="absmiddle" alt="" border="0"></p> 
                                                        <div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px; border-radius: 3px; margin: 9px 0">
                                                            <div class="codeContent panelContent" style="padding: 9px 12px"> 
                                                                <pre class="code-java" style="margin: 10px 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<span class="code-keyword" style="color: #000091">public</span> void doSomethingIfExists(List&lt;<span class="code-object" style="color: #910091">Integer</span>&gt; ids) {
        Session session = getSession();

        Query&lt;Post&gt; query = session.createQuery(<span class="code-quote" style="color: #009100">"from Post p where p.id in (:ids)"</span>);
        query.setParameterList(<span class="code-quote" style="color: #009100">"ids"</span>, ids);
        List&lt;Post&gt; posts = query.list();

        <span class="code-keyword" style="color: #000091">for</span> (Post post : posts) {
                <span class="code-object" style="color: #910091">System</span>.out.println(post.getText());
        }
}
</pre> 
                                                            </div>
                                                        </div> <p style="margin: 10px 0 0">doSomethingIfExists will print <b>Post 1</b>, <b>Post 2</b><br> (Session will flush saved posts before executing HQL query)</p> 
                                                        <div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px; border-radius: 3px; margin: 9px 0">
                                                            <div class="codeContent panelContent" style="padding: 9px 12px"> 
                                                                <pre class="code-java" style="margin: 10px 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<span class="code-keyword" style="color: #000091">public</span> void doSomethingIfExists(List&lt;<span class="code-object" style="color: #910091">Integer</span>&gt; ids) {
        Session session = getSession();

        List&lt;Post&gt; posts = <span class="code-keyword" style="color: #000091">new</span> ArrayList&lt;&gt;();
        <span class="code-keyword" style="color: #000091">for</span>(<span class="code-object" style="color: #910091">Integer</span> id : ids) {
                Post post = session.byId(Post.class).load(id);
                posts.add(post);
        }

        <span class="code-keyword" style="color: #000091">for</span> (Post post : posts) {
                <span class="code-object" style="color: #910091">System</span>.out.println(post.getText());
        }
}
</pre> 
                                                            </div>
                                                        </div> <p style="margin: 10px 0 0">doSomethingIfExists will print <b>Post 1</b>, <b>Post 2</b><br> (byId.load each Id)</p> <p style="margin: 10px 0 0">When using multiLoad printed already deleted entity.</p> <p style="margin: 10px 0 0">I think Session should check if managed entities are DELETED marked and exclude it. (sessionCheckingEnabled == true)<br> If sessionCheckingEnabled == false Session should flush before executing multiLoad like HQL.</p> <p style="margin: 10px 0 0">I think we need to fix theses behavior for consistency result when using multiLoad.</p> <p style="margin: 10px 0 0">Thanks.</p> </td> 
                                                </tr> 
                                            </tbody>
                                        </table> </td> 
                                </tr> 
                                <tr> 
                                    <td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff"> 
                                        <table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> 
                                            <tbody>
                                                <tr> 
                                                    <td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0"> 
                                                        <table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0"> 
                                                            <tbody>
                                                                <tr> 
                                                                    <td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-10984#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-5adcfb90-ce69-4b71-bfcd-1e0f2e8793db" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td> 
                                                                    <td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-10984#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td> 
                                                                </tr> 
                                                            </tbody>
                                                        </table> </td> 
                                                </tr> 
                                            </tbody>
                                        </table> </td> 
                                </tr> 
                                <!-- there needs to be content in the cell for it to render in some clients --> 
                                <tr> 
                                    <td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff">&nbsp;</td> 
                                </tr> 
                            </tbody>
                        </table> </td> 
                </tr> 
                <tr> 
                    <td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px"> 
                        <table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0"> 
                            <tbody>
                                <tr> 
                                    <td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian JIRA <span id="footer-build-information">(v1000.184.1#100008-<span title="1fb1cc9d7843d715cb5c8659dca05d9b0372565f" data-commit-id="1fb1cc9d7843d715cb5c8659dca05d9b0372565f}">sha1:1fb1cc9</span>)</span> </td> 
                                    <td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top"> 
                                        <table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0"> 
                                            <tbody>
                                                <tr> 
                                                    <td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-0a9694dd-6ae5-41d0-84f6-cbe791a3d988" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix"> </td> 
                                                </tr> 
                                            </tbody>
                                        </table> </td> 
                                </tr> 
                            </tbody>
                        </table> </td> 
                </tr> 
            </tbody>
        </table>   
    </body>
</html>