<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="cid:jira-generated-image-avatar-0ca01be2-52f3-44af-b353-ca6a45a4b854" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="jaroslav.strouhal" id="email_jaroslav.strouhal" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=jaroslav.strouhal" style="color:#6c797f;; color: #3b73af; text-decoration: none">Jaroslav Strouhal</a> <strong>updated</strong> an issue </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="page-title-pattern-first-line " style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://hibernate.atlassian.net/browse/HV" style="color: #3b73af; text-decoration: none">Hibernate Validator</a> / <a href="https://hibernate.atlassian.net/browse/HV-1080" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-4fda7bfa-a971-45ec-8119-1043b634db84" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom"></a> <a href="https://hibernate.atlassian.net/browse/HV-1080" style="color: #3b73af; text-decoration: none">HV-1080</a> </td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HV-1080" style="color: #3b73af; text-decoration: none">Validation of Java 8 Optional throws Class cast exception</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 10px; padding-bottom: 5px" bgcolor="#ffffff">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Change By:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="jaroslav.strouhal" id="email_jaroslav.strouhal" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=jaroslav.strouhal" style="color:#6c797f;; color: #3b73af; text-decoration: none">Jaroslav Strouhal</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 5px; padding-bottom: 10px" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <span class="diffcontext">validation of nested Optional object throws class cast exception, if the getter is Optional but field<br><br>for example: following code ends with class cast exception: <br><br>{code}<br>private class X {<br><br> @Valid<br> private Y y;<br><br> public void setY(Y y) {<br> this.y = y;<br> }<br><br> public Optional<Y> getY() {<br> return Optional.ofNullable(y);<br> }<br> }<br><br> private class Y {<br><br> @Valid<br> private Z z;<br><br> public void setZ(Z z) {<br> this.z = z;<br> }<br><br> public Optional<Z> z() {<br> return Optional.ofNullable(z);<br> }<br> }<br><br> private class Z {<br><br> @NotNull<br> private String karel;<br><br> @NotNull(groups = Group1.class)<br> private String johny;<br><br> @NotNull<br> private Integer test;<br><br><br> public String getKarel() {<br> return karel;<br> }<br><br> public void setKarel(String karel) {<br> this.karel = karel;<br> }<br><br> public String getJohny() {<br> return johny;<br> }<br><br> public void setJohny(String johny) {<br> this.johny = johny;<br> }<br><br> public Optional<Integer> getTest() {<br> return null;<br> }<br> }<br><br> private interface Group1 {<br><br> }<br><br> private ValidationService validationService = validationService();<br><br> private ValidationService validationService() {<br><br> ValidationServiceImpl service = new ValidationServiceImpl();<br> return service;<br> }<br><br> @Test<br> public void test_1() {<br><br> X x = new X();<br> x.y = new Y();<br> x.y.z = new Z();<br> x.y.z.test = 1;<br><br> Assert.assertEquals(2, validationService.getConstraintViolations(x, Group1.class).size());<br> }<br>{code}<br><br>The problem is that code tries to unwrap that Optional without checking, if the original field value is really Optional (it probably checks only getter)<br><br>{color:red}*Workaround exist*{color}<br><br>if you explicitly change your classes to "do not unwrap", the validation is successfully finished but I would expected that</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> in this case</span> <span class="diffcontext"> it should work in this way automatically without that annotation.<br><br>{code}<br>private class X {<br><br> @Valid<br> @UnwrapValidatedValue(false)<br> private Y y;<br><br> public void setY(Y y) {<br> this.y = y;<br> }<br><br> public Optional<Y> getY() {<br> return Optional.ofNullable(y);<br> }<br> }<br><br> private class Y {<br><br> @Valid<br> @UnwrapValidatedValue(false)<br> private Z z;<br><br> public void setZ(Z z) {<br> this.z = z;<br> }<br><br> public Optional<Z> z() {<br> return Optional.ofNullable(z);<br> }<br> }<br><br> private class Z {<br><br> @NotNull<br> private String karel;<br><br> @NotNull(groups = Group1.class)<br> private String johny;<br><br> @NotNull<br> @UnwrapValidatedValue(false)<br> private Integer test;<br><br><br> public String getKarel() {<br> return karel;<br> }<br><br> public void setKarel(String karel) {<br> this.karel = karel;<br> }<br><br> public String getJohny() {<br> return johny;<br> }<br><br> public void setJohny(String johny) {<br> this.johny = johny;<br> }<br><br> public Optional<Integer> getTest() {<br> return null;<br> }<br> }<br><br> private interface Group1 {<br><br> }<br><br> private ValidationService validationService = validationService();<br><br> private ValidationService validationService() {<br><br> ValidationServiceImpl service = new ValidationServiceImpl();<br> return service;<br> }<br><br> @Test<br> public void test_1() {<br><br> X x = new X();<br> x.y = new Y();<br> x.y.z = new Z();<br> x.y.z.test = 1;<br><br> Assert.assertEquals(2, validationService.getConstraintViolations(x, Group1.class).size());<br> }<br>{code}</span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HV-1080#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-812306a3-5072-40a0-a0c7-38e2791ffb33" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HV-1080#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian JIRA <span id="footer-build-information">(v1000.217.1#100008-<span title="fdd523c323c2c9db17acf28ef688f81d0a4b61ea" data-commit-id="fdd523c323c2c9db17acf28ef688f81d0a4b61ea}">sha1:fdd523c</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-213a9f88-ce1a-4757-be2e-8ca0ab7f7668" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>