<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="cid:jira-generated-image-avatar-9df7391e-3391-430f-bac6-7789605c1d76" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="crancran" id="email_crancran" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=crancran" style="color:#6c797f;; color: #3b73af; text-decoration: none">Chris Cranford</a> <strong>updated</strong> an issue </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="page-title-pattern-first-line " style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://hibernate.atlassian.net/browse/HHH" style="color: #3b73af; text-decoration: none">Hibernate ORM</a> / <a href="https://hibernate.atlassian.net/browse/HHH-11020" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-bce85aea-1729-4b39-8b06-409b04c2345f" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom"></a> <a href="https://hibernate.atlassian.net/browse/HHH-11020" style="color: #3b73af; text-decoration: none">HHH-11020</a> </td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-11020" style="color: #3b73af; text-decoration: none">calling EntityManager.unwrap(Session.class) to gain access to Hibernated Session in a Weld CDI environment results in ClassCastException</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 10px; padding-bottom: 5px" bgcolor="#ffffff">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Change By:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="crancran" id="email_crancran" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=crancran" style="color:#6c797f;; color: #3b73af; text-decoration: none">Chris Cranford</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 5px; padding-bottom: 10px" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <span class="diffcontext">We have an application that was using the following successfully:<br><br>Hibernate 5.0.10.FINAL<br>Weld 2.3.5.FINAL<br>Java 8u101<br>PostgreSQL 9.5.2<br><br>In this application we use Weld CDI to manage the EntityManager reference. There is one spot where we gain access to the underlying Hibernate Session by calling EntityManager.unwrap(Session.class) in order to call Session.setDefaultReadOnly(true). It looks something like:<br><br>{</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">{</span> <span class="diffaddedchars" style="background-color:#ddfade;">code}<br></span> <span class="diffcontext">public abstract class AbstractDao<E, K extends Serializable> implements Dao<E, K> {<br>...<br>@Inject<br> protected EntityManager em;<br>...<br>public E find(....) {<br>...<br> if (readOnly) {<br> em.unwrap(Session.class).setDefaultReadOnly(true);<br> }<br>...<br>}<br></span> <span class="diffaddedchars" style="background-color:#ddfade;">{code</span> <span class="diffcontext">}</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">}</span> <span class="diffcontext"><br>We attempted to upgrade to Hibernate 5.2.1.FINAL with no other changes, this results in the call to em.unwrap(Session.class) to now fail with a ClassCastException:<br><br></span> <span class="diffaddedchars" style="background-color:#ddfade;">{quote}<br></span> <span class="diffcontext">java.lang.ClassCastException: org.jboss.weldx.persistence.EntityManager$1473582185$Proxy$_$$_WeldClientProxy cannot be cast to org.hibernate.Session<br></span> <span class="diffaddedchars" style="background-color:#ddfade;">{quote}</span> <span class="diffcontext"><br></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br></span> <span class="diffcontext">This appears to be a result of SessionImpl now directly implementing javax.persistence.EntityManager and returning itself (i.e. "this"), from the unwrap method, from 5.2.1.FINAL version of SessionImpl.java:<br><br>{</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">{</span> <span class="diffaddedchars" style="background-color:#ddfade;">code}<br></span> <span class="diffcontext"> @Override<br> @SuppressWarnings("unchecked")<br> public <T> T unwrap(Class<T> clazz) {<br> checkOpen();<br><br> if ( Session.class.isAssignableFrom( clazz ) ) {<br></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">--></span> <span class="diffcontext"> return (T) this;</span> <span class="diffaddedchars" style="background-color:#ddfade;"> // <--</span> <span class="diffcontext"><br> }<br> if ( SessionImplementor.class.isAssignableFrom( clazz ) ) {<br> return (T) this;<br> }<br> if ( SharedSessionContractImplementor.class.isAssignableFrom( clazz ) ) {<br> return (T) this;<br> }<br> if ( EntityManager.class.isAssignableFrom( clazz ) ) {<br> return (T) this;<br> }<br><br> throw new PersistenceException( "Hibernate cannot unwrap " + clazz );<br> }<br></span> <span class="diffaddedchars" style="background-color:#ddfade;">{code</span> <span class="diffcontext">}</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">}</span> <span class="diffcontext"><br></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br></span> <span class="diffcontext">The SessionImpl.unwrap method returns the correct value, however there appears to be a negative interaction with Weld, in Weld's ProxyMethodHandler.java:<br><br>{</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">{</span> <span class="diffaddedchars" style="background-color:#ddfade;">code}<br></span> <span class="diffcontext"> /* (non-Javadoc)<br> * @see javassist.util.proxy.MethodHandler#invoke(java.lang.Object, java.lang.reflect.Method, java.lang.reflect.Method, java.lang.Object[])<br> */<br> public Object invoke(Object self, Method thisMethod, Method proceed, Object[] args) throws Throwable {<br> if (thisMethod == null) {<br> BeanLogger.LOG.methodHandlerProcessingReturningBeanInstance(self.getClass());<br> if (beanInstance == null) {<br> throw BeanLogger.LOG.beanInstanceNotSetOnProxy(getBean());<br> }<br> return beanInstance.getInstance();<br> }<br> BeanLogger.LOG.methodHandlerProcessingCall(thisMethod, self.getClass());<br> if (thisMethod.getDeclaringClass().equals(TargetInstanceProxy.class)) {<br> if (beanInstance == null) {<br> throw BeanLogger.LOG.beanInstanceNotSetOnProxy(getBean());<br> }<br> if (thisMethod.getName().equals("getTargetInstance")) {<br> return beanInstance.getInstance();<br> } else if (thisMethod.getName().equals("getTargetClass")) {<br> return beanInstance.getInstanceType();<br> } else {<br> return null;<br> }<br> } else if (thisMethod.getName().equals("_initMH")) {<br> BeanLogger.LOG.settingNewMethodHandler(args[0], self.getClass());<br> return new ProxyMethodHandler(contextId, new TargetBeanInstance(args[0]), getBean());<br> } else {<br> if (beanInstance == null) {<br> throw BeanLogger.LOG.beanInstanceNotSetOnProxy(getBean());<br> }<br> Object instance = beanInstance.getInstance();<br> Object result = beanInstance.invoke(instance, thisMethod, args);<br> // if the method returns this and the return type matches the proxy type, return the proxy instead<br> // to prevent the bean instance escaping<br></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">---></span> <span class="diffcontext"> if (result != null && result == instance && (thisMethod.getReturnType().isAssignableFrom(self.getClass()))) {</span> <span class="diffaddedchars" style="background-color:#ddfade;"> // <---</span> <span class="diffcontext"><br> return self;<br> }<br> return result;<br> }<br> }<br></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"><br></span> <span class="diffaddedchars" style="background-color:#ddfade;">{code</span> <span class="diffcontext">}</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">}</span> <span class="diffcontext"><br><br>Weld detects that the object returned from calling SessionImpl.unwrap is the object wrapped in the Weld client proxy and returns the Weld client proxy rather than a direct reference to the SessionImpl object. Unfortunately the Weld client proxy object only implements the EntityManager interface, not all interfaces that SessionImpl implements which includes Session.<br><br>I'm not sure if this is a Hibernate bug or a Weld bug or a combination of both.</span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-11020#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-5d56ff5a-ac87-4d7a-8391-20b95701e93c" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-11020#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian JIRA <span id="footer-build-information">(v1000.217.1#100008-<span title="fdd523c323c2c9db17acf28ef688f81d0a4b61ea" data-commit-id="fdd523c323c2c9db17acf28ef688f81d0a4b61ea}">sha1:fdd523c</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-34571b55-6f67-49fe-954f-625de538e7c1" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>