<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="cid:jira-generated-image-avatar-b00a4db2-53f3-4693-b002-8d0ae8311311" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="steve" id="email_steve" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=steve" style="color:#6c797f;; color: #3b73af; text-decoration: none">Steve Ebersole</a> <strong>commented</strong> on <a href="https://hibernate.atlassian.net/browse/HHH-11019" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-f6458003-bf95-49a0-b35f-537307a1f26d" height="16" width="16" border="0" align="absmiddle" alt="Improvement"> HHH-11019</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-11019" style="color: #3b73af; text-decoration: none">Re: Extend DelayedPostInsertIdentifier support to EXTENDED PC</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; border-bottom: none; padding-bottom: 0" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <p style="margin: 10px 0 0; margin-top: 0">Based on my proposed changes (PR), I temporarily added the following <tt>#main</tt>:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px; border-radius: 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
/**
* Here just to temporarily and easily show the outcomes
*/
<span class="code-keyword" style="color: #000091">public</span> <span class="code-keyword" style="color: #000091">static</span> void main(<span class="code-object" style="color: #910091">String</span>... args) {
<span class="code-object" style="color: #910091">System</span>.out.println( <span class="code-quote" style="color: #009100">"requiresImmediateIdAccess = <span class="code-keyword" style="color: #000091; color: #009100">false</span> ..."</span> );
decide( <span class="code-keyword" style="color: #000091">false</span>, <span class="code-keyword" style="color: #000091">true</span>, MANUAL );
decide( <span class="code-keyword" style="color: #000091">false</span>, <span class="code-keyword" style="color: #000091">false</span>, MANUAL );
decide( <span class="code-keyword" style="color: #000091">false</span>, <span class="code-keyword" style="color: #000091">true</span>, AUTO );
decide( <span class="code-keyword" style="color: #000091">false</span>, <span class="code-keyword" style="color: #000091">false</span>, AUTO );
decide( <span class="code-keyword" style="color: #000091">false</span>, <span class="code-keyword" style="color: #000091">true</span>, ALWAYS );
decide( <span class="code-keyword" style="color: #000091">false</span>, <span class="code-keyword" style="color: #000091">false</span>, ALWAYS );
<span class="code-object" style="color: #910091">System</span>.out.println( <span class="code-quote" style="color: #009100">"requiresImmediateIdAccess = <span class="code-keyword" style="color: #000091; color: #009100">true</span> ..."</span> );
decide( <span class="code-keyword" style="color: #000091">true</span>, <span class="code-keyword" style="color: #000091">true</span>, MANUAL );
decide( <span class="code-keyword" style="color: #000091">true</span>, <span class="code-keyword" style="color: #000091">false</span>, MANUAL );
decide( <span class="code-keyword" style="color: #000091">true</span>, <span class="code-keyword" style="color: #000091">true</span>, AUTO );
decide( <span class="code-keyword" style="color: #000091">true</span>, <span class="code-keyword" style="color: #000091">false</span>, AUTO );
decide( <span class="code-keyword" style="color: #000091">true</span>, <span class="code-keyword" style="color: #000091">true</span>, ALWAYS );
decide( <span class="code-keyword" style="color: #000091">true</span>, <span class="code-keyword" style="color: #000091">false</span>, ALWAYS );
}
<span class="code-keyword" style="color: #000091">private</span> <span class="code-keyword" style="color: #000091">static</span> void decide(<span class="code-object" style="color: #910091">boolean</span> requiresImmediateIdAccess, <span class="code-object" style="color: #910091">boolean</span> inTxn, FlushMode flushMode) {
<span class="code-comment" style="color: #808080">// `requiresImmediateIdAccess` indicates whether the calling context requires access to the
</span> <span class="code-comment" style="color: #808080">// real identifier value immediately upon <span class="code-keyword" style="color: #000091; color: #808080">return</span> from <span class="code-keyword" style="color: #000091; color: #808080">this</span> call. E.g., a method call like
</span> <span class="code-comment" style="color: #808080">// Session#save requires immediate access to the real id (because it is defined to <span class="code-keyword" style="color: #000091; color: #808080">return</span> that
</span> <span class="code-comment" style="color: #808080">// as its <span class="code-keyword" style="color: #000091; color: #808080">return</span> value), whereas a method like EntityManager#persist does not
</span>
<span class="code-comment" style="color: #808080">// `inTxn` - indicates whether we are currently in a transaction
</span>
<span class="code-comment" style="color: #808080">// `flushMode` represents the Session FlushMode, <span class="code-keyword" style="color: #000091; color: #808080">for</span> an <span class="code-quote" style="color: #009100; color: #808080">"EXTENDED PC"</span> <span class="code-keyword" style="color: #000091; color: #808080">this</span> would be MANUAL
</span>
<span class="code-comment" style="color: #808080">// the outcome
</span> <span class="code-object" style="color: #910091">boolean</span> shouldDelayIdentityInserts = shouldDelayIdentityInserts( requiresImmediateIdAccess, inTxn, flushMode );
<span class="code-object" style="color: #910091">System</span>.out.printf(
<span class="code-quote" style="color: #009100">"shouldDelayIdentityInserts (requiresImmediateIdAccess=%s, inTxn=%s, flushMode=%s) = %s"</span>,
requiresImmediateIdAccess,
inTxn,
flushMode.name(),
shouldDelayIdentityInserts
);
<span class="code-object" style="color: #910091">System</span>.out.println();
}
</pre>
</div>
</div> <p style="margin: 10px 0 0">which produces the following output:</p>
<div class="preformatted panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px; border-radius: 3px; margin: 9px 0">
<div class="preformattedContent panelContent" style="padding: 9px 12px">
<pre style="margin: 10px 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal; white-space: pre; word-break: normal; word-wrap: break-word; word-break: break-all; white-space: pre-wrap">requiresImmediateIdAccess=false ...
shouldDelayIdentityInserts (requiresImmediateIdAccess=false, inTxn=true, flushMode=MANUAL) = true
shouldDelayIdentityInserts (requiresImmediateIdAccess=false, inTxn=false, flushMode=MANUAL) = true
shouldDelayIdentityInserts (requiresImmediateIdAccess=false, inTxn=true, flushMode=AUTO) = false
shouldDelayIdentityInserts (requiresImmediateIdAccess=false, inTxn=false, flushMode=AUTO) = true
shouldDelayIdentityInserts (requiresImmediateIdAccess=false, inTxn=true, flushMode=ALWAYS) = false
shouldDelayIdentityInserts (requiresImmediateIdAccess=false, inTxn=false, flushMode=ALWAYS) = true
requiresImmediateIdAccess=true ...
shouldDelayIdentityInserts (requiresImmediateIdAccess=true, inTxn=true, flushMode=MANUAL) = false
shouldDelayIdentityInserts (requiresImmediateIdAccess=true, inTxn=false, flushMode=MANUAL) = false
shouldDelayIdentityInserts (requiresImmediateIdAccess=true, inTxn=true, flushMode=AUTO) = false
shouldDelayIdentityInserts (requiresImmediateIdAccess=true, inTxn=false, flushMode=AUTO) = false
shouldDelayIdentityInserts (requiresImmediateIdAccess=true, inTxn=true, flushMode=ALWAYS) = false
shouldDelayIdentityInserts (requiresImmediateIdAccess=true, inTxn=false, flushMode=ALWAYS) = false
</pre>
</div>
</div> <p style="margin: 10px 0 0">Which all seem like correct resolutions for <tt>shouldDelayIdentityInserts</tt>.</p> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-11019#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-5fa4e931-7c8b-4700-99d0-d128e5e8621d" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-11019#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian JIRA <span id="footer-build-information">(v1000.217.1#100008-<span title="fdd523c323c2c9db17acf28ef688f81d0a4b61ea" data-commit-id="fdd523c323c2c9db17acf28ef688f81d0a4b61ea}">sha1:fdd523c</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-a1620a4f-30ff-477c-bf9b-85b4d301cac9" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>