<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="cid:jira-generated-image-avatar-4c4b95b9-412c-432d-b525-a4dff5651c11" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="yrodiere" id="email_yrodiere" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=yrodiere" style="color:#6c797f;; color: #3b73af; text-decoration: none">Yoann Rodière</a> <strong>commented</strong> on <a href="https://hibernate.atlassian.net/browse/HSEARCH-2443" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-2410c382-9fee-4ad4-9038-e3f3629f0a21" height="16" width="16" border="0" align="absmiddle" alt="Improvement"> HSEARCH-2443</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HSEARCH-2443" style="color: #3b73af; text-decoration: none">Re: Hibernate Search pom leads to incorrect dependencies used in client project</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; border-bottom: none; padding-bottom: 0" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <p style="margin: 10px 0 0; margin-top: 0">Making <tt>hibernate-entitymanager</tt> and <tt>hibernate-core</tt> <tt>provided</tt> in <tt>hibernate-search-orm</tt> would harm simpler use (where you don't specify the Hibernate version). From a user's perspective, I wouldn't like the artifact I use to require me to know about their dependencies in order for them to work properly... That is, unless you meant something else when you said "optional dependencies".</p> <p style="margin: 10px 0 0">A solution to your issue is to specify the dependency without the version, and to fix the version using <a href="https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Dependency_Management" class="external-link" rel="nofollow" style="color: #3b73af; text-decoration: none">dependency management</a> instead. Then you don't need exclusion anymore. This is actually a really common issue when building application on top of multiple external libraries, so I don't think it's worth a workaround. Unless, again, I missed the point.</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px; border-radius: 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-xml" style="margin: 10px 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<span class="code-tag" style="color: #000091"><properties></span>
<span class="code-tag" style="color: #000091"><project.build.sourceEncoding></span>UTF-8<span class="code-tag" style="color: #000091"></project.build.sourceEncoding></span>
<span class="code-tag" style="color: #000091"><project.reporting.outputEncoding></span>UTF-8<span class="code-tag" style="color: #000091"></project.reporting.outputEncoding></span>
<span class="code-tag" style="color: #000091"><maven.compiler.source></span>1.8<span class="code-tag" style="color: #000091"></maven.compiler.source></span>
<span class="code-tag" style="color: #000091"><maven.compiler.target></span>1.8<span class="code-tag" style="color: #000091"></maven.compiler.target></span>
<span class="code-tag" style="color: #000091"><version.org.hibernate.orm></span>5.1.2.Final<span class="code-tag" style="color: #000091"></version.org.hibernate.orm></span>
<span class="code-tag" style="color: #000091"><version.org.hibernate.search></span>5.6.0.Beta3<span class="code-tag" style="color: #000091"></version.org.hibernate.search></span>
<span class="code-tag" style="color: #000091"><slf4jVersion></span>1.6.4<span class="code-tag" style="color: #000091"></slf4jVersion></span>
<span class="code-tag" style="color: #000091"></properties></span>
<span class="code-tag" style="color: #000091"><dependencies></span>
<span class="code-tag" style="color: #000091"><dependency></span>
<span class="code-tag" style="color: #000091"><groupId></span>org.hibernate<span class="code-tag" style="color: #000091"></groupId></span>
<span class="code-tag" style="color: #000091"><artifactId></span>hibernate-search-orm<span class="code-tag" style="color: #000091"></artifactId></span>
<span class="code-tag" style="color: #000091"></dependency></span>
<span class="code-tag" style="color: #000091"><dependency></span>
<span class="code-tag" style="color: #000091"><groupId></span>org.hibernate<span class="code-tag" style="color: #000091"></groupId></span>
<span class="code-tag" style="color: #000091"><artifactId></span>hibernate-search-elasticsearch<span class="code-tag" style="color: #000091"></artifactId></span>
<span class="code-tag" style="color: #000091"></dependency></span>
<span class="code-tag" style="color: #000091"><dependency></span>
<span class="code-tag" style="color: #000091"><groupId></span>org.hibernate<span class="code-tag" style="color: #000091"></groupId></span>
<span class="code-tag" style="color: #000091"><artifactId></span>hibernate-entitymanager<span class="code-tag" style="color: #000091"></artifactId></span>
<span class="code-tag" style="color: #000091"></dependency></span>
<span class="code-tag" style="color: #000091"></dependencies></span>
<span class="code-tag" style="color: #000091"><dependencyManagement></span>
<span class="code-tag" style="color: #000091"><dependency></span>
<span class="code-tag" style="color: #000091"><groupId></span>org.hibernate<span class="code-tag" style="color: #000091"></groupId></span>
<span class="code-tag" style="color: #000091"><artifactId></span>hibernate-search-orm<span class="code-tag" style="color: #000091"></artifactId></span>
<span class="code-tag" style="color: #000091"><version></span>${version.org.hibernate.search}<span class="code-tag" style="color: #000091"></version></span>
<span class="code-tag" style="color: #000091"></dependency></span>
<span class="code-tag" style="color: #000091"><dependency></span>
<span class="code-tag" style="color: #000091"><groupId></span>org.hibernate<span class="code-tag" style="color: #000091"></groupId></span>
<span class="code-tag" style="color: #000091"><artifactId></span>hibernate-search-elasticsearch<span class="code-tag" style="color: #000091"></artifactId></span>
<span class="code-tag" style="color: #000091"><version></span>${version.org.hibernate.search}<span class="code-tag" style="color: #000091"></version></span>
<span class="code-tag" style="color: #000091"></dependency></span>
<span class="code-tag" style="color: #000091"><dependency></span>
<span class="code-tag" style="color: #000091"><groupId></span>org.hibernate<span class="code-tag" style="color: #000091"></groupId></span>
<span class="code-tag" style="color: #000091"><artifactId></span>hibernate-entitymanager<span class="code-tag" style="color: #000091"></artifactId></span>
<span class="code-tag" style="color: #000091"><version></span>${version.org.hibernate.orm}<span class="code-tag" style="color: #000091"></version></span>
<span class="code-tag" style="color: #000091"></dependency></span>
<span class="code-tag" style="color: #000091"><dependency></span>
<span class="code-tag" style="color: #000091"><groupId></span>org.hibernate<span class="code-tag" style="color: #000091"></groupId></span>
<span class="code-tag" style="color: #000091"><artifactId></span>hibernate-core<span class="code-tag" style="color: #000091"></artifactId></span>
<span class="code-tag" style="color: #000091"><version></span>${version.org.hibernate.orm}<span class="code-tag" style="color: #000091"></version></span>
<span class="code-tag" style="color: #000091"></dependency></span>
<span class="code-tag" style="color: #000091"></dependencyManagement></span>
</pre>
</div>
</div> <p style="margin: 10px 0 0">I've always seen dependency management being defined in some parent pom, and actual dependencies in modules, but it should also work if done in the same pom.</p> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HSEARCH-2443#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-392d72ab-4767-4692-8b3a-4827e768184e" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HSEARCH-2443#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian JIRA <span id="footer-build-information">(v1000.482.3#100017-<span title="2ae3eee4bd6ec3a41d7a0a514f7bc953e9cb16ae" data-commit-id="2ae3eee4bd6ec3a41d7a0a514f7bc953e9cb16ae}">sha1:2ae3eee</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-28511514-0808-40ce-9c94-21366406e20a" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>