<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://secure.gravatar.com/avatar/4a5a63cf0912335f6ba068c522f2914e?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="jxr" id="email_jxr" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=jxr" style="color:#6c797f;; color: #3b73af; text-decoration: none">jxr</a> <strong>created</strong> an issue </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="page-title-pattern-first-line " style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://hibernate.atlassian.net/browse/HHH" style="color: #3b73af; text-decoration: none">Hibernate ORM</a> / <a href="https://hibernate.atlassian.net/browse/HHH-11396" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-7488fd73-9bd3-48e3-9af3-98cc92ddbfcc" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom"></a> <a href="https://hibernate.atlassian.net/browse/HHH-11396" style="color: #3b73af; text-decoration: none">HHH-11396</a> </td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-11396" style="color: #3b73af; text-decoration: none">Conversion of Date to LocalDate does not consider timezone difference</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 10px; padding-bottom: 5px" bgcolor="#ffffff">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Issue Type:</th>
<td class="has-icon" style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <img src="cid:jira-generated-image-avatar-7488fd73-9bd3-48e3-9af3-98cc92ddbfcc" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom"> Bug </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Affects Versions:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> 5.2.6 </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Assignee:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> Unassigned </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Components:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> hibernate-core </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Created:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> 13/Jan/2017 12:09 PM </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Environment:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> MySQL:5.5.32 <br> mysql-connector-java:5.1.25 <br> spring-boot:1.4.3.RELEASE <br> hibernate-core:5.2.6 </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Priority:</th>
<td class="has-icon" style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <img src="cid:jira-generated-image-static-critical-09ef9d74-5fe4-497e-ab9a-1e09ab719491" height="16" width="16" border="0" align="absmiddle" alt="Critical" style="vertical-align: text-bottom"> Critical </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Reporter:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="jxr" id="email_jxr" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=jxr" style="color:#6c797f;; color: #3b73af; text-decoration: none">jxr</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 5px; padding-bottom: 10px" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0; margin-top: 0"><b>tl;dr</b> </p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">The current implementation of <tt>Date</tt> to <tt>LocalDate</tt> conversion in <a href="https://github.com/hibernate/hibernate-orm/blob/master/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/LocalDateJavaDescriptor.java#L115" class="external-link" rel="nofollow" style="color: #3b73af; text-decoration: none">LocalDateJavaDescriptor</a> <em>shifts the date by one day</em> if producer (e.g. MySQL RDBMS) and consumer (e.g. Spring Boot application) are running in different timezones.</p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0"><b>Long Issue Description:</b></p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">Given an application instance and a DB instance in two different timezones:</p>
<ul class="alternate" type="square">
<li>a MariaDB/MySQL which is running on a server in the in the "Europe/Berlin" (UTC+01:00) timezone and</li>
<li>a Java (Spring Bootstrap) application on a server in the GMT (UTC+00:00) timezone.</li>
</ul> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">The database contains a table <tt>students</tt> with a column <tt>birthday</tt> of a timezone-agnostic type <tt>DATE</tt>. The appropriate persistence entity looks as following:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px; border-radius: 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
@Entity(name = <span class="code-quote" style="color: #009100">"students"</span>)
<span class="code-keyword" style="color: #000091">public</span> class StudentDo {
@Id
<span class="code-keyword" style="color: #000091">private</span> <span class="code-object" style="color: #910091">Integer</span> id;
@Column
<span class="code-keyword" style="color: #000091">private</span> LocalDate birthday;
<span class="code-comment" style="color: #808080">// ...
</span>}
</pre>
</div>
</div> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">The Java application is connected to the producer using the following JDBC URL:</p>
<div class="preformatted panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px; border-radius: 3px; margin: 9px 0">
<div class="preformattedContent panelContent" style="padding: 9px 12px">
<pre style="margin: 10px 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal; white-space: pre; word-break: normal; word-wrap: break-word; word-break: break-all; white-space: pre-wrap">jdbc:mysql://localhost/exampledb?zeroDateTimeBehavior=convertToNull&useUnicode=true&useJDBCCompliantTimezoneShift=true&useLegacyDatetimeCode=false&serverTimezone=Europe/Berlin
</pre>
</div>
</div> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">Now, when fetching the entities from the database using a <a href="https://docs.spring.io/spring-data/data-commons/docs/1.6.1.RELEASE/reference/html/repositories.html" class="external-link" rel="nofollow" style="color: #3b73af; text-decoration: none">Spring Data Repository</a> all <tt>birthday</tt> values are shifted by one day, e.g. <tt>1979-12-31</tt> while <tt>1980-01-01</tt> is stored in the database.</p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0"><b>Investigation:</b></p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">For my understanding, the following happens when Hibernate gets the response from the DB:</p>
<ol>
<li>The <tt>DATE</tt> value (which is e.g. <tt>1980-01-01</tt>) is obtained from producer.</li>
<li>The value is stored in consumer as <tt>java.sql.Date</tt>, producer timezone is considered (value is <tt>315529200000</tt> "milliseconds", see <a href="http://www.fileformat.info/tip/java/date2millis.htm" class="external-link" rel="nofollow" style="color: #3b73af; text-decoration: none">Online Converter</a>).</li>
<li>Because the consumer is in GMT, the date's internal calendar is represented as <tt>1979-12-31T23:00:00.000Z</tt>, which can be still described as correct because the time part is obligatory in the underlying calendar.</li>
<li><b>ISSUE HERE:</b> The date is now converted to <tt>LocalDate</tt> in <a href="https://github.com/hibernate/hibernate-orm/blob/master/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/LocalDateJavaDescriptor.java#L115" class="external-link" rel="nofollow" style="color: #3b73af; text-decoration: none">LocalDateJavaDescriptor</a> using <a href="https://docs.oracle.com/javase/8/docs/api/java/sql/Date.html#toLocalDate--" class="external-link" rel="nofollow" style="color: #3b73af; text-decoration: none">Date#toLocalDate</a> which simple cuts off time and timezone. The result is <tt>1979-12-31</tt>.</li>
</ol> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0"><b>Expectation:</b></p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">Obviously, if the date <tt>1980-01-01</tt> stored in the DB as a timezone-less value, it should also appear as the same timezone-less value <tt>1980-01-01</tt> after conversion to <tt>LocalDate</tt> in the persistent entity.</p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0"><b>Current Workarouds:</b></p>
<ol>
<li>Obviously, switching default JVM timezone using <tt>-Duser.timezone=Europe/Berlin</tt> option or programmatically by <tt>TimeZone.setDefault(TimeZone.getTimeZone("Europe/Berlin"));</tt> to the timezone of the producer eleminates this issues.</li>
<li>Another option would be a creation of a custom attribute converter for conversion from <tt>java.sql.Date</tt> to <tt>java.time.LocalDate</tt>:
<div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px; border-radius: 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
@Converter(autoApply = <span class="code-keyword" style="color: #000091">true</span>)
<span class="code-keyword" style="color: #000091">public</span> class LocalDateAttributeConverter <span class="code-keyword" style="color: #000091">implements</span> AttributeConverter<LocalDate, Date> {
<span class="code-keyword" style="color: #000091">public</span> <span class="code-keyword" style="color: #000091">static</span> <span class="code-keyword" style="color: #000091">final</span> ZoneId ZONE_EUROPE_BERLIN = ZoneId.of(<span class="code-quote" style="color: #009100">"Europe/Berlin"</span>);
@Override
<span class="code-keyword" style="color: #000091">public</span> Date convertToDatabaseColumn(LocalDate locDate) {
<span class="code-keyword" style="color: #000091">if</span> (locDate == <span class="code-keyword" style="color: #000091">null</span>) {
<span class="code-keyword" style="color: #000091">return</span> <span class="code-keyword" style="color: #000091">null</span>;
}
<span class="code-comment" style="color: #808080">// Untested, probably something like <span class="code-keyword" style="color: #000091; color: #808080">this</span>
</span>
ZonedDateTime zonedDateTime = locDate.atStartOfDay(ZONE_EUROPE_BERLIN);
LocalDate producerLocalDate = zonedDateTime.toLocalDate();
Date date = Date.valueOf(producerLocalDate);
<span class="code-keyword" style="color: #000091">return</span> date;
}
@Override
<span class="code-keyword" style="color: #000091">public</span> LocalDate convertToEntityAttribute(Date sqlDate) {
<span class="code-keyword" style="color: #000091">if</span> (sqlDate == <span class="code-keyword" style="color: #000091">null</span>) {
<span class="code-keyword" style="color: #000091">return</span> <span class="code-keyword" style="color: #000091">null</span>;
}
<span class="code-comment" style="color: #808080">// Fixed implementation considering server timezone
</span>
Instant instant = Instant.ofEpochMilli(sqlDate.getTime());
LocalDateTime localDateTime = LocalDateTime.ofInstant(instant, ZONE_EUROPE_BERLIN);
LocalDate localDate = localDateTime.toLocalDate();
<span class="code-keyword" style="color: #000091">return</span> localDate;
}
}
</pre>
</div>
</div></li>
</ol> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">P. S. Currently not sure how to write a proper test demonstrating this behavior. Hints welcome.</p> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff"> <script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"description": "View Issue",
"potentialAction": {
"@type": "ViewAction",
"target": "https://hibernate.atlassian.net/browse/HHH-11396?inbox=true&",
"name": "View Issue"
},
"publisher": {
"@type": "Organization",
"name": "Atlassian",
"url": "https://www.atlassian.com"
}
}
</script>
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-11396#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-541b57b5-71bd-4cff-ad66-3e9988c3e882" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-11396#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian JIRA <span id="footer-build-information">(v1000.695.1#100025-<span title="c4480eba7ce76938eaf9fa97abdfbc002f0adc9d" data-commit-id="c4480eba7ce76938eaf9fa97abdfbc002f0adc9d}">sha1:c4480eb</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-4542bec6-40e8-4ab6-96bc-06cba0d0488d" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>