<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://secure.gravatar.com/avatar/4a5a63cf0912335f6ba068c522f2914e?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="jxr" id="email_jxr" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=jxr" style="color:#6c797f;; color: #3b73af; text-decoration: none">jxr</a> <strong>updated</strong> an issue </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="page-title-pattern-first-line " style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://hibernate.atlassian.net/browse/HHH" style="color: #3b73af; text-decoration: none">Hibernate ORM</a> / <a href="https://hibernate.atlassian.net/browse/HHH-11396" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-099bd807-76e0-4739-b86c-a128430cb8af" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom"></a> <a href="https://hibernate.atlassian.net/browse/HHH-11396" style="color: #3b73af; text-decoration: none">HHH-11396</a> </td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-11396" style="color: #3b73af; text-decoration: none">Conversion of Date to LocalDate does not consider timezone difference</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 10px; padding-bottom: 5px" bgcolor="#ffffff">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Change By:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="jxr" id="email_jxr" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=jxr" style="color:#6c797f;; color: #3b73af; text-decoration: none">jxr</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 5px; padding-bottom: 10px" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <span class="diffcontext">*tl;dr* <br><br>The current implementation of {{Date}} to {{LocalDate}} conversion in [LocalDateJavaDescriptor|https://github.com/hibernate/hibernate-orm/blob/master/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/LocalDateJavaDescriptor.java#L115] _shifts the date by one day_ if producer (e.g. MySQL RDBMS) and consumer (e.g. Spring Boot application) are running in different timezones.<br><br>*Long Issue Description:*<br><br>Given an application instance and a DB instance in two different timezones:<br>- a MariaDB/MySQL which is running on a server in the in the "Europe/Berlin" (UTC+01:00) timezone and<br>- a Java (Spring Bootstrap) application on a server in the GMT (UTC+00:00) timezone.<br><br>The database contains a table {{students}} with a column {{birthday}} of a timezone-agnostic type {{DATE}}. The appropriate persistence entity looks as following:<br>{code}<br>@Entity(name = "students")<br>public class StudentDo {<br> @Id<br> private Integer id;<br><br> @Column<br> private LocalDate birthday;<br><br> // ...<br>}<br>{code}<br><br>The Java application is connected to the producer using the following JDBC URL:<br>{noformat}<br>jdbc:mysql://localhost/exampledb?zeroDateTimeBehavior=convertToNull&useUnicode=true&useJDBCCompliantTimezoneShift=true&useLegacyDatetimeCode=false&serverTimezone=Europe/Berlin<br>{noformat}<br><br>Now, when fetching the entities from the database using a [Spring Data Repository|https://docs.spring.io/spring-data/data-commons/docs/1.6.1.RELEASE/reference/html/repositories.html] all {{birthday}} values are shifted by one day, e.g. {{1979-12-31}} while {{1980-01-01}} is stored in the database.<br><br>*Investigation:*<br><br>For my understanding, the following happens when Hibernate gets the response from the DB:<br># The {{DATE}} value (which is e.g. {{1980-01-01}}) is obtained from producer.<br># The value is stored in consumer as {{java.sql.Date}}, producer timezone is considered (value is {{315529200000}} "milliseconds", see [Online Converter|http://www.fileformat.info/tip/java/date2millis.htm]).<br># Because the consumer is in GMT, the date's internal calendar is represented as {{1979-12-31T23:00:00.000Z}}, which can be still described as correct because the time part is obligatory in the underlying calendar.<br># *ISSUE HERE:* The date is now converted to {{LocalDate}} in [LocalDateJavaDescriptor|https://github.com/hibernate/hibernate-orm/blob/master/hibernate-core/src/main/java/org/hibernate/type/descriptor/java/LocalDateJavaDescriptor.java#L115] using [Date#toLocalDate|https://docs.oracle.com/javase/8/docs/api/java/sql/Date.html#toLocalDate--] which simple cuts off time and timezone. The result is {{1979-12-31}}.<br><br>*Expectation:*<br><br>Obviously, if the date {{1980-01-01}} stored in the DB as a timezone-less value, it should also appear as the same timezone-less value {{1980-01-01}} after conversion to {{LocalDate}} in the persistent entity.<br><br>*Current Workarouds:*<br><br># Obviously, switching default JVM timezone using {{-Duser.timezone=Europe/Berlin}} option or programmatically by {{TimeZone.setDefault(TimeZone.getTimeZone("Europe/Berlin"));}} to the timezone of the producer eleminates this issues.<br># Another option would be a creation of a custom attribute converter for conversion from {{java.sql.Date}} to {{java.time.LocalDate}}:<br>{code}<br>@Converter(autoApply = true)<br>public class LocalDateAttributeConverter implements AttributeConverter<LocalDate, Date> {<br><br> public static final ZoneId ZONE_EUROPE_BERLIN = ZoneId.of("Europe/Berlin");<br><br> @Override<br> public Date convertToDatabaseColumn(LocalDate locDate) {<br> if (locDate == null) {<br> return null;<br> }<br><br> // Untested, probably something like this<br><br> ZonedDateTime zonedDateTime = locDate.atStartOfDay(ZONE_EUROPE_BERLIN);<br> LocalDate producerLocalDate = zonedDateTime.toLocalDate();<br> Date date = Date.valueOf(producerLocalDate);<br><br> return date;<br> }<br><br> @Override<br> public LocalDate convertToEntityAttribute(Date sqlDate) {<br> if (sqlDate == null) {<br> return null;<br> }<br><br> // Fixed implementation considering server timezone<br><br> Instant instant = Instant.ofEpochMilli(sqlDate.getTime());<br> LocalDateTime localDateTime = LocalDateTime.ofInstant(instant, ZONE_EUROPE_BERLIN);<br> LocalDate localDate = localDateTime.toLocalDate();<br><br> return localDate;<br> }<br>}<br>{code}<br><br></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">P</span> <span class="diffaddedchars" style="background-color:#ddfade;">*Test Case*<br><br>The attached [test case|^HHH-11396</span> <span class="diffcontext">.</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> S</span> <span class="diffaddedchars" style="background-color:#ddfade;">zip] which demonstrates the current behavior of {{LocalDateJavaDescriptor}} and of the custom {{LocalDateAttributeConverter}}</span> <span class="diffcontext">.</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> Currently not sure how</span> <span class="diffaddedchars" style="background-color:#ddfade;"> However, it is hard</span> <span class="diffcontext"> to</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> write a proper test demonstrating this behavior</span> <span class="diffaddedchars" style="background-color:#ddfade;"> reproduce the "real" complex distributed setup depicted above</span> <span class="diffcontext">.</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> Hints welcome.</span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff"> <script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"description": "View Issue",
"potentialAction": {
"@type": "ViewAction",
"target": "https://hibernate.atlassian.net/browse/HHH-11396?inbox=true&",
"name": "View Issue"
},
"publisher": {
"@type": "Organization",
"name": "Atlassian",
"url": "https://www.atlassian.com"
}
}
</script>
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-11396#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-55d556ab-cd81-428a-b00a-67451dfd255f" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-11396#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian JIRA <span id="footer-build-information">(v1000.695.1#100025-<span title="c4480eba7ce76938eaf9fa97abdfbc002f0adc9d" data-commit-id="c4480eba7ce76938eaf9fa97abdfbc002f0adc9d}">sha1:c4480eb</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-89cb2b46-9054-4294-a01e-b2b63e26e2fc" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>