<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="cid:jira-generated-image-avatar-5a6f6197-08ab-43ed-883e-f610f45b854e" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="vlcek" id="email_vlcek" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=vlcek" style="color:#6c797f;; color: #3b73af; text-decoration: none">Martin Vlcek</a> <strong>updated</strong> an issue </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="page-title-pattern-first-line " style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://hibernate.atlassian.net/browse/HHH" style="color: #3b73af; text-decoration: none">Hibernate ORM</a> / <a href="https://hibernate.atlassian.net/browse/HHH-11410" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-88aa1f50-1b4e-4c06-9a3e-e1594898a24e" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom"></a> <a href="https://hibernate.atlassian.net/browse/HHH-11410" style="color: #3b73af; text-decoration: none">HHH-11410</a> </td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-11410" style="color: #3b73af; text-decoration: none">ManyToMany with Filter generates incorrect load SQL</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 10px; padding-bottom: 5px" bgcolor="#ffffff">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Change By:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="vlcek" id="email_vlcek" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=vlcek" style="color:#6c797f;; color: #3b73af; text-decoration: none">Martin Vlcek</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 5px; padding-bottom: 10px" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <span class="diffcontext">A filter condition for a many-to-many association is added to the where clause instead of to the left outer join on clause when doing a get by ID with eager join fetching. This means that the select returns no records, when there are associated entities, but they are all filtered out.<br><br>The example below generates this SQL:<br>{code:sql}<br> select<br> myuserdbo0_.id as id1_8_0_,<br> myuserdbo0_.active as active2_8_0_,<br> myuserdbo0_.name as name3_8_0_,<br> roles1_.MYUSER_id as MYUSER_i1_8_1_,<br> myroledbo2_.id as roles_id2_9_1_,<br> myroledbo2_.id as id1_7_2_,<br> myroledbo2_.active as active2_7_2_,<br> myroledbo2_.name as name3_7_2_ <br> from<br> MYUSER myuserdbo0_ <br> left outer join<br> MYUSER_MYROLE roles1_ <br> on myuserdbo0_.id=roles1_.MYUSER_id <br> left outer join<br> MYROLE myroledbo2_ <br> on roles1_.roles_id=myroledbo2_.id <br> where<br> myroledbo2_.active = 1 <br> and myuserdbo0_.id=?<br>{code}<br>instead of <br>{code:sql}<br> select<br> myuserdbo0_.id as id1_8_0_,<br> myuserdbo0_.active as active2_8_0_,<br> myuserdbo0_.name as name3_8_0_,<br> roles1_.MYUSER_id as MYUSER_i1_8_1_,<br> myroledbo2_.id as roles_id2_9_1_,<br> myroledbo2_.id as id1_7_2_,<br> myroledbo2_.active as active2_7_2_,<br> myroledbo2_.name as name3_7_2_ <br> from<br> MYUSER myuserdbo0_ <br> left outer join<br> MYUSER_MYROLE roles1_ <br> on myuserdbo0_.id=roles1_.MYUSER_id <br> left outer join<br> MYROLE myroledbo2_ <br> on roles1_.roles_id=myroledbo2_.id and myroledbo2_.active = 1<br> where <br> and myuserdbo0_.id=?<br>{code}<br></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> <br></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br>BTW: createCriteria with ManyToMany association and Filter creates the correct SQL.<br><br>Example DBOs:<br></span> <span class="diffcontext">{code:java}<br>@MappedSuperclass<br>public abstract class AbstractMyDBO implements Serializable {<br><br> @Id<br> @GeneratedValue(strategy = GenerationType.SEQUENCE, generator = SequenceName.GENERATOR)<br> @SequenceGenerator(name = SequenceName.GENERATOR, sequenceName = SequenceName.SEQUENCE)<br> private Integer id;<br> ...<br>}<br>{code}<br><br><br>{code:java}<br>@Entity<br>@Table(name = "MYUSER")<br>@FilterDef(name = "activeUserFilter", defaultCondition = "active = 1")<br>@Filter(name = "activeUserFilter")<br>public class MyUserDBO extends AbstractMyDBO {<br><br> private String name;<br><br> private int active;<br><br> @ManyToMany()<br> @Fetch(FetchMode.JOIN)<br> @Filter(name = "activeRoleFilter")<br> private Set<MyRoleDBO> roles;<br> ...<br>}<br>{code}<br><br><br>{code:java}<br>@Entity<br>@Table(name = "MYROLE")<br>@FilterDef(name = "activeRoleFilter", defaultCondition = "active = 1")<br>@Filter(name = "activeRoleFilter")<br>public class MyRoleDBO extends AbstractMyDBO {<br><br> private String name;<br><br> private int active;<br> ...<br>}<br>{code}<br><br></span> <span class="diffaddedchars" style="background-color:#ddfade;">Example Test using above DBOs: testManyToManyFilterGet fails, while testManyToManyFilterGetAll succeeds.<br></span> <span class="diffcontext">{code:java}<br>public class HibernateFilterTest extends ... {<br><br> @Autowired<br> private TransactionTemplate transactionTemplate;<br><br> @Autowired<br> private SessionFactory sessionFactory;<br><br> @Test<br> public void testManyToManyFilterGet() {<br> final List<MyUserDBO> users = new ArrayList<>();<br> final List<MyRoleDBO> roles = new ArrayList<>();<br> this.doInTransaction(() -> {<br> roles.add(this.save(this.role("R1", false)));<br> roles.add(this.save(this.role("R2", false)));<br> users.add(this.save(this.user("A", true, roles.get(0), roles.get(1))));<br> });<br> this.doInTransaction(() -> {<br> final MyUserDBO dbUser = this.get(MyUserDBO.class, users.get(0).getId());<br> Assert.assertNotNull(dbUser);<br> Assert.assertThat(dbUser.getRoles(), Matchers.empty());<br> });<br> }<br><br> @Test<br> public void testManyToManyFilterGetAll() {<br> final List<MyUserDBO> users = new ArrayList<>();<br> final List<MyRoleDBO> roles = new ArrayList<>();<br> this.doInTransaction(() -> {<br> roles.add(this.save(this.role("R1", false)));<br> roles.add(this.save(this.role("R2", false)));<br> users.add(this.save(this.user("A", true, roles.get(0), roles.get(1))));<br> });<br> this.doInTransaction(() -> {<br> final List<MyUserDBO> dbUsers = this.getAll(MyUserDBO.class);<br> Assert.assertNotNull(dbUsers);<br> Assert.assertThat(dbUsers.size(), Matchers.is(1));<br> Assert.assertThat(dbUsers.get(0).getRoles(), Matchers.empty());<br> });<br> }<br><br> private void doInTransaction(final Runnable r) {<br> this.transactionTemplate.execute(new TransactionCallback<Object>() {<br> @Override<br> public Object doInTransaction(final TransactionStatus status) {<br> r.run();<br> return null;<br> }<br> });<br> }<br><br> private Session getSession() {<br> final Session session = this.sessionFactory.getCurrentSession();<br> session.enableFilter("activeUserFilter");<br> session.enableFilter("activeRoleFilter");<br> return session;<br> }<br><br> private <T extends AbstractMyDBO> T save(final T dbo) {<br> this.getSession().save(dbo);<br> return dbo;<br> }<br><br> @SuppressWarnings("unchecked")<br> private <T> T get(final Class<T> clazz, final Serializable id) {<br> return (T) this.getSession().get(clazz, id);<br> }<br><br> @SuppressWarnings("unchecked")<br> private <T> List<T> getAll(final Class<T> clazz) {<br> return this.getSession().createCriteria(clazz).setResultTransformer(Criteria.DISTINCT_ROOT_ENTITY).list();<br> }<br><br> private MyUserDBO user(final String name, final boolean active, final MyRoleDBO... roles) {<br> final MyUserDBO user = new MyUserDBO();<br> user.setName(name);<br> user.setActive(active ? 1 : 0);<br> user.setRoles(new HashSet<>(Arrays.asList(roles)));<br> return user;<br> }<br><br> private MyRoleDBO role(final String name, final boolean active) {<br> final MyRoleDBO role = new MyRoleDBO();<br> role.setName(name);<br> role.setActive(active ? 1 : 0);<br> return role;<br> }<br>}<br>{code}<br><br></span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff"> <script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"description": "View Issue",
"potentialAction": {
"@type": "ViewAction",
"target": "https://hibernate.atlassian.net/browse/HHH-11410?inbox=true&",
"name": "View Issue"
},
"publisher": {
"@type": "Organization",
"name": "Atlassian",
"url": "https://www.atlassian.com"
}
}
</script>
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-11410#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-3629936e-f553-401f-8bf7-bb162c0e11f2" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-11410#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian JIRA <span id="footer-build-information">(v1000.695.1#100025-<span title="c4480eba7ce76938eaf9fa97abdfbc002f0adc9d" data-commit-id="c4480eba7ce76938eaf9fa97abdfbc002f0adc9d}">sha1:c4480eb</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-e513cd76-11e3-4646-87e7-a1f6859363f0" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>