<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://secure.gravatar.com/avatar/d6fe1e540a78fd076a574815e5d9c74e?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="avallen" id="email_avallen" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=avallen" style="color:#6c797f;; color: #3b73af; text-decoration: none">Andreas Vallen</a> <strong>commented</strong> on <a href="https://hibernate.atlassian.net/browse/HHH-10574" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-4fd7ea12-127f-4a4b-8673-70b961742566" height="16" width="16" border="0" align="absmiddle" alt="Bug"> HHH-10574</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-10574" style="color: #3b73af; text-decoration: none">Re: In hibernate 5 Schema update re create foreign keys and unique keys against hibernate 4 DB</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; border-bottom: none; padding-bottom: 0" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <p style="margin: 10px 0 0; margin-top: 0">In hibernate 4.3 at least the <tt>ImplicitForeignKeyNameSource</tt> <em>does</em> actually give access to the list of referenced columns via <tt>org.hibernate.boot.model.naming.ImplicitForeignKeyNameSource#getReferencedColumnNames</tt> and similarly for unique key names in <tt>org.hibernate.boot.model.naming.ImplicitConstraintNameSource#getColumnNames</tt>.</p> <p style="margin: 10px 0 0">However the above code for generating key names is from hibernate 4.0, and hibernate 4.3 already had a different foreign key name generation algorithm, which was as follows, which is found in <tt>org.hibernate.mapping.Constraint#generateName(java.lang.String, org.hibernate.mapping.Table, org.hibernate.mapping.Column...)</tt>.</p> <p style="margin: 10px 0 0">In order to reproduce the hibernate 4.3 foreign and unique key naming strategy the following worked for me - added to a custom ImplicitNamingStrategy:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px; border-radius: 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
/**
* Following code <span class="code-keyword" style="color: #000091">implements</span> hibernate 4.3's constraint naming strategy, adapted from:
* org.hibernate.mapping.Constraint#generateName(java.lang.<span class="code-object" style="color: #910091">String</span>, org.hibernate.mapping.Table, org.hibernate.mapping.Column...)
*/
@Override
<span class="code-keyword" style="color: #000091">public</span> Identifier determineForeignKeyName(ImplicitForeignKeyNameSource source) {
List<<span class="code-object" style="color: #910091">String</span>> columnNames = source.getReferencedColumnNames().stream().map(i -> i.getText()).collect(Collectors.toList());
<span class="code-keyword" style="color: #000091">return</span> generateName(<span class="code-quote" style="color: #009100">"FK_"</span>, source.getTableName().getText(), columnNames);
}
@Override
<span class="code-keyword" style="color: #000091">public</span> Identifier determineUniqueKeyName(ImplicitUniqueKeyNameSource source) {
List<<span class="code-object" style="color: #910091">String</span>> columnNames = source.getColumnNames().stream().map(i -> i.getText()).collect(Collectors.toList());
<span class="code-keyword" style="color: #000091">return</span> generateName(<span class="code-quote" style="color: #009100">"UK_"</span>, source.getTableName().getText(), columnNames);
}
/**
* If a constraint is not explicitly named, <span class="code-keyword" style="color: #000091">this</span> is called to generate
* a unique hash using the table and column names.
* Static so the name can be generated prior to creating the Constraint.
* They're cached, keyed by name, in multiple locations.
*/
<span class="code-keyword" style="color: #000091">private</span> Identifier generateName(<span class="code-object" style="color: #910091">String</span> prefix, <span class="code-object" style="color: #910091">String</span> table, List<<span class="code-object" style="color: #910091">String</span>> columnNames) {
StringBuilder sb = <span class="code-keyword" style="color: #000091">new</span> StringBuilder( <span class="code-quote" style="color: #009100">"table`"</span> + table + <span class="code-quote" style="color: #009100">"`"</span> );
<span class="code-comment" style="color: #808080">// Ensure a consistent ordering of columns, regardless of the order
</span> <span class="code-comment" style="color: #808080">// they were bound.
</span> <span class="code-comment" style="color: #808080">// Clone the list, as sometimes a set of order-dependent Column
</span> <span class="code-comment" style="color: #808080">// bindings are given.
</span> columnNames.sort(<span class="code-object" style="color: #910091">String</span>::compareTo);
<span class="code-keyword" style="color: #000091">for</span> ( <span class="code-object" style="color: #910091">String</span> column : columnNames ) {
<span class="code-object" style="color: #910091">String</span> columnName = column == <span class="code-keyword" style="color: #000091">null</span> ? "" : column;
sb.append(<span class="code-quote" style="color: #009100">"column`"</span>).append(columnName).append(<span class="code-quote" style="color: #009100">"`"</span>);
}
<span class="code-keyword" style="color: #000091">return</span> <span class="code-keyword" style="color: #000091">new</span> Identifier(prefix + hashedName(sb.toString()).toUpperCase(), <span class="code-keyword" style="color: #000091">false</span>);
}
/**
* Hash a constraint name using MD5. Convert the MD5 digest to base 35
* (full alphanumeric), guaranteeing
* that the length of the name will always be smaller than the 30
* character identifier restriction enforced by a few dialects.
*/
<span class="code-keyword" style="color: #000091">public</span> <span class="code-keyword" style="color: #000091">static</span> <span class="code-object" style="color: #910091">String</span> hashedName(<span class="code-object" style="color: #910091">String</span> s) {
<span class="code-keyword" style="color: #000091">try</span> {
MessageDigest md = MessageDigest.getInstance( <span class="code-quote" style="color: #009100">"MD5"</span> );
md.reset();
md.update( s.getBytes() );
<span class="code-object" style="color: #910091">byte</span>[] digest = md.digest();
BigInteger bigInt = <span class="code-keyword" style="color: #000091">new</span> BigInteger( 1, digest );
<span class="code-comment" style="color: #808080">// By converting to base 35 (full alphanumeric), we guarantee
</span> <span class="code-comment" style="color: #808080">// that the length of the name will always be smaller than the 30
</span> <span class="code-comment" style="color: #808080">// character identifier restriction enforced by a few dialects.
</span> <span class="code-keyword" style="color: #000091">return</span> bigInt.toString( 35 );
}
<span class="code-keyword" style="color: #000091">catch</span> ( NoSuchAlgorithmException e ) {
<span class="code-keyword" style="color: #000091">throw</span> <span class="code-keyword" style="color: #000091">new</span> HibernateException( <span class="code-quote" style="color: #009100">"Unable to generate a hashed Constraint name!"</span>, e );
}
}
</pre>
</div>
</div> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff"> <script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"description": "View Issue",
"potentialAction": {
"@type": "ViewAction",
"target": "https://hibernate.atlassian.net/browse/HHH-10574?inbox=true&focusedCommentId=92004&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-92004",
"name": "View Comment"
},
"publisher": {
"@type": "Organization",
"name": "Atlassian",
"url": "https://www.atlassian.com"
}
}
</script>
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-10574#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-a4b399f0-9336-4772-ae65-83845b0c0b79" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-10574#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian JIRA <span id="footer-build-information">(v1000.844.1#100035-<span title="ca7c2ca47ad02c2098e956fffbf89820cc12f6d8" data-commit-id="ca7c2ca47ad02c2098e956fffbf89820cc12f6d8}">sha1:ca7c2ca</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-805361bc-058e-42b0-89a7-1c4f98a63de3" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>