<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://secure.gravatar.com/avatar/f87b69d5b7162593263f5e1eb3ca2202?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="cuipengfei" id="email_cuipengfei" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=cuipengfei" style="color:#6c797f;; color: #3b73af; text-decoration: none">Cui Pengfei</a> <strong>updated</strong> an issue </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="page-title-pattern-first-line " style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://hibernate.atlassian.net/browse/HHH" style="color: #3b73af; text-decoration: none">Hibernate ORM</a> / <a href="https://hibernate.atlassian.net/browse/HHH-11581" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-127e34f3-8f50-4392-bc7f-08ea8a6dbb4f" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom"></a> <a href="https://hibernate.atlassian.net/browse/HHH-11581" style="color: #3b73af; text-decoration: none">HHH-11581</a> </td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-11581" style="color: #3b73af; text-decoration: none">JPA AttributeConverter makes hibernate generate update statements on whole table in transaction</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 10px; padding-bottom: 5px" bgcolor="#ffffff">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Change By:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="cuipengfei" id="email_cuipengfei" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=cuipengfei" style="color:#6c797f;; color: #3b73af; text-decoration: none">Cui Pengfei</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 5px; padding-bottom: 10px" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <span class="diffcontext">All code in this post can be found here: https://github.com/cuipengfei/gs-accessing-data-jpa/tree/master/complete<br><br>You can run this test to reproduce the problem: https://github.com/cuipengfei/gs-accessing-data-jpa/blob/master/complete/src/test/java/hello/T1ServiceTest.java<br><br>I have a domain model:<br><br></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br>{code:java}<br></span> <span class="diffcontext">@Entity<br>@Table(name = "t1", schema = "test")<br>public class T1 extends BaseEntity {<br><br> @Column(nullable = false)<br> private UUID someField;<br><br> @Column()<br> private ZonedDateTime date;<br><br> public T1(UUID someField, ZonedDateTime date) {<br> this.someField = someField;<br> this.date = date;<br> }<br>}<br></span> <span class="diffaddedchars" style="background-color:#ddfade;">{code}<br><br></span> <span class="diffcontext">It has a field typed as ZonedDateTime, so I have a converter to convert it to sql time stamp:<br><br></span> <span class="diffaddedchars" style="background-color:#ddfade;">{code:java}<br><br></span> <span class="diffcontext">@Converter(autoApply = true)<br>public class ZonedDateTimeAttributeConverter<br> implements AttributeConverter<ZonedDateTime, Timestamp> {<br><br> @Override<br> public Timestamp convertToDatabaseColumn(ZonedDateTime entityValue) {<br> return (entityValue == null) ? null :<br> valueOf(entityValue.withZoneSameInstant(of("UTC")).toLocalDateTime());<br> }<br><br> @Override<br> public ZonedDateTime convertToEntityAttribute(Timestamp databaseValue) {<br> return (databaseValue == null) ? null : databaseValue.toLocalDateTime().atZone(<br> of("UTC"));<br> }<br>}<br></span> <span class="diffaddedchars" style="background-color:#ddfade;">{code}<br><br></span> <span class="diffcontext">When I try to create a lot of T1s in a transaction like this:<br><br></span> <span class="diffaddedchars" style="background-color:#ddfade;">{code:java}<br><br></span> <span class="diffcontext">@Service<br>public class T1Service {<br> private static final Logger log = LoggerFactory.getLogger(T1Service.class);<br><br> @Autowired<br> T1Repository t1Repository;<br><br> @Transactional<br> public void insertMany() {<br> for (int i = 0; i < 1000; i++) {<br> log.info("!!! " + (i + 1) + "th item start");<br><br> UUID randomUUID = UUID.randomUUID();<br> T1 foundT1 = tryToFindExistingT1(randomUUID);//certainly won't find<br><br> if (foundT1 == null) {<br> log.info("t1 not found");<br> ZonedDateTime date = now();<br> //date = null;<br> //if you enable the line above, there won't be any update statements anymore<br> //and find will also become faster<br> T1 t1 = new T1(randomUUID, date);<br> saveT1(t1);<br> }<br><br> log.info("!!! " + (i + 1) + "th item finished");<br> log.info("====================================");<br> }<br> }<br><br> private T1 tryToFindExistingT1(UUID someField) {<br> long start = currentTimeMillis();<br> T1 t1Id = t1Repository.findBySomeField(someField);<br> //as nth item increases, the line above will become very very slow<br> //and also, there will be more and more update statements<br> //but if you set date of t1 to null, update statement will disappear and it'll not be slow<br> log.info("find took: " + (currentTimeMillis() - start) + " milliseconds");<br> return t1Id;<br> }<br><br> private T1 saveT1(T1 t1) {<br> long start = currentTimeMillis();<br> T1 savedT1 = t1Repository.save(t1);<br> log.info("save took: " + (currentTimeMillis() - start) + " milliseconds");<br> return savedT1;<br> }<br><br>}<br></span> <span class="diffaddedchars" style="background-color:#ddfade;">{code}<br><br></span> <span class="diffcontext">There will be update statements generated by hibernate for the whole t1 table.<br><br>Here is the log for the first a few rounds of the for loop:<br><br></span> <span class="diffaddedchars" style="background-color:#ddfade;">{code:java}<br><br></span> <span class="diffcontext">2017-03-20 17:51:54.039 INFO 74789 --- [ main] hello.T1Service : !!! 1th item start<br>2017-03-20 17:51:54.052 INFO 74789 --- [ main] o.h.h.i.QueryTranslatorFactoryInitiator : HHH000397: Using ASTQueryTranslatorFactory<br>Hibernate: select t1x0_.id as id1_0_, t1x0_.date as date2_0_, t1x0_.some_field as some_fie3_0_ from test.t1 t1x0_ where t1x0_.some_field=?<br>2017-03-20 17:51:54.154 INFO 74789 --- [ main] hello.T1Service : find took: 114 milliseconds<br>2017-03-20 17:51:54.154 INFO 74789 --- [ main] hello.T1Service : t1 not found<br>2017-03-20 17:51:54.177 INFO 74789 --- [ main] hello.T1Service : save took: 15 milliseconds<br>2017-03-20 17:51:54.177 INFO 74789 --- [ main] hello.T1Service : !!! 1th item finished<br>2017-03-20 17:51:54.177 INFO 74789 --- [ main] hello.T1Service : ====================================<br>2017-03-20 17:51:54.177 INFO 74789 --- [ main] hello.T1Service : !!! 2th item start<br>Hibernate: insert into test.t1 (date, some_field, id) values (?, ?, ?)<br>Hibernate: update test.t1 set date=?, some_field=? where id=?<br>Hibernate: select t1x0_.id as id1_0_, t1x0_.date as date2_0_, t1x0_.some_field as some_fie3_0_ from test.t1 t1x0_ where t1x0_.some_field=?<br>2017-03-20 17:51:54.194 INFO 74789 --- [ main] hello.T1Service : find took: 17 milliseconds<br>2017-03-20 17:51:54.194 INFO 74789 --- [ main] hello.T1Service : t1 not found<br>2017-03-20 17:51:54.195 INFO 74789 --- [ main] hello.T1Service : save took: 1 milliseconds<br>2017-03-20 17:51:54.195 INFO 74789 --- [ main] hello.T1Service : !!! 2th item finished<br>2017-03-20 17:51:54.195 INFO 74789 --- [ main] hello.T1Service : ====================================<br>2017-03-20 17:51:54.195 INFO 74789 --- [ main] hello.T1Service : !!! 3th item start<br>Hibernate: insert into test.t1 (date, some_field, id) values (?, ?, ?)<br>Hibernate: update test.t1 set date=?, some_field=? where id=?<br>Hibernate: update test.t1 set date=?, some_field=? where id=?<br>Hibernate: select t1x0_.id as id1_0_, t1x0_.date as date2_0_, t1x0_.some_field as some_fie3_0_ from test.t1 t1x0_ where t1x0_.some_field=?<br>2017-03-20 17:51:54.200 INFO 74789 --- [ main] hello.T1Service : find took: 4 milliseconds<br>2017-03-20 17:51:54.200 INFO 74789 --- [ main] hello.T1Service : t1 not found<br>2017-03-20 17:51:54.200 INFO 74789 --- [ main] hello.T1Service : save took: 0 milliseconds<br>2017-03-20 17:51:54.200 INFO 74789 --- [ main] hello.T1Service : !!! 3th item finished<br>2017-03-20 17:51:54.200 INFO 74789 --- [ main] hello.T1Service : ====================================<br>2017-03-20 17:51:54.200 INFO 74789 --- [ main] hello.T1Service : !!! 4th item start<br>Hibernate: insert into test.t1 (date, some_field, id) values (?, ?, ?)<br>Hibernate: update test.t1 set date=?, some_field=? where id=?<br>Hibernate: update test.t1 set date=?, some_field=? where id=?<br>Hibernate: update test.t1 set date=?, some_field=? where id=?<br>Hibernate: select t1x0_.id as id1_0_, t1x0_.date as date2_0_, t1x0_.some_field as some_fie3_0_ from test.t1 t1x0_ where t1x0_.some_field=?<br>2017-03-20 17:51:54.209 INFO 74789 --- [ main] hello.T1Service : find took: 9 milliseconds<br>2017-03-20 17:51:54.209 INFO 74789 --- [ main] hello.T1Service : t1 not found<br>2017-03-20 17:51:54.210 INFO 74789 --- [ main] hello.T1Service : save took: 1 milliseconds<br>2017-03-20 17:51:54.210 INFO 74789 --- [ main] hello.T1Service : !!! 4th item finished<br>2017-03-20 17:51:54.210 INFO 74789 --- [ main] hello.T1Service : ====================================<br></span> <span class="diffaddedchars" style="background-color:#ddfade;">{code}<br><br></span> <span class="diffcontext">As you can see in the log, more and more update statements will be generated by hibernate.<br><br>It looks like the number of update statements is always same as how many rows of T1 waiting to be committed.<br><br>Now if I remove the converter, this problem goes away.<br><br>I can use hibernate-java8 lib instead of this converter to achieve the same effect, but why does this happen?<br><br>Why does JPA AttributeConverter make hibernate generate update statements on whole table in transaction?</span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff"> <script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"description": "View Issue",
"potentialAction": {
"@type": "ViewAction",
"target": "https://hibernate.atlassian.net/browse/HHH-11581?inbox=true&",
"name": "View Issue"
},
"publisher": {
"@type": "Organization",
"name": "Atlassian",
"url": "https://www.atlassian.com"
}
}
</script>
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-11581#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-aacd5548-67d7-46d0-9080-92cf9a7fad89" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-11581#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian JIRA <span id="footer-build-information">(v1000.844.1#100035-<span title="ca7c2ca47ad02c2098e956fffbf89820cc12f6d8" data-commit-id="ca7c2ca47ad02c2098e956fffbf89820cc12f6d8}">sha1:ca7c2ca</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-d4513a7b-16ef-474b-bb0d-c79be80e49e8" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>