<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://secure.gravatar.com/avatar/e744cb5ef7da1cde88a746117d5a1a52?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="Allan" id="email_Allan" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=Allan" style="color:#6c797f;; color: #3b73af; text-decoration: none">Jones</a> <strong>commented</strong> on <a href="https://hibernate.atlassian.net/browse/HHH-10677" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-eaba5188-394b-461c-98d6-0df62bd8d373" height="16" width="16" border="0" align="absmiddle" alt="Bug"> HHH-10677</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-10677" style="color: #3b73af; text-decoration: none">Re: ClusteredTimestampsRegionImpl: Local Timestamp cache is not updated right after cache.put(key, value)</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; border-bottom: none; padding-bottom: 0" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <p style="margin: 10px 0 0; margin-top: 0">I can now confirm it also happens in Hibernate 5.2.9.Final and Infinispan 8.2.6.Final.</p> <p style="margin: 10px 0 0">But I completely failed to isolate this issue in an isolated test case. In my acceptance tests it fails quite consistently.</p> <p style="margin: 10px 0 0">Our workaround is to use a custom timestamp region which makes sure the local cache is up-to-date before put method returns:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px; border-radius: 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
<span class="code-keyword" style="color: #000091">import</span> java.lang.reflect.Field;
<span class="code-keyword" style="color: #000091">import</span> java.util.Map;
<span class="code-keyword" style="color: #000091">import</span> org.hibernate.cache.CacheException;
<span class="code-keyword" style="color: #000091">import</span> org.hibernate.cache.infinispan.InfinispanRegionFactory;
<span class="code-keyword" style="color: #000091">import</span> org.hibernate.cache.infinispan.timestamp.ClusteredTimestampsRegionImpl;
<span class="code-keyword" style="color: #000091">import</span> org.hibernate.engine.spi.SharedSessionContractImplementor;
<span class="code-keyword" style="color: #000091">import</span> org.infinispan.AdvancedCache;
<span class="code-keyword" style="color: #000091">import</span> org.infinispan.notifications.Listener;
/**
* See https:<span class="code-comment" style="color: #808080">//hibernate.atlassian.net/browse/HHH-10677
</span> * In a cluster environment, the timestamp cache is updated asynchronously, even <span class="code-keyword" style="color: #000091">for</span> operations that happens in the same
* node. This is a <span class="code-quote" style="color: #009100">"hack"</span> to make sure the timestamp local cache is always up-to-date in the node that originated the call.
*
* This will ensure that a cached query will <span class="code-keyword" style="color: #000091">return</span> the correct results just after the flush() was called.
*/
@Listener
<span class="code-keyword" style="color: #000091">public</span> <span class="code-keyword" style="color: #000091">class </span>CustomClusteredTimestampsRegionImpl <span class="code-keyword" style="color: #000091">extends</span> ClusteredTimestampsRegionImpl {
<span class="code-keyword" style="color: #000091">private</span> <span class="code-keyword" style="color: #000091">final</span> Map localCache = retrieveLocalCacheFieldValue(<span class="code-keyword" style="color: #000091">this</span>);
<span class="code-keyword" style="color: #000091">public</span> CustomClusteredTimestampsRegionImpl(AdvancedCache cache, <span class="code-object" style="color: #910091">String</span> name, InfinispanRegionFactory factory) {
<span class="code-keyword" style="color: #000091">super</span>(cache, name, factory);
}
<span class="code-keyword" style="color: #000091">private</span> <span class="code-keyword" style="color: #000091">static</span> Map retrieveLocalCacheFieldValue(ClusteredTimestampsRegionImpl target) {
<span class="code-keyword" style="color: #000091">try</span> {
Field field = ClusteredTimestampsRegionImpl.<span class="code-keyword" style="color: #000091">class.</span>getDeclaredField(<span class="code-quote" style="color: #009100">"localCache"</span>);
field.setAccessible(<span class="code-keyword" style="color: #000091">true</span>);
<span class="code-keyword" style="color: #000091">return</span> (Map) field.get(target);
} <span class="code-keyword" style="color: #000091">catch</span> (NoSuchFieldException | SecurityException | IllegalAccessException e) {
<span class="code-keyword" style="color: #000091">throw</span> <span class="code-keyword" style="color: #000091">new</span> ExceptionInInitializerError(e);
}
}
@Override
<span class="code-keyword" style="color: #000091">public</span> void put(SharedSessionContractImplementor session, <span class="code-keyword" style="color: #000091">final</span> <span class="code-object" style="color: #910091">Object</span> key, <span class="code-keyword" style="color: #000091">final</span> <span class="code-object" style="color: #910091">Object</span> value) <span class="code-keyword" style="color: #000091">throws</span> CacheException {
<span class="code-keyword" style="color: #000091">super</span>.put(session, key, value);
localCache.put(key, value);
}
}
</pre>
</div>
</div> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff"> <script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"description": "View Issue",
"potentialAction": {
"@type": "ViewAction",
"target": "https://hibernate.atlassian.net/browse/HHH-10677?inbox=true&focusedCommentId=92300&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-92300",
"name": "View Comment"
},
"publisher": {
"@type": "Organization",
"name": "Atlassian",
"url": "https://www.atlassian.com"
}
}
</script>
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-10677#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-2442cc01-e84c-41e3-a390-e975c64824cf" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-10677#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian JIRA <span id="footer-build-information">(v1000.867.1#100039-<span title="c4637520e67acc33d41ac99673114e1cb4831627" data-commit-id="c4637520e67acc33d41ac99673114e1cb4831627}">sha1:c463752</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-9bfe3c84-f8d3-492a-b809-4afcfd3b8102" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>