<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="cid:jira-generated-image-avatar-03cf3132-26f5-46ed-995b-3dd9887f376b" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="crancran" id="email_crancran" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=crancran" style="color:#6c797f;; color: #3b73af; text-decoration: none">Chris Cranford</a> <strong>commented</strong> on <a href="https://hibernate.atlassian.net/browse/HHH-8058" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-18e31ef2-5bc5-4fca-b346-fbeec9416361" height="16" width="16" border="0" align="absmiddle" alt="New Feature"> HHH-8058</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-8058" style="color: #3b73af; text-decoration: none">Re: Querying property-level revisions</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; border-bottom: none; padding-bottom: 0" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <p style="margin: 10px 0 0; margin-top: 0">This is the query stubs I am proposing for Hibernate Envers 6.0:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px; border-radius: 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
/**
         * Creates a query that selects the revisions at which the given entity was modified. Unless a
         * projection is set, the result will be a list of 4-element arrays, containing the following:
         * <ol>
         * <li>The entity instance</li>
         * <li>Revision entity, corresponding to the revision where the entity was modified. If no custom
         * revision entit yis used, <span class="code-keyword" style="color: #000091">this</span> will be an instance of {@link org.hibernate.envers.DefaultRevisionEntity}.</li>
         * <li>The revision type, an <span class="code-keyword" style="color: #000091">enum</span> of class {@link org.hibernate.envers.RevisionType}.</li>
         * <li>The names of the properties changed in <span class="code-keyword" style="color: #000091">this</span> revision</li>
         * </ol>
         * Additional criterion may be specified to filter the result set.
         *
         * @param clazz <span class="code-object" style="color: #910091">Class</span> of the entities <span class="code-keyword" style="color: #000091">for</span> which to query.
         * @param selectDeletedEntities If <span class="code-keyword" style="color: #000091">true</span>, the result set will include revisions where entities were deleted.
         *
         * @<span class="code-keyword" style="color: #000091">return</span> the audit query
         */
        @Incubating(since = <span class="code-quote" style="color: #009100">"6.0"</span>)
        <span class="code-keyword" style="color: #000091">public</span> AuditQuery forRevisionsOfEntityWithChanges(<span class="code-object" style="color: #910091">Class</span><?> clazz, <span class="code-object" style="color: #910091">boolean</span> selectDeletedEntities);
        /**
         * Creates a query that selects the revisions at which the given entity was modified. Unless a
         * projection is set, the result will be a list of 4-element arrays, containing the following:
         * <ol>
         * <li>The entity instance</li>
         * <li>Revision entity, corresponding to the revision where the entity was modified. If no custom
         * revision entit yis used, <span class="code-keyword" style="color: #000091">this</span> will be an instance of {@link org.hibernate.envers.DefaultRevisionEntity}.</li>
         * <li>The revision type, an <span class="code-keyword" style="color: #000091">enum</span> of class {@link org.hibernate.envers.RevisionType}.</li>
         * <li>The names of the properties changed in <span class="code-keyword" style="color: #000091">this</span> revision</li>
         * </ol>
         * Additional criterion may be specified to filter the result set.
         *
         * @param clazz <span class="code-object" style="color: #910091">Class</span> of the entities <span class="code-keyword" style="color: #000091">for</span> which to query.
         * @param entityName Name of the entity (<span class="code-keyword" style="color: #000091">if</span> it can't be guessed basing on the {@code clazz}).
         * @param selectDeletedEntities If <span class="code-keyword" style="color: #000091">true</span>, the result set will include revisions where entities were deleted.
         *
         * @<span class="code-keyword" style="color: #000091">return</span> the audit query
         */
        @Incubating(since = <span class="code-quote" style="color: #009100">"6.0"</span>)
        <span class="code-keyword" style="color: #000091">public</span> AuditQuery forRevisionsOfEntityWithChanges(<span class="code-object" style="color: #910091">Class</span><?> clazz, <span class="code-object" style="color: #910091">String</span> entityName, <span class="code-object" style="color: #910091">boolean</span> selectDeletedEntities);
</pre>
</div>
</div> <p style="margin: 10px 0 0">The property change names will require that the entity class identified by <tt>clazz</tt> support the use of the modified-flags feature. </p> <p style="margin: 10px 0 0">The original request stated to capture property names changed during all state changes; however its safe to assume that all properties changed during the add operation and none of them changed during a remove operation. Therefore, the API presently will only return property changes for update operations and not for the other two. </p> <p style="margin: 10px 0 0">The API is marked <tt>@Incubating</tt> so its free to change from release to release (this includes dot releases) until we deem it stable, so any input is greatly welcomed. </p> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff"> <script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"description": "View Issue",
"potentialAction": {
"@type": "ViewAction",
"target": "https://hibernate.atlassian.net/browse/HHH-8058?inbox=true&focusedCommentId=93107&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-93107",
"name": "View Comment"
},
"publisher": {
"@type": "Organization",
"name": "Atlassian",
"url": "https://www.atlassian.com"
}
}
</script>
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-8058#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-e37a23f5-9bc7-4789-8622-ee6ede84f996" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-8058#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian JIRA <span id="footer-build-information">(v1000.892.1#100040-<span title="1f62bbb903b64f8ba280ac537f75e9dbb3fc3406" data-commit-id="1f62bbb903b64f8ba280ac537f75e9dbb3fc3406}">sha1:1f62bbb</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-5234980a-c1cf-4ee6-8a9a-8b2a0e827f21" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>