<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://secure.gravatar.com/avatar/d6fe1e540a78fd076a574815e5d9c74e?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="avallen" id="email_avallen" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=avallen" style="color:#6c797f;; color: #3b73af; text-decoration: none">Andreas Vallen</a> <strong>commented</strong> on <a href="https://hibernate.atlassian.net/browse/HHH-10574" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-f350a5e7-7dc3-4149-9046-8fc802dd6363" height="16" width="16" border="0" align="absmiddle" alt="Bug"> HHH-10574</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-10574" style="color: #3b73af; text-decoration: none">Re: In hibernate 5 Schema update re create foreign keys and unique keys against hibernate 4 DB</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; border-bottom: none; padding-bottom: 0" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <p style="margin: 10px 0 0; margin-top: 0">As long as this remains unfixed, the following custom naming strategy is used successfully by us in order to replicate the naming EJB3NamingStrategy that we had used before.</p> <p style="margin: 10px 0 0">This is not necessarily an exact replication, but proved enough for our purposes.</p> <p style="margin: 10px 0 0">The above </p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px; border-radius: 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
/**
* Custom implicit naming strategy <span class="code-keyword" style="color: #000091">for</span> hibernate 5.
* <p/>
* Necessary because the <span class="code-keyword" style="color: #000091">new</span> hibernate version introduced <span class="code-keyword" style="color: #000091">new</span> semantics and <span class="code-keyword" style="color: #000091">new</span> interfaces and configuration of
* the naming strategy which is responsible <span class="code-keyword" style="color: #000091">for</span> the determination of the names of database objects (tables, fields,
* constraints, indices and others) that are not explicitly named.
* <p/>
* Unfortunately the <span class="code-keyword" style="color: #000091">new</span> naming strategies <span class="code-keyword" style="color: #000091">do</span> not replicate the exact same behaviour of each of the
* old ones - because the <span class="code-keyword" style="color: #000091">new</span> strategies use more context knowledge than the old ones which
* ignored some of it.
* <p/>
* The <span class="code-keyword" style="color: #000091">new</span> naming strategy that is closest to the EJB3NamingStrategy which we we used before is the
* ImplicitNamingStrategyLegacyJpaImpl (its javadoc says it corresponds <span class="code-quote" style="color: #009100">"roughly"</span> to it) which is what we use as
* a base <span class="code-keyword" style="color: #000091">for</span> further customization in order to work around some remaining differences.
*/
<span class="code-keyword" style="color: #000091">public</span> <span class="code-keyword" style="color: #000091">class </span>EJB3ImplicitNamingStrategy <span class="code-keyword" style="color: #000091">extends</span> ImplicitNamingStrategyLegacyJpaImpl {
/**
* the original strategy would use the table name which often is set explicitly (e.g. <span class="code-quote" style="color: #009100">"USERS"</span> <span class="code-keyword" style="color: #000091">for</span> the <span class="code-quote" style="color: #009100">"User"</span> class)
* but we need the original <span class="code-keyword" style="color: #000091">class </span>name which is what EJB3NamingStrategy seemingly was using (<span class="code-quote" style="color: #009100">"USER"</span> instead of <span class="code-quote" style="color: #009100">"USERS"</span>).
* <p/>
* Following code is copy of superclass which only changes <span class="code-keyword" style="color: #000091">this</span> detail.
*/
@Override
<span class="code-keyword" style="color: #000091">public</span> Identifier determineCollectionTableName(ImplicitCollectionTableNameSource source) {
<span class="code-object" style="color: #910091">String</span> owningClassName = source.getOwningEntityNaming().getClassName();
<span class="code-object" style="color: #910091">String</span> owningTableName = owningClassName.substring(owningClassName.lastIndexOf(<span class="code-quote" style="color: #009100">'.'</span>) + 1);
Identifier identifier = toIdentifier(
owningTableName + <span class="code-quote" style="color: #009100">"_"</span> + transformAttributePath(source.getOwningAttributePath()),
source.getBuildingContext()
);
<span class="code-keyword" style="color: #000091">if</span> (source.getOwningPhysicalTableName().isQuoted()) {
identifier = Identifier.quote(identifier);
}
<span class="code-keyword" style="color: #000091">return</span> identifier;
}
/**
* Same as above, base <span class="code-keyword" style="color: #000091">new</span> identifier on <span class="code-keyword" style="color: #000091">class </span>name instead of declared table name. Again copied
* and changed code from superclass.
*/
@Override
<span class="code-keyword" style="color: #000091">public</span> Identifier determineJoinColumnName(ImplicitJoinColumnNameSource source) {
<span class="code-keyword" style="color: #000091">final</span> <span class="code-object" style="color: #910091">String</span> name;
<span class="code-keyword" style="color: #000091">if</span> (source.getNature() == ImplicitJoinColumnNameSource.Nature.ELEMENT_COLLECTION
|| source.getAttributePath() == <span class="code-keyword" style="color: #000091">null</span>) {
<span class="code-object" style="color: #910091">String</span> referencedClassName = source.getEntityNaming().getClassName();
<span class="code-object" style="color: #910091">String</span> referencedTableName = referencedClassName.substring(referencedClassName.lastIndexOf(<span class="code-quote" style="color: #009100">'.'</span>) + 1);
name = referencedTableName
+ <span class="code-quote" style="color: #009100">'_'</span>
+ source.getReferencedColumnName().getText();
} <span class="code-keyword" style="color: #000091">else</span> {
name = transformAttributePath(source.getAttributePath())
+ <span class="code-quote" style="color: #009100">'_'</span>
+ source.getReferencedColumnName().getText();
}
<span class="code-keyword" style="color: #000091">return</span> toIdentifier(name, source.getBuildingContext());
}
/**
* Replicate hibernate 4.3's constraint naming strategy in EJBNamingStrategy, which differs in the following
* ways:
* - include underscore between prefix and hash value
* - prefix unique indices also with UK_ instead of IDX_
* - <span class="code-keyword" style="color: #000091">do</span> not include the referenced table name in the hash value generation <span class="code-keyword" style="color: #000091">for</span> foreign keys (<span class="code-keyword" style="color: #000091">do</span> not use
* generateHashedFkName method but instead stay with generateHashedConstraintName).
*/
@Override
<span class="code-keyword" style="color: #000091">public</span> Identifier determineForeignKeyName(ImplicitForeignKeyNameSource source) {
<span class="code-keyword" style="color: #000091">return</span> generateHashedConstraintName(source, <span class="code-quote" style="color: #009100">"FK_"</span>);
}
@Override
<span class="code-keyword" style="color: #000091">public</span> Identifier determineUniqueKeyName(ImplicitUniqueKeyNameSource source) {
<span class="code-keyword" style="color: #000091">return</span> generateHashedConstraintName(source, <span class="code-quote" style="color: #009100">"UK_"</span>);
}
@Override
<span class="code-keyword" style="color: #000091">public</span> Identifier determineIndexName(ImplicitIndexNameSource source) {
<span class="code-keyword" style="color: #000091">return</span> generateHashedConstraintName(source, <span class="code-quote" style="color: #009100">"UK_"</span>);
}
<span class="code-keyword" style="color: #000091">private</span> Identifier generateHashedConstraintName(ImplicitConstraintNameSource source, <span class="code-object" style="color: #910091">String</span> prefix) {
<span class="code-keyword" style="color: #000091">return</span> toIdentifier(
NamingHelper.INSTANCE.generateHashedConstraintName(
prefix,
source.getTableName(),
source.getColumnNames()
),
source.getBuildingContext()
);
}
}
</pre>
</div>
</div> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff"> <script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"description": "View Issue",
"potentialAction": {
"@type": "ViewAction",
"target": "https://hibernate.atlassian.net/browse/HHH-10574?inbox=true&focusedCommentId=94600&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-94600",
"name": "View Comment"
},
"publisher": {
"@type": "Organization",
"name": "Atlassian",
"url": "https://www.atlassian.com"
}
}
</script>
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-10574#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-6a354ce0-35df-4899-9c2b-567e2b8f3d8f" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-10574#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian JIRA <span id="footer-build-information">(v1000.1010.1#100044-<span title="669d9b4c7ef31d2dc83da83b215f0403dc644ee9" data-commit-id="669d9b4c7ef31d2dc83da83b215f0403dc644ee9}">sha1:669d9b4</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-4fe99901-61ae-4598-9606-7855f8b57bfa" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>