<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://avatar-cdn.atlassian.com/2d08b9a73e22d20401282aa1c8d66102?s=48&d=https%3A%2F%2Fhibernate.atlassian.net%2Fsecure%2Fuseravatar%3FownerId%3Dcrancran%26avatarId%3D18440%26noRedirect%3Dtrue" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="crancran" id="email_crancran" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=crancran" style="color:#6c797f;; color: #3b73af; text-decoration: none">Chris Cranford</a> <strong>commented</strong> on <a href="https://hibernate.atlassian.net/browse/HHH-11968" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-e167c0c3-84b4-4257-a72a-cc59860a14d9" height="16" width="16" border="0" align="absmiddle" alt="Bug"> HHH-11968</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-11968" style="color: #3b73af; text-decoration: none">Re: Map element columns are added to audit table's primary key unnecessarily.</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; border-bottom: none; padding-bottom: 0" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <p style="margin: 10px 0 0; margin-top: 0">After doing a bit more research, I see why Envers elected to use the map-values as part of the PK.</p> <p style="margin: 10px 0 0">Lets consider the following element collection mapping:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px; border-radius: 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
@ElementCollection
<span class="code-keyword" style="color: #000091">private</span> Map<OtherEntity, SomeEnum> theMap;
</pre>
</div>
</div> <p style="margin: 10px 0 0">We would ultimately have a middle table that would look something like this (where fields marked with <tt>*</tt> represent the PK):</p>
<div class="table-wrap">
<table class="confluenceTable" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-collapse: collapse; margin: 5px 0 5px 2px; width: auto">
<tbody>
<tr>
<th class="confluenceTh" style="border: 1px solid #cccccc; background: #f5f5f5; padding: 3px 4px; text-align: center; font: bold 14px/20px Arial, sans-serif">SomeEntity_id *</th>
<th class="confluenceTh" style="border: 1px solid #cccccc; background: #f5f5f5; padding: 3px 4px; text-align: center; font: bold 14px/20px Arial, sans-serif">theMap_KEY *</th>
<th class="confluenceTh" style="border: 1px solid #cccccc; background: #f5f5f5; padding: 3px 4px; text-align: center; font: bold 14px/20px Arial, sans-serif">theMap *</th>
<th class="confluenceTh" style="border: 1px solid #cccccc; background: #f5f5f5; padding: 3px 4px; text-align: center; font: bold 14px/20px Arial, sans-serif">REV *</th>
<th class="confluenceTh" style="border: 1px solid #cccccc; background: #f5f5f5; padding: 3px 4px; text-align: center; font: bold 14px/20px Arial, sans-serif">REVTYPE</th>
</tr>
</tbody>
</table>
</div> <p style="margin: 10px 0 0">Let us assume our owning entity, <tt>SomeEntity</tt> has a PK of <tt>1</tt> and our <tt>SomeEnum</tt> has a value-set of A and B. If we insert into the above map <tt>OtherEntity</tt> with PK of <tt>2</tt> with <tt>SomeEnum.A</tt>, the table would consist of the following state:</p>
<div class="table-wrap">
<table class="confluenceTable" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-collapse: collapse; margin: 5px 0 5px 2px; width: auto">
<tbody>
<tr>
<th class="confluenceTh" style="border: 1px solid #cccccc; background: #f5f5f5; padding: 3px 4px; text-align: center; font: bold 14px/20px Arial, sans-serif">SomeEntity_id *</th>
<th class="confluenceTh" style="border: 1px solid #cccccc; background: #f5f5f5; padding: 3px 4px; text-align: center; font: bold 14px/20px Arial, sans-serif">theMap_KEY *</th>
<th class="confluenceTh" style="border: 1px solid #cccccc; background: #f5f5f5; padding: 3px 4px; text-align: center; font: bold 14px/20px Arial, sans-serif">theMap *</th>
<th class="confluenceTh" style="border: 1px solid #cccccc; background: #f5f5f5; padding: 3px 4px; text-align: center; font: bold 14px/20px Arial, sans-serif">REV *</th>
<th class="confluenceTh" style="border: 1px solid #cccccc; background: #f5f5f5; padding: 3px 4px; text-align: center; font: bold 14px/20px Arial, sans-serif">REVTYPE</th>
</tr>
<tr>
<td class="confluenceTd" style="padding: 0; border-collapse: collapse; border: 1px solid #cccccc; padding: 3px 4px; font: normal 14px/20px Arial, sans-serif">1</td>
<td class="confluenceTd" style="padding: 0; border-collapse: collapse; border: 1px solid #cccccc; padding: 3px 4px; font: normal 14px/20px Arial, sans-serif">2</td>
<td class="confluenceTd" style="padding: 0; border-collapse: collapse; border: 1px solid #cccccc; padding: 3px 4px; font: normal 14px/20px Arial, sans-serif">A</td>
<td class="confluenceTd" style="padding: 0; border-collapse: collapse; border: 1px solid #cccccc; padding: 3px 4px; font: normal 14px/20px Arial, sans-serif">1</td>
<td class="confluenceTd" style="padding: 0; border-collapse: collapse; border: 1px solid #cccccc; padding: 3px 4px; font: normal 14px/20px Arial, sans-serif">0</td>
</tr>
</tbody>
</table>
</div> <p style="margin: 10px 0 0">In the next transaction, we decide to change the associated <tt>SomeEnum</tt> value with <tt>OtherEntity#2</tt> from <tt>A</tt> to <tt>B</tt>.</p>
<div class="table-wrap">
<table class="confluenceTable" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-collapse: collapse; margin: 5px 0 5px 2px; width: auto">
<tbody>
<tr>
<th class="confluenceTh" style="border: 1px solid #cccccc; background: #f5f5f5; padding: 3px 4px; text-align: center; font: bold 14px/20px Arial, sans-serif">SomeEntity_id *</th>
<th class="confluenceTh" style="border: 1px solid #cccccc; background: #f5f5f5; padding: 3px 4px; text-align: center; font: bold 14px/20px Arial, sans-serif">theMap_KEY *</th>
<th class="confluenceTh" style="border: 1px solid #cccccc; background: #f5f5f5; padding: 3px 4px; text-align: center; font: bold 14px/20px Arial, sans-serif">theMap *</th>
<th class="confluenceTh" style="border: 1px solid #cccccc; background: #f5f5f5; padding: 3px 4px; text-align: center; font: bold 14px/20px Arial, sans-serif">REV *</th>
<th class="confluenceTh" style="border: 1px solid #cccccc; background: #f5f5f5; padding: 3px 4px; text-align: center; font: bold 14px/20px Arial, sans-serif">REVTYPE</th>
</tr>
<tr>
<td class="confluenceTd" style="padding: 0; border-collapse: collapse; border: 1px solid #cccccc; padding: 3px 4px; font: normal 14px/20px Arial, sans-serif">1</td>
<td class="confluenceTd" style="padding: 0; border-collapse: collapse; border: 1px solid #cccccc; padding: 3px 4px; font: normal 14px/20px Arial, sans-serif">2</td>
<td class="confluenceTd" style="padding: 0; border-collapse: collapse; border: 1px solid #cccccc; padding: 3px 4px; font: normal 14px/20px Arial, sans-serif">A</td>
<td class="confluenceTd" style="padding: 0; border-collapse: collapse; border: 1px solid #cccccc; padding: 3px 4px; font: normal 14px/20px Arial, sans-serif">1</td>
<td class="confluenceTd" style="padding: 0; border-collapse: collapse; border: 1px solid #cccccc; padding: 3px 4px; font: normal 14px/20px Arial, sans-serif">0</td>
</tr>
<tr>
<td class="confluenceTd" style="padding: 0; border-collapse: collapse; border: 1px solid #cccccc; padding: 3px 4px; font: normal 14px/20px Arial, sans-serif">1</td>
<td class="confluenceTd" style="padding: 0; border-collapse: collapse; border: 1px solid #cccccc; padding: 3px 4px; font: normal 14px/20px Arial, sans-serif">2</td>
<td class="confluenceTd" style="padding: 0; border-collapse: collapse; border: 1px solid #cccccc; padding: 3px 4px; font: normal 14px/20px Arial, sans-serif">A</td>
<td class="confluenceTd" style="padding: 0; border-collapse: collapse; border: 1px solid #cccccc; padding: 3px 4px; font: normal 14px/20px Arial, sans-serif">2</td>
<td class="confluenceTd" style="padding: 0; border-collapse: collapse; border: 1px solid #cccccc; padding: 3px 4px; font: normal 14px/20px Arial, sans-serif">2</td>
</tr>
<tr>
<td class="confluenceTd" style="padding: 0; border-collapse: collapse; border: 1px solid #cccccc; padding: 3px 4px; font: normal 14px/20px Arial, sans-serif">1</td>
<td class="confluenceTd" style="padding: 0; border-collapse: collapse; border: 1px solid #cccccc; padding: 3px 4px; font: normal 14px/20px Arial, sans-serif">2</td>
<td class="confluenceTd" style="padding: 0; border-collapse: collapse; border: 1px solid #cccccc; padding: 3px 4px; font: normal 14px/20px Arial, sans-serif">B</td>
<td class="confluenceTd" style="padding: 0; border-collapse: collapse; border: 1px solid #cccccc; padding: 3px 4px; font: normal 14px/20px Arial, sans-serif">2</td>
<td class="confluenceTd" style="padding: 0; border-collapse: collapse; border: 1px solid #cccccc; padding: 3px 4px; font: normal 14px/20px Arial, sans-serif">1</td>
</tr>
</tbody>
</table>
</div> <p style="margin: 10px 0 0">One possible solution here may be to make use of <tt>REVTYPE</tt> to drive the difference in PK for the two rows rather than <tt>theMap</tt> map-value. We'll need to make some tests to verify this doesn't break any existing functionality and determine a strategy for how best to implement dealing with the schema change.</p> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff"> <script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"description": "View Issue",
"potentialAction": {
"@type": "ViewAction",
"target": "https://hibernate.atlassian.net/browse/HHH-11968?inbox=true&focusedCommentId=100138&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-100138",
"name": "View Comment"
},
"publisher": {
"@type": "Organization",
"name": "Atlassian",
"url": "https://www.atlassian.com"
}
}
</script>
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-11968#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-939684c2-256c-49b4-bdb1-294b7829324a" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-11968#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-mobile-separated-links" class="mobile-resize-text" width="100%" colspan="2" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> Get Jira notifications on your phone! Download the Jira Cloud app for <a href="https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail" style="color: #3b73af; text-decoration: none">Android</a> or <a href="https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8" style="color: #3b73af; text-decoration: none">iOS</a>
<hr> </td>
</tr>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian Jira <span id="footer-build-information">(v1001.0.0-SNAPSHOT#100066-<span title="b2cb24429f14542fa6c05a80e6ba25590ea54464" data-commit-id="b2cb24429f14542fa6c05a80e6ba25590ea54464}">sha1:b2cb244</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px; opacity: 0.150"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-5877b639-e805-46e3-90a5-0c897d893c51" alt="Atlassian logo" title="Atlassian logo" width="192" height="24" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
<img src="https://u4043402.ct.sendgrid.net/wf/open?upn=YNXLe5Uzuivj8jGpuXra04BSJ-2BS7raa1puTAtyVUP-2F0vngXMYTK-2FS3Irgj0Y-2FFD4BB9jvkzdPvl2cR24A8QBqeqma8cv4JrlLHs-2Br-2FLPmwz3tVvo8y6X22htRFK6S6sAzBoZZ0KGCOe3PZekREAbUqE9RkcKCwIqHCKpg-2BuIK8FBhjZTBwU5xmw9j-2FFv1zKRWepDTLjtSvpYNLngwgZDgSeAknGRsLRdO1ubwtcdgF0PrMys0vxzSF8Jn0vnVRA3" alt="" width="1" height="1" border="0" style="height:1px !important;width:1px !important;border-width:0 !important;margin-top:0 !important;margin-bottom:0 !important;margin-right:0 !important;margin-left:0 !important;padding-top:0 !important;padding-bottom:0 !important;padding-right:0 !important;padding-left:0 !important;"/>
</body>
</html>