<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://avatar-cdn.atlassian.com/df12d7792bd3b7be3a4edf12cabd58cb?s=48&d=https%3A%2F%2Fsecure.gravatar.com%2Favatar%2Fdf12d7792bd3b7be3a4edf12cabd58cb%3Fd%3Dmm%26s%3D48%26noRedirect%3Dtrue" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="steve" id="email_steve" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=steve" style="color:#6c797f;; color: #3b73af; text-decoration: none">Steve Ebersole</a> <strong>updated</strong> an issue </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="page-title-pattern-first-line " style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://hibernate.atlassian.net/browse/HHH" style="color: #3b73af; text-decoration: none">Hibernate ORM</a> / <a href="https://hibernate.atlassian.net/browse/HHH-12125" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-9b578789-0bed-4883-90af-9adc39194a58" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom"></a> <a href="https://hibernate.atlassian.net/browse/HHH-12125" style="color: #3b73af; text-decoration: none">HHH-12125</a> </td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-12125" style="color: #3b73af; text-decoration: none">Support @GeneratedValue without explicit generator definition</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 10px; padding-bottom: 5px" bgcolor="#ffffff">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Change By:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="steve" id="email_steve" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=steve" style="color:#6c797f;; color: #3b73af; text-decoration: none">Steve Ebersole</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 5px; padding-bottom: 10px" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <span class="diffcontext">Historically Hibernate always expects that {{@GeneratedValue}} is matched with a matching named "generator definition". The name is provided by {{GeneratedValue#generator}}. The corresponding "generator definition" would be a {{@GenericGenerator}}, {{@SequenceGenerator}} or {{@TableGenerator}} based on the value of {{GeneratedValue#strategy}}:<br><br>h3. {{SEQUENCE}} and {{TABLE}}<br><br>Given {{@GeneratedValue( strategy=SEQUENCE, ... )}} Hibernate would look for a matching {{@GenericGenerator}} or a {{@SequenceGenerator}}.<br>Given {{@GeneratedValue( strategy=TABLE, ... )}} Hibernate would look for a matching {{@GenericGenerator}} or a {{@TableGenerator}}.<br><br>Again, it would be an error if Hibernate did not find the matching {{@GenericGenerator}}, {{@SequenceGenerator}} or {{@TableGenerator}}. Ultimately though, these generator definitions are really just about handling non-default situations (e.g., use a specific increment size for a sequence/table, etc). But it should be ok for the user to leave them off and just get the "default behavior" (e.g. increment size of 50 as JPA defines for {{@SequenceGenerator}} and {{@TableGenerator}}).<br><br>*_NOTE: I will talk about SEQUENCE here, but the same holds true for TABLE_*<br><br>In other words, this should be a valid mapping:<br><br>{code}<br> @Id<br> @GeneratedValue( strategy = GenerationType.SEQUENCE, generator = "my_db_sequence" )<br> public Integer id;<br>{code}<br><br>Here we would pick up the JPA defined defaults (see {{@SequenceGenerator}} and {{@TableGenerator}} for the defined defaults). <br><br>The name is an additional discussion, and is the same discussion for:<br><br>{code}<br> @Id<br> @GeneratedValue( strategy = GenerationType.SEQUENCE, generator = "my_db_sequence" )<br> @SequenceGenerator( name = "my_db_sequence", initialValue = 100, allocationSize = 500 )<br> public Integer id;<br>{code}<br><br>In both cases we do not provide an explicit {{@SequenceGenerator#sequenceName}} value. Historically Hibernate interprets the default name for both sequence and table as {{"hibernate_sequence"}}. Ideally though (keeping with the theme of {{@SequenceGenerator}} and {{@TableGenerator}} defining just overrides) we'd want the sequence here to be named {{"my_db_sequence"}}.<br><br>So another part of the work here is to support</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> that. This is controlled</span> <span class="diffaddedchars" style="background-color:#ddfade;"> this distinction -</span> <span class="diffcontext"> by a</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> new</span> <span class="diffcontext"> setting {{hibernate.model.generator_name_as_sequence_name}}. By default, this is</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> false which means that</span> <span class="diffaddedchars" style="background-color:#ddfade;"> <br></span> <span class="diffcontext"> {{</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">"hibernate_sequence"</span> <span class="diffaddedchars" style="background-color:#ddfade;">true</span> <span class="diffcontext">}}</span> <span class="diffaddedchars" style="background-color:#ddfade;"> which means we</span> <span class="diffcontext"> will</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> be used for any case where</span> <span class="diffaddedchars" style="background-color:#ddfade;"> pick</span> <span class="diffcontext"> {{</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">@SequenceGenerator#sequenceName</span> <span class="diffaddedchars" style="background-color:#ddfade;">"my_db_sequence"</span> <span class="diffcontext">}}</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> or</span> <span class="diffaddedchars" style="background-color:#ddfade;"> (</span> <span class="diffcontext"> {{@</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">TableGenerator</span> <span class="diffaddedchars" style="background-color:#ddfade;">GeneratedValue</span> <span class="diffcontext">#</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">table</span> <span class="diffaddedchars" style="background-color:#ddfade;">generator</span> <span class="diffcontext">}}</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> is not specified. If this</span> <span class="diffaddedchars" style="background-color:#ddfade;">));</span> <span class="diffcontext"> setting</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> is enabled, we would instead use the value specified for</span> <span class="diffaddedchars" style="background-color:#ddfade;"> that to</span> <span class="diffcontext"> {{</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">@GeneratedValue#generator</span> <span class="diffaddedchars" style="background-color:#ddfade;">false</span> <span class="diffcontext">}}</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">.<br><br>*_NOTE: we might decide</span> <span class="diffaddedchars" style="background-color:#ddfade;"> indicates</span> <span class="diffcontext"> to</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> reverse this before releasing 5.3 such that</span> <span class="diffaddedchars" style="background-color:#ddfade;"> pick</span> <span class="diffcontext"> the</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> default is to use</span> <span class="diffaddedchars" style="background-color:#ddfade;"> legacy</span> <span class="diffcontext"> {{</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">@GeneratedValue#generator</span> <span class="diffaddedchars" style="background-color:#ddfade;">"hibernate_sequence"</span> <span class="diffcontext">}}</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> as the the sequence/table name_*</span> <span class="diffaddedchars" style="background-color:#ddfade;"> name.</span> <span class="diffcontext"><br><br></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"><br></span> <span class="diffcontext">h3. {{IDENTITY}}<br><br>This discussion has no bearing on how {{GenerationType#IDENTITY}} is handled.<br><br><br>h3. {{AUTO}}<br><br>In keeping with "less typing == better", this also covers some cases related to {{GenerationType#AUTO}} specifically in how {{org.hibernate.boot.model.IdGeneratorStrategyInterpreter#determineGeneratorName}} can operate. This work changes the "parameter object" passed in to that method to give it access to the {{@GeneratedValue#generator}} value. At the moment, this only case this is used is to handle:<br><br>{code}<br> @Id<br> @GeneratedValue( strategy = GenerationType.AUTO, generator = "increment" )<br> public Integer id;<br>{code}<br><br>Previously this mapping would not work. Instead a user would have to say:<br><br>{code}<br> @Id<br> @GeneratedValue( strategy = GenerationType.AUTO, generator = "increment" )<br> @GenericGenerator( name="increment", strategy="increment" )<br> public Integer id;<br>{code}<br><br>"increment" generator is a Hibernate-specific, in-memory strategy performing simple incrementing for generating id values. Specifically it is a short-name for Hibernate's {{org.hibernate.id.IncrementGenerator}}. Generally speaking there is little need to configure {{IncrementGenerator}}, so requiring the {{@GenericGenerator}} is unnecessary in most cases.<br></span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff"> <script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"description": "View Issue",
"potentialAction": {
"@type": "ViewAction",
"target": "https://hibernate.atlassian.net/browse/HHH-12125?inbox=true&",
"name": "View Issue"
},
"publisher": {
"@type": "Organization",
"name": "Atlassian",
"url": "https://www.atlassian.com"
}
}
</script>
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-12125#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-b3ac73cc-d4d6-4be2-9ebc-245d4d3ec5c6" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-12125#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-mobile-separated-links" class="mobile-resize-text" width="100%" colspan="2" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> Get Jira notifications on your phone! Download the Jira Cloud app for <a href="https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail" style="color: #3b73af; text-decoration: none">Android</a> or <a href="https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8" style="color: #3b73af; text-decoration: none">iOS</a>
<hr> </td>
</tr>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian Jira <span id="footer-build-information">(v1001.0.0-SNAPSHOT#100073-<span title="1f935842d4d343fbee765729298649c05e6c0f23" data-commit-id="1f935842d4d343fbee765729298649c05e6c0f23}">sha1:1f93584</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px; opacity: 0.150"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-bcd46a8d-6ebf-4d3e-9039-85db06174b11" alt="Atlassian logo" title="Atlassian logo" width="192" height="24" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
<img src="https://u4043402.ct.sendgrid.net/wf/open?upn=YNXLe5Uzuivj8jGpuXra04BSJ-2BS7raa1puTAtyVUP-2F0vngXMYTK-2FS3Irgj0Y-2FFD4rMAxfc-2ByB8VqQWu8BNzXfSM9wRL3fmn0vAlKWE02uYiNjEAFF-2BspI9Xvc5gK8ArvscMYAqXJquMH1QS15l9L-2BLbOjUR-2F4V5oRGlgmZ47FFunzz1wIpbPogCof9Bh1yEss7C8S9p6wtGnJe3RHJwlsE-2BBoDcb-2FkGSYWreLuBy5fY9vu0810EdI2IYgJt9H-2FQ-2B" alt="" width="1" height="1" border="0" style="height:1px !important;width:1px !important;border-width:0 !important;margin-top:0 !important;margin-bottom:0 !important;margin-right:0 !important;margin-left:0 !important;padding-top:0 !important;padding-bottom:0 !important;padding-right:0 !important;padding-left:0 !important;"/>
</body>
</html>