<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://avatar-cdn.atlassian.com/0de205ecb4075ddd28b0c824b8d151ca?s=48&d=https%3A%2F%2Fsecure.gravatar.com%2Favatar%2F0de205ecb4075ddd28b0c824b8d151ca%3Fd%3Dmm%26s%3D48%26noRedirect%3Dtrue" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="jesus.menendez-castellano" id="email_jesus.menendez-castellano" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=jesus.menendez-castellano" style="color:#6c797f;; color: #3b73af; text-decoration: none">Jesus Menendez Castellano</a> <strong>updated</strong> an issue </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="page-title-pattern-first-line " style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://hibernate.atlassian.net/browse/HV" style="color: #3b73af; text-decoration: none">Hibernate Validator</a> / <a href="https://hibernate.atlassian.net/browse/HV-1534" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-0acb5fcd-e2af-40bc-9829-e7afa35881c7" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom"></a> <a href="https://hibernate.atlassian.net/browse/HV-1534" style="color: #3b73af; text-decoration: none">HV-1534</a> </td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HV-1534" style="color: #3b73af; text-decoration: none"><getter> property validation doesn't work when using <constraint-mappings> xml configuration</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 10px; padding-bottom: 5px" bgcolor="#ffffff">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Change By:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="jesus.menendez-castellano" id="email_jesus.menendez-castellano" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=jesus.menendez-castellano" style="color:#6c797f;; color: #3b73af; text-decoration: none">Jesus Menendez Castellano</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 5px; padding-bottom: 10px" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <span class="diffcontext">Given the contraint mapping constraints-config.xml:<br><br>{code:xml}<br><constraint-mappings<br> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"<br> xsi:schemaLocation="http://jboss.org/xml/ns/javax/validation/mapping/validation-mapping-1.1.xsd"<br> xmlns="http://jboss.org/xml/ns/javax/validation/mapping" version="1.1"><br><br> <bean class="mypackage.MyClass"><br> <getter name="id"><br> <constraint annotation="org.hibernate.validator.constraints.NotBlank"/><br> </getter><br> </bean><br></constraint-mappings><br>{code}<br><br>Where MyClass extends from MyObject<br><br>{code:java}<br> public class MyObject {<br> private final String id;<br><br> public MyObject(String id) {<br> this.id = id;<br> }<br><br> public String getId() {<br> return id;<br> }<br> }<br> <br> public class MyClass extends MyObject {<br> <br> public MyClass(String id) {<br> super(id);<br> }<br> }<br>{code}<br><br>The Validator built using the constraint mappings xml, ignores the</span> <span class="diffaddedchars" style="background-color:#ddfade;"> <</span> <span class="diffcontext"> getter</span> <span class="diffaddedchars" style="background-color:#ddfade;">></span> <span class="diffcontext"> Constraint<br><br><br>{code:java}<br><br> class Main {<br> static void main(String[] args) {<br><br> MyClass myinstance = new MyClass("");<br> Set<ConstraintViolation<MyClass>> constraintViolations = getValidator().validate(myinstance);<br> }<br><br><br> static final Validator getValidator() {<br> final Configuration<?> config = Validation.byDefaultProvider().configure();<br><br> try (InputStream inputStream = Thread.currentThread().getContextClassLoader().getResourceAsStream("contraints-config.xml")) {<br> config.addMapping(inputStream);<br> return config.buildValidatorFactory().getValidator();<br><br> } catch (IOException ex) {<br> throw new UncheckedIOException(ex);<br> }<br><br> }<br> }<br>{code}<br><br>No constraint validations are reported even if the id is blank<br><br>But if I add to the constraints-config.xml, a group-sequence element with two entries with the same group value using the class name, then it works.<br>And I think the reason is in the org.hibernate.validator.internal.engine.ValidatorImpl<br><br>So if I add the group-</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">s</span> <span class="diffaddedchars" style="background-color:#ddfade;">sequence</span> <span class="diffcontext"><br>{code:xml}<br><constraint-mappings<br> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"<br> xsi:schemaLocation="http://jboss.org/xml/ns/javax/validation/mapping/validation-mapping-1.1.xsd"<br> xmlns="http://jboss.org/xml/ns/javax/validation/mapping" version="1.1"><br><br> <bean class="mypackage.MyClass"><br><!-- A group sequence with two entries needs to be created because a xtrange bug that make getter properties not to be validated --><br> <group-sequence><br> <value>mypackage.MyClass</value><br> <value>mypackage.MyClass</value><br> </group-sequence><br> <getter name="id"><br> <constraint annotation="org.hibernate.validator.constraints.NotBlank"/><br> </getter><br> </bean><br></constraint-mappings><br>{code}<br><br>Now the validation works, and reports a ConstraintValidation<br><br></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br>Looking at the code in org.hibernate.validator.internal.engine.ValidatorImpl.java<br>When the groupSequence of a bean is no redefined this lines are executed<br><br><br>{code:java}<br>else {<br> Set<MetaConstraint<?>> metaConstraints = hostingBeanMetaData.getDirectMetaConstraints();<br> validateConstraintsForSingleDefaultGroupElement( validationContext, valueContext, validatedInterfaces, clazz, metaConstraints,<br> Group.DEFAULT_GROUP );<br> }<br>{code}<br><br><br>If I change the metaConstaints to be <br>{code:java}<br>else {<br> Set<MetaConstraint<?>> metaConstraints = hostingBeanMetaData.getMetaConstraints();<br> validateConstraintsForSingleDefaultGroupElement( validationContext, valueContext, validatedInterfaces, clazz, metaConstraints,<br> Group.DEFAULT_GROUP );<br> }<br>{code:java}<br><br>Then the <getter> constraint is executed.<br><br>The only way to force the current code to call hostingBeanMetaData.getMetaConstraints() is to force the hostingBeanMetaData.defaultGroupSequenceIsRedefined() to be true which i could do by adding two times the same group to the <group-sequence> element<br><br>Why is hostingBeanMetaData.getMetaConstraints() used in one case and hostingBeanMetaData.getDirectMetaConstraints() in the other?.<br>Using hostingBeanMetaData.getMetaConstraints() makes the <getter> constraint work<br><br>Not sure is a bug, but definitely a very strange behaviour, and a strange workaround to make the getter constraint to work.<br></span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff"> <script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"description": "View Issue",
"potentialAction": {
"@type": "ViewAction",
"target": "https://hibernate.atlassian.net/browse/HV-1534?inbox=true&",
"name": "View Issue"
},
"publisher": {
"@type": "Organization",
"name": "Atlassian",
"url": "https://www.atlassian.com"
}
}
</script>
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HV-1534#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-f9a825e6-ff25-42ab-bb00-7c4b3c4e2d3d" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HV-1534#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-mobile-separated-links" class="mobile-resize-text" width="100%" colspan="2" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> Get Jira notifications on your phone! Download the Jira Cloud app for <a href="https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail" style="color: #3b73af; text-decoration: none">Android</a> or <a href="https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8" style="color: #3b73af; text-decoration: none">iOS</a>
<hr> </td>
</tr>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian Jira <span id="footer-build-information">(v1001.0.0-SNAPSHOT#100073-<span title="af7f5196b8ccab2346cf947fa277b2af49d30c34" data-commit-id="af7f5196b8ccab2346cf947fa277b2af49d30c34}">sha1:af7f519</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px; opacity: 0.150"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-7715f793-336c-4b02-9711-2e85d50c0d7a" alt="Atlassian logo" title="Atlassian logo" width="192" height="24" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
<img src="https://u4043402.ct.sendgrid.net/wf/open?upn=YNXLe5Uzuivj8jGpuXra04BSJ-2BS7raa1puTAtyVUP-2F0vngXMYTK-2FS3Irgj0Y-2FFD4m7D1DYbIPDeAZntMlflO7pKNLjSEdP4CeeG5Onc6YyKM5gPA2YYoLAY-2BGTVphfcPm-2Fm-2Fu-2FWyiTGFqoV3uHMl9GVVXUsEfcYoaD7SZQufy6Qi-2FAD7nlIaJnkW1m43uADeCu7ZemAkzCZz-2F-2BiNgFws54bmAVYugtYBoSpIQgJ9KjaUz8qNi6CrffoSt5vJ57JF" alt="" width="1" height="1" border="0" style="height:1px !important;width:1px !important;border-width:0 !important;margin-top:0 !important;margin-bottom:0 !important;margin-right:0 !important;margin-left:0 !important;padding-top:0 !important;padding-bottom:0 !important;padding-right:0 !important;padding-left:0 !important;"/>
</body>
</html>