<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://avatar-cdn.atlassian.com/ec96387a1a8295b6fd6dffb68f80c352?s=48&d=https%3A%2F%2Fsecure.gravatar.com%2Favatar%2Fec96387a1a8295b6fd6dffb68f80c352%3Fd%3Dmm%26s%3D48%26noRedirect%3Dtrue" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="gsmet" id="email_gsmet" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=gsmet" style="color:#6c797f;; color: #3b73af; text-decoration: none">Guillaume Smet</a> <strong>updated</strong> an issue </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="page-title-pattern-first-line " style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://hibernate.atlassian.net/browse/HV" style="color: #3b73af; text-decoration: none">Hibernate Validator</a> / <a href="https://hibernate.atlassian.net/browse/HV-1533" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-ed9e1c5c-f7fd-41fc-80e5-ea4e7a8cfb4f" height="16" width="16" border="0" align="absmiddle" alt="Improvement" style="vertical-align: text-bottom"></a> <a href="https://hibernate.atlassian.net/browse/HV-1533" style="color: #3b73af; text-decoration: none">HV-1533</a> </td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HV-1533" style="color: #3b73af; text-decoration: none">Small performance improvements</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 10px; padding-bottom: 5px" bgcolor="#ffffff">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Change By:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="gsmet" id="email_gsmet" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=gsmet" style="color:#6c797f;; color: #3b73af; text-decoration: none">Guillaume Smet</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 5px; padding-bottom: 10px" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <span class="diffcontext">While studying the result of a profiling session of the Bean Validation benchmark with Marko, we noticed a few things:<br><br> * There's far too much time spent in {{LocalizedMessage#equals()}}. We thought about 2 things: interverting the 2 equals condition to test the message first: it's far more discriminating than the locale in most cases, and (maybe) try to avoid creating {{LocalizedMessage}} instances using a nested map (but the benefit should be measured, it's not obvious).<br> * {{ConstraintTree#mainConstraintNeedsEvaluation()}} can be tuned to test early if the {{constraintViolations}} set is empty.<br></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> * There is a lot of time spent in {{ReflectionHelper#getValue()}}. Maybe we could optimize things by storing</span> <span class="diffaddedchars" style="background-color:#ddfade;"><br>John O'Hara also mentioned that</span> <span class="diffcontext"> the</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> constraint per location in</span> <span class="diffcontext"> {{</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">BeanMetaData}}, thus calling {{ReflectionHelper</span> <span class="diffaddedchars" style="background-color:#ddfade;">CollectionHelper</span> <span class="diffcontext">#</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">getValue</span> <span class="diffaddedchars" style="background-color:#ddfade;">newHashMap</span> <span class="diffcontext">()}}</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> only once per location, instead of calling it once per constraint.<br> * Less pressing (it's pretty low</span> <span class="diffaddedchars" style="background-color:#ddfade;"> call</span> <span class="diffcontext"> in</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> the profile) but might be worth some investigation:</span> <span class="diffcontext"> {{</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">ConstraintTree</span> <span class="diffaddedchars" style="background-color:#ddfade;">ValidatorImpl</span> <span class="diffcontext">#</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">passesCompositionTypeRequirement</span> <span class="diffaddedchars" style="background-color:#ddfade;">validateConstraintsForDefaultGroup</span> <span class="diffcontext">()}}</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> appears in the profile whereas it's only</span> <span class="diffaddedchars" style="background-color:#ddfade;"> was preventing some</span> <span class="diffcontext"> useful</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> if we have composing constraints (which is not the common case)</span> <span class="diffaddedchars" style="background-color:#ddfade;"> compiler optimization</span> <span class="diffcontext">.</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> Maybe we could try to have a fast path in {{validateConstraints()}} when we don</span> <span class="diffaddedchars" style="background-color:#ddfade;"> Let</span> <span class="diffcontext">'</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">t have any composing constraints. If the gain is very limited,</span> <span class="diffaddedchars" style="background-color:#ddfade;">s get rid of</span> <span class="diffcontext"> it</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> might not be worth</span> <span class="diffaddedchars" style="background-color:#ddfade;"> as</span> <span class="diffcontext"> it</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> to complicate the code.<br><br>I also had a potentially interesting idea to reduce the cost of hashCoding the {{Path}}. We have a few nodes that have an invariant hashCode (considering that now the parent is not part of the hashCode anymore): at least bean nodes, return</span> <span class="diffaddedchars" style="background-color:#ddfade;"> has no</span> <span class="diffcontext"> value</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> nodes, cross parameter nodes</span> <span class="diffcontext">.</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"><br><br>Moreover if we moved the name at the end of the hashCode, we could also probably compute the property node hashCode from a static one + some calculations to add the name.<br><br>I would be curious to see if that buys us much.</span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff"> <script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"description": "View Issue",
"potentialAction": {
"@type": "ViewAction",
"target": "https://hibernate.atlassian.net/browse/HV-1533?inbox=true&",
"name": "View Issue"
},
"publisher": {
"@type": "Organization",
"name": "Atlassian",
"url": "https://www.atlassian.com"
}
}
</script>
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HV-1533#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-8ccd3316-6822-4707-8150-74f1607ef55c" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HV-1533#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-mobile-separated-links" class="mobile-resize-text" width="100%" colspan="2" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> Get Jira notifications on your phone! Download the Jira Cloud app for <a href="https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail" style="color: #3b73af; text-decoration: none">Android</a> or <a href="https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8" style="color: #3b73af; text-decoration: none">iOS</a>
<hr> </td>
</tr>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian Jira <span id="footer-build-information">(v1001.0.0-SNAPSHOT#100074-<span title="e1ada01f1ee26d2f5a89af2c8da01955d217eea6" data-commit-id="e1ada01f1ee26d2f5a89af2c8da01955d217eea6}">sha1:e1ada01</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px; opacity: 0.150"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-5eb65d12-6fc3-4c11-8d10-eae52fcb5a8f" alt="Atlassian logo" title="Atlassian logo" width="192" height="24" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
<img src="https://u4043402.ct.sendgrid.net/wf/open?upn=YNXLe5Uzuivj8jGpuXra04BSJ-2BS7raa1puTAtyVUP-2F0UG25sB-2BHToWWBMcbXwnNUqDn7KxxRKW9rvq7I4RXngiyS79SiEtFAGudjNDHB5wTLPvjb75rPcduRlSMS3434GVV9678pWhJS7YY43ysC1QdpvvycpQp7U3FZfguEiSuqAMo1p7LAjpIDtShuQnzGZr59zTbY-2BWotZd6j2hOc8WX6QL6V3KdrJRfF8hA9ilqlztb1eWnALg6uhuPVQ-2Fagf7ow6D3zfkkWB1cMQl339TtGo15g5vDvrMtQ53Fy3tobgFO-2FKFoLQgyk-2BW72eVssNqWN36Voag8FQKaeHWb2Q5uKEgEKcxuPxwdhn-2Bz2mA-2BYlibkHrSZru-2FsNOrAZqPLWOws5fZGbQooubDMe4a-2Byc1DTxxTLhylCFaE5L3PQ20O-2BaNv60y0nGoaAGmU8Z1sYr-2BGNHDMYUEuPDZ01WYDUQ-3D-3D" alt="" width="1" height="1" border="0" style="height:1px !important;width:1px !important;border-width:0 !important;margin-top:0 !important;margin-bottom:0 !important;margin-right:0 !important;margin-left:0 !important;padding-top:0 !important;padding-bottom:0 !important;padding-right:0 !important;padding-left:0 !important;"/>
</body>
</html>