<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://avatar-cdn.atlassian.com/0bad67ab4fc6fbd607f181c0bbef536d?s=48&d=https%3A%2F%2Fsecure.gravatar.com%2Favatar%2F0bad67ab4fc6fbd607f181c0bbef536d%3Fd%3Dmm%26s%3D48%26noRedirect%3Dtrue" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="ant.kutschera" id="email_ant.kutschera" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=ant.kutschera" style="color:#6c797f;; color: #3b73af; text-decoration: none">Ant Kutschera</a> <strong>updated</strong> an issue </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="page-title-pattern-first-line " style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://hibernate.atlassian.net/browse/HHH" style="color: #3b73af; text-decoration: none">Hibernate ORM</a> / <a href="https://hibernate.atlassian.net/browse/HHH-12204" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-9ad4755a-820c-4d4d-b788-25e4faa00443" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom"></a> <a href="https://hibernate.atlassian.net/browse/HHH-12204" style="color: #3b73af; text-decoration: none">HHH-12204</a> </td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-12204" style="color: #3b73af; text-decoration: none">Hibernate Tools StandardTableExporter does not add a point (".") between table and column names, when generating comment DDL</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 10px; padding-bottom: 5px" bgcolor="#ffffff">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Change By:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="ant.kutschera" id="email_ant.kutschera" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=ant.kutschera" style="color:#6c797f;; color: #3b73af; text-decoration: none">Ant Kutschera</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 5px; padding-bottom: 10px" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <span class="diffcontext">Currently the generator outputs comments like this:<br><br>{code}<br>comment on column T_JES_COMMANDATTEMPTS is 'Type:Integer,Anzahl der Retries';<br>{code}<br><br>Notice the missing dot / point to separate the table name (T_JES_COMMAND) and the column name (ATTEMPTS).<br><br>The problem can be fixed by overriding the applyComments method of the StandardTableExporter class as follows:<br><br>{code}<br>public class MobiOracle10gDialect extends Oracle10gDialect {<br> @Override<br> public boolean supportsUniqueConstraintInCreateAlterTable() {<br> return false;<br> }<br><br> @Override<br> public Exporter<Table> getTableExporter() {<br> return new StandardTableExporter(this){<br> protected void applyComments(Table table, QualifiedName tableName, List<String> sqlStrings) {<br> if ( dialect.supportsCommentOn() ) {<br> if ( table.getComment() != null ) {<br> sqlStrings.add( "comment on table " + tableName + " is '" + table.getComment() + "'" );<br> }<br> final Iterator iter = table.getColumnIterator();<br> while ( iter.hasNext() ) {<br> Column column = (Column) iter.next();<br> String columnComment = column.getComment();<br> if ( columnComment != null ) {<br> //this line is buggy in hibernate 5 :-(<br> //the point is missing between table name and column!<br> sqlStrings.add( "comment on column " + tableName + "." + column.getQuotedName( dialect ) + " is '" + columnComment + "'" );<br> }<br> }<br> }<br> }<br> };<br> }<br>}<br>{code}<br><br>Compare this line:<br><br>{code}<br>sqlStrings.add( "comment on column " + tableName + "." + column.getQuotedName( dialect ) + " is '" + columnComment + "'" );<br>{code}<br><br>with the original:<br><br>{code}<br>sqlStrings.add( "comment on column " + tableName + column.getQuotedName( dialect ) + " is '" + columnComment + "'" );<br>{code}<br><br>Notice the missing dot.<br><br></span> <span class="diffaddedchars" style="background-color:#ddfade;">The following JUnit tests demonstrates the problem:<br><br>{code}<br>package ch.mobi.jes.persistence.hibernate.dialect;<br><br>import static org.junit.jupiter.api.Assertions.*;<br>import static org.mockito.Mockito.mock;<br>import static org.mockito.Mockito.when;<br><br>import java.sql.Types;<br><br>import org.hibernate.boot.Metadata;<br>import org.hibernate.boot.model.relational.Database;<br>import org.hibernate.dialect.Oracle10gDialect;<br>import org.hibernate.engine.jdbc.env.internal.QualifiedObjectNameFormatterStandardImpl;<br>import org.hibernate.engine.jdbc.env.spi.JdbcEnvironment;<br>import org.hibernate.engine.jdbc.env.spi.NameQualifierSupport;<br>import org.hibernate.mapping.Column;<br>import org.hibernate.mapping.Table;<br>import org.junit.jupiter.api.Test;<br><br>class Oracle10gDialectTest {<br><br> @Test<br> public void testCommentsAreGeneratedWithDot() {<br><br> //setup<br> Table table = new Table();<br> table.setName("MyTable");<br> table.setQuoted(false);<br> table.setSchema("MySchema");<br> table.setQuoted(false);<br> Column col = new Column("MyCol");<br> col.setComment("aComment");<br> col.setSqlTypeCode(Types.NUMERIC);<br> col.setSqlType("NUM");<br> table.addColumn(col);<br> Metadata metadata = mock(Metadata.class);<br> Database db = mock(Database.class);<br> when(metadata.getDatabase()).thenReturn(db);<br> JdbcEnvironment env = mock(JdbcEnvironment.class);<br> when(db.getJdbcEnvironment()).thenReturn(env);<br> when(env.getQualifiedObjectNameFormatter()).thenReturn(new QualifiedObjectNameFormatterStandardImpl(NameQualifierSupport.BOTH));<br><br> //run<br> String[] sql = new Oracle10gDialect().getTableExporter().getSqlCreateStrings(table, metadata);<br><br> //assert<br> assertEquals(2, sql.length);<br> assertEquals("create table MySchema.MyTable (MyCol NUM)", sql[0]);<br> <br> //this test fails on the following line, because currently no dot is generated between the table and column name here:<br> // |<br> // v<br> assertEquals("comment on column MySchema.MyTable.MyCol is 'aComment'", sql[1]);<br> }<br>}<br>{code}</span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff"> <script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"description": "View Issue",
"potentialAction": {
"@type": "ViewAction",
"target": "https://hibernate.atlassian.net/browse/HHH-12204?inbox=true&",
"name": "View Issue"
},
"publisher": {
"@type": "Organization",
"name": "Atlassian",
"url": "https://www.atlassian.com"
}
}
</script>
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-12204#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-55e0475a-5687-4530-9610-72ed0cc8ba8d" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-12204#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-mobile-separated-links" class="mobile-resize-text" width="100%" colspan="2" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> Get Jira notifications on your phone! Download the Jira Cloud app for <a href="https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail" style="color: #3b73af; text-decoration: none">Android</a> or <a href="https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8" style="color: #3b73af; text-decoration: none">iOS</a>
<hr> </td>
</tr>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian Jira <span id="footer-build-information">(v1001.0.0-SNAPSHOT#100075-<span title="48e9f7a1ad7cd35e68416503bbeec82b2a176195" data-commit-id="48e9f7a1ad7cd35e68416503bbeec82b2a176195}">sha1:48e9f7a</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px; opacity: 0.150"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-8af6d1e2-0283-4851-a1d3-001df89498f4" alt="Atlassian logo" title="Atlassian logo" width="192" height="24" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
<img src="https://u4043402.ct.sendgrid.net/wf/open?upn=YNXLe5Uzuivj8jGpuXra04BSJ-2BS7raa1puTAtyVUP-2F0UG25sB-2BHToWWBMcbXwnNU8-2FfB85gMJ-2Bl0g4eAp7P9pEmualS5OSu5cNo3Fj0amZsZwGoJK5CBzEqWcig4XI-2Fsq9T-2F6uzSNFoUWMEiPXSpBwhb2VQYjksiVjQjiQVeSfxxB5QaQwDl39IrF1kW9ldH8Yn9XxkSggCU4i0GQX-2BjdSuDhzlEjzWAJbsptJ-2FqdGBQMbx8ZmYAgq2ZrWesX1IUJh-2B5IF17-2BOJkb3IoZe0ygKqAPhaO8UQQGihi3Or5Tc4PuiWgS4ZS-2FrJg8CaceTepHvgww3mFhrNcvCH5PP9c0EOymRqLPgJgLVzSq1W1USPRxvk9F1lwy2egbMp9inIG6fphz-2FkMA97hh-2BfQwCRbTDmJ4bvN3ipsMcpWxjv0LnfltftO8CKz01WrRFxs3-2F2T083O1TIHmiaxie0BwO2Hbg-3D-3D" alt="" width="1" height="1" border="0" style="height:1px !important;width:1px !important;border-width:0 !important;margin-top:0 !important;margin-bottom:0 !important;margin-right:0 !important;margin-left:0 !important;padding-top:0 !important;padding-bottom:0 !important;padding-right:0 !important;padding-left:0 !important;"/>
</body>
</html>