<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://avatar-cdn.atlassian.com/df12d7792bd3b7be3a4edf12cabd58cb?s=48&d=https%3A%2F%2Fsecure.gravatar.com%2Favatar%2Fdf12d7792bd3b7be3a4edf12cabd58cb%3Fd%3Dmm%26s%3D48%26noRedirect%3Dtrue" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="steve" id="email_steve" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=steve" style="color:#6c797f;; color: #3b73af; text-decoration: none">Steve Ebersole</a> <strong>updated</strong> an issue </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="page-title-pattern-first-line " style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://hibernate.atlassian.net/browse/HHH" style="color: #3b73af; text-decoration: none">Hibernate ORM</a> / <a href="https://hibernate.atlassian.net/browse/HHH-12323" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-9fc43886-d3d3-4e41-aa55-ef3575b05f96" height="16" width="16" border="0" align="absmiddle" alt="Improvement" style="vertical-align: text-bottom"></a> <a href="https://hibernate.atlassian.net/browse/HHH-12323" style="color: #3b73af; text-decoration: none">HHH-12323</a> </td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-12323" style="color: #3b73af; text-decoration: none">Update Statistics API and SPI based on changes to 2nd level caching changes</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 10px; padding-bottom: 5px" bgcolor="#ffffff">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Change By:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="steve" id="email_steve" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=steve" style="color:#6c797f;; color: #3b73af; text-decoration: none">Steve Ebersole</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 5px; padding-bottom: 10px" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <span class="diffcontext">The goal here is to align stats with changes in caching SPI and to address some inconsistencies in its API/SPI. Some potential designs...<br><br><br>h2. (1) Drop {{SecondLevelCacheStatistics}}<br><br>In this approach, caching-related statistics are actually exposed on the thing being cached. For example, caching-related stats for an entity would be expose on {{EntityStatistics}}, etc.<br><br>This has the drawbacks that:<br># There is no over-arching view of the statistics for a given region (not convinced this is so bad, see comments)<br># Stats related to entity persistence-related events and caching-related events are modeled together even though there are distinct concepts.<br><br>E.g<br><br>{code}<br>interface Statistics ... {<br> ...<br> EntityStatistics getEntityStatistics(String entityName);<br>}<br><br>interface EntityStatistics ... {<br> // ~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br> // persistence-related stats...<br><br> long getInsertCount();<br> long getUpdateCount();<br> ...<br><br> // ~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br> // caching-related stats<br><br> long getPutCount();<br> long getHitCount();<br> ...<br>}<br>{code}<br><br><br>h2. (2) Drop "cache-related stats" from {{QueryStatistics}} and {{</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">NaturalId</span> <span class="diffaddedchars" style="background-color:#ddfade;">NaturalIdCacheStatistics}}</span> <span class="diffcontext"><br><br></span> <span class="diffaddedchars" style="background-color:#ddfade;">Currently both {{QueryStatistics}} and {{NaturalIdCacheStatistics}} expose caching-related stats in addition to their specific stats. That is an inconsistency. Either we should drop these from {{QueryStatistics}} and {{NaturalIdCacheStatistics}}, or add the same to {{EntityStatistics}} and {{CollectionStatistic}}.<br><br></span> <span class="diffcontext">Here,</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> there</span> <span class="diffaddedchars" style="background-color:#ddfade;"> all caching-specific stats</span> <span class="diffcontext"> would be</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> a statistic object specifically for describing</span> <span class="diffaddedchars" style="background-color:#ddfade;"> exposed through</span> <span class="diffcontext"> the</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> stats related</span> <span class="diffaddedchars" style="background-color:#ddfade;"> dedicated {{SecondLevelCacheStatistics}} (which I propose we rename</span> <span class="diffcontext"> to</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> a particular caching region</span> <span class="diffaddedchars" style="background-color:#ddfade;"> {{CacheRegionStatistics}})</span> <span class="diffcontext">.</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> <br></span> <span class="diffcontext"><br></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br>Another aspects to the inconsistency here is that currently {{SecondLevelCacheStatistics}} does not cover query nor natural-id caching - those are only available from {{QueryStatistics}} and {{NaturalIdCacheStatistics}}<br><br></span> <span class="diffcontext">The main "drawback" here is that we would not expose caching related stats specific to entity, collection, natural-id - it would be region-wide. E.g.<br><br>{code}<br>interface Statistics ... {<br> ...<br> EntityStatistics getEntityStatistics(String entityName);<br> CacheRegionStatistics getCacheRegionStatistics(String regionName);<br>}<br><br>interface EntityStatistics ... {<br> // ~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br> // persistence-related stats...<br><br> long getInsertCount();<br> long getUpdateCount();<br> ...<br>}<br><br>interface CacheRegionStatistics ... {<br> long getPutCount();<br> long getHitCount();<br> ...<br>}<br>{code}<br><br></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">The second approach feels cleaner</span> <span class="diffaddedchars" style="background-color:#ddfade;"><br>h2.(3) Combination - expose both ways<br><br>Here</span> <span class="diffcontext">,</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> but I</span> <span class="diffaddedchars" style="background-color:#ddfade;"> we</span> <span class="diffcontext">'</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">m just not sure how important it is to users to be able to locate</span> <span class="diffaddedchars" style="background-color:#ddfade;">d expose</span> <span class="diffcontext"> caching stats</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> specific to an entity</span> <span class="diffaddedchars" style="background-color:#ddfade;"> from all of {{EntityStatistics}}</span> <span class="diffcontext">,</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> natural-id</span> <span class="diffaddedchars" style="background-color:#ddfade;"> {{CollectionStatistic}}</span> <span class="diffcontext">,</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> collection. I think that since the user chooses to configure what data is kept</span> <span class="diffaddedchars" style="background-color:#ddfade;"> {{QueryStatistics}} and {{NaturalIdCacheStatistics}}</span> <span class="diffcontext"> in</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> which regions that this is actually not such a big deal</span> <span class="diffaddedchars" style="background-color:#ddfade;"> addition to also having them available from {{SecondLevelCacheStatistics}} ({{CacheRegionStatistics}})</span> <span class="diffcontext">.</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> However</span> <span class="diffaddedchars" style="background-color:#ddfade;"> The values exposed from {{EntityStatistics}}</span> <span class="diffcontext">,</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> if they do end</span> <span class="diffaddedchars" style="background-color:#ddfade;"> {{CollectionStatistic}}, {{QueryStatistics}} and {{NaturalIdCacheStatistics}} would be specific to those things where as the values exposed from {{SecondLevelCacheStatistics}} would be a "roll</span> <span class="diffcontext"> up</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> caching multiple types</span> <span class="diffaddedchars" style="background-color:#ddfade;">"</span> <span class="diffcontext"> of</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> data in</span> <span class="diffcontext"> the</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> same</span> <span class="diffaddedchars" style="background-color:#ddfade;"> individual things stored in that particular</span> <span class="diffcontext"> region</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> then they'd really need the per</span> <span class="diffaddedchars" style="background-color:#ddfade;">.<br><br></span> <span class="diffcontext">-</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">type</span> <span class="diffcontext">-</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">of</span> <span class="diffcontext">-</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">data stats</span> <span class="diffaddedchars" style="background-color:#ddfade;">-<br>It is important</span> <span class="diffcontext"> to</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> be able</span> <span class="diffaddedchars" style="background-color:#ddfade;"> note that any of these represent a change</span> <span class="diffcontext"> to</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> tune caching</span> <span class="diffaddedchars" style="background-color:#ddfade;"> the API and SPI for stats</span> <span class="diffcontext">.</span> <span class="diffaddedchars" style="background-color:#ddfade;"> (3) gives the greatest compatibility. (1) is pretty compatible except for custom stats implementors. (2) can be done in a pretty compatible manner with deprecations.<br><br>Coupled with this discussion is </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff"> <script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"description": "View Issue",
"potentialAction": {
"@type": "ViewAction",
"target": "https://hibernate.atlassian.net/browse/HHH-12323?inbox=true&",
"name": "View Issue"
},
"publisher": {
"@type": "Organization",
"name": "Atlassian",
"url": "https://www.atlassian.com"
}
}
</script>
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-12323#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-080fdbb9-ca4d-45be-ae64-3cb2bc913623" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-12323#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-mobile-separated-links" class="mobile-resize-text" width="100%" colspan="2" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> Get Jira notifications on your phone! Download the Jira Cloud app for <a href="https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail" style="color: #3b73af; text-decoration: none">Android</a> or <a href="https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8" style="color: #3b73af; text-decoration: none">iOS</a>
<hr> </td>
</tr>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian Jira <span id="footer-build-information">(v1001.0.0-SNAPSHOT#100081-<span title="e872ab0ec2511366f034b6e83ad016aa92208f92" data-commit-id="e872ab0ec2511366f034b6e83ad016aa92208f92}">sha1:e872ab0</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px; opacity: 0.150"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-552549be-26b7-4bca-bbd4-89e1d9f50369" alt="Atlassian logo" title="Atlassian logo" width="192" height="24" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
<img src="https://u4043402.ct.sendgrid.net/wf/open?upn=YNXLe5Uzuivj8jGpuXra04BSJ-2BS7raa1puTAtyVUP-2F0UG25sB-2BHToWWBMcbXwnNU9XEWsLrJvnxTCAaSGalHAACHVMGmOkf9dXuVk4fu-2BaK23kM2PQB1tWVFCp5K7QL4hz9xFxDSWijY-2F7-2F5jvcF3l8gz4WaW-2F5QdNyFyV6OWRMxfrKOeby0Ra6EMuYSHVMii3EjSmfhvuOMcQ-2BOiBy9QJ03s-2BXSSyXk2cRBNjfETpUGoheD97kS6MA5rA7fgzTLWgvh1-2BUDRh2P2Zdr5I8oyWyQDdeJI4Jbd8RHSzx8knjsfjTLEfAxmYDMBe7gTwFxmKvtV0b6vbU6E9xafiUxnvzi5HXRprnVOaKPiDj2NUoApW2-2BZz8zqkrfdfPX2qo-2FdWvBdGjcUIzUISlN1aTt2R1O0GAxuPBaXgPeBpy4lnpioKfbglTBR0vAh5r0bx0ippRdvXwlzcTVCGYUigtoZw-3D-3D" alt="" width="1" height="1" border="0" style="height:1px !important;width:1px !important;border-width:0 !important;margin-top:0 !important;margin-bottom:0 !important;margin-right:0 !important;margin-left:0 !important;padding-top:0 !important;padding-bottom:0 !important;padding-right:0 !important;padding-left:0 !important;"/>
</body>
</html>