<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://hibernate.atlassian.net">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://avatar-cdn.atlassian.com/7447b128f8696bc3b6c2982269c8bed7?s=48&d=https%3A%2F%2Fsecure.gravatar.com%2Favatar%2F7447b128f8696bc3b6c2982269c8bed7%3Fd%3Dmm%26s%3D48%26noRedirect%3Dtrue" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="rdearnaley" id="email_rdearnaley" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=rdearnaley" style="color:#6c797f;; color: #3b73af; text-decoration: none">Roger Dearnaley</a> <strong>created</strong> an issue </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="page-title-pattern-first-line " style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://hibernate.atlassian.net/browse/HHH" style="color: #3b73af; text-decoration: none">Hibernate ORM</a> / <a href="https://hibernate.atlassian.net/browse/HHH-12434" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-54e54640-e6ca-4637-bd4d-c769753ce936" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom"></a> <a href="https://hibernate.atlassian.net/browse/HHH-12434" style="color: #3b73af; text-decoration: none">HHH-12434</a> </td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-12434" style="color: #3b73af; text-decoration: none">PersistentSortedSet<String> with @SortComparator(CaseInsensitiveOrdering.class) duplicates records in the join table if you delete an entry and then re-add a value that differs only by case without a flush between them</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 10px; padding-bottom: 5px" bgcolor="#ffffff">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Issue Type:</th>
<td class="has-icon" style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <img src="cid:jira-generated-image-avatar-54e54640-e6ca-4637-bd4d-c769753ce936" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom"> Bug </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Assignee:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> Unassigned </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Created:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> 26/Mar/2018 22:21 PM </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Priority:</th>
<td class="has-icon" style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <img src="cid:jira-generated-image-static-major-bfa61d35-9277-49f3-adf7-11ac23f71ad3" height="16" width="16" border="0" align="absmiddle" alt="Major" style="vertical-align: text-bottom"> Major </td>
</tr>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Reporter:</th>
<td style="padding: 0; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="rdearnaley" id="email_rdearnaley" href="https://hibernate.atlassian.net/secure/ViewProfile.jspa?name=rdearnaley" style="color:#6c797f;; color: #3b73af; text-decoration: none">Roger Dearnaley</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 5px; padding-bottom: 10px" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0; border-collapse: collapse; padding: 0 0 10px"> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0; margin-top: 0">I have the following class:</p>
<div class="code panel" style="border-width: 1px;; border: 1px solid #cccccc; background: #f5f5f5; font-size: 12px; line-height: 1.333; font-family: monospace; border: 1px solid #cccccc; -moz-border-radius: 3px; border-radius: 3px; margin: 9px 0">
<div class="codeContent panelContent" style="padding: 9px 12px">
<pre class="code-java" style="margin: 10px 0 0; margin-top: 0; max-height: 30em; overflow: auto; white-space: pre-wrap; word-wrap: normal">
@Audited @DynamicInsert @DynamicUpdate
@Entity(name = <span class="code-quote" style="color: #009100">"ResourcePool"</span>)
@Proxy(proxyClass = ResourcePool.class)
@Table(
name = <span class="code-quote" style="color: #009100">"ec_resource_pool"</span>,
uniqueConstraints =
@UniqueConstraint(
name = <span class="code-quote" style="color: #009100">"iu_resource_pool_name"</span>,
columnNames = <span class="code-quote" style="color: #009100">"name"</span>
)
)
<span class="code-keyword" style="color: #000091">public</span> <span class="code-keyword" style="color: #000091">class </span>ResourcePoolImpl
<span class="code-keyword" style="color: #000091">extends</span> AbstractProtectedPropertySheetOwner
<span class="code-keyword" style="color: #000091">implements</span> ResourcePool
{
...
<span class="code-keyword" style="color: #000091">private</span> UUID m_id;
<span class="code-keyword" style="color: #000091">private</span> SortedSet<<span class="code-object" style="color: #910091">String</span>> m_resourceNames;
...
@Override <span class="code-keyword" style="color: #000091">public</span> <span class="code-object" style="color: #910091">boolean</span> addResourceName(
@NonNls @NotNull <span class="code-object" style="color: #910091">String</span> resourceName)
{
<span class="code-keyword" style="color: #000091">if</span> (m_resourceNames == <span class="code-keyword" style="color: #000091">null</span>) {
m_resourceNames = CollectionUtil.createCaseInsensitiveSet();
}
<span class="code-keyword" style="color: #000091">return</span> m_resourceNames.add(resourceName);
}
...
@Column(
length = UUID_LENGTH,
updatable = <span class="code-keyword" style="color: #000091">false</span>,
nullable = <span class="code-keyword" style="color: #000091">false</span>
)
@DocumentId
@GeneratedValue(generator = <span class="code-quote" style="color: #009100">"ecid"</span>)
@GenericGenerator(
name = <span class="code-quote" style="color: #009100">"ecid"</span>,
strategy = <span class="code-quote" style="color: #009100">"com.electriccloud.dao.EntityIdentifierGenerator"</span>
)
@Id @NonNls @NotNull @Override <span class="code-keyword" style="color: #000091">public</span> UUID getId()
{
<span class="code-keyword" style="color: #000091">return</span> m_id;
}
...
@AuditJoinTable(name = <span class="code-quote" style="color: #009100">"ec_resource_pool_resource_aud"</span>)
@Column(
name = <span class="code-quote" style="color: #009100">"resource_name"</span>,
length = MAX_NAME_LENGTH
)
@ElementCollection(fetch = LAZY)
@JoinTable(
name = <span class="code-quote" style="color: #009100">"ec_resource_pool_resource"</span>,
joinColumns =
@JoinColumn(
name = <span class="code-quote" style="color: #009100">"resource_pool_id"</span>,
foreignKey = @ForeignKey(name = <span class="code-quote" style="color: #009100">"fk_resource_pool"</span>)
)
)
@Nullable @Override
@SortComparator(CaseInsensitiveOrdering.class)
<span class="code-keyword" style="color: #000091">public</span> SortedSet<<span class="code-object" style="color: #910091">String</span>> getResourceNames()
{
<span class="code-keyword" style="color: #000091">return</span> m_resourceNames;
}
...
@Override <span class="code-keyword" style="color: #000091">public</span> <span class="code-object" style="color: #910091">boolean</span> removeResourceName(
@NonNls @NotNull <span class="code-object" style="color: #910091">String</span> resourceName)
{
<span class="code-keyword" style="color: #000091">return</span> m_resourceNames != <span class="code-keyword" style="color: #000091">null</span> && m_resourceNames.remove(resourceName);
}
...
@Override <span class="code-keyword" style="color: #000091">public</span> void setId(@NonNls @Nullable UUID id)
{
m_id = id;
}
...
@Override <span class="code-keyword" style="color: #000091">public</span> void setResourceNames(SortedSet<<span class="code-object" style="color: #910091">String</span>> resourceNames)
{
m_resourceNames = resourceNames;
}
}
</pre>
</div>
</div> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">The join table ec_resource_pool_resource and the audit table ec_resource_pool_resource_aud both have case-insensitive collation order.</p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">I create a resource pool whose m_resourceNames with some id which contains the entry 'foo', which produces a row in ec_resource_pool_resource with that id and resource_name = 'foo'</p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">I then do:</p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">resourcePool.remove("foo");<br> resourcePool.add("FOO"); // Differs from the previous value only by case</p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">Once this is committed, I find I have TWO rows in ec_resource_pool_resource with the same id one with resource_name = 'FOO' (as expected) but the original one with resource_name = 'foo' – which should have been deleted, but was not.</p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">(NOTE – If you have auditing turned on, you won't be able to get this far, due to a constraint violation issue which I will file a separate JIRA for.)</p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">If I make further changes only by case (e.g. tothe resource 'Foo'), then I get even more duplicated rows in ec_resource_pool_resource.</p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">This problem does NOT occur if I put a flush between the delete and the add.</p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">This problem has existed at least since Hibernate 4.3.x.</p> <p style="margin-top:0;margin-bottom:10px;; margin: 10px 0 0">I haven't yet turned this into a test case – hopefully I'll be able to do so fairly soon.</p> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff"> <script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"description": "View Issue",
"potentialAction": {
"@type": "ViewAction",
"target": "https://hibernate.atlassian.net/browse/HHH-12434?inbox=true&",
"name": "View Issue"
},
"publisher": {
"@type": "Organization",
"name": "Atlassian",
"url": "https://www.atlassian.com"
}
}
</script>
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://hibernate.atlassian.net/browse/HHH-12434#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-0571a29d-a3f2-4f4b-a943-f23d0b3a9874" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://hibernate.atlassian.net/browse/HHH-12434#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-mobile-separated-links" class="mobile-resize-text" width="100%" colspan="2" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> Get Jira notifications on your phone! Download the Jira Cloud app for <a href="https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail" style="color: #3b73af; text-decoration: none">Android</a> or <a href="https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8" style="color: #3b73af; text-decoration: none">iOS</a>
<hr> </td>
</tr>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian Jira <span id="footer-build-information">(v1001.0.0-SNAPSHOT#100082-<span title="d1dd9cd5f846b1427168f25ba3cd23169f819d4c" data-commit-id="d1dd9cd5f846b1427168f25ba3cd23169f819d4c}">sha1:d1dd9cd</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0; mso-table-rspace: 0">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0; border-collapse: collapse; padding-top: 3px; opacity: 0.150"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-2fe97379-6313-4173-b514-fa8eb9fd058c" alt="Atlassian logo" title="Atlassian logo" width="192" height="24" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
<img src="https://u4043402.ct.sendgrid.net/wf/open?upn=YNXLe5Uzuivj8jGpuXra04BSJ-2BS7raa1puTAtyVUP-2F0UG25sB-2BHToWWBMcbXwnNUY1xCsMgdXnQn1rXAlopW223ZLRCHCvTMaUH-2Bja2xOGjMa-2FdfMDllhJZQynArhdVB74n2dV0alvDj28OmKeNyxiqt9XXlWyrtgNtP4zfMqFhaMeUS5ElRDQIX6uzVhIkx0qPNg6-2BhsTl2CZds2GZBlEURRlqh15xX3Q10FV2eNij-2BxRqlZdvVy8TGo8VXYQTMH3eLgSlD-2F-2BCS13-2FHN-2Fk5lN5JuGWL4HV9e4Y2i-2FcNUj1wCyMDLR9KgdzqaMllOMfBpNQ-2FLAUugVnvnFbtCKx2WTGEtAxPRIkqFnoAFrO3spgqOjKIB5BAOTUwT2FKVqiQcZUpD3qK9IwrDaUiuNMsk5gotn5luD9ShmSqsqHdWaFKiQvwHzM7CcxtD6eAT8ESTd0Hi1iFu77CdEMxH9NJJw-3D-3D" alt="" width="1" height="1" border="0" style="height:1px !important;width:1px !important;border-width:0 !important;margin-top:0 !important;margin-bottom:0 !important;margin-right:0 !important;margin-left:0 !important;padding-top:0 !important;padding-bottom:0 !important;padding-right:0 !important;padding-left:0 !important;"/>
</body>
</html>